[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 1: https://github.com/google/googletest/issues/533 has some discussion here

[kudu-CR] [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3304/2//COMMIT_MSG

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-07 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/3228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Re

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3309/2//COMMIT_MSG Commit Message: Line

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/3304/4//COMMIT_MSG Commit

[kudu-CR] WIP: KUDU-1466: improve error message when writes fail at TS

2016-06-07 Thread Todd Lipcon (Code Review)
/26/3326/1 -- To view, visit http://gerrit.cloudera.org:8080/3326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f1de8159e515cbb5f52fdc440d71370437c1af2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1446 Consider data types in predicate evaluation order .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3298 To unsubscribe

[kudu-CR] KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

2016-05-24 Thread Todd Lipcon (Code Review)
-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <david.al...@cloudera.com>

[kudu-CR](branch-0.9.x) java: use truncated randomized exponential backoff for retries

2016-05-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: use truncated randomized exponential backoff for retries .. java: use truncated randomized exponential backoff for retries This changes the Java

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/3013/5/src/kudu/client/client.h File src/kudu/client

[kudu-CR] KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas

2016-05-25 Thread Todd Lipcon (Code Review)
ubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6bfa3fc6f41998b0f1ff58c5c8ea39881022de5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@clouder

[kudu-CR] KUDU-1385 Part 1: Modify documentation landing page

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1385 Part 1: Modify documentation landing page .. KUDU-1385 Part 1: Modify documentation landing page Rename introduction.html to index.html and get

[kudu-CR] Add unique id generation to the client

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3077 To unsubscribe, visit http

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 6: (2 comments) wonder whether it would be a clearer API to instead have a flag like context

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 6: OK. The code now looks good, but missing a test. Sorry, I should have mentioned that previously. Maybe

[kudu-CR](gh-pages) Add weekly update for 06/01

2016-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add weekly update for 06/01 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3269 To unsubscribe, visit http://gerrit.cloudera.org

[kudu-CR](branch-0.9.x) Disable tracing for tablet bootstrap during remote bootstrap

2016-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3267 Change subject: Disable tracing for tablet bootstrap during remote bootstrap .. Disable tracing for tablet bootstrap during remote

[kudu-CR](branch-0.9.x) Add python/pytest.ini in RAT exclude

2016-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add python/pytest.ini in RAT exclude .. Add python/pytest.ini in RAT exclude Needed just for branch-0.9.x. Change-Id

[kudu-CR](branch-0.9.x) Make 0.9.0 not SNAPSHOT for release

2016-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Make 0.9.0 not SNAPSHOT for release .. Make 0.9.0 not SNAPSHOT for release Change-Id: I912336be4cce91f8708673b32e6f18ff0022f0cf Reviewed-on: http

[kudu-CR](branch-0.9.x) Make 0.9.0 not SNAPSHOT for release

2016-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Make 0.9.0 not SNAPSHOT for release .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3261 To unsubscribe, visit http

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 8: Looks like this needs a manual rebase -- To view, visit http://gerrit.cloudera.org:8080/3013

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3013 To unsubscribe, visit http

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/2/src/kudu/consensus/log.cc

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Specify guaranteed semantics of GetTableLocations RPC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3240/1/src/kudu/master/catalog_manager.cc

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3179/3/src/kudu/rpc/rpc_controller.h File src

[kudu-CR] Fix stray memory writes due to tcmalloc profiling

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix stray memory writes due to tcmalloc profiling .. Fix stray memory writes due to tcmalloc profiling This fixes an issue that has been causing frequent

[kudu-CR] Fix stray memory writes due to tcmalloc profiling

2016-06-22 Thread Todd Lipcon (Code Review)
Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org>

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 12: (25 comments) http://gerrit.cloudera.org:8080/#/c/3190/12/src/kudu/rpc

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/4/src/kudu

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

2016-06-22 Thread Todd Lipcon (Code Review)
Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dra

[kudu-CR](gh-pages) Add weekly update for 06/21

2016-06-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add weekly update for 06/21 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3415 To unsubscribe, visit http://gerrit.cloudera.org

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3179 To unsubscribe, visit http

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 9: Looks like a small compile error here -- To view, visit http

[kudu-CR] KUDU-1491. Address TSAN warning for compaction

2016-06-22 Thread Todd Lipcon (Code Review)
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I42d2566eca096da172440ce3a88d0393dda9d324 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org>

[kudu-CR](branch-0.9.x) update dist-test configuration for new client.py location

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3459 Change subject: update dist-test configuration for new client.py location .. update dist-test configuration for new client.py location

[kudu-CR] KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3321/1

[kudu-CR](branch-0.9.x) Bump version to 0.9.1-SNAPSHOT

2016-06-22 Thread Todd Lipcon (Code Review)
: I472c2999c0b13a2c046366a9e1ad7474eedf68d0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>

[kudu-CR] KUDU-1491. Address TSAN warning for compaction

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1491. Address TSAN warning for compaction .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3454/1/src/kudu/tablet/compaction.cc File src/kudu

[kudu-CR] KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup

2016-06-22 Thread Todd Lipcon (Code Review)
080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8ecf8d780de1aa89fae4e0510d8291eb1f1cee11 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Ku

[kudu-CR](branch-0.9.x) KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3455 Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. KUDU-1469. Fix handling of fully-deduped

[kudu-CR] Integrate the request tracker with the client

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/rpc/retriable_rpc.h File src/kudu

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3228/4/src/kudu

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 6: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3409

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Clarify the difference between 'call_id' and 'request_id' This adds a bit more information

[kudu-CR](branch-0.9.x) Fix stray memory writes due to tcmalloc profiling

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3456 Change subject: Fix stray memory writes due to tcmalloc profiling .. Fix stray memory writes due to tcmalloc profiling This fixes

[kudu-CR] KUDU-1491. Address TSAN warning for compaction

2016-06-22 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/3454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42d2566eca096da172440ce3a88d0393dda9d324 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer

[kudu-CR] Integrate the request tracker with the client

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 8: (10 comments) http://gerrit.cloudera.org:8080/#/c/3080/8//COMMIT_MSG Commit Message: Line 15: any

[kudu-CR](branch-0.9.x) [java-client] RPC timeout may sometimes be reported as max attempts violation

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3457 Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. [java-client] RPC timeout may sometimes

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3289/2/src/kudu/consensus

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem and add a test .. Patch Set 11: (9 comments) http://gerrit.cloudera.org:8080/#/c/3192/11/src/kudu/common

[kudu-CR](branch-0.9.x) KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3464 Change subject: KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup .. KUDU-1477. Pending COMMIT

[kudu-CR](gh-pages) Control how content is cached on the Kudu web site

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Control how content is cached on the Kudu web site .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3462 To unsubscribe

[kudu-CR] KUDU-1491. Address TSAN warning for compaction

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1491. Address TSAN warning for compaction .. KUDU-1491. Address TSAN warning for compaction This adds a missing memory barrier that was exposed when

[kudu-CR](branch-0.9.x) [java-client] RPC timeout may sometimes be reported as max attempts violation

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. [java-client] RPC timeout may sometimes be reported as max attempts

[kudu-CR](branch-0.9.x) Fix stray memory writes due to tcmalloc profiling

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix stray memory writes due to tcmalloc profiling .. Fix stray memory writes due to tcmalloc profiling This fixes an issue that has been causing frequent

[kudu-CR](branch-0.9.x) Fix stray memory writes due to tcmalloc profiling

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix stray memory writes due to tcmalloc profiling .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3456 To unsubscribe, visit http

[kudu-CR](branch-0.9.x) KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. KUDU-1469. Fix handling of fully-deduped requests after a leader change

[kudu-CR](gh-pages) Control how content is cached on the Kudu web site

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Control how content is cached on the Kudu web site .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3462/1/.htaccess File .htaccess: Line 1

[kudu-CR](branch-0.9.x) Bump version to 0.9.1-SNAPSHOT

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump version to 0.9.1-SNAPSHOT .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3458 To unsubscribe, visit http://gerrit.cloudera.org

[kudu-CR](branch-0.9.x) Bump version to 0.9.1-SNAPSHOT

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Bump version to 0.9.1-SNAPSHOT .. Bump version to 0.9.1-SNAPSHOT Change-Id: I472c2999c0b13a2c046366a9e1ad7474eedf68d0 Reviewed-on: http

[kudu-CR](branch-0.9.x) update dist-test configuration for new client.py location

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: update dist-test configuration for new client.py location .. update dist-test configuration for new client.py location client.py has been moved to bin

[kudu-CR](branch-0.9.x) update dist-test configuration for new client.py location

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: update dist-test configuration for new client.py location .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3459 To unsubscribe

[kudu-CR](branch-0.9.x) KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3455

[kudu-CR](gh-pages) Control how content is cached on the Kudu web site

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Control how content is cached on the Kudu web site .. Control how content is cached on the Kudu web site Change-Id

[kudu-CR](branch-0.9.x) KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup .. Patch Set 2: Code-Review+2 -- To view, visit http

[kudu-CR](branch-0.9.x) KUDU-1477. Pending COMMIT message for failed write operation can prevent tablet startup

2016-06-23 Thread Todd Lipcon (Code Review)
wpatchset Gerrit-Change-Id: I8ecf8d780de1aa89fae4e0510d8291eb1f1cee11 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 4: Sorry for the delay on this, Will. I was on PTO the last couple of weeks. Hope

[kudu-CR] tablet: fix sloppiness around atomic mutation lists

2016-06-20 Thread Todd Lipcon (Code Review)
-MessageType: newchange Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>

[kudu-CR] tsan: remove two old suppressions

2016-06-20 Thread Todd Lipcon (Code Review)
: I25354ce37300ba495aa73909b6a2ba3672f22906 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>

[kudu-CR](branch-0.9.x) Release notes for 0.9.1

2016-06-23 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@a

[kudu-CR] Release notes for 0.9.1

2016-06-23 Thread Todd Lipcon (Code Review)
for 0.9.1 Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Reviewed-on: http://gerrit.cloudera.org:8080/3463 Reviewed-by: Misty Stanley-Jones <mi...@apache.org> Reviewed-by: Jean-Daniel Cryans <jdcry...@apache.org> Tested-by: Todd Lipcon <t...@apache.org> --- M docs/instal

[kudu-CR](branch-0.9.x) Release notes for 0.9.1

2016-06-23 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@a

[kudu-CR](branch-0.9.x) Release notes for 0.9.1

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Release notes for 0.9.1 .. Release notes for 0.9.1 Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Reviewed-on: http://gerrit.cloudera.org:8080/3463

[kudu-CR] lock manager: fix TSAN error in LockTable::Resize()

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: lock_manager: fix TSAN error in LockTable::Resize() .. Patch Set 1: We had a suppression on ScopedRowLock::Release originally (since we first introduced TSAN

[kudu-CR](branch-0.9.x) Bump version to 0.9.1

2016-06-23 Thread Todd Lipcon (Code Review)
: Ied911c99b45f9bdae20d14f0ecbe2ae9010f1476 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>

[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix .gitignore .. Patch Set 1: this seems kind of fragile.. why not just use a different checkout for this branch? -- To view, visit http://gerrit.cloudera.org

[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix .gitignore .. Patch Set 1: It's just trying to prevent you from tryig to 'publish' when in fact you forgot to 'git add' something. Could add a --ignore

[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix .gitignore .. Patch Set 1: Although I guess I should add that the reason it does this is that jekyll will see all your untracked files, think

[kudu-CR] Release notes for 0.9.1

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Release notes for 0.9.1 .. Release notes for 0.9.1 Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Reviewed-on: http://gerrit.cloudera.org:8080/3463

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. KUDU-1398 CFile index blocks can store shortest separating prefix (No changes

[kudu-CR] catalog manager: prevent spurious dirty callbacks from crashing the process

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: catalog_manager: prevent spurious dirty callbacks from crashing the process .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3465

[kudu-CR](branch-0.9.x) Release notes for 0.9.1

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Release notes for 0.9.1 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3463 To unsubscribe, visit http://gerrit.cloudera.org:8080

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow for reserving disk space for non-Kudu processes .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3135 To unsubscribe, visit

[kudu-CR] Allow for reserving disk space for non-Kudu processes

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow for reserving disk space for non-Kudu processes .. Patch Set 9: Any particular areas you think I should take a close look at? Otherwise happy to trust

[kudu-CR] lock manager: fix TSAN error in LockTable::Resize()

2016-06-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3469 Change subject: lock_manager: fix TSAN error in LockTable::Resize() .. lock_manager: fix TSAN error in LockTable::Resize() This function

[kudu-CR] Add a ToString() method to Proxy

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 1: would be nice to add a new assertion to one of the RPC layer tests which calls this -- To view, visit http

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread Todd Lipcon (Code Review)
: newchange Gerrit-Change-Id: I99bdd6298349a5be5f1fc3a666fe04305699e293 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: yea, ASAN does insert poisoning between variables on the stack: http://llvm.org/docs

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add 6/27 weekly update .. Add 6/27 weekly update Change-Id: I6ce4bf6e02a5481bf3e032d3345d7afc93c244a2 Reviewed-on: http://gerrit.cloudera.org:8080/3515

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add 6/27 weekly update .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3515 To unsubscribe, visit http://gerrit.cloudera.org:8080

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6ce4bf6e02a5481bf3e032d3345d7afc93c244a2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>

[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange .. Patch Set 1: A java test failed due to https://issues.apache.org/jira/browse/KUDU-1496

[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3511

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc File src/kudu/util/rw_mutex.cc

[kudu-CR] locks: switch from boost::shared lock to kudu::shared lock

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: locks: switch from boost::shared_lock to kudu::shared_lock .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3498 To unsubscribe

[kudu-CR] Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal .. Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal This test was flaky because

[kudu-CR] locks: stop using errno around base::NumCPUs and base::MaxCPUIndex

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: locks: stop using errno around base::NumCPUs and base::MaxCPUIndex .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3495

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread Todd Lipcon (Code Review)
rit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3289

[kudu-CR] Add a Barrier implementation and use it in cbtree-test

2016-06-24 Thread Todd Lipcon (Code Review)
: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>

  1   2   3   >