Todd Lipcon has posted comments on this change.
Change subject: Avoid missing 'override' keyword warnings in
raft_consensus-test.cc
..
Patch Set 1:
https://github.com/google/googletest/issues/533 has some discussion here
--
Todd Lipcon has posted comments on this change.
Change subject: [WIP] KUDU-1398 CFile index blocks can store shortest
separating prefix
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3304/2//COMMIT_MSG
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3228
to look at the new patch set (#4).
Change subject: KUDU-1469. Fix handling of fully-deduped requests after a
leader change
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3309/2//COMMIT_MSG
Commit Message:
Line
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1398 CFile index blocks can store shortest separating
prefix
..
Patch Set 4:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/3304/4//COMMIT_MSG
Commit
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3326
to review the following change.
Change subject: WIP: KUDU-1466: improve error message when writes fail at TS
..
WIP:
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1446 Consider data types in predicate evaluation order
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3298
To unsubscribe,
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3208
to review the following change.
Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT
..
Todd Lipcon has submitted this change and it was merged.
Change subject: java: use truncated randomized exponential backoff for retries
..
java: use truncated randomized exponential backoff for retries
This changes the Java
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1444. Get resource metrics of a scan.
..
Patch Set 5:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/3013/5/src/kudu/client/client.h
File
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3221
to look at the new patch set (#2).
Change subject: KUDU-749 (part 2): avoid O(n^2) behavior when compacting deltas
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1385 Part 1: Modify documentation landing page
..
KUDU-1385 Part 1: Modify documentation landing page
Rename introduction.html to index.html and get
Todd Lipcon has posted comments on this change.
Change subject: Add unique id generation to the client
..
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3077
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: Add a RpcContext::RespondFailure() method
..
Patch Set 6:
(2 comments)
wonder whether it would be a clearer API to instead have a flag like
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1444. Get resource metrics of a scan.
..
Patch Set 6:
OK. The code now looks good, but missing a test. Sorry, I should have mentioned
that previously. Maybe
Todd Lipcon has posted comments on this change.
Change subject: Add weekly update for 06/01
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3269
To unsubscribe, visit
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3267
Change subject: Disable tracing for tablet bootstrap during remote bootstrap
..
Disable tracing for tablet bootstrap during remote
Todd Lipcon has submitted this change and it was merged.
Change subject: Add python/pytest.ini in RAT exclude
..
Add python/pytest.ini in RAT exclude
Needed just for branch-0.9.x.
Change-Id:
Todd Lipcon has submitted this change and it was merged.
Change subject: Make 0.9.0 not SNAPSHOT for release
..
Make 0.9.0 not SNAPSHOT for release
Change-Id: I912336be4cce91f8708673b32e6f18ff0022f0cf
Reviewed-on:
Todd Lipcon has posted comments on this change.
Change subject: Make 0.9.0 not SNAPSHOT for release
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3261
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1444. Get resource metrics of a scan.
..
Patch Set 8:
Looks like this needs a manual rebase
--
To view, visit http://gerrit.cloudera.org:8080/3013
To
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1444. Get resource metrics of a scan.
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3013
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: log: Mark allocation finished even if allocation had an error
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3234/2/src/kudu/consensus/log.cc
Todd Lipcon has posted comments on this change.
Change subject: Specify guaranteed semantics of GetTableLocations RPC
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3240/1/src/kudu/master/catalog_manager.cc
Todd Lipcon has posted comments on this change.
Change subject: Allow to set RequestId in the RPC RequestHeader
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3179/3/src/kudu/rpc/rpc_controller.h
File
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix stray memory writes due to tcmalloc profiling
..
Fix stray memory writes due to tcmalloc profiling
This fixes an issue that has been causing frequent
Hello David Ribeiro Alves, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3445
to review the following change.
Change subject: Fix stray memory writes due to tcmalloc profiling
Todd Lipcon has posted comments on this change.
Change subject: Add a ResultTracker class that will track server side results
..
Patch Set 12:
(25 comments)
Todd Lipcon has posted comments on this change.
Change subject: log: Mark allocation finished even if allocation had an error
..
Patch Set 4: Code-Review+1
(1 comment)
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3410
to look at the new patch set (#2).
Change subject: tablet: fix sloppiness around atomic mutation lists
Todd Lipcon has posted comments on this change.
Change subject: Add weekly update for 06/21
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3415
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: Allow to set RequestId in the RPC RequestHeader
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3179
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1398 CFile index blocks can store shortest separating
prefix
..
Patch Set 9:
Looks like a small compile error here
--
To view, visit
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3454
to review the following change.
Change subject: KUDU-1491. Address TSAN warning for compaction
..
KUDU-1491. Address
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3459
Change subject: update dist-test configuration for new client.py location
..
update dist-test configuration for new client.py location
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1477. Pending COMMIT message for failed write operation
can prevent tablet startup
..
Patch Set 1:
(5 comments)
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3458
to review the following change.
Change subject: Bump version to 0.9.1-SNAPSHOT
..
Bump version to
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1491. Address TSAN warning for compaction
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3454/1/src/kudu/tablet/compaction.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3321
to look at the new patch set (#2).
Change subject: KUDU-1477. Pending COMMIT message for failed write operation
can prevent tablet startup
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3455
Change subject: KUDU-1469. Fix handling of fully-deduped requests after a
leader change
..
KUDU-1469. Fix handling of fully-deduped
Todd Lipcon has posted comments on this change.
Change subject: Integrate the request tracker with the client
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/rpc/retriable_rpc.h
File
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1469. Fix handling of fully-deduped requests after a
leader change
..
Patch Set 4:
(1 comment)
Todd Lipcon has posted comments on this change.
Change subject: Clarify the difference between 'call_id' and 'request_id'
..
Patch Set 6: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3409
To
Todd Lipcon has submitted this change and it was merged.
Change subject: Clarify the difference between 'call_id' and 'request_id'
..
Clarify the difference between 'call_id' and 'request_id'
This adds a bit more information
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3456
Change subject: Fix stray memory writes due to tcmalloc profiling
..
Fix stray memory writes due to tcmalloc profiling
This fixes an
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3454
to look at the new patch set (#2).
Change subject: KUDU-1491. Address TSAN warning for compaction
..
Todd Lipcon has posted comments on this change.
Change subject: Integrate the request tracker with the client
..
Patch Set 8:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/3080/8//COMMIT_MSG
Commit Message:
Line 15: any
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3457
Change subject: [java-client] RPC timeout may sometimes be reported as max
attempts violation
..
[java-client] RPC timeout may sometimes
Todd Lipcon has posted comments on this change.
Change subject: Avoid missing 'override' keyword warnings in
raft_consensus-test.cc
..
Patch Set 2:
(1 comment)
Todd Lipcon has posted comments on this change.
Change subject: Integrate the ResultTracker into the rpc subsystem and add a
test
..
Patch Set 11:
(9 comments)
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3464
Change subject: KUDU-1477. Pending COMMIT message for failed write operation
can prevent tablet startup
..
KUDU-1477. Pending COMMIT
Todd Lipcon has posted comments on this change.
Change subject: Control how content is cached on the Kudu web site
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3462
To
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1491. Address TSAN warning for compaction
..
KUDU-1491. Address TSAN warning for compaction
This adds a missing memory barrier that was exposed when
Todd Lipcon has submitted this change and it was merged.
Change subject: [java-client] RPC timeout may sometimes be reported as max
attempts violation
..
[java-client] RPC timeout may sometimes be reported as max attempts
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix stray memory writes due to tcmalloc profiling
..
Fix stray memory writes due to tcmalloc profiling
This fixes an issue that has been causing frequent
Todd Lipcon has posted comments on this change.
Change subject: Fix stray memory writes due to tcmalloc profiling
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3456
To unsubscribe, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1469. Fix handling of fully-deduped requests after a
leader change
..
KUDU-1469. Fix handling of fully-deduped requests after a leader change
This
Todd Lipcon has posted comments on this change.
Change subject: Control how content is cached on the Kudu web site
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3462/1/.htaccess
File .htaccess:
Line 1: #
Todd Lipcon has posted comments on this change.
Change subject: Bump version to 0.9.1-SNAPSHOT
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3458
To unsubscribe, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: Bump version to 0.9.1-SNAPSHOT
..
Bump version to 0.9.1-SNAPSHOT
Change-Id: I472c2999c0b13a2c046366a9e1ad7474eedf68d0
Reviewed-on:
Todd Lipcon has submitted this change and it was merged.
Change subject: update dist-test configuration for new client.py location
..
update dist-test configuration for new client.py location
client.py has been moved to
Todd Lipcon has posted comments on this change.
Change subject: update dist-test configuration for new client.py location
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3459
To unsubscribe,
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1469. Fix handling of fully-deduped requests after a
leader change
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3455
To
Todd Lipcon has submitted this change and it was merged.
Change subject: Control how content is cached on the Kudu web site
..
Control how content is cached on the Kudu web site
Change-Id:
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1477. Pending COMMIT message for failed write operation
can prevent tablet startup
..
Patch Set 2: Code-Review+2
--
To view, visit
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3464
to look at the new patch set (#2).
Change subject: KUDU-1477. Pending COMMIT message for failed write operation
can prevent tablet startup
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1398 CFile index blocks can store shortest separating
prefix
..
Patch Set 4:
Sorry for the delay on this, Will. I was on PTO the last couple of weeks. Hope
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3410
to review the following change.
Change subject: tablet: fix sloppiness around atomic mutation lists
..
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3411
to review the following change.
Change subject: tsan: remove two old suppressions
..
tsan: remove two old suppressions
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3463
to look at the new patch set (#3).
Change subject: Release notes for 0.9.1
..
Release notes for 0.9.1
Change-Id:
Hello Jean-Daniel Cryans, Misty Stanley-Jones,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3470
to review the following change.
Change subject: Release notes for 0.9.1
..
Release notes
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3463
to look at the new patch set (#2).
Change subject: Release notes for 0.9.1
..
Release notes for 0.9.1
Change-Id:
Todd Lipcon has submitted this change and it was merged.
Change subject: Release notes for 0.9.1
..
Release notes for 0.9.1
Change-Id: I797980d105e0e1000420aedf58e094f9505053c6
Reviewed-on: http://gerrit.cloudera.org:8080/3463
Todd Lipcon has posted comments on this change.
Change subject: lock_manager: fix TSAN error in LockTable::Resize()
..
Patch Set 1:
We had a suppression on ScopedRowLock::Release originally (since we first
introduced TSAN a
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3473
to review the following change.
Change subject: Bump version to 0.9.1
..
Bump version to 0.9.1
Change-Id:
Todd Lipcon has posted comments on this change.
Change subject: Fix .gitignore
..
Patch Set 1:
this seems kind of fragile.. why not just use a different checkout for this
branch?
--
To view, visit
Todd Lipcon has posted comments on this change.
Change subject: Fix .gitignore
..
Patch Set 1:
It's just trying to prevent you from tryig to 'publish' when in fact you forgot
to 'git add' something. Could add a
Todd Lipcon has posted comments on this change.
Change subject: Fix .gitignore
..
Patch Set 1:
Although I guess I should add that the reason it does this is that jekyll will
see all your untracked files, think they are
Todd Lipcon has submitted this change and it was merged.
Change subject: Release notes for 0.9.1
..
Release notes for 0.9.1
Change-Id: I797980d105e0e1000420aedf58e094f9505053c6
Reviewed-on: http://gerrit.cloudera.org:8080/3463
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1398 CFile index blocks can store shortest separating
prefix
..
KUDU-1398 CFile index blocks can store shortest separating prefix
(No changes:
Todd Lipcon has posted comments on this change.
Change subject: catalog_manager: prevent spurious dirty callbacks from crashing
the process
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3465
Todd Lipcon has posted comments on this change.
Change subject: Release notes for 0.9.1
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3463
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: Allow for reserving disk space for non-Kudu processes
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3135
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: Allow for reserving disk space for non-Kudu processes
..
Patch Set 9:
Any particular areas you think I should take a close look at? Otherwise happy
to trust that
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3469
Change subject: lock_manager: fix TSAN error in LockTable::Resize()
..
lock_manager: fix TSAN error in LockTable::Resize()
This function
Todd Lipcon has posted comments on this change.
Change subject: Add a ToString() method to Proxy
..
Patch Set 1:
would be nice to add a new assertion to one of the RPC layer tests which calls
this
--
To view, visit
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3517
to review the following change.
Change subject: tablet: change default bloom filter FP rate to 0.01%
..
Todd Lipcon has posted comments on this change.
Change subject: Implement kudu::optional replacement for boost::optional
..
Patch Set 1:
yea, ASAN does insert poisoning between variables on the stack:
Todd Lipcon has submitted this change and it was merged.
Change subject: Add 6/27 weekly update
..
Add 6/27 weekly update
Change-Id: I6ce4bf6e02a5481bf3e032d3345d7afc93c244a2
Reviewed-on: http://gerrit.cloudera.org:8080/3515
Todd Lipcon has posted comments on this change.
Change subject: Add 6/27 weekly update
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3515
To unsubscribe, visit
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3515
to review the following change.
Change subject: Add 6/27 weekly update
..
Add 6/27 weekly update
Change-Id:
Todd Lipcon has posted comments on this change.
Change subject: Fix flakiness in
RaftConsensusITest.TestMasterNotifiedOnConfigChange
..
Patch Set 1:
A java test failed due to https://issues.apache.org/jira/browse/KUDU-1496
Todd Lipcon has posted comments on this change.
Change subject: Fix flakiness in
RaftConsensusITest.TestMasterNotifiedOnConfigChange
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3511
To
Todd Lipcon has posted comments on this change.
Change subject: locks: add new read-write mutex
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc
File src/kudu/util/rw_mutex.cc:
Todd Lipcon has posted comments on this change.
Change subject: locks: switch from boost::shared_lock to kudu::shared_lock
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3498
To unsubscribe,
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
..
Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
This test was flaky because it was
Todd Lipcon has posted comments on this change.
Change subject: locks: stop using errno around base::NumCPUs and
base::MaxCPUIndex
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3495
To
Hello Jean-Daniel Cryans, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3517
to look at the new patch set (#2).
Change subject: tablet: change default bloom filter FP rate to 0.01%
Todd Lipcon has posted comments on this change.
Change subject: Avoid missing 'override' keyword warnings in
raft_consensus-test.cc
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3289
To
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3494
to review the following change.
Change subject: Add a Barrier implementation and use it in cbtree-test
..
1 - 100 of 207 matches
Mail list logo
