Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-1571

Review Request 44656: Introduced `KillPolicy` protobuf.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4909

Review Request 44628: Fixed a comment and ordering in mesos.proto.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44628/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44630/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1571

Re: Review Request 43763: Passed `Duration` as const reference in the executor library.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43763/ --- (Updated March 10, 2016, 5:14 p.m.) Review request for mesos and Ben Mahler.

Review Request 44626: Fixed whitespaces in mesos.proto.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44626/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44651: Fixed formatting in executor library.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44651/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44634: Updated the log message in the HTTP API executor library.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44634/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122937 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

Review Request 44653: Fixed formatting in command executor.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44653/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44629: Fixed ordering and inconsistencies in slave constants.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44629/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4911

Review Request 44662: Added kill policies and shutdown grace period to the CHANGELOG.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44662/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44635: Corrected the log message and variable name in executor library.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44635/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44650: Omitted names of unused parameters in executor library.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44650/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44652: Omitted names of unused parameters in command executor.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44652/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44631: Cleaned up the comment around executor shutdown event.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44631/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44657: Used `KillPolicy` in command executor.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- Review request for mesos, Ben Mahler and Gilbert Song. Bugs: MESOS-4909

Review Request 44659: Updated the comment about docker executor.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44659/ --- Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos

Review Request 44627: Removed a stale comment in the 1.0 mesos.proto.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44627/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen. Bugs:

Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- Review request for mesos, Ben Mahler and Timothy Chen. Bugs: MESOS-4910

Review Request 44658: Removed unused signal escalation constant.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44658/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1571

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review122892 --- Looks great! Just some minor nits and a question about

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review122901 --- Can you add some tests for these endpoints that show that hitting

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-10 Thread Adam B
> On March 9, 2016, 8:02 p.m., Alexander Rojas wrote: > > I just did a grep and I found this: > > > > ```sh > > $ ag --cpp --ignore="build/.*" '\"mesos\"' . > > # ... > > src/authentication/http/basic_authenticator_factory.cpp > > 66: Authenticator* authenticator = new

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review122900 --- Patch looks great! Reviews applied: [42705, 44606] Passed

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122897 --- include/mesos/mesos.proto (line 443)

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/#review122902 --- Fix it, then Ship it! Looks good. Just some alpha-order nits,

Review Request 44581: fixed docker's stdout/stderr streams got corrupted after calling docker->stop.

2016-03-10 Thread Martin Bydzovsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44581/ --- Review request for mesos. Repository: mesos Description --- fixed

Re: Review Request 44581: fixed docker's stdout/stderr streams got corrupted after calling docker->stop.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44581/#review122909 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 10, 2016, 10:31 a.m.) Review request for mesos, Adam B,

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-10 Thread Joerg Schad
> On March 10, 2016, 6:26 a.m., Adam B wrote: > > Can you add some tests for these endpoints that show that hitting them with > > a bad credential will fail with status `Unauthorized`? See > > `TeardownTest.TeardownEndpointBadCredentials` or > > `PersistentVolumeEndpointsTest.BadCredentials`.

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-10 Thread Joerg Schad
> On March 10, 2016, 6:26 a.m., Adam B wrote: > > src/tests/master_maintenance_tests.cpp, line 129 > > > > > > Why set this to false and then still createBasicAuthHeaders for these > > tests? > > Why can't we

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122905 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 10, 2016, 3:10 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Alexander Rojas
> On March 10, 2016, 10:14 a.m., Adam B wrote: > > src/authorizer/authorizer.cpp, lines 43-44 > > > > > > Double-blank line between impls, please screw up while rebasing. - Alexander

Review Request 44620: Documented how to make executors work with SSL.

2016-03-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/ --- Review request for mesos, Adam B and Alexander Rojas. Bugs: MESOS-4750

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 10, 2016, 3:15 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 10, 2016, 1:49 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Jan Schlicht
> On March 10, 2016, 9:22 a.m., Klaus Ma wrote: > > include/mesos/mesos.proto, line 443 > > > > > > Also added in v1 APIs? Oh sure, good catch! - Jan ---

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 10, 2016, 3:09 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122914 --- Patch looks great! Reviews applied: [44286, 44186] Passed

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Jan Schlicht
> On March 10, 2016, 7:31 a.m., Adam B wrote: > > src/master/validation.cpp, line 381 > > > > > > It may be sufficient to only check `if (task.has_owner() && > > task.has_executor())` since a custom executor should

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

2016-03-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/#review122956 --- Fix it, then Ship it! src/master/http.cpp (line 1849)

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 10, 2016, 7:15 p.m.) Review request for mesos and Benjamin

Review Request 44670: Added master_detector and master_contender flags.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- Review request for mesos. Repository: mesos Description --- The

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/#review122961 --- Fix it, then Ship it! Looks good. Some minor comments.

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-03-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/#review122949 --- Ship it! Ship It! - Michael Park On March 9, 2016, 7:25

Re: Review Request 44666: Fixed typos in comments in libprocess.

2016-03-10 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44666/#review122950 --- Ship it! Ship It! - Cong Wang On March 10, 2016, 6:13 p.m.,

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-10 Thread Neil Conway
> On March 10, 2016, 7:16 a.m., Adam B wrote: > > src/master/http.cpp, lines 1166-1167 > > > > > > Why is the space removed here? > > Do we need to put a space after `JSON` instead? TLDR processing inserts

Review Request 44666: Fixed typos in comments in libprocess.

2016-03-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44666/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44666: Fixed typos in comments in libprocess.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44666/#review122952 --- Ship it! Ship It! - Jie Yu On March 10, 2016, 6:13 p.m.,

Re: Review Request 44584: Improved docs for dynamic weights.

2016-03-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44584/ --- (Updated March 10, 2016, 6:40 p.m.) Review request for mesos, Adam B and

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 10, 2016, 7:16 p.m.) Review request for mesos and Benjamin

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-03-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/#review122958 --- src/slave/http.cpp (lines 89 - 105)

Re: Review Request 42516: Add support for user-defined networks.

2016-03-10 Thread Jie Yu
> On Feb. 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- Review request for mesos. Repository: mesos Description --- The

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

2016-03-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/#review122957 --- Ship it! Ship It! - Michael Park On Feb. 29, 2016, 6:55

Re: Review Request 44342: XFS disk resource isolator.

2016-03-10 Thread Jiang Yan Xu
> On March 9, 2016, 10:03 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 573-576 > > > > > > We do need to handle orphans, as you've commented in `cleanup()`. > > > >

Re: Review Request 44652: Omitted names of unused parameters in command executor.

2016-03-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44652/#review122944 --- Fix it, then Ship it! src/launcher/executor.cpp (line 124)

Re: Review Request 44584: Improved docs for dynamic weights.

2016-03-10 Thread Neil Conway
> On March 10, 2016, 7:47 a.m., Yongqiao Wang wrote: > > docs/weights.md, lines 40-46 > > > > > > Why adjust this order? `role` is an optional item in `/weights` `PUT` > > request, and `/weights` is focus on

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 10, 2016, 7:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 10, 2016, 7:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 10, 2016, 7:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 10, 2016, 7:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-03-10 Thread Joseph Wu
> On March 9, 2016, 10:46 a.m., Michael Park wrote: > > src/tests/cluster.hpp, line 88 > > > > > > Why do we need to return `Try` as opposed to > > `Try`? > > Joseph Wu wrote: > We return an

Re: Review Request 43707: Windows:[1/3] Added zlib definitions for Windows.

2016-03-10 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43707/#review122993 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25

Re: Review Request 44433: Added empty line for list in maintenance doc.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44433/#review122972 --- Ship it! Ship It! - Joris Van Remoortere On March 8, 2016,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 10, 2016, 7:45 p.m.) Review request for mesos, Adam B,

Re: Review Request 44537: Update PendingUnavailabilityTest to use the new scheduler mock.

2016-03-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44537/ --- (Updated March 10, 2016, 1:08 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-10 Thread Greg Mann
> On March 10, 2016, 8:57 a.m., Adam B wrote: > > Can you add some tests for these endpoints that show that hitting them with > > a bad credential will fail with status Unauthorized? See > > `TeardownTest.TeardownEndpointBadCredentials` or > > `PersistentVolumeEndpointsTest.BadCredentials`.

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/#review122977 --- src/slave/containerizer/mesos/linux_launcher.cpp (lines 247 -

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 10, 2016, 1:01 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44537: Update PendingUnavailabilityTest to use the new scheduler mock.

2016-03-10 Thread Joseph Wu
> On March 8, 2016, 5:54 p.m., Guangya Liu wrote: > > src/tests/master_maintenance_tests.cpp, lines 501-503 > > > > > > @Joseph, just a question, how can this guarantee that there is no other > > events after the

Re: Review Request 44537: Update PendingUnavailabilityTest to use the new scheduler mock.

2016-03-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44537/#review122992 --- Ship it! - Anand Mazumdar On March 10, 2016, 9:08 p.m.,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- (Updated March 10, 2016, 9:40 p.m.) Review request for mesos, Adam B,

Re: Review Request 44280: Removed `FLAGS_v` assignment in test case.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44280/#review122970 --- Ship it! Ship It! - Joris Van Remoortere On March 2, 2016,

Re: Review Request 44407: Fixed a typo in a log message in an example framework.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44407/#review122971 --- Ship it! Ship It! - Joris Van Remoortere On March 4, 2016,

Review Request 44672: Added normalize method to registry puller.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Review Request 44674: Supported image name specified with private registry prefix.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 10, 2016, 12:28 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

2016-03-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated March 10, 2016, 12:28 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-03-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated March 10, 2016, 12:28 p.m.) Review request for mesos, Benjamin

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 10, 2016, 9:22 p.m.) Review request for mesos and Benjamin

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 10, 2016, 9:22 p.m.) Review request for mesos and Benjamin

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 10, 2016, 9:22 p.m.) Review request for mesos and Benjamin

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 10, 2016, 9:22 p.m.) Review request for mesos and Benjamin

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 10, 2016, 9:22 p.m.) Review request for mesos and Benjamin

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review122996 --- 3rdparty/libprocess/src/metrics/metrics.cpp (line 234)

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-10 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/#review122998 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25

Re: Review Request 44620: Documented how to make executors work with SSL.

2016-03-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/#review122997 --- docs/ssl.md (line 102)

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Cong Wang
> On March 10, 2016, 9:32 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 234 > > > > > > (1) Why not just `snapshot`? > > (2) We don't use default capture by reference. Could you

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 10, 2016, 7:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 44584: Improved docs for dynamic weights.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44584/#review122969 --- Patch looks great! Reviews applied: [44583, 44584] Passed

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 10, 2016, 7:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 10, 2016, 7:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 10, 2016, 7:34 p.m.) Review request for mesos and Benjamin

Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/ --- Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu. Bugs:

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 10, 2016, 9:21 p.m.) Review request for mesos and Benjamin

  1   2   3   >