Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124375 --- I ran the review by Ben again and sat with him to rework it to

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

2016-03-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review124373 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Re: Review Request 45067: Updated the long-lived-framework example.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review124377 --- Fix it, then Ship it! Ship It!

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review124379 ---

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review124370 --- src/cli/execute.cpp (line 317)

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Yong Tang
> On March 15, 2016, 9:24 p.m., Michael Park wrote: > > support/clang-format, lines 101-107 > > > > > > We can help out a little more here: > > > > The following code orders the headers: > > (1) C

Re: Review Request 44767: Added authentication information to master endpoints.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44767/ --- (Updated March 18, 2016, 4:48 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 17, 2016, 9:17 p.m.) Review request for mesos, Avinash

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 18, 2016, 5:23 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

2016-03-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/#review123864 --- Ship it! Ship It! - Michael Park On March 14, 2016, 9:32

Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.

2016-03-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44135/ --- (Updated March 18, 2016, 6:48 p.m.) Review request for mesos, Alex Naparu,

Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

2016-03-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44766/ --- (Updated March 17, 2016, 11:55 a.m.) Review request for mesos, Adam B and Greg

Re: Review Request 44948: Add XFS disk resource isolator.

2016-03-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124097 --- src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 220)

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-19 Thread Greg Mann
> On March 18, 2016, 8:55 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 87-91 > > > > > > Is it ok to specify a realm but no credentials? Does that just mean > > that nobody

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
> On March 17, 2016, 7:48 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 241 > > > > > > The default value of `containerizer` is `mesos`, do we need to check > > this? > > > > What about make the

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-19 Thread Joerg Schad
> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-03-19 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 18, 2016, 2:47 p.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Vinod Kone
> On March 19, 2016, 1:24 a.m., Ben Whitehead wrote: > > src/master/http.cpp, line 959 > > > > > > According to the rules defined in > > https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a > >

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123913 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Review Request 44892: Remove `Fetcher` in `Containerizer::create`.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44892/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-19 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Review Request 45017: Updated C++ dialect macro in libprocess.

2016-03-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45017/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 44963: Added a missing include to a stout header.

2016-03-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44963/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43884: Added allocator metrics for used quotas.

2016-03-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 18, 2016, 5:08 p.m.) Review request for mesos, Alexander

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-19 Thread Alexander Rukletsov
> On March 15, 2016, 10:25 p.m., Ben Mahler wrote: > > src/launcher/executor.cpp, lines 121-125 > > > > > > Ditto from previous review comments, could you adjust the comment and > > logic to reflect that it's not a

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

2016-03-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review124289 --- Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:33

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review123857 --- Committed with the following formatting fixes.

Review Request 44996: Fixed how we detect C++11 compiler support in libprocess.

2016-03-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44996/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4963

Re: Review Request 45070: Clean up libprocess gtest macros (MESOS-4112).

2016-03-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45070/#review124386 --- Patch looks great! Reviews applied: [45070] Passed command:

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44766/ --- (Updated March 17, 2016, 5:32 p.m.) Review request for mesos, Adam B and Greg

Review Request 45037: Regenerated agent endpoint documentation.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45037/ --- Review request for mesos, Adam B and Greg Mann. Repository: mesos

Review Request 45036: Added authentication information to agent endpoints.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45036/ --- Review request for mesos, Adam B and greg-cooke greg-cooke. Repository: mesos

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review124385 --- Fix it, then Ship it! Unnecessary summaries, but shippable

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Ben Whitehead
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124350 --- src/master/http.cpp (line 958)

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-19 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated March 16, 2016, 8:10 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 44760: Windows: Fixed non-blocking connect.

2016-03-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 18, 2016, 6:49 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-19 Thread Joerg Schad
> On March 18, 2016, 3:47 p.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 677 > > > > > > Where is this coming from? I would expect this in slave/constants.hpp > > similar as for the master > > > >

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-19 Thread Anurag Singh
> On March 18, 2016, 9:03 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 16-17 > > > > > > You might have missed my earlier comment (because I didn't make it a RB > > "issue"). Are these two files

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-19 Thread Greg Mann
> On March 18, 2016, 9:07 a.m., Adam B wrote: > > include/mesos/authentication/http/basic_authenticator_factory.hpp, lines > > 56-57 > > > > > > Why are these quotes escaped, but the others aren't? Because they're

Review Request 44971: MESOS-3902: Fix location header in redirect from non-leading master.

2016-03-19 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44971/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review124259 --- Sorry for the delay... As Vinod suggested, you might want to

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- (Updated March 18, 2016, 12:48 a.m.) Review request for mesos and Jie Yu.

Review Request 44999: Fixed m4 macro to enable strict C++11 conformance in libprocess.

2016-03-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44999/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4963

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review123863 --- Ship it! src/tests/fetcher_cache_tests.cpp (lines 165 - 167)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-19 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123984 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/#review124380 --- src/launcher/fetcher.cpp (line 77)

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 17, 2016, 7:43 p.m.) Review request for mesos, Adam B,

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/ --- (Updated March 16, 2016, 11:21 a.m.) Review request for mesos and Till

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-19 Thread Avinash sridharan
> On March 11, 2016, 6:45 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358 > > > > > > If we block here, it will lock the isolator, and prevent the > >

Re: Review Request 43884: Added allocator metrics for used quotas.

2016-03-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review124061 --- Thanks Benjamin! The main higher level suggestion here is to add

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 18, 2016, 2:31 p.m.) Review request for mesos, Avinash

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-19 Thread Joerg Schad
> On March 19, 2016, 10:49 a.m., Joerg Schad wrote: > > docs/authentication.md, line 45 > > > > > > Does it make to create a 'Master and Slave Options' section similar to > > configuration.md. > > Otherwise we

Review Request 44898: Update containerizer construction in health_check_tests.cpp.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44898/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44998: Fixed m4 macro to enable strict C++11 conformance.

2016-03-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44998/#review124133 --- Ship it! Ship It! - Joris Van Remoortere On March 17, 2016,

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-03-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 17, 2016, 6:53 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-03-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 18, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/#review124281 --- 3rdparty/libprocess/include/process/collect.hpp (line 260)

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-19 Thread Greg Mann
> On March 14, 2016, 9:38 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 63-64 > > > > > > Seems like you're changing the meaning of the parameters in > >

Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

2016-03-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44978/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-03-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 18, 2016, 3:45 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

2016-03-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 17, 2016, 6:53 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 18, 2016, 6:32 p.m.) Review request for mesos, Adam B,

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 18, 2016, 7:30 p.m.) Review request for mesos, Adam B,

Re: Review Request 44760: Windows: Fixed non-blocking connect.

2016-03-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 17, 2016, 6:54 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44826: Remove `SlaveState` in `TestContainerizer` during recover.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44826/ --- (Updated March 16, 2016, 11:26 a.m.) Review request for mesos and Till

Re: Review Request 44991: Enabled mocking on `TestContainerizer::destroy`.

2016-03-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44991/#review124293 --- Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:46

Re: Review Request 44777: Added a flags parser for vector to src/common/parse.hpp.

2016-03-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44777/ --- (Updated March 18, 2016, 12:14 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44852: Documented existing allocator metrics.

2016-03-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44852/#review124056 --- docs/monitoring.md (line 863)

Re: Review Request 44651: Cleaned up formatting in executor library.

2016-03-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44651/ --- (Updated March 17, 2016, 11:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44900: Update containerizer construction in slave_tests.cpp.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44900/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till

Review Request 44948: Add XFS disk resource isolator.

2016-03-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOs-4828

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124387 --- Fix it, then Ship it! One last question src/tests/mesos.cpp

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-19 Thread Adam B
> On March 18, 2016, 2:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling

Review Request 45007: Fixed `using` declaration order in `mesos-execute`.

2016-03-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45007/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3559

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-19 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 17, 2016, 1:39 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124390 --- src/tests/resource_offers_tests.cpp (lines 84 - 85)

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124395 --- src/tests/resource_offers_tests.cpp (line 77)

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-19 Thread Tomasz Janiszewski
> On March 19, 2016, 7:08 a.m., haosdent huang wrote: > > In fact zipfile containg duplicates is valid zip. There is a problem with extracting files, becouse `unzip` will prompt user how to deal with it. Forcing overwrite makes unzip works like `tar` and `gunzip`. When zip file is invalid or

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124397 --- src/tests/slave_tests.cpp (line 1504)

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-19 Thread Adam B
> On March 18, 2016, 1:55 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 87-91 > > > > > > Is it ok to specify a realm but no credentials? Does that just mean > > that nobody

Review Request 45001: Replaced const ref to temporary in tests for consistency.

2016-03-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45001/ --- Review request for mesos, Jie Yu and Neil Conway. Repository: mesos

Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

2016-03-19 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4070

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 16, 2016, 8:57 p.m.) Review request for mesos, Avinash

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review124391 --- Ship it! - Joerg Schad On March 18, 2016, 6:13 p.m., Greg

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review124274 --- Looks like the recent test refactor (mine) created more work for

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-19 Thread Qian Zhang
> On March 17, 2016, 1:35 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 240-244 > > > > > > I think this comment is for static IP addresses. You should be > >

Re: Review Request 44651: Cleaned up formatting in executor library.

2016-03-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44651/#review124270 --- Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:27

Re: Review Request 44901: Update containerizer construction in filesystem_isolator_tests.cpp.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44901/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review124388 --- Ship it! Ship It! - Adam B On March 17, 2016, 12:42 p.m.,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124392 --- src/slave/flags.cpp (line 685)

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review124394 --- Ship it! Ship It! - Joerg Schad On March 17, 2016, 7:42

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124393 --- src/launcher/fetcher.cpp (lines 255 - 256)

Re: Review Request 45040: Added a test for task's kill policy.

2016-03-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45040/ --- (Updated March 19, 2016, 10:40 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-19 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/ --- (Updated March 19, 2016, 10:26 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 44652: Omitted names of unused parameters in command executor.

2016-03-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44652/ --- (Updated March 19, 2016, 10:31 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review124384 --- Ship it! Ship It! - Adam B On March 18, 2016, 10:28 a.m.,

Review Request 44084: Windows: Forked os::rename().

2016-03-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/#review124398 --- docs/authentication.md (line 45)

Re: Review Request 44903: Update containerizer construction in port_mapping_tests.cpp.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44903/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till

  1   2   3   4   >