Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review125394 --- Fix it, then Ship it! Let's agree to remove the below check

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review125395 --- Great test for the rescind patch! Just a few cleanup suggestions

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/ --- (Updated March 25, 2016, 9:13 a.m.) Review request for mesos and Adam B.

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review125393 --- Fix it, then Ship it! Looks great. I'll fix up these last bits

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125397 --- Patch looks great! Reviews applied: [45317] Passed command:

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 25, 2016, 8:20 a.m.) Review request for mesos, Adam B and

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

2016-03-25 Thread Jay Guo
> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the

Re: Review Request 44500: Implemented passing image and user env var to command task.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/#review125413 --- Patch looks great! Reviews applied: [44498, 44499, 44500]

Re: Review Request 45214: Updated protobuf to support external storage.

2016-03-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- (Updated 三月 25, 2016, 2:07 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-25 Thread Greg Mann
> On March 24, 2016, 7:57 p.m., Greg Mann wrote: > > src/cli/execute.cpp, line 215 > > > > > > s/sepcified/specified/ > > Jian Qiu wrote: > Sorry for the typo... please review again. No worries :-) The patch

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-25 Thread Neil Conway
> On March 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. > > Neil Conway wrote: > Are non-ASCII characters in .md files actually required? We should be > able to use HTML character entities instead (e.g., ``) instead. >

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/#review125425 --- Patch looks great! Reviews applied: [45327] Passed command:

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125427 --- Thanks for working on this. Added some comments. Also, one more

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-25 Thread Vinod Kone
> On March 24, 2016, 7:16 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [44372] > > > > Failed command: ./support/apply-review.sh -n -r 44372 > > > > Error: > > 2016-03-24 07:16:51 URL:https://reviews.apache.org/r/44372/diff/raw/ > > [104639/104639] -> "44372.patch"

Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45299/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45300/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- (Updated March 25, 2016, 8:55 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
> On March 25, 2016, 8:20 p.m., Vinod Kone wrote: > > LGTM. > > > > Can you update the CHANGELOG and call out this change in "Additonal API > > Changes" section for 0.29.0? Thanks Vinod. Just updated the CHANGELOG. - Yong --- This is

Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/ --- Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. Bugs:

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

2016-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/#review125471 --- Can you split this review into 2 reviews 1) Changes needed just

Re: Review Request 45000: MESOS-3902: [Updated] Fix location header in redirect from non-leader.

2016-03-25 Thread Ashwin Murthy
Thanks! On Fri, Mar 25, 2016 at 10:18 AM, Vinod Kone wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45000/ > > Ship it! > > Thanks for following up with a real test! > > Btw, no need for that NOTE as the bug is attached

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125463 --- Can you also make a similar change as

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 9:19 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125462 --- Ship it! LGTM - Anand Mazumdar On March 25, 2016, 5:56

Re: Review Request 44376: [WIP]Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

2016-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/#review125468 --- Regarding testing: The upgrade script doesn't really test ZK

Re: Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45300/#review125473 --- Bad patch! Reviews applied: [45300, 45299, 44084, 44978, 44082,

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
> On March 25, 2016, 9:23 p.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you rebase? Just rebased the review request. Thanks a lot! - Yong --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45073: Restructured authentication.md to group common flags.

2016-03-25 Thread Greg Mann
> On March 20, 2016, 5:44 p.m., Greg Mann wrote: > > Personally, I'm not convinced that this is a useful way to format our flag > > documentation. I've been meaning to propose eliminating it from > > 'configuration.md'. I think it's more confusing to have the lists of flags > > broken up into

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 9:25 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Daniel Pravat
> On March 25, 2016, 6:48 p.m., Yi Sun wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 87 > > > > > > nit: getpagesize() is irrelevant now. Alex is working on replacing getpagesize()

Re: Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/#review125469 --- Patch looks great! Reviews applied: [44678, 44703, 44515, 44523,

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
> On March 25, 2016, 8:18 p.m., Anand Mazumdar wrote: > > Can you also make a similar change as https://reviews.apache.org/r/45317/ > > to `src/slave/validation.cpp` if `Call::Type` is not present. Hi Anand, the review request has been updated. Let me know if there are other issues. Again,

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
> On March 25, 2016, 8:22 p.m., Vinod Kone wrote: > > LGTM modulo Anand's comments. Please also update the CHANGELOG. Hi Vinod, the CHANGELOG has been updated. Let me know if there are other issues and thanks a lot for the review. - Yong

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125486 --- Patch looks great! Reviews applied: [45342] Passed command:

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Vinod Kone
> On March 25, 2016, 9:23 p.m., Vinod Kone wrote: > > Ship It! Can you rebase? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125476

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125476 --- Ship it! Ship It! - Vinod Kone On March 25, 2016, 9:19

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125464 --- LGTM. Can you update the CHANGELOG and call out this change in

Re: Review Request 45120: Extended `os::rmdir` in stout to support preserving the root directory.

2016-03-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45120/#review125489 ---

Re: Review Request 43883: Added a metric for querying the number offer filters for a role.

2016-03-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review125485 --- The code looks pretty clean, thanks! However, there were two bugs

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/#review125499 --- src/tests/persistent_volume_tests.cpp (line 243)

Re: Review Request 44376: [WIP]Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/#review125488 --- Bad patch! Reviews applied: [44376] Failed command:

Re: Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/#review125495 --- Bad patch! Reviews applied: [44678, 44703, 44515, 44523, 44553,

Re: Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ --- (Updated March 26, 2016, 12:07 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-25 Thread Kevin Klues
> On March 18, 2016, 6:51 p.m., Vinod Kone wrote: > > Looks good to me. Couple of things before this can get committed. > > > > --> Have you sent an email to dev/user list about this backwards > > incompatible change? If not, you should. > > > > --> If users are depending on the return code

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

2016-03-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44499/#review125506 --- src/launcher/executor.cpp (line 311)

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-25 Thread Deshi Xiao
> On 三月 23, 2016, 8:21 a.m., Deshi Xiao wrote: > > can we ignore .md scan? the .md possible container non-ascii characters. > > Neil Conway wrote: > Are non-ASCII characters in .md files actually required? We should be > able to use HTML character entities instead (e.g., ``) instead. > >

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/#review125490 --- Bad patch! Reviews applied: [44257] Failed command:

Re: Review Request 45120: Extended `os::rmdir` in stout to support preserving the root directory.

2016-03-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45120/#review125493 --- Ship it! Ship It! - Jie Yu On March 26, 2016, 12:25 a.m.,

Re: Review Request 45120: Extended `os::rmdir` in stout to support preserving the root directory.

2016-03-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45120/ --- (Updated March 26, 2016, 12:25 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/ --- (Updated March 26, 2016, 12:25 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 45121: Implemented deletion for persistent volumes.

2016-03-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45121/#review125492 --- Fix it, then Ship it! src/slave/slave.cpp (line 2333)

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125465 --- LGTM modulo Anand's comments. Please also update the CHANGELOG.

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

2016-03-25 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45015/#review125446 --- Fix it, then Ship it! Ship It!

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125449 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 45009: Transition `filesystem_tests.cpp` to use `path::join`.

2016-03-25 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45009/#review125448 --- Ship it! Ship It! - Yi Sun On March 18, 2016, 12:51 a.m.,

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-25 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review125451 --- Ship it! Ship It! - Yi Sun On March 24, 2016, 2:59 p.m.,

Re: Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45299/#review125452 --- Fix it, then Ship it! Ship It!

Re: Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45300/#review125453 --- Ship it! Ship It! - Yi Sun On March 25, 2016, 6:12 p.m.,

Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 6:58 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
> On March 25, 2016, 5:02 p.m., Anand Mazumdar wrote: > > Thanks for working on this. Added some comments. > > > > Also, one more additional change would be needed: > > > > Since now that the `Type` field is optional we would like to add validation > > on master to ignore the request if the

Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

2016-03-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45249/ --- (Updated March 25, 2016, 4:42 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 45290: Added a test for the '/files/debug' endpoint.

2016-03-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ --- (Updated March 25, 2016, 4:42 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review125437 --- Patch looks great! Reviews applied: [44450, 45202] Passed

Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- (Updated March 25, 2016, 5:56 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45000: MESOS-3902: [Updated] Fix location header in redirect from non-leader.

2016-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review125434 --- Ship it! Thanks for following up with a real test! Btw, no

Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.

2016-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/#review125435 --- Ship it! Ship It! - Vinod Kone On March 25, 2016, 2:28