Re: Review Request 46814: Refactored FlagsBase::load().

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46814/ --- (Updated April 29, 2016, 6:43 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/ --- (Updated April 29, 2016, 5:05 p.m.) Review request for mesos, Adam B, haosdent

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/ --- (Updated April 29, 2016, 5:13 p.m.) Review request for mesos, Adam B, haosdent

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131066 --- It would be great to implement `CHECK_NREADY`,

Re: Review Request 46828: Fixed newline for `--log_dir` flag usage message.

2016-04-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46828/#review131067 --- Ship it! Ship It! - Alexander Rukletsov On April 29, 2016,

Re: Review Request 46828: Fixed newline for `--log_dir` flag usage message.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46828/ --- (Updated April 29, 2016, 9:30 a.m.) Review request for mesos and Alexander

Re: Review Request 46736: Added authorization description to quota endpoint help.

2016-04-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46736/ --- (Updated April 29, 2016, 9:40 a.m.) Review request for mesos, Adam B,

Re: Review Request 46735: Added support for Authorization information to HELP.

2016-04-29 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46735/#review131064 --- Ship it! Ship It! - Alexander Rojas On April 27, 2016, 5:33

Review Request 46823: Fully qualified addresses of Flag members in add calls.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46823/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-3335

Review Request 46821: Avoided slicing of flags in subprocess.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46821/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-3335

Review Request 46824: Fully qualified addresses of Flag members in add calls.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-3335

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/ --- (Updated April 29, 2016, 8:11 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review131062 --- src/master/http.cpp (line 868)

Re: Review Request 46763: Removed unused include in quota_handler.cpp.

2016-04-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46763/ --- (Updated April 29, 2016, 9:09 a.m.) Review request for mesos and Alexander

Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46818/ --- Review request for mesos, Ben Mahler, Greg Mann, and Michael Park. Bugs:

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46815/ --- (Updated April 29, 2016, 6:47 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread Zhiwei Chen
> On April 29, 2016, 2:08 p.m., haosdent huang wrote: > > I saw we order the dependencies by alphabetically, may you update it to > > make sure this? Thanks, fixed. - Zhiwei --- This is an automatically generated e-mail. To reply,

Re: Review Request 46763: Removed unused include in quota_handler.cpp.

2016-04-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46763/#review131063 --- Ship it! Ship It! - Alexander Rukletsov On April 29, 2016,

Review Request 46828: Fixed newline for `--log_dir` flag usage message.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46828/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131053 --- I saw we order the dependencies by alphabetically, may you update

Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 46826: Removed unused header include in libprocess.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46826/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-3335

Review Request 46822: Avoided slicing of flags in subprocess.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46822/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-3335

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-04-29 Thread Jan Schlicht
> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote: > > src/master/http.cpp, line 868 > > > > > > Could you make this capture list explicit (`[this, request]`)? The style guide recommends to prefer default

Re: Review Request 46792: Parameterized agent authorization tests by endpoint.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46792/#review131056 --- src/tests/slave_authorization_tests.cpp (line 65)

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

2016-04-29 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/#review131058 --- This target will not be removed until the term 'slave' is

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/#review131059 --- Patch looks great! Reviews applied: [46816] Passed command:

Re: Review Request 46826: Removed unused header include in libprocess.

2016-04-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46826/#review131068 --- Ship it! Ship It! - Alexander Rukletsov On April 29, 2016,

Re: Review Request 46796: Synced endpoint documentation by running generation script.

2016-04-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46796/#review131073 --- Ship it! Ship It! - haosdent huang On April 29, 2016, 9:57

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

2016-04-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/#review131069 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131075 --- Ship it! Having applied this patch to the master branch, I ran

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-04-29 Thread Benjamin Bannier
> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote: > > src/master/http.cpp, line 868 > > > > > > Could you make this capture list explicit (`[this, request]`)? > > Jan Schlicht wrote: > The style guide

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated April 29, 2016, 1:12 p.m.) Review request for mesos, Alexander

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-29 Thread Guangya Liu
> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote: > > src/cli/execute.cpp, line 283 > > > > > > How to handle those command parameters contains "," here? For example, > > if user want to try "cat 'a,b'". > >

Re: Review Request 46796: Synced endpoint documentation by running generation script.

2016-04-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46796/ --- (Updated April 29, 2016, 9:57 a.m.) Review request for mesos, Alexander

Re: Review Request 46826: Removed unused header include in libprocess.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46826/ --- (Updated April 29, 2016, 9:57 a.m.) Review request for mesos and Alexander

Re: Review Request 46796: Synced endpoint documentation by running generation script.

2016-04-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46796/ --- (Updated April 29, 2016, 9:57 a.m.) Review request for mesos, Alexander

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-04-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/ --- (Updated 四月 29, 2016, 9:56 a.m.) Review request for mesos, Alexander

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Neil Conway
> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote: > > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we > > could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do > > you want to do it here or follow up with another patch? Seems reasonable

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131078 --- Patch looks great! Reviews applied: [46813] Passed command:

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131077 --- src/linux/cgroups.cpp

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-04-29 Thread Benjamin Bannier
> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote: > > src/master/http.cpp, line 868 > > > > > > Could you make this capture list explicit (`[this, request]`)? > > Jan Schlicht wrote: > The style guide

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131070 --- Patch looks great! Reviews applied: [46730] Passed command:

Review Request 46832: Fixed the CMake build.

2016-04-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46832/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/ --- (Updated April 29, 2016, 1:03 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131084 --- Patch looks great! Reviews applied: [46826, 46827] Passed

Re: Review Request 46735: Added support for Authorization information to HELP.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46735/#review131090 --- Fix it, then Ship it!

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review131093 --- Patch looks great! Reviews applied: [46821, 46822, 46823, 46824,

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread Tomasz Janiszewski
> On April 27, 2016, 7:41 p.m., Ben Mahler wrote: > > Could you also update the testing section? How did you ensure this compiles > > on the affected architectures? What do you mean by "testing section"? Unfortunatelly I've only tested it on ARM and x86_64 > On April 27, 2016, 7:41 p.m.,

Re: Review Request 46832: Fixed the CMake build.

2016-04-29 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46832/#review131091 --- Ship it! Ship It! - Bernd Mathiske On April 29, 2016, 6:31

Re: Review Request 46735: Added support for Authorization information to HELP.

2016-04-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46735/ --- (Updated April 29, 2016, 2:25 p.m.) Review request for mesos, Adam B and

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review131104 --- Patch looks great! Reviews applied: [42386] Passed command:

Re: Review Request 46735: Added support for Authorization information to HELP.

2016-04-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46735/ --- (Updated April 29, 2016, 2:24 p.m.) Review request for mesos, Adam B and

Re: Review Request 46736: Added authorization description to quota endpoint help.

2016-04-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46736/ --- (Updated April 29, 2016, 2:26 p.m.) Review request for mesos, Adam B,

Re: Review Request 46735: Added support for Authorization information to HELP.

2016-04-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46735/ --- (Updated April 29, 2016, 2:25 p.m.) Review request for mesos, Adam B and

Re: Review Request 46736: Added authorization description to quota endpoint help.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46736/#review131100 --- Ship it! Ship It! - Neil Conway On April 29, 2016, 2:26

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review131092 --- docs/authorization.md (line 8)

Re: Review Request 46792: Parameterized agent authorization tests by endpoint.

2016-04-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46792/#review131098 --- src/tests/slave_authorization_tests.cpp (lines 82 - 87)

Re: Review Request 46796: Synced endpoint documentation by running generation script.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46796/#review131119 --- Patch looks great! Reviews applied: [46796] Passed command:

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

2016-04-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/#review131120 --- Fix it, then Ship it! Thanks Joseph! LGTM, modulo Joerg's

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

2016-04-29 Thread Vinod Kone
> On April 29, 2016, 7:27 p.m., Michael Park wrote: > > (1) Just so I understand, is this a necessary introduction? or is it an > > improvement? > > (2) In some parts, we access the `name.value` directly, and other times we > > use `stringify(name)`. From the implementation it looks like they

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

2016-04-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review131242 --- Ship it! Ship It! - Greg Mann On April 30, 2016, 1:56 a.m.,

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/#review131233 --- Patch looks great! Reviews applied: [46807, 46858] Passed

Re: Review Request 46621: Added alias support for flags.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated April 30, 2016, 2 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46814: Refactored FlagsBase::load().

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46814/ --- (Updated April 30, 2016, 1:59 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46863/#review131238 --- Bad patch! Reviews applied: [46863, 46669, 46624, 46623, 46622,

Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46863/ --- Review request for mesos and Michael Park. Bugs: MESOS-5271

Re: Review Request 46669: Added deprecation support to Flag name.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ --- (Updated April 30, 2016, 2:01 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/#review131239 --- Bad patch! Reviews applied: [46670, 46815, 46818, 46669, 46624,

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46818/ --- (Updated April 30, 2016, 3:44 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46623: Updated libprocess to work with flag alias.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46623/ --- (Updated April 30, 2016, 3:43 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46621: Added alias support for flags.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated April 30, 2016, 3:43 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46622: Added tests for flag aliases.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46622/ --- (Updated April 30, 2016, 3:43 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46624: Added support to mesos to work with flag alias.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46624/ --- (Updated April 30, 2016, 3:43 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46669: Added deprecation support to Flag name.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ --- (Updated April 30, 2016, 3:44 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/ --- (Updated April 30, 2016, 2:03 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/ --- (Updated April 30, 2016, 1:56 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46621: Added alias support for flags.

2016-04-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review131240 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46815/ --- (Updated April 30, 2016, 3:44 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46863/ --- (Updated April 30, 2016, 3:44 a.m.) Review request for mesos and Michael Park.

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/ --- (Updated April 30, 2016, 3:45 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46814: Refactored FlagsBase::load().

2016-04-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46814/#review131243 --- Ship it! Ship It! - Greg Mann On April 30, 2016, 1:59 a.m.,

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/#review131221 --- Patch looks great! Reviews applied: [46620, 46814, 46621, 46622,

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

2016-04-29 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131235 --- 3rdparty/libprocess/src/subprocess_windows.cpp (lines 305 - 352)

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/#review131244 --- Patch looks great! Reviews applied: [46620, 46814, 46621, 46622,

Re: Review Request 46730: Cleanup syscalls logic.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131157 --- Patch looks great! Reviews applied: [46730] Passed command:

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

2016-04-29 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review131166 --- (1) Just so I understand, is this a necessary introduction? or is

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-04-29 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/ --- (Updated April 29, 2016, 6:41 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131167 --- Patch looks great! Reviews applied: [46827] Passed command:

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131165 --- Ship it! Ship It! - Kapil Arya On April 29, 2016, 5:13

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review131140 --- Patch looks great! Reviews applied: [46784] Passed command:

Re: Review Request 46669: Added deprecation support to Flag name.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ --- (Updated April 29, 2016, 7:08 p.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/ --- (Updated April 29, 2016, 7:10 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-04-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46815/ --- (Updated April 29, 2016, 7:09 p.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46814: Refactored FlagsBase::load().

2016-04-29 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46814/#review131168 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/#review131203 --- Patch looks great! Reviews applied: [46369, 46370, 46371, 46798,

Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-04-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/ --- Review request for mesos, Gilbert Song, Ian Downes, and Timothy Chen. Bugs:

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread Zhiwei Chen
> On April 30, 2016, 12:20 a.m., haosdent huang wrote: > > 3rdparty/versions.am, line 25 > > > > > > I saw the latest version of setuptools is `20.10.1` in > > https://pypi.python.org/pypi/setuptools Do we have any

Re: Review Request 46779: Clarified and improved maintenance docs.

2016-04-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46779/#review131187 --- Fix it, then Ship it! Some suggestions below:

  1   2   >