Re: Review Request 52240: Fixed unit test 'ROOT_RecoverOrphanedPersistentVolume'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52240/#review150352 --- src/tests/containerizer/filesystem_isolator_tests.cpp

Re: Review Request 52008: Added slave helper function for nested containers 'getSandboxPath()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52008/#review150351 --- src/slave/paths.hpp (line 201)

Re: Review Request 52148: Added support for killing child containers to the default executor.

> On Sept. 24, 2016, 9:40 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 492 > > > > > > why VLOG instead of LOG(ERROR)? hmm, this can happen if the container terminated _just_ before the

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/ --- (Updated Sept. 25, 2016, 9:38 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52235: Supported mesos containerizer recover to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52235/#review150344 --- src/slave/containerizer/mesos/containerizer.hpp (line 311)

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

> On Sept. 24, 2016, 9:53 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 427 > > > > > > just inline this function. This is invoked by the `retry()` handler too asynchronously. Hence, it can't

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/ --- (Updated Sept. 25, 2016, 10:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

> On Sept. 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, lines 797-803 > > > > > > Would be great if these can be merged into one struct `Container` > > > > struct Container

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/ --- (Updated Sept. 25, 2016, 10:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52219: Removed slave/agent in the comments of subprocess.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52219/#review150363 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2016, 9:48 a.m.,

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/#review150349 --- Patch looks great! Reviews applied: [52092] Passed command:

Re: Review Request 52246: Added WEXITSTATUS and WTERMSIG gtest helpers to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52246/#review150355 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2016, 4:03 p.m.,

Re: Review Request 52248: Refactored 'os::clone()' to take an optional stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52248/#review150357 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2016, 4:04 p.m.,

Re: Review Request 52146: Made `killTask()` invoke `shutdown()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52146/ --- (Updated Sept. 25, 2016, 9:34 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52231: Fixed driver based schedulers to ACK updates from HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52231/ --- (Updated Sept. 25, 2016, 10:11 p.m.) Review request for mesos and Benjamin

Re: Review Request 51277: Added an 'ns::clone' helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51277/#review150358 --- src/linux/ns.hpp (lines 427 - 430)

Re: Review Request 52249: Refactored some lambda::bind to C++11 lambdas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52249/#review150359 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2016, 4:06 p.m.,

Re: Review Request 52165: Disabled default executor tests for now.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52165/ --- (Updated Sept. 25, 2016, 10:06 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52231: Fixed driver based schedulers to ACK updates from HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52231/ --- (Updated Sept. 25, 2016, 10:08 p.m.) Review request for mesos and Benjamin

Re: Review Request 52245: Added WEXITSTATUS and WTERMSIG gtest helpers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52245/#review150353 --- Fix it, then Ship it! 3rdparty/stout/include/stout/gtest.hpp

Re: Review Request 52247: Updated Mesos tests to use WEXITSTATUS and WTERMSIG gtest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52247/#review150356 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2016, 4:03 p.m.,

Re: Review Request 52147: Added support for launching child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52147/ --- (Updated Sept. 25, 2016, 9:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review150361 --- src/slave/containerizer/mesos/linux_launcher.cpp (line 105)

Re: Review Request 52165: Disabled default executor tests for now.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52165/#review150364 --- Patch looks great! Reviews applied: [52143, 52144, 52164, 52145,

Re: Review Request 52234: Added containerizer helper method 'getContainerIds()'.

> On Sept. 25, 2016, 11:10 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/paths.cpp, lines 156-169 > > > > > > The logic here is a little hard to follow. I am wondering if we should > > let the recursive

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review150371 --- Ship it! LGTM! Much appreciated. - Jiang Yan Xu On Sept.

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/ --- (Updated Sept. 25, 2016, 9:44 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52219: Removed slave/agent in the comments of subprocess.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52219/#review150328 --- Patch looks great! Reviews applied: [51561, 51803, 51560, 52219]

Re: Review Request 52219: Removed slave/agent in the comments of subprocess.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52219/ --- (Updated Sept. 25, 2016, 9:48 a.m.) Review request for mesos, Jie Yu and Joerg

Re: Review Request 46298: Rejected relative path agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/#review150329 --- Discard this PR for now. Will update it after `Flags.load()`

Re: Review Request 52219: Removed slave/agent in the comments of subprocess.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52219/ --- (Updated Sept. 25, 2016, 7:41 a.m.) Review request for mesos, Jie Yu and Joerg

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/ --- (Updated Sept. 26, 2016, 4:31 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52219: Removed slave/agent in the comments of subprocess.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52219/#review150331 --- Patch looks great! Reviews applied: [52219] Passed command:

Review Request 52245: Added WEXITSTATUS and WTERMSIG gtest helpers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52245/ --- Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues. Repository:

Re: Review Request 51275: Factored out a cgroups::isolate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51275/ --- (Updated Sept. 25, 2016, 4:05 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51277: Added an 'ns::clone' helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51277/ --- (Updated Sept. 25, 2016, 4:05 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52245: Added WEXITSTATUS and WTERMSIG gtest helpers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52245/ --- (Updated Sept. 25, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52245: Added WEXITSTATUS and WTERMSIG gtest helpers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52245/ --- (Updated Sept. 25, 2016, 4:10 p.m.) Review request for mesos, Gilbert Song,

Review Request 52246: Added WEXITSTATUS and WTERMSIG gtest helpers to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52246/ --- Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues. Repository:

Review Request 52248: Refactored 'os::clone()' to take an optional stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52248/ --- Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues. Repository:

Re: Review Request 51277: Added an 'ns::enter' helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51277/ --- (Updated Sept. 25, 2016, 4:04 p.m.) Review request for mesos, Gilbert Song,

Review Request 52247: Updated Mesos tests to use WEXITSTATUS and WTERMSIG gtest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52247/ --- Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues. Repository:

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/ --- (Updated Sept. 25, 2016, 4:07 p.m.) Review request for mesos, Gilbert Song,

Review Request 52249: Refactored some lambda::bind to C++11 lambdas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52249/ --- Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues. Repository:

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/ --- (Updated Sept. 25, 2016, 4:08 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51277: Added an 'ns::clone' helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51277/ --- (Updated Sept. 25, 2016, 4:33 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51275: Factored out a cgroups::isolate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51275/ --- (Updated Sept. 25, 2016, 4:34 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51668: Changed the nested ContainerID from hashmap to hashset in memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/#review150335 --- Ship it! Ship It! - Jie Yu On Sept. 24, 2016, 6:50 p.m.,

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/#review150334 --- Ship it! Ship It! - Jie Yu On Sept. 24, 2016, 6:50 p.m.,

Re: Review Request 51669: Changed ContainerConfig::ExecutorInfo from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51669/#review150336 --- Ship it! Ship It! - Jie Yu On Sept. 24, 2016, 6:50 p.m.,

Re: Review Request 51670: Changed the containerizer launch interface for nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51670/#review150337 --- Fix it, then Ship it!

Re: Review Request 51673: Updated mesos containerizer isolate and status for nested support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51673/#review150338 --- Ship it! Ship It! - Jie Yu On Sept. 24, 2016, 6:50 p.m.,

Re: Review Request 51672: Changed containerizer launch for nested containers to return a bool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51672/ --- (Updated Sept. 25, 2016, 10:14 a.m.) Review request for mesos, Benjamin

Re: Review Request 51668: Changed the nested ContainerID from hashmap to hashset in memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/#review150340 --- src/slave/containerizer/mesos/containerizer.hpp (line 340)

Re: Review Request 51674: Supported mesos containerizer destroy to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51674/#review150339 --- src/slave/containerizer/mesos/containerizer.hpp (line 234)

Re: Review Request 52233: Changed 'ExecutorInfo' to be optional in ContainerState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52233/#review150341 --- Fix it, then Ship it! include/mesos/slave/containerizer.proto

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/ --- (Updated Sept. 25, 2016, 5:44 p.m.) Review request for mesos, Gilbert Song,

Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Repository:

Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Repository:

Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Repository:

Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Repository:

Re: Review Request 52234: Added containerizer helper method 'getContainerIds()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52234/#review150342 --- src/slave/containerizer/mesos/paths.hpp (lines 79 - 80)

Re: Review Request 51257: Add external process container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51257/ --- (Updated Sept. 25, 2016, 6:11 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52008: Added slave helper function for nested containers 'getSandboxPath()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52008/ --- (Updated Sept. 25, 2016, 6:11 p.m.) Review request for mesos, Benjamin

Re: Review Request 51258: Add documentation for the ExternalContainerLogger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51258/ --- (Updated Sept. 25, 2016, 6:12 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review150346 --- src/slave/containerizer/mesos/linux_launcher.cpp (line 578)

Re: Review Request 51668: Changed the nested ContainerID from hashmap to hashset in memory.

> On Sept. 25, 2016, 10:27 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 340 > > > > > > Should we change 'containers' to 'children'? You can do that in a > > followup patch.