Review Request 64217: Added scheduler driver benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64217/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8120

Re: Review Request 64217: Added scheduler driver benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64217/ --- (Updated Nov. 30, 2017, 10:03 a.m.) Review request for mesos and Benjamin

Re: Review Request 63633: Added ability to protect nested bind expressions from composition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63633/ --- (Updated Nov. 30, 2017, 9:21 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63628: Implemented index_sequence and related functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63628/#review192316 --- I'm thinking we can actually move this to a `stout/cpp14.hpp`

Review Request 64218: Terminated the Slave first before cleaning up its dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64218/ --- Review request for mesos, Chun-Hung Hsiao and Joseph Wu. Repository: mesos

Re: Review Request 63842: Allowed removing non-terminal offer operations.

> On Nov. 30, 2017, 1:33 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Line 7044 (original) > > > > > > Can you add a TODO here to update `Framework::allocatedResources()` to > > include those used by non

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 30, 2017, 5 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 30, 2017, 5 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 63732: Reconciled offer operations between agent and master.

> On Nov. 30, 2017, 2:55 a.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 7426 (patched) > > > > > > See my comment in https://reviews.apache.org/r/63842/ > > > > since removeOfferOperation will

Re: Review Request 63732: Reconciled offer operations between agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/ --- (Updated Nov. 30, 2017, 5 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/ --- (Updated Nov. 30, 2017, 5 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64163: Made sure only non-terminal operations use resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64163/ --- (Updated Nov. 30, 2017, 5 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64086/ --- (Updated Nov. 30, 2017, 5 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Nov. 30, 2017, 10:16 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 63850: Used fully qualified namespace in the scheduler library for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63850/ --- (Updated Nov. 30, 2017, 6:30 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64142: Updated master ACCEPT handler to disallow offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64142/#review192355 --- Fix it, then Ship it! src/master/master.cpp Lines 4139-4143

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 7:01 p.m., Ilya Pronin wrote: > > src/master/master.cpp > > Lines 6789 (patched) > > > > > > I think this is not specific to unreachable agents. Can be an agent > > that was recovered after

Re: Review Request 64218: Terminated the Slave first before cleaning up its dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64218/ --- (Updated Nov. 30, 2017, 7:13 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 63804: Added plumbing for master to reconcile offer operations with agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/ --- (Updated Nov. 30, 2017, 6:20 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63988: Fixed indentation in a test header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63988/ --- (Updated Nov. 30, 2017, 6:31 p.m.) Review request for mesos and Gaston

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review192333 --- Fix it, then Ship it!

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 7:22 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 6788 (patched) > > > > > > I think this type of status updates could benefit from a distinct > > reason for to make it more

Re: Review Request 63804: Added plumbing for master to reconcile offer operations with agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/#review192349 --- Fix it, then Ship it!

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review192379 --- src/status_update_manager/status_update_manager_process.hpp

Re: Review Request 63277: Windows: Ported CPU and memory isolator tests.

> On Nov. 14, 2017, 9:07 a.m., Akash Gupta wrote: > > src/tests/containerizer/cpu_isolator_tests.cpp > > Line 251 (original), 270 (patched) > > > > > > Personally, I think it makes sense to increase this time on

Re: Review Request 63629: Added partial function application implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63629/ --- (Updated Nov. 30, 2017, 8:40 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63628: Implemented index_sequence and related functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63628/ --- (Updated Nov. 30, 2017, 8:40 p.m.) Review request for mesos, Benjamin Mahler

Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/ --- Review request for mesos and Jie Yu. Bugs: MESOS-8284

Re: Review Request 64093: Added operators for offer operation update protobuf classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64093/#review192352 --- src/messages/messages.hpp Lines 48-50 (patched)

Re: Review Request 64094: Added the `OfferOperationStatusUpdateRecord` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64094/#review192377 --- Fix it, then Ship it! src/messages/messages.cpp Lines 213

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 11:22 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 6788 (patched) > > > > > > I think this type of status updates could benefit from a distinct > > reason for to make it more

Re: Review Request 63804: Added plumbing for master to reconcile offer operations with agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/#review192350 --- include/mesos/resource_provider/resource_provider.proto Lines 39

Re: Review Request 64218: Terminated the Slave first before cleaning up its dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64218/#review192353 --- Ship it! It should be fine to flip the ordering here. Since

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/ --- (Updated Nov. 30, 2017, 4:10 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64226: Added a `ns::supported` convenience API.

> On Dec. 1, 2017, 12:07 a.m., Jie Yu wrote: > > src/linux/ns.hpp > > Lines 99 (patched) > > > > > > Can you add some reason why there is a kernel version check there? The reason is in the implementation. I'll move

Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63276/#review192412 --- Ship it! Ship It! - Akash Gupta On Nov. 30, 2017, 11:34

Review Request 64238: Updated the allocator to track allocations via a single code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64238/ --- Review request for mesos, Benjamin Bannier, Jie Yu, Michael Park, and Meng Zhu.

Re: Review Request 64195: Updated the tests to use MULTI_ROLE frameworks by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64195/#review192421 --- Ship it! src/tests/persistent_volume_tests.cpp Line 150

Re: Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review192402 --- src/linux/ns.hpp Lines 99 (patched)

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Nov. 30, 2017, 4:27 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64194: Stripped AllocationInfo from offers to non-MULTI_ROLE schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64194/#review192417 --- Ship it! src/master/master.cpp Lines 8128 (patched)

Review Request 64237: Removed a stale TODO from before frameworks could modify their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64237/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.

Review Request 64236: Documented when ReregisterSlaveMessage.frameworks was introduced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64236/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63276/#review192414 --- src/slave/containerizer/mesos/isolators/windows/cpu.hpp Lines

Re: Review Request 63277: Windows: Ported `Cpu` and `Mem` isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63277/#review192422 --- Ship it! Ship It! - Jie Yu On Nov. 6, 2017, 11:19 p.m.,

Re: Review Request 64236: Documented when ReregisterSlaveMessage.frameworks was introduced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64236/#review192425 --- Ship it! Ship It! - Jie Yu On Dec. 1, 2017, 1:03 a.m.,

Re: Review Request 64217: Added scheduler driver benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64217/#review192386 --- Thanks! We've done the cross-process benchmarking technique a

Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63276/ --- (Updated Nov. 30, 2017, 3:34 p.m.) Review request for mesos, Aaron Wood, Akash

Re: Review Request 64146: Added offer operation update acknowledgement to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64146/#review192391 --- src/slave/slave.cpp Lines 3850 (patched)

Re: Review Request 63278: Windows: Documented the `cpu` and `mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63278/ --- (Updated Nov. 30, 2017, 3:35 p.m.) Review request for mesos, Aaron Wood, Akash

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64144/#review192396 --- src/master/master.cpp Lines 7495 (patched)

Re: Review Request 64233: Removed some dead code in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64233/ --- (Updated Nov. 30, 2017, 11:40 p.m.) Review request for mesos, Benjamin

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64143/#review192389 --- include/mesos/resource_provider/resource_provider.proto Line 37

Re: Review Request 64009: Added new UpdateSlave registry operation.

> On Nov. 29, 2017, 4:30 p.m., Michael Park wrote: > > I think the fact that `UpdateSlave` gets a `SlaveInfo` in the old format is > > due > > to the fact that we don't upgrade those resources in the master until we > > get to > > the `Slave` struct ctors, as well as the fact that the agents

Review Request 64232: Add a temporary filter for overlay backend related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64232/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 64093: Added operators for offer operation update protobuf classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64093/ --- (Updated Nov. 30, 2017, 3:22 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64094: Added the `OfferOperationStatusUpdateRecord` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64094/ --- (Updated Nov. 30, 2017, 3:22 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64145: Added status update acknowledgement to resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64145/#review192397 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 6 p.m., Greg

Review Request 64233: Removed some dead code in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64233/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.

Re: Review Request 63277: Windows: Ported `Cpu` and `Mem` isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63277/#review192403 --- Ship it! Ship It! - Akash Gupta On Nov. 6, 2017, 11:19

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64144/#review192378 --- src/common/protobuf_utils.hpp Lines 156 (patched)

Re: Review Request 64217: Added scheduler driver benchmarks.

> On Nov. 30, 2017, 2:44 p.m., Benjamin Mahler wrote: > > Thanks! > > > > We've done the cross-process benchmarking technique a few times already to > > avoid the local message passing, but it's rather complicated. The question > > has come up before of whether we can add an option to disable

Re: Review Request 64136: Introduced an allocator helper function to track used resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64136/#review192390 --- src/master/allocator/mesos/hierarchical.cpp Lines 1902-1910

Re: Review Request 64093: Added operators for offer operation update protobuf classes.

> On Nov. 30, 2017, 1:40 p.m., Greg Mann wrote: > > src/messages/messages.hpp > > Lines 48-50 (patched) > > > > > > `OfferOperationStatus` is defined in 'include/mesos/mesos.proto', so > > the correct place for its

Re: Review Request 63274: Windows: Added `os::get_job_mem` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63274/ --- (Updated Nov. 30, 2017, 3:32 p.m.) Review request for mesos, Aaron Wood, Akash

Re: Review Request 63275: Windows: Abstracted out `os::name_job` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63275/ --- (Updated Nov. 30, 2017, 3:32 p.m.) Review request for mesos, Aaron Wood, Akash

Re: Review Request 64233: Removed some dead code in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64233/#review192399 --- Ship it! Ship It! - Benjamin Mahler On Nov. 30, 2017, 11:40

Re: Review Request 63779: Windows: Fixed `SlaveReregisterTaskExecutorIds` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63779/ --- (Updated Nov. 30, 2017, 3:41 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 63779: Windows: Fixed `SlaveReregisterTaskExecutorIds` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63779/#review192401 --- Ship it! Ship It! - Akash Gupta On Nov. 30, 2017, 11:41

Re: Review Request 63021: Added `getService()` function to launch CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/ --- (Updated Dec. 1, 2017, 1:36 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review192409 --- Result of the review session with Graag.

Re: Review Request 64102: Renamed curl target to libcurl, and staging of curl.exe on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64102/#review192431 --- Ship it! Ship It! - Andrew Schwartzmeyer On Nov. 30, 2017,

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63387/ --- (Updated Dec. 1, 2017, 1:55 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 64103: Changed dependency of curl to libcurl for stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64103/#review192432 --- Ship it! Ship It! - Andrew Schwartzmeyer On Nov. 30, 2017,

Re: Review Request 63859: Windows: Fixed mock signal values in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review192435 --- 3rdparty/stout/include/stout/windows.hpp Lines 343-348

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Nov. 16, 2017, 11:25 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 67 (patched) > > > > > > You could declare a `Seconds(30)` and not have to use > >

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review192436 --- src/tests/containerizer/docker_tests.cpp Lines 62 (patched)

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63823/#review192440 --- src/resource_provider/storage/provider.cpp Lines 245 (patched)

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63823/ --- (Updated Dec. 1, 2017, 1:34 a.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 64044: Recover controller and node services and clean up unused containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64044/ --- (Updated Dec. 1, 2017, 1:38 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/ --- (Updated Nov. 30, 2017, 5:42 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64102: Renamed curl target to libcurl, and staging of curl.exe on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64102/#review192430 --- 3rdparty/CMakeLists.txt Lines 614-617 (patched)

Re: Review Request 64075: Added the `ResourceProviderState` protobuf for resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64075/ --- (Updated Dec. 1, 2017, 1:47 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review192429 --- src/docker/docker.cpp Lines 742-743 (original), 742-752

Re: Review Request 63386: Added utility functions to print types in resource provider events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63386/ --- (Updated Dec. 1, 2017, 1:53 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Dec. 1, 2017, 1:52 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/#review192433 --- Fix it, then Ship it! src/slave/CMakeLists.txt Lines 25-28

Re: Review Request 63628: Implemented index_sequence and related functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63628/#review192445 --- Ship it! Ship It! - Michael Park On Nov. 30, 2017, 12:40

Re: Review Request 64168: Introduced a 'OperationUUID' type.

> On Nov. 30, 2017, 4:05 a.m., Jie Yu wrote: > > include/mesos/mesos.proto > > Lines 2186 (patched) > > > > > > In fact, I think it might make sense to make it a general UUID type > > (rather than specific to

Re: Review Request 64151: Added a V1 API call to list resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64151/ --- (Updated Nov. 30, 2017, 3:11 p.m.) Review request for mesos, Benjamin Bannier