Review Request 64885: Made sure continuations using actor state are executed in actor context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64885/ --- Review request for mesos, Gilbert Song and Zhitao Li. Repository: mesos

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Jan. 2, 2018, 10:27 p.m., Gaston Kleiman wrote: > > docs/csi.md > > Lines 288-291 (patched) > > > > > > s/framework/scheduler/ > > s/that is available to the frameworks/that is available to them/ > >

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 151 (patched) > > > > > > Can we make it clear that we're talking about a hypothetical EBS > > plugin? AFAIK the external resource

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/ --- (Updated Jan. 3, 2018, 5:09 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64885: Made sure continuations using actor state are executed in actor context.

> On Jan. 2, 2018, 5:12 p.m., Zhitao Li wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp > > Line 568 (original), 568 (patched) > > > > > > I don't think the callback here uses any internal state

Re: Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents.

> On Jan. 2, 2018, 4:55 p.m., Benno Evers wrote: > > src/master/master.cpp > > Line 6597 (original) > > > > > > Should we issue a warning if an agent that is not resource > > provider-capable tries to reregister

Re: Review Request 64888: Added check for handling of checkpointed resources in reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64888/ --- (Updated Jan. 2, 2018, 6:27 p.m.) Review request for mesos, Benno Evers, Jie

Re: Review Request 64885: Made sure continuations using actor state are executed in actor context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64885/#review194629 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp Line

Re: Review Request 64885: Made sure continuations using actor state are executed in actor context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64885/#review194634 --- Ship it! Ship It!

Review Request 64891: Future-proofed use of agent capabilities in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64891/ --- Review request for mesos, Benno Evers and Jie Yu. Repository: mesos

Re: Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64889/ --- (Updated Jan. 2, 2018, 6:27 p.m.) Review request for mesos, Benno Evers, Jie

Re: Review Request 64885: Made sure continuations using actor state are executed in actor context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64885/#review194632 --- Ship it! Ship It! - Zhitao Li On Jan. 2, 2018, 10:38 a.m.,

Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64889/ --- Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht. Bugs:

Review Request 64888: Added check for handling of checkpointed resources in reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64888/ --- Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht. Bugs:

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194631 --- docs/csi.md Lines 21 (patched)

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194646 --- Should we mention somewhere that the `--enable-grpc` configure

Re: Review Request 64879: Updated fetcher cache tests for the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64879/#review194603 --- src/tests/fetcher_cache_tests.cpp Lines 391-393 (original),

Review Request 64908: Refactored `HttpProxy` to not rely on `SocketManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64908/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 64907: Added abandonment and process exit support to `loop()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64907/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 64906: Exposed `send()` helpers for `Socket`'s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64906/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 64909: Removed unnecessary `SocketManager::dispose` data structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64909/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 298 (patched) > > > > > > this feels like a separate feature. should it be documented elsewhere? Removed the protobuf because it's not

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 137 (patched) > > > > > > > Any disk resource ... inherits the same profile as the storage pool. > > > > Why, and who enforces

Review Request 64901: Renamed ACL fields for standalone container API for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64901/ --- Review request for mesos, Jie Yu and Joseph Wu. Repository: mesos

Re: Review Request 64739: Upgraded resources that come from `protobuf::read`.

> On Jan. 2, 2018, 2:39 p.m., Benjamin Mahler wrote: > > Is there a ticket for being more robust in the face of inability to recover > > a downgraded agent? Can you file one if not? > > Also, do we want to target a ticket for 2.1 that stops downgrading? I > > assume the strategy to end the 1.x

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 385 (patched) > > > > > > I'd like to see it called out clearly in the text (vs. being embedded > > in a link) the specific version of

Re: Review Request 64901: Renamed ACL fields for standalone container API for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64901/#review194677 --- Ship it! Ship It! - Jie Yu On Jan. 3, 2018, 12:49 a.m.,

Re: Review Request 64899: Removed `nodist_liburi_volume_profile_SOURCES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64899/#review194678 --- Ship it! Ship It! - Jie Yu On Jan. 2, 2018, 10:48 p.m.,

Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63976/ --- (Updated Jan. 2, 2018, 3:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Jan. 2, 2018, 7:53 p.m., Greg Mann wrote: > > Should we mention somewhere that the `--enable-grpc` configure flag must be > > set to enable CSI support in the agent? Good call. Added. - Jie --- This is an automatically generated

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Jan. 2, 2018, 7:49 p.m., Greg Mann wrote: > > docs/csi.md > > Lines 109 (patched) > > > > > > I'm curious: is this accurate as written, or would "must not be set by > > frameworks" be more appropriate? > >

Re: Review Request 64898: Removed duplicated code that tests for removable tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64898/ --- (Updated Jan. 3, 2018, 12:26 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 64898: Removed duplicated code that tests for removable tasks.

> On Jan. 2, 2018, 10:43 p.m., Gaston Kleiman wrote: > > I think that you need to rebase this RR. Thanks! - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64898/#review194661

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

- Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194631 --- On Dec. 29, 2017, 4:53 a.m., Jie Yu wrote: > >

Re: Review Request 64739: Upgraded resources that come from `protobuf::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64739/ --- (Updated Jan. 2, 2018, 3:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Jan. 2, 2018, 10:27 p.m., Gaston Kleiman wrote: > > docs/csi.md > > Lines 781-783 (patched) > > > > > > We should probalby say what's the difference between removing an SLRP > > and marking it as gone. I guess

Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

> On Dec. 20, 2017, 6:24 p.m., Benjamin Mahler wrote: > > src/common/resources_utils.hpp > > Line 175 (original), 175-176 (patched) > > > > > > s/does/do/? > > > > Maybe remove the first sentence and just

Re: Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64694/#review194649 --- src/tests/resource_provider_manager_tests.cpp Line 1032

Review Request 64897: Fixed CI build failure for `volume_profile.pb.h`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64897/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-8369

Re: Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`.

> On Jan. 2, 2018, 12:56 p.m., Greg Mann wrote: > > src/tests/resource_provider_manager_tests.cpp > > Line 1032 (original), 1017 (patched) > > > > > > It does work to declare this as a const ref, but a bit weird.

Review Request 64895: Renamed "normalize" to "upgrade" in resources adjustment operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64895/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/#review194648 --- src/slave/slave.cpp Lines 7294 (patched)

Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63976/ --- (Updated Jan. 2, 2018, 12:55 p.m.) Review request for mesos and Benjamin

Re: Review Request 64739: Upgraded resources that come from `protobuf::read`.

> On Dec. 21, 2017, 6:55 p.m., Benjamin Mahler wrote: > > Hm.. I was a little puzzled here, why do some use convert with POST and > > some use the reflection based upgrade? Shouldn't we just use the reflection > > based upgrade everywhere? Sorry for the confusion. The `upgradeResources` used

Re: Review Request 64897: Fixed CI build failure for `volume_profile.pb.h`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64897/#review194652 --- Ship it! Ship It! - Jie Yu On Jan. 2, 2018, 9:15 p.m.,

Re: Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64694/#review194656 --- Ship it! Ship It! - Greg Mann On Dec. 19, 2017, 12:04 a.m.,

Review Request 64898: Removed duplicated code that tests for removable tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64898/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`.

> On Jan. 2, 2018, 8:56 p.m., Greg Mann wrote: > > src/tests/resource_provider_manager_tests.cpp > > Line 1032 (original), 1017 (patched) > > > > > > It does work to declare this as a const ref, but a bit weird.

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review194604 --- src/python/lib/mesos/http.py Lines 149 (patched)

Re: Review Request 64739: Upgraded resources that come from `protobuf::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64739/#review194659 --- Ship it! Is there a ticket for being more robust in the face

Re: Review Request 64898: Removed duplicated code that tests for removable tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64898/#review194661 --- I think that you need to rebase this RR. - Gaston Kleiman On

Review Request 64899: Removed `nodist_liburi_volume_profile_SOURCES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64899/ --- Review request for mesos, Jie Yu and James Peach. Bugs: MESOS-8370

Re: Review Request 63977: Used the protobuf-reflection-based 'downgradeResources' utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63977/#review194660 --- Fix it, then Ship it! src/slave/slave.cpp Lines 1294-1296

Re: Review Request 64895: Renamed "normalize" to "upgrade" in resources adjustment operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64895/#review194657 --- Ship it! Ship It! - Benjamin Mahler On Jan. 2, 2018, 8:41

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194653 --- docs/csi.md Lines 21 (patched)