Re: Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66327/#review200096 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200098 --- 3rdparty/CMakeLists.txt Lines 58-63 (patched)

Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66330/#review200103 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66325: Implemented idempotency for agent resource provider config API calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66325/#review200104 --- src/resource_provider/daemon.cpp Line 186 (original), 187

Re: Review Request 66309: Externalize creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review200105 --- src/resource_provider/registrar.hpp Lines 28 (patched)

Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66330/#review200107 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66330/ --- (Updated March 28, 2018, 2:01 p.m.) Review request for mesos, Andrew

Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66330/#review200106 --- Patch looks great! Reviews applied: [66330] Passed command:

Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review200131 --- Thanks for all efforts on this issue, Andrei. However, adding a

Re: Review Request 66052: Added new operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/ --- (Updated March 28, 2018, 11:28 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/ --- (Updated March 28, 2018, 11:29 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/ --- (Updated March 28, 2018, 11:25 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66144: Enforced task launch order on the agent.

> On March 23, 2018, 1:12 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2906-2910 (patched) > > > > > > In this case, the executor struct exists - do we really want to erase > > the sequence here? ah,

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- (Updated March 28, 2018, 12:05 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

> On March 27, 2018, 6:58 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 11881-11887 (original), 11885-11890 (patched) > > > > > > Currently, it looks like `Slave::usedResources` is the same as the >

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review200126 --- Bad patch! Reviews applied: [66050, 66049, 66343, 66342] Failed

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated March 28, 2018, 11:26 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 3:24 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 4258 (original), 4258 (patched) > > > > > > Could you split the agent changes into a separate patch? This is a > > significant

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 12:14 p.m., Greg Mann wrote: > > src/common/resources_utils.cpp > > Lines 203-205 (patched) > > > > > > This is already done in the validation code - do we need to do it again > > here? Ditto

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated March 28, 2018, 11:24 a.m.) Review request for mesos, Chun-Hung

Review Request 66344: Supported non-speculative operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66344/ --- Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.

Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66255/#review200130 --- Ship it! Ship It! - Zhitao Li On March 23, 2018, 1:44 p.m.,

Re: Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66327/#review200169 --- PASS: Mesos patch 66327 was successfully built and tested.

Re: Review Request 66342: Added difference operator overload for hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66342/#review200167 --- Ship it! Ship It! - Jason Lai On March 28, 2018, 6:23 p.m.,

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review200172 --- Ship it! Ship It! - Gilbert Song On March 28, 2018, 5:07

Re: Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65856/#review200171 --- Ship it! Ship It! - Gilbert Song On March 28, 2018, 4:51

Re: Review Request 66347: Added a test for killing executor during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66347/#review200170 --- Patch looks great! Reviews applied: [66118, 66119, 66120, 65679,

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

> On March 22, 2018, 11:08 p.m., Gilbert Song wrote: > > As we discussed, the motivation to remove the default values is to make it explicit at the call site to improve readability. - Chun-Hung --- This is an automatically generated

Re: Review Request 66325: Implemented idempotency for agent resource provider config API calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66325/ --- (Updated March 29, 2018, 2:10 a.m.) Review request for mesos, Benjamin

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review200166 --- PASS: Mesos patch 65876 was successfully built and tested.

Re: Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66327/#review200125 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66342: Added difference operator overload for hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66342/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Jason Lai.

Review Request 66343: Added test for difference operator of hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66343/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Jason Lai.

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/ --- (Updated March 29, 2018, 12:07 a.m.) Review request for mesos and Gilbert

Re: Review Request 66326: Added tests for agent resource provider API idempotency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66326/#review200155 --- Ship it! Ship It! - Jie Yu On March 28, 2018, 3:09 a.m.,

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200154 --- PASS: Mesos patch 66323 was successfully built and tested.

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review200164 --- Patch looks great! Reviews applied: [65855, 65856, 65876]

Re: Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65856/ --- (Updated March 28, 2018, 11:51 p.m.) Review request for mesos and Gilbert

Re: Review Request 66347: Added a test for killing executor during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66347/#review200159 --- PASS: Mesos patch 66347 was successfully built and tested.

Re: Review Request 66206: Used native protobuf map in Docker v1 image spec.

> On March 22, 2018, 11:39 a.m., Chun-Hung Hsiao wrote: > > include/mesos/docker/v1.proto > > Line 67 (original), 57 (patched) > > > > > > Since this is a public proto file, is there any endpoint or API that > >

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 3:24 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 8054-8056 (patched) > > > > > > Looks like we will now run `checkpointResources()` on resource provider > > resources which are

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review200142 --- Ship it! Ship It! - Greg Mann On March 28, 2018, 6:24 p.m.,

Re: Review Request 66211: Added the fields `ExposedPorts` and `Volumes` into Docker v1 image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66211/#review200146 --- We were planning to land these patches when we need them. For

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 10:24 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 8054-8056 (patched) > > > > > > Looks like we will now run `checkpointResources()` on resource provider > > resources which are

Re: Review Request 66206: Used native protobuf map in Docker v1 image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66206/#review200141 --- Ship it! Ship It! - Gilbert Song On March 21, 2018, 11:56

Re: Review Request 66207: Used native protobuf map in OCI v1 image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66207/#review200145 --- Ship it! Ship It! - Gilbert Song On March 21, 2018, 11:59

Re: Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66327/ --- (Updated March 28, 2018, 10:22 p.m.) Review request for mesos, Benjamin

Review Request 66347: Added a test for killing executor during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66347/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8617 and MESOS-8624

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 26, 2018, 5:37 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8053-8059 (patched) > > > > > > If we checkpoint resources after sending status updates, then say if > > the agent crashes

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 26, 2018, 5:37 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 4292-4324 (original), 4292-4342 (patched) > > > > > > Let's do some refactoring here. There are 3 cases: > > > > 1.

Re: Review Request 66344: Supported non-speculative operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66344/ --- (Updated March 28, 2018, 2:29 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66325: Implemented idempotency for agent resource provider config API calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66325/ --- (Updated March 28, 2018, 10:20 p.m.) Review request for mesos, Benjamin

Re: Review Request 66344: Supported non-speculative operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66344/ --- (Updated March 28, 2018, 2:41 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 66346: Added two matchers for TaskInfo and TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66346/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66344: Supported non-speculative operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66344/#review200149 --- - Greg Mann On March 28, 2018, 9:41 p.m., Zhitao Li wrote: > >

Re: Review Request 66344: Supported non-speculative operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66344/#review200143 --- src/slave/slave.cpp Line 4311 (original), 4308 (patched)

Re: Review Request 66318: Made agent resource provider config API calls idempotent.

> On March 28, 2018, 2:36 a.m., James DeFelice wrote: > > include/mesos/agent/agent.proto > > Line 332 (original), 338 (patched) > > > > > > Maybe return 409 instead of 404 here, if the caller tries to update a > >

Re: Review Request 66318: Made agent resource provider config API calls idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66318/#review200151 --- Ship it! Ship It! - Jie Yu On March 28, 2018, 3:22 a.m.,

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated March 28, 2018, 4:28 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 66331: Fixed test to assert precondition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66331/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description

Re: Review Request 66331: Fixed test to assert precondition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66331/#review200110 --- Ship it! Ship It! - Jan Schlicht On March 28, 2018, 4:21

Re: Review Request 66291: Added support to max_duration in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66291/#review200119 --- src/launcher/default_executor.cpp Lines 1098-1102 (patched)

Re: Review Request 63733: Don't print full usage for invocation errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63733/#review200116 --- Ship it! Thanks for this Benno - had annoyed me for so long

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200118 --- FAIL: Some of the unit tests failed. Please check the relevant