Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

> On April 18, 2018, 5:03 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.hpp > > Line 815 (original), 819 (patched) > > > > > > This is inconsistent with the existing codebase. Could you justify why > > favoring

Re: Review Request 66531: Added new authorization for `UpdateVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66531/#review201425 --- src/master/master.cpp Line 4432 (original), 4474 (patched)

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated April 18, 2018, 4:28 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66560: Added a new agent flag .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66560/#review201420 --- Patch looks great! Reviews applied: [66559, 66560] Passed

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66652/#review201421 --- Fix it, then Ship it!

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/#review201411 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66683: Updated address field of new CLI config to accept URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review201422 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/#review201427 --- Patch looks great! Reviews applied: [66608] Passed command:

Review Request 66692: Fixed an documentation error in `monitoring.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66692/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 66679: Made the master send operation status updates when dropping operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66679/#review201433 --- Fix it, then Ship it! src/master/master.cpp Line 4047

Re: Review Request 66651: Supported host and port in hdfs constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66651/#review201415 --- Can you add a test in `uri_fetcher_tests.cpp` to verify fetching

Review Request 66683: Updated address field of new CLI config to accept URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8025

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66562/#review201417 --- Fix it, then Ship it!

Re: Review Request 66696: Updated Scheduler HTTP API doc for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66696/#review201458 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > src/tests/CMakeLists.txt > > Line 237 (original), 250-254 (patched) > > > > > > So `uri_disk_profile_adaptor` is, what, a module? that depends on (and

Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66435/#review201462 --- Ship it! Ship It! - Joseph Wu On April 3, 2018, 10:52 p.m.,

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- (Updated April 18, 2018, 2:36 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66696: Updated Scheduler HTTP API doc for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66696/#review201466 --- docs/scheduler-http-api.md Lines 167-172 (original), 170-175

Re: Review Request 66699: Added include to stouts os.hpp header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66699/#review201474 --- 3rdparty/stout/include/stout/windows/os.hpp Lines 43 (patched)

Re: Review Request 66679: Made the master send operation status updates when dropping operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66679/ --- (Updated April 18, 2018, 1:38 p.m.) Review request for mesos and Greg Mann.

Review Request 66700: Changed call from os::shell() to os::system().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66700/ --- Review request for mesos. Repository: mesos Description --- The

Review Request 66699: Added include to stouts os.hpp header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66699/ --- Review request for mesos. Repository: mesos Description --- The header

Re: Review Request 66679: Made the master send operation status updates when dropping operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66679/#review201459 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66692: Fixed an documentation error in `monitoring.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66692/#review201461 --- Patch looks great! Reviews applied: [66692] Passed command:

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201449 --- src/resource_provider/registrar.hpp Line 67 (original), 69

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201469 --- src/resource_provider/registrar.hpp Lines 67-73 (original),

Re: Review Request 66526: Renamed resource provider `AgentRegistrar` to `GenericRegistrar`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66526/#review201470 --- Ship it! Ship It! - Chun-Hung Hsiao On April 10, 2018,

Review Request 66696: Updated Scheduler HTTP API doc for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66696/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66436/#review201463 --- Ship it! Ship It! - Joseph Wu On April 3, 2018, 10:54 p.m.,

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

> On April 18, 2018, 9:51 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.hpp > > Lines 67-73 (original), 69-75 (patched) > > > > > > Not yours, but if each `create()` corresponds to a different type

Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/#review201023 --- Ship it! - Joseph Wu On April 3, 2018, 10:47 p.m., Andrew

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/#review200967 --- Fix it, then Ship it!

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review201021 --- Fix it, then Ship it!

Re: Review Request 66683: Updated address field of new CLI config to accept URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review201439 --- Patch looks great! Reviews applied: [66683] Passed command:

Re: Review Request 61096: Building gRPC with CMake.

> On April 12, 2018, 9:41 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 1012-1015 (patched) > > > > > > As stated above, the probably won't work on Windows yet. Ths VS > > solutions

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review201442 --- 3rdparty/stout/include/stout/os/windows/read.hpp Lines 39-44

Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66434/#review201455 --- Ship it! Ship It! - Joseph Wu On April 4, 2018, 12:18 p.m.,

Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `FileEndOfFileInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66455/#review201258 --- Ship it! - Joseph Wu On April 6, 2018, 4:09 p.m., Andrew

Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66427/#review201030 --- Ship it! - Joseph Wu On April 3, 2018, 10:48 p.m., Andrew

Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/#review201266 --- Ship it! - Joseph Wu On April 3, 2018, 10:50 p.m., Andrew

Re: Review Request 66426: Windows: More constness in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/#review201028 --- Ship it! - Joseph Wu On April 3, 2018, 10:48 p.m., Andrew

Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/#review201259 --- Ship it! - Joseph Wu On April 4, 2018, 12:17 p.m., Andrew

Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66428/#review201125 --- Ship it! - Joseph Wu On April 6, 2018, 3:53 p.m., Andrew

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 387-390 (patched) > > > > > > Do you know which targets actually require `ENABLE_GRPC` set as a > >

Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66432/#review201451 --- Ship it! Ship It! - Joseph Wu On April 6, 2018, 4:14 p.m.,

Review Request 66694: Updated the 1.6.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66694/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Alexander

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201443 --- 3rdparty/CMakeLists.txt Lines 1001 (patched)

Re: Review Request 66692: Fixed an documentation error in `monitoring.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66692/#review201435 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

> On April 18, 2018, 3:03 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8833-8840 (patched) > > > > > > There was a recent discussion in the API WG about adding routes > > dynamically (after

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

> On April 12, 2018, 9:55 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt > > Lines 91 (patched) > > > > > > I think this should instead be appended above. That is, after setting >

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/#review201438 --- Fix it, then Ship it! src/slave/slave.cpp Lines 839 (patched)

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

> On April 12, 2018, 9:55 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt > > Lines 91 (patched) > > > > > > I think this should instead be appended above. That is, after setting >

Re: Review Request 66694: Updated the 1.6.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66694/#review201448 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote: > > src/tests/CMakeLists.txt > > Line 237 (original), 250-254 (patched) > > > > > > So `uri_disk_profile_adaptor` is, what, a module? that depends on (and

Re: Review Request 61096: Building gRPC with CMake.

> On April 18, 2018, 6:57 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 1001 (patched) > > > > > > I see `gpr` in here which looks like a typo for `grp`? No. It's GPR, a library used in

Re: Review Request 66560: Added a new agent flag .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66560/#review201399 --- Where do we use this flag? - Qian Zhang On April 12, 2018,

Re: Review Request 66560: Added a new agent flag .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66560/#review201401 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66561: Supported hdfs fetching in local puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66561/#review201378 ---

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/#review201398 --- Patch looks great! Reviews applied: [66649] Passed command:

Re: Review Request 66651: Supported host and port in hdfs constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66651/#review201407 --- Ship it! Ship It! - Qian Zhang On April 17, 2018, 1:32

Re: Review Request 66711: Made 3rdparty jemalloc only build when enabled.

> On April 18, 2018, 8:57 p.m., Mesos Reviewbot Windows wrote: > > PASS: Mesos patch 66711 was successfully built and tested. > > > > Reviews applied: `['66711']` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66711 Yay, it

Re: Review Request 66526: Renamed resource provider `AgentRegistrar` to `GenericRegistrar`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66526/#review201498 --- src/resource_provider/registrar.cpp Line 186 (original), 186

Re: Review Request 66711: Made 3rdparty jemalloc only build when enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66711/#review201495 --- PASS: Mesos patch 66711 was successfully built and tested.

Re: Review Request 66696: Updated Scheduler HTTP API doc for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66696/#review201497 --- Patch looks great! Reviews applied: [66696] Passed command:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated April 18, 2018, 10:13 p.m.) Review request for mesos and James Peach.

Re: Review Request 66696: Updated Scheduler HTTP API doc for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66696/ --- (Updated April 18, 2018, 3:15 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/#review201475 --- src/resource_provider/manager.hpp Lines 42 (patched)

Re: Review Request 66694: Updated the 1.6.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66694/#review201486 --- Patch looks great! Reviews applied: [66694] Passed command:

Re: Review Request 66699: Added include to stouts os.hpp header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66699/#review201489 --- Ship it! Caveat: We should file an issue and remove

Re: Review Request 66700: Changed call from os::shell() to os::system().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66700/#review201477 --- FAIL: Mesos binaries failed to build. Reviews applied:

Re: Review Request 66696: Updated Scheduler HTTP API doc for operation feedback.

> On April 18, 2018, 2:51 p.m., Greg Mann wrote: > > docs/scheduler-http-api.md > > Lines 426-428 (patched) > > > > > > This call requires the `Accept` header, right? It technically doesn't require the header, but

Review Request 66708: Refactored sending a TASK_DROPPED status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/ --- Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. Bugs:

Review Request 66706: Handled failing to create the executor sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66706/ --- Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. Bugs:

Review Request 66705: Propagated executor sandbox creation errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66705/ --- Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. Bugs:

Review Request 66707: Added a test for launching a task as an unknown user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66707/ --- Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. Bugs:

Review Request 66704: Refactored the executor launch path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66704/ --- Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. Bugs:

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201476 --- src/resource_provider/registrar.hpp Line 113 (original), 114

Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/#review201481 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66700: Changed call from os::shell() to os::system().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66700/#review201490 --- Ship it! I applied and tested this chain manually, it fixed

Re: Review Request 62472: Fixed the ordering of Mesos containerizer isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62472/#review201447 --- src/slave/containerizer/mesos/containerizer.cpp Line 175

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On April 4, 2018, 6:06 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 544 (patched) > > > > > > I may be missing something here, why do you need this? Are you > >

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 4:35 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 368 (patched) > > > > > > Move this into the case statement block. > > Harold Dost wrote: >

Re: Review Request 66679: Made the master send operation status updates when dropping operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66679/#review201493 --- Patch looks great! Reviews applied: [66679] Passed command:

Review Request 66709: Windows: Fixed Ninja in Release configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66709/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Repository: mesos

Re: Review Request 66709: Windows: Fixed Ninja in Release configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66709/#review201492 --- Ship it! Ship It! - Joseph Wu On April 18, 2018, 6:17 p.m.,

Review Request 66711: Made 3rdparty jemalloc only build when enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66711/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benno Evers,

Re: Review Request 66709: Windows: Fixed Ninja in Release configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66709/#review201494 --- FAIL: Mesos binaries failed to build. Reviews applied: