Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review209608 --- Fix it, then Ship it! src/linux/ns.cpp Lines 274 (patched)

Re: Review Request 63654: Added a `net::socketpair` helper to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63654/#review209607 --- Fix it, then Ship it!

Review Request 69041: Relaxed `Promise` constructor and assignment operator requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69041/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Repository: mesos

Review Request 69042: Enabled more constructors for master `RegistryOperation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/ --- Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. Repository:

Re: Review Request 69037: WIP: Added an optional `vendor` field to `DiskInfo.Source`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69037/#review209598 --- PASS: Mesos patch 69037 was successfully built and tested.

Re: Review Request 63654: Added a `net::socketpair` helper to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63654/#review209599 --- Ship it! Ship It! - Gilbert Song On Oct. 1, 2018, 10:36

Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review209600 --- Ship it! Ship It! - Gilbert Song On Oct. 1, 2018, 10:37

Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69053/ --- Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan

Review Request 69052: Added a test to ensure UUID size, variant, version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69052/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review209646 --- PASS: Mesos patch 68706 was successfully built and tested.

Re: Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69053/#review209647 --- Ship it! Ship It! - James DeFelice On Oct. 16, 2018, 6:57

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 16, 2018, 4:49 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69053/#review209659 --- PASS: Mesos patch 69053 was successfully built and tested.

Review Request 69032: Optimized resources filter operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Bugs: MESOS-9325

Re: Review Request 69053: Documented that UUID is a 128 bits (or 16 bytes).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69053/#review209657 --- Ship it! Ship It! - Gastón Kleiman On Oct. 16, 2018, 11:57

Re: Review Request 68089: Added LevelDB compaction after replicated log truncation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68089/#review209663 --- include/mesos/log/log.hpp Lines 202-209 (patched)

Re: Review Request 68089: Added LevelDB compaction after replicated log truncation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68089/#review209665 --- src/log/leveldb.cpp Lines 412-413 (original), 412 (patched)

Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review209668 --- PASS: Mesos patch 63655 was successfully built and tested.

Re: Review Request 69032: Optimized resources filter operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/#review209669 --- Ship it! Can you also post the filter benchmark results?

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review209671 --- Patch looks great! Reviews applied: [68706] Passed command:

Re: Review Request 69032: Optimized resources filter operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/#review209670 --- PASS: Mesos patch 69032 was successfully built and tested.

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review209595 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209597 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 68994: Logged request processing time for some endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68994/#review209616 --- PASS: Mesos patch 68994 was successfully built and tested.

Re: Review Request 68992: Added 'received' timestamp into `process::Request`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68992/#review209605 --- Fix it, then Ship it!

Re: Review Request 68993: Introduced `logResponse` for http handlers.

> On Oct. 11, 2018, 3:11 p.m., Benno Evers wrote: > > src/common/http.cpp > > Lines 1200 (patched) > > > > > > Since the outputs of this log line are likely to be used for > > rudimentary analysis using shell

Re: Review Request 68977: Added Record-IO encoder and decoder to Python library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/ --- (Updated Okt. 16, 2018, 12:16 nachm.) Review request for mesos and Kevin

Re: Review Request 68977: Added Record-IO encoder and decoder to Python library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/ --- (Updated Okt. 16, 2018, 12:35 nachm.) Review request for mesos and Kevin

Re: Review Request 68971: Moved import of '../lib' from new CLI bootstrap to pip-requirements.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68971/ --- (Updated Oct. 16, 2018, 1:33 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 68993: Introduced `logResponse` for http handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68993/#review209609 --- Ship it! Modulo Benno's comment. src/common/http.hpp Lines

Re: Review Request 68994: Logged request processing time for some endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68994/#review209611 --- Ship it! Ship It! - Till Toenshoff On Oct. 11, 2018, 2:16

Re: Review Request 68994: Logged request processing time for some endpoints.

> On Oct. 12, 2018, 10:32 p.m., Benno Evers wrote: > > As we already discussed offline, it's a bit unfortunate to have some code > > duplication here and only have the statistics enabled for selected > > endpoints. (for those unaware, this is done in order to avoid spamming the > > logs with

Re: Review Request 68993: Introduced `logResponse` for http handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68993/ --- (Updated Oct. 16, 2018, 11:57 a.m.) Review request for mesos, Benjamin

Re: Review Request 68994: Logged request processing time for some endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68994/ --- (Updated Oct. 16, 2018, 11:57 a.m.) Review request for mesos, Benjamin

Review Request 69043: Disabled warnings-as-errors for cares build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69043/ --- Review request for mesos. Bugs: MESOS-9302

Review Request 69047: Updated Python library to be easier to handle as a Python module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69047/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8795

Re: Review Request 69047: Updated Python library to be easier to handle as a Python module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69047/#review209612 --- Ship it! Ship It! - Kevin Klues On Okt. 16, 2018, 11:31

Re: Review Request 68992: Added 'received' timestamp into `process::Request`.

> On Oct. 16, 2018, 11:41 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Lines 568-569 (patched) > > > > > > As discussed out of band, let's come up with a proper story here in a >

Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/#review209614 --- PASS: Mesos patch 69042 was successfully built and tested.

Re: Review Request 68992: Added 'received' timestamp into `process::Request`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68992/ --- (Updated Oct. 16, 2018, 11:56 a.m.) Review request for mesos, Benjamin

Re: Review Request 68971: Moved import of '../lib' from new CLI bootstrap to pip-requirements.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68971/#review209615 --- Ship it! Ship It! - Kevin Klues On Okt. 16, 2018, 11:33

Re: Review Request 69043: Disabled warnings-as-errors for cares build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69043/#review209631 --- PASS: Mesos patch 69043 was successfully built and tested.

Re: Review Request 68991: Added a test `FsTest.Lsof`.

> On Oct. 12, 2018, 5:40 p.m., James Peach wrote: > > 3rdparty/stout/tests/os/filesystem_tests.cpp > > Lines 830 (patched) > > > > > > Maybe also add: > > ``` > > EXPECT_FALSE(std::find(fds->begin(),

Re: Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68644/#review209636 --- Ship it! - James Peach On Oct. 14, 2018, 2:05 p.m., Qian

Re: Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess.

> On Oct. 12, 2018, 5:40 p.m., James Peach wrote: > > 3rdparty/libprocess/src/posix/subprocess.hpp > > Lines 213 (patched) > > > > > > Since you are planning a different code path for macOS, maybe hoist > > this

Re: Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68644/#review209635 --- 3rdparty/libprocess/src/posix/subprocess.hpp Lines 19 (patched)

Re: Review Request 68090: Added log_auto_compact flag to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68090/#review209664 --- src/master/flags.cpp Lines 124-128 (patched)

Re: Review Request 63654: Added a `net::socketpair` helper to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63654/ --- (Updated Oct. 16, 2018, 10:26 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/ --- (Updated Oct. 16, 2018, 10:26 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69016: Added a test `SubprocessTest.WhiteListFds`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69016/#review209637 --- Ship it! 3rdparty/libprocess/src/tests/subprocess_tests.cpp