Re: Review Request 69675: Added volume gid manager.

> On Feb. 25, 2019, 10:15 p.m., Benjamin Bannier wrote: > > How is this patch related to https://reviews.apache.org/r/69541/ and > > https://reviews.apache.org/r/69344/? Some issues were raised over there and > > a discussion started. We should strongly avoid loosing such context as it > >

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

> On Feb. 25, 2019, 10:15 p.m., Benjamin Bannier wrote: > > How is this patch related to https://reviews.apache.org/r/69542/? Some > > issues were raised over there and a discussion started. We should strongly > > avoid loosing such context as it makes it harder to understand patches > >

Re: Review Request 69676: Implemented recovery for volume gid manager.

> On Feb. 25, 2019, 10:15 p.m., Benjamin Bannier wrote: > > How is this patch related to https://reviews.apache.org/r/69543/? Some > > issues were raised over there and a discussion started. We should strongly > > avoid loosing such context as it makes it harder to understand patches > >

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated Feb. 26, 2019, 11:05 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/#review213233 --- Bad review! Reviews applied: [66746] Error: 2019-02-26 21:33:43

Re: Review Request 69676: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69676/ --- (Updated Feb. 26, 2019, 11:17 p.m.) Review request for mesos. Changes

Re: Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70060/#review213242 --- Patch looks great! Reviews applied: [70060] Passed command:

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213247 --- Patch looks great! Reviews applied: [70061, 70062, 70063]

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213241 --- Commit description could use some extra context. Not sure if you

Re: Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70060/#review213240 --- Patch looks great! Reviews applied: [70060] Passed command:

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/#review213238 --- Ship it! I feel the patch description is a bit lacking.

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213245 --- Patch looks great! Reviews applied: [70061, 70062, 70063]

Re: Review Request 70044: Moved status update streams of operations on agent's default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/ --- (Updated Feb. 26, 2019, 11:01 a.m.) Review request for mesos, Benno Evers,

Re: Review Request 70044: Moved status update streams of operations on agent's default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/#review213205 --- Note on commit message: s// src/slave/paths.hpp Lines 365

Re: Review Request 69869: Added test for tearing down frameworks while creating disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69869/#review213229 --- Ship it! Ship It! - Greg Mann On Feb. 25, 2019, 9 p.m.,

Re: Review Request 69869: Added test for tearing down frameworks while creating disks.

> On Feb. 25, 2019, 6:59 p.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 5130 (patched) > > > > > > LAUNCH_GROUP isn't a non-speculative operation; it uses `addTask()` > >

Re: Review Request 69869: Added test for tearing down frameworks while creating disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69869/ --- (Updated Feb. 26, 2019, 11:24 a.m.) Review request for mesos, Benno Evers,

Re: Review Request 70040: Added test for terminal operation updates after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70040/ --- (Updated Feb. 26, 2019, 11:25 a.m.) Review request for mesos, Benno Evers,

Re: Review Request 70044: Moved status update streams of operations on agent's default resources.

> On Feb. 26, 2019, 10:46 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 7452 (patched) > > > > > > What's the reason for moving this? I had to change the method's signature in order to be able to be

Re: Review Request 67044: Renamed a method in the master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67044/#review213237 --- Bad review! Reviews applied: [67044] Error: 2019-02-27 00:10:54

Review Request 70061: Added method `fromScalarResources` in `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70061/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9608

Review Request 70062: Refactored and augmented `class ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70062/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9608

Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9608

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/#review213230 --- cmake/CompilationConfigure.cmake Lines 630-637 (original),

Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70054/ --- (Updated Feb. 26, 2019, 8:45 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70044: Moved status update streams of operations on agent's default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/#review213231 --- Patch looks great! Reviews applied: [69977, 69978, 70044]

Re: Review Request 70044: Moved status update streams of operations on agent's default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/#review213232 --- Patch looks great! Reviews applied: [69977, 69978, 70044]

Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70060/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Bugs:

Re: Review Request 70044: Moved status update streams of operations on agent's default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/#review213235 --- Ship it! Ship It! - Greg Mann On Feb. 26, 2019, 7:01 p.m.,

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/#review213234 --- Fly by comment! src/slave/slave.cpp Lines 4694 (patched)

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

> On Feb. 26, 2019, 3:16 p.m., Joseph Wu wrote: > > src/slave/slave.cpp > > Lines 4694 (patched) > > > > > > Is there any reason why this is not the following? > > ``` > > operation->latest_status().state()