Re: Review Request 70907: Added recovery of agent drain information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70907/ --- (Updated June 26, 2019, 2:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/ --- (Updated June 26, 2019, 2:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 70748: Changed semantics of TLS certificate verification flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated June 26, 2019, 10:26 a.m.) Review request for mesos, Alexander

Re: Review Request 70936: Adjusted task status updates during draining.

> On June 25, 2019, 11:48 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 12109 (patched) > > > > > > Maybe we should unconditionally set the reason to > > REASON_AGENT_DRAINING? It doesn't make

Re: Review Request 70897: Supported suppressedRoles in updateFramework() in V0 Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70897/ --- (Updated June 26, 2019, 3:32 p.m.) Review request for mesos and Benjamin

Re: Review Request 70894: Provided ability to change suppressed roles via V0 updateFramework().

> On June 25, 2019, 7:13 p.m., Benjamin Mahler wrote: > > include/mesos/scheduler.hpp > > Lines 290-293 (patched) > > > > > > // NOTE: if the framework is not connected to the master, the suppressed > > // roles

Re: Review Request 70884: Added optional 'host' string member to UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/ --- (Updated June 26, 2019, 1:37 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70895: Added a test for suppressing roles via V0 updateFramework().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70895/ --- (Updated June 26, 2019, 3:33 p.m.) Review request for mesos and Benjamin

Re: Review Request 70895: Added a test for supperssing roles via V0 updateFramework().

> On June 25, 2019, 7:21 p.m., Benjamin Mahler wrote: > > src/tests/master/update_framework_tests.cpp > > Lines 992-996 (patched) > > > > > > The framework update already occurred, and it may be in the allocator's

Re: Review Request 70894: Provided ability to change suppressed roles via V0 updateFramework().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70894/ --- (Updated June 26, 2019, 3:28 p.m.) Review request for mesos and Benjamin

Re: Review Request 70894: Provided ability to change suppressed roles via V0 updateFramework().

> On June 25, 2019, 7:13 p.m., Benjamin Mahler wrote: > > include/mesos/scheduler.hpp > > Lines 290-293 (patched) > > > > > > // NOTE: if the framework is not connected to the master, the suppressed > > // roles

Re: Review Request 70949: Added master minimum capability `QUOTA_V2`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70949/#review216156 --- Ditto comment below w.r.t. the description, can you make the

Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/#review216160 --- src/slave/slave.cpp Lines 5732-5734 (patched)

Re: Review Request 70923: Added a registry operation for the DRAIN_AGENT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70923/ --- (Updated June 26, 2019, 1:44 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 70956: Modified registry operations for unreachable draining agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70956/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and

Re: Review Request 70950: Added a registry field for `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70950/#review216157 --- Can you also expand the commit description with a more precise

Re: Review Request 70951: Updated registry operation `UpdateQuota` to persist `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70951/#review216159 --- src/master/master.cpp Lines 1740-1741 (patched)

Re: Review Request 70936: Adjusted task status updates during draining.

> On June 26, 2019, 10:16 p.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Lines 5732-5734 (patched) > > > > > > I think I got this part incorrect; we should unconditionally set a > >

Review Request 70957: Added registry operation for marking an agent as drained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70957/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and

Re: Review Request 70924: Added registry operations for DE/RE-ACTIVATE_AGENT calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70924/ --- (Updated June 26, 2019, 1:46 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70895: Added a test for suppressing roles via V0 updateFramework().

> On June 25, 2019, 7:21 p.m., Benjamin Mahler wrote: > > src/tests/master/update_framework_tests.cpp > > Lines 992-996 (patched) > > > > > > The framework update already occurred, and it may be in the allocator's

Re: Review Request 70949: Added master minimum capability `QUOTA_V2`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70949/ --- (Updated June 26, 2019, 9:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 70949: Added master minimum capability `QUOTA_V2`.

> On June 26, 2019, 12:18 p.m., Benjamin Mahler wrote: > > Ditto comment below w.r.t. the description, can you make the description > > more precise about the overall approach with this minimum capability and > > the registry? Done. > On June 26, 2019, 12:18 p.m., Benjamin Mahler wrote: > >

Re: Review Request 70950: Added a registry field for `QuotaConfig`.

> On June 26, 2019, 12:22 p.m., Benjamin Mahler wrote: > > Can you also expand the commit description with a more precise comment > > about how these two fields will be used? Done. > On June 26, 2019, 12:22 p.m., Benjamin Mahler wrote: > > src/master/registry.proto > > Lines 140-141

Re: Review Request 70951: Updated registry operation `UpdateQuota` to persist `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70951/ --- (Updated June 26, 2019, 9:50 p.m.) Review request for mesos and Benjamin

Re: Review Request 70951: Updated registry operation `UpdateQuota` to persist `QuotaConfig`.

> On June 26, 2019, 1:21 p.m., Benjamin Mahler wrote: > > src/master/quota.hpp > > Line 64 (original), 64 (patched) > > > > > > What is this comment saying? This constructor is for the UPDATE_QUOTA > > master call

Review Request 70959: Cleared agent drain state when draining is finished.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70959/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9860

Re: Review Request 70907: Added recovery of agent drain information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70907/ --- (Updated June 27, 2019, 1:55 a.m.) Review request for mesos, Greg Mann and

Review Request 70960: Added test for agent to leave draining state on its own.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70960/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9860

Review Request 70958: Changed agent to fail task launches received during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70958/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9862

Re: Review Request 70936: Adjusted task status updates during draining.

> On June 25, 2019, 9:48 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 12109 (patched) > > > > > > Maybe we should unconditionally set the reason to > > REASON_AGENT_DRAINING? It doesn't make

Re: Review Request 70949: Added master minimum capability `QUOTA_V2`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70949/ --- (Updated June 25, 2019, 10:58 p.m.) Review request for mesos and Benjamin

Re: Review Request 70951: Updated registry operation `UpdateQuota` to persist `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70951/ --- (Updated June 25, 2019, 11:03 p.m.) Review request for mesos and Benjamin