Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-11 Thread Alex Clemmer
://reviews.apache.org/r/36837/#comment149713 This line breaks the build on my machine OS X 10.10, and I'm not sure how to fix it because CMake's weird string eval semantics make it hard to just pass a normal quoted string in. Does this break on your machien too? - Alex Clemmer On Aug

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-10 Thread Alex Clemmer
/37273/#comment149372 In glog's solution, you're required to migrate the project to VS2015 before building it. Does this script do that automatically? (Sorry about the noob question, I don't actually know how this works.) - Alex Clemmer On Aug. 10, 2015, 9:50 a.m., haosdent huang wrote

Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.

2015-08-10 Thread Alex Clemmer
locally to the Stout tests CMakeLists, and I think it makes sense to wrap them up into one diff, and push them into master. - Alex Clemmer On Aug. 9, 2015, 6:21 p.m., haosdent huang wrote: --- This is an automatically generated e-mail

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-10 Thread Alex Clemmer
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/glog-0.3.3.patch, line 21 https://reviews.apache.org/r/37273/diff/2/?file=1036048#file1036048line21 Looks like your updating the patchfile here to include my glog PR that opens it to working on MSVC

Re: Review Request 37291: Add missing unimplemented.hpp to windows specific OS code.

2015-08-10 Thread Alex Clemmer
far. What do you think of that option? - Alex Clemmer On Aug. 10, 2015, 10:17 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37291

Re: Review Request 36741: Add small fixes allowing CMake to build Process lib tests on OS X 10.10

2015-07-23 Thread Alex Clemmer
/ProcessConfigure.cmake d6cdd05e281f23f0a57809d3798b5766fb2e9aa6 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 082489ca4a31843886f764105e70e6af9779ca11 Diff: https://reviews.apache.org/r/36741/diff/ Testing --- Tested fixes on OS X 10.10 and Ubuntu 14 boxes. Thanks, Alex

Re: Review Request 36743: Cause CMake to fail and return error code if C++11 not supported

2015-07-23 Thread Alex Clemmer
. Thanks, Alex Clemmer

Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library

2015-07-21 Thread Alex Clemmer
/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/src/tests/CMakeLists.txt PRE-CREATION CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/36514/diff/ Testing --- Includes tests for the process library that all run and pass. Thanks, Alex Clemmer

Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library

2015-07-21 Thread Alex Clemmer
/libprocess/src/tests/CMakeLists.txt PRE-CREATION CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/36514/diff/ Testing --- Includes tests for the process library that all run and pass. Thanks, Alex Clemmer

Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library

2015-07-20 Thread Alex Clemmer
tests for the process library that all run and pass. Thanks, Alex Clemmer

Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

2015-10-24 Thread Alex Clemmer
--- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer

Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

2015-10-24 Thread Alex Clemmer
--- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer

Review Request 39623: CMake: Added protobuf compilation to Windows builds.

2015-10-24 Thread Alex Clemmer
Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-22 Thread Alex Clemmer
is yes. Also, you might be leery of committing this without tests. That's ok! We need this to pull the FS tests out of `os_tests.cpp` though. The last function we will need to port to get those tests functional on Windows is `rmdir`, and I'm almost done. - Alex Clemmer On Oct. 22, 2015

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-22 Thread Alex Clemmer
> On Oct. 22, 2015, 6:33 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > line 31 > > <https://reviews.apache.org/r/39559/diff/1/?file=1103501#file1103501line31> > > > > Just so I catch

Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-23 Thread Alex Clemmer
on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Alex Clemmer
, Alex Clemmer

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-10-24 Thread Alex Clemmer
` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-10-24 Thread Alex Clemmer
; code. Yes, I admit it's a super nitpicky thing to do. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review101663 ------

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-10-24 Thread Alex Clemmer
--- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Alex Clemmer
eviews.apache.org/r/39583/#review103746 --- On Oct. 23, 2015, 8:57 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-23 Thread Alex Clemmer
autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

2015-10-23 Thread Alex Clemmer
.apache.org/r/39540/#review103800 --- On Oct. 22, 2015, 3:36 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39540/ > -

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-22 Thread Alex Clemmer
/stout/os/mkdir.hpp PRE-CREATION Diff: https://reviews.apache.org/r/39383/diff/ Testing --- CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10. Autotools `make check` on Ubuntu 15. Thanks, Alex Clemmer

Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

2015-10-22 Thread Alex Clemmer
Wu. Repository: mesos Description --- CMake: Add state.cpp, flags.cpp to Windows agent build. Diffs - src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd Diff: https://reviews.apache.org/r/39560/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

2015-10-22 Thread Alex Clemmer
and ran `make check` on Ubuntu 15. Thanks, Alex Clemmer

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-22 Thread Alex Clemmer
an't commit this stuff with tests" is "yes, I agree, but I have to write this before we can open up the tests!" :) - Alex Clemmer On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote: > > --- > This is an automaticall

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-22 Thread Alex Clemmer
--- CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10. Autotools `make check` on Ubuntu 15. Thanks, Alex Clemmer

Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-22 Thread Alex Clemmer
/stout/posix/os.hpp b6afe0e76366d0bc68d37097ced83a1e14828d84 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 3e6f2aafd0f541f512025dfa683ab4178701f7c4 Diff: https://reviews.apache.org/r/39559/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

2015-10-22 Thread Alex Clemmer
y, because it is not obvious. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39537/#review103599 --- On Oct.

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-27 Thread Alex Clemmer
eviews.apache.org/r/39559/#review103815 --- On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-27 Thread Alex Clemmer
autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

2015-10-27 Thread Alex Clemmer
/ Testing --- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-27 Thread Alex Clemmer
ps://reviews.apache.org/r/39559/#review103815 ------- On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-27 Thread Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp b6afe0e76366d0bc68d37097ced83a1e14828d84 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 3e6f2aafd0f541f512025dfa683ab4178701f7c4 Diff: https://reviews.apache.org/r/39559/diff/ Testing --- Thanks, Alex

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-27 Thread Alex Clemmer
> On Oct. 23, 2015, 6:45 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > line 34 > > <https://reviews.apache.org/r/39559/diff/1/?file=1103501#file1103501line34> > > > > `strlen()` might be better

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-27 Thread Alex Clemmer
autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-27 Thread Alex Clemmer
autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-27 Thread Alex Clemmer
7a8819541506f57f70a9b577dc97a76fc26ebaa8 Diff: https://reviews.apache.org/r/39539/diff/ Testing --- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

2015-10-27 Thread Alex Clemmer
check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-27 Thread Alex Clemmer
--- CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10. Autotools `make check` on Ubuntu 15. Thanks, Alex Clemmer

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-27 Thread Alex Clemmer
nake case. Have I missed something important? - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/#review103815 ------

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-27 Thread Alex Clemmer
. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-27 Thread Alex Clemmer
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review104054 --- On Oct. 27, 2015, 8:23 a.m., Alex Clemmer wrote

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-27 Thread Alex Clemmer
/rmdir.hpp (line 138) <https://reviews.apache.org/r/39584/#comment162433> note that actually `::rmdir` here will deal appropriately with Unix-style paths, so there's no real need to normalize them. - Alex Clemmer On Oct. 27, 2015, 8:23 a.m., Alex Clemmer

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

2015-10-21 Thread Alex Clemmer
--- Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15. Thanks, Alex Clemmer

Review Request 39538: Windows: Moved `os::touch` to its own file, `stout/os/touch.hpp`.

2015-10-21 Thread Alex Clemmer
/libprocess/3rdparty/stout/include/stout/windows/os.hpp 3e6f2aafd0f541f512025dfa683ab4178701f7c4 Diff: https://reviews.apache.org/r/39538/diff/ Testing --- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex

Review Request 39541: Windows: Moved `os::chdir` to its own file, `stout/os/chdir.hpp`.

2015-10-21 Thread Alex Clemmer
on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-21 Thread Alex Clemmer
://reviews.apache.org/r/39539/diff/ Testing --- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

2015-10-21 Thread Alex Clemmer
on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-21 Thread Alex Clemmer
right? - Alex Clemmer On Oct. 22, 2015, 3:35 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-09 Thread Alex Clemmer
> correct? > > Joseph Wu wrote: > Windows doesn't have a temp-directory function. Are you suggesting > calling `mktemp` and then using the file's name as the argument to `mkdir`? > > Joris Van Remoortere wrote: > Indeed. It seems like that's what we are doing man

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-09 Thread Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d Diff: https://reviews.apache.org/r/39559/diff/ Testing --- Thanks, Alex

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
hat correct? > > > > (At least, I don't think the command exists in other Windows shells, > > like PowerShell.) > > Alex Clemmer wrote: > That's mostly correct, yes: we do not assume the user has PowerShell > right now, and we do assume the shell running t

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
t: https://reviews.apache.org/r/40131/#review106154 ------- On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
hat correct? > > > > (At least, I don't think the command exists in other Windows shells, > > like PowerShell.) > > Alex Clemmer wrote: > That's mostly correct, yes: we do not assume the user has PowerShell > right now, and we do assume the shell running t

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
, Alex Clemmer

Review Request 40195: Changed commit hook linting to ignore empty diffs.

2015-11-16 Thread Alex Clemmer
altogether. Diffs - support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d Diff: https://reviews.apache.org/r/40195/diff/ Testing --- Branches tested manually. Thanks, Alex Clemmer

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
ted e-mail. To reply, visit: https://reviews.apache.org/r/40131/#review106154 ------- On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote: > > --- > This is an automatically gener

Re: Review Request 39805: Moved filesystems tests to their own file.

2015-11-16 Thread Alex Clemmer
/os_tests.cpp 8791cfe628563b25ac86a8170966d458c3a9c0c8 Diff: https://reviews.apache.org/r/39805/diff/ Testing --- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2015-11-16 Thread Alex Clemmer
/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 Diff: https://reviews.apache.org/r/39803/diff/ Testing --- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

2015-11-16 Thread Alex Clemmer
://reviews.apache.org/r/39850/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-11-16 Thread Alex Clemmer
://reviews.apache.org/r/39851/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39834: Made `path_tests.cpp` standalone.

2015-11-16 Thread Alex Clemmer
/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a Diff: https://reviews.apache.org/r/39834/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

2015-11-16 Thread Alex Clemmer
and ran `make check` on Ubuntu 15. Thanks, Alex Clemmer

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-11-16 Thread Alex Clemmer
1a7037d64afeedc340258c92067e95d1d3caa027 Diff: https://reviews.apache.org/r/39888/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

2015-11-16 Thread Alex Clemmer
/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp e8238383c3c5feb688b10e37e544556ba9d43107 Diff: https://reviews.apache.org/r/40102/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory.

2015-11-16 Thread Alex Clemmer
Thanks, Alex Clemmer

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

2015-11-16 Thread Alex Clemmer
on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-16 Thread Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d Diff: https://reviews.apache.org/r/39559/diff/ Testing --- Thanks, Alex

Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.

2015-11-16 Thread Alex Clemmer
check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer

Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

2015-11-16 Thread Alex Clemmer
, Alex Clemmer

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-11-16 Thread Alex Clemmer
. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-11-16 Thread Alex Clemmer
://reviews.apache.org/r/39802/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

2015-11-16 Thread Alex Clemmer
, Alex Clemmer

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-11-16 Thread Alex Clemmer
autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

2015-11-16 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Re: Review Request 39889: Windows: Added support for `files/files.hpp`.

2015-11-16 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

2015-11-16 Thread Alex Clemmer
c9a1 support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e Diff: https://reviews.apache.org/r/40340/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

2015-11-17 Thread Alex Clemmer
/3rdparty/stout/include/stout/os/strerror.hpp 71689089a7818e3465e7e51becc43c7836b67240 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 Diff: https://reviews.apache.org/r/40382/diff/ Testing --- Thanks, Alex Clemmer

Review Request 40382: Windows: Added threadsafe `strerror_r` implementaiton.

2015-11-17 Thread Alex Clemmer
/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 Diff: https://reviews.apache.org/r/40382/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-11-17 Thread Alex Clemmer
we change this, will it break logging infrastructure somewhere? - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review104806 ------- On Nov. 16, 2015, 9:14 a.m., Alex Clemmer wrote: > > ---

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-11-17 Thread Alex Clemmer
ps://reviews.apache.org/r/39019/#review104784 ------- On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-11-17 Thread Alex Clemmer
` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-11-17 Thread Alex Clemmer
/stout/include/stout/os/windows/ls.hpp 5b6fba13ce215af5801fd0867f6e774e100689ca Diff: https://reviews.apache.org/r/39802/diff/ Testing --- Thanks, Alex Clemmer

Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-10 Thread Alex Clemmer
Remoortere, and Joseph Wu. Repository: mesos Description --- Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`. Diffs - bootstrap.bat PRE-CREATION Diff: https://reviews.apache.org/r/40131/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-29 Thread Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d Diff: https://reviews.apache.org/r/39559/diff/ Testing --- Thanks, Alex

Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

2015-10-29 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

2015-10-29 Thread Alex Clemmer
and ran `make check` on Ubuntu 15. Thanks, Alex Clemmer

Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

2015-10-29 Thread Alex Clemmer
, Alex Clemmer

Re: Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory.

2015-10-29 Thread Alex Clemmer
Thanks, Alex Clemmer

Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

2015-10-29 Thread Alex Clemmer
, Alex Clemmer

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-29 Thread Alex Clemmer
. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-30 Thread Alex Clemmer
autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-10-30 Thread Alex Clemmer
, Alex Clemmer

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-10-29 Thread Alex Clemmer
` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.

2015-10-29 Thread Alex Clemmer
check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-11-02 Thread Alex Clemmer
://reviews.apache.org/r/39851/diff/ Testing --- Thanks, Alex Clemmer

  1   2   3   4   5   6   7   8   9   10   >