://reviews.apache.org/r/36837/#comment149713
This line breaks the build on my machine OS X 10.10, and I'm not sure how
to fix it because CMake's weird string eval semantics make it hard to just pass
a normal quoted string in.
Does this break on your machien too?
- Alex Clemmer
On Aug
/37273/#comment149372
In glog's solution, you're required to migrate the project to VS2015 before
building it. Does this script do that automatically? (Sorry about the noob
question, I don't actually know how this works.)
- Alex Clemmer
On Aug. 10, 2015, 9:50 a.m., haosdent huang wrote
locally to the Stout tests CMakeLists, and I
think it makes sense to wrap them up into one diff, and push them into master.
- Alex Clemmer
On Aug. 9, 2015, 6:21 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote:
3rdparty/libprocess/3rdparty/glog-0.3.3.patch, line 21
https://reviews.apache.org/r/37273/diff/2/?file=1036048#file1036048line21
Looks like your updating the patchfile here to include my glog PR that
opens it to working on MSVC
far.
What do you think of that option?
- Alex Clemmer
On Aug. 10, 2015, 10:17 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37291
/ProcessConfigure.cmake
d6cdd05e281f23f0a57809d3798b5766fb2e9aa6
3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
082489ca4a31843886f764105e70e6af9779ca11
Diff: https://reviews.apache.org/r/36741/diff/
Testing
---
Tested fixes on OS X 10.10 and Ubuntu 14 boxes.
Thanks,
Alex
.
Thanks,
Alex Clemmer
/libprocess/src/tests/CMakeLists.txt PRE-CREATION
CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/36514/diff/
Testing
---
Includes tests for the process library that all run and pass.
Thanks,
Alex Clemmer
tests for the process library that all run and pass.
Thanks,
Alex Clemmer
---
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
---
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
is yes.
Also, you might be leery of committing this without tests. That's ok! We
need this to pull the FS tests out of `os_tests.cpp` though. The last function
we will need to port to get those tests functional on Windows is `rmdir`, and
I'm almost done.
- Alex Clemmer
On Oct. 22, 2015
> On Oct. 22, 2015, 6:33 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp,
> > line 31
> > <https://reviews.apache.org/r/39559/diff/1/?file=1103501#file1103501line31>
> >
> > Just so I catch
on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
,
Alex Clemmer
` project in VS on Windows 10.
Thanks,
Alex Clemmer
; code.
Yes, I admit it's a super nitpicky thing to do.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review101663
------
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
eviews.apache.org/r/39583/#review103746
---
On Oct. 23, 2015, 8:57 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To re
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
.apache.org/r/39540/#review103800
---
On Oct. 22, 2015, 3:36 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39540/
> -
Wu.
Repository: mesos
Description
---
CMake: Add state.cpp, flags.cpp to Windows agent build.
Diffs
-
src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd
Diff: https://reviews.apache.org/r/39560/diff/
Testing
---
Thanks,
Alex Clemmer
and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
an't commit this stuff with
tests" is "yes, I agree, but I have to write this before we can open up the
tests!" :)
- Alex Clemmer
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automaticall
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
/stout/posix/os.hpp
b6afe0e76366d0bc68d37097ced83a1e14828d84
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
3e6f2aafd0f541f512025dfa683ab4178701f7c4
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex Clemmer
y,
because it is not obvious.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39537/#review103599
---
On Oct.
eviews.apache.org/r/39559/#review103815
---
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To re
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
ps://reviews.apache.org/r/39559/#review103815
-------
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
b6afe0e76366d0bc68d37097ced83a1e14828d84
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
3e6f2aafd0f541f512025dfa683ab4178701f7c4
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
> On Oct. 23, 2015, 6:45 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp,
> > line 34
> > <https://reviews.apache.org/r/39559/diff/1/?file=1103501#file1103501line34>
> >
> > `strlen()` might be better
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
7a8819541506f57f70a9b577dc97a76fc26ebaa8
Diff: https://reviews.apache.org/r/39539/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
nake case. Have I missed something
important?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review103815
------
.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review104054
---
On Oct. 27, 2015, 8:23 a.m., Alex Clemmer wrote
/rmdir.hpp (line 138)
<https://reviews.apache.org/r/39584/#comment162433>
note that actually `::rmdir` here will deal appropriately with Unix-style
paths, so there's no real need to normalize them.
- Alex Clemmer
On Oct. 27, 2015, 8:23 a.m., Alex Clemmer
---
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/windows/os.hpp
3e6f2aafd0f541f512025dfa683ab4178701f7c4
Diff: https://reviews.apache.org/r/39538/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex
on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
://reviews.apache.org/r/39539/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
right?
- Alex Clemmer
On Oct. 22, 2015, 3:35 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> correct?
>
> Joseph Wu wrote:
> Windows doesn't have a temp-directory function. Are you suggesting
> calling `mktemp` and then using the file's name as the argument to `mkdir`?
>
> Joris Van Remoortere wrote:
> Indeed. It seems like that's what we are doing man
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
hat correct?
> >
> > (At least, I don't think the command exists in other Windows shells,
> > like PowerShell.)
>
> Alex Clemmer wrote:
> That's mostly correct, yes: we do not assume the user has PowerShell
> right now, and we do assume the shell running t
---
Thanks,
Alex Clemmer
t:
https://reviews.apache.org/r/40131/#review106154
-------
On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e
hat correct?
> >
> > (At least, I don't think the command exists in other Windows shells,
> > like PowerShell.)
>
> Alex Clemmer wrote:
> That's mostly correct, yes: we do not assume the user has PowerShell
> right now, and we do assume the shell running t
---
Thanks,
Alex Clemmer
,
Alex Clemmer
altogether.
Diffs
-
support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3
support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d
Diff: https://reviews.apache.org/r/40195/diff/
Testing
---
Branches tested manually.
Thanks,
Alex Clemmer
ted e-mail. To reply, visit:
https://reviews.apache.org/r/40131/#review106154
-------
On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically gener
/os_tests.cpp
8791cfe628563b25ac86a8170966d458c3a9c0c8
Diff: https://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
://reviews.apache.org/r/39850/diff/
Testing
---
Thanks,
Alex Clemmer
/path_tests.cpp
ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
---
Thanks,
Alex Clemmer
and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39888/diff/
Testing
---
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp
e8238383c3c5feb688b10e37e544556ba9d43107
Diff: https://reviews.apache.org/r/40102/diff/
Testing
---
Thanks,
Alex Clemmer
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
,
Alex Clemmer
.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
/3rdparty/stout/include/stout/os/strerror.hpp
71689089a7818e3465e7e51becc43c7836b67240
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/40382/diff/
Testing
---
Thanks,
Alex Clemmer
/windows.hpp
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/40382/diff/
Testing
---
Thanks,
Alex Clemmer
we change this, will it break logging
infrastructure somewhere?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39802/#review104806
-------
On Nov. 16, 2015, 9:14 a.m., Alex Clemmer wrote:
>
> ---
ps://reviews.apache.org/r/39019/#review104784
-------
On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
` project in VS on Windows 10.
Thanks,
Alex Clemmer
/stout/include/stout/os/windows/ls.hpp
5b6fba13ce215af5801fd0867f6e774e100689ca
Diff: https://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
Remoortere, and Joseph Wu.
Repository: mesos
Description
---
Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.
Diffs
-
bootstrap.bat PRE-CREATION
Diff: https://reviews.apache.org/r/40131/diff/
Testing
---
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
---
Thanks,
Alex Clemmer
and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Thanks,
Alex Clemmer
,
Alex Clemmer
.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
,
Alex Clemmer
` project in VS on Windows 10.
Thanks,
Alex Clemmer
check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
230/#comment162998>
Sorry I'm super late to the party. Does it make sense to add these to the
CMake build system as well?
- Alex Clemmer
On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically g
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
g/r/39634/#comment162999>
If it's not too much trouble, it would be great to see this logic added
also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple lines
of code.
- Alex Clemmer
On Oct. 30, 2015, 5:05 a.m., David Forsythe
/path_tests.cpp
ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
s to its own tests file so that we can run it on
Windows too? `os_test.cpp` has is too big and full of unimplemented stuff to
add Windows support right now.
- Alex Clemmer
On Oct. 23, 2015, 7:49 a.m., Benjamin B
719/#comment163000>
It looks like it might make sense to add this to `src/CMakeLists.txt` also?
- Alex Clemmer
On Nov. 2, 2015, 6:52 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
1 - 100 of 1228 matches
Mail list logo