/slave_authorization_tests.cpp
536a8efda0cc1ba08285c379b01af6ec64a82117
Diff: https://reviews.apache.org/r/61666/diff/1/
Testing
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
t;docker,mesos" --master="127.0.1.1:5050"`
5. launch docker executor: `./src/mesos-execute --master="127.0.1.1:5050"
--name="a" --containerizer=docker --docker_image="ubuntu:xenial"
--command="while true; do : ; done"`
Thanks,
Andrei Budnik
master, agent
4. launch a task using docker executor via mesos-execute in terminal
5. send SIGINT to the launched mesos-execute
6. check stderr logs of an executor in its sandbox
Thanks,
Andrei Budnik
-master="127.0.1.1:5050"
--name="a" --containerizer=docker --docker_image="ubuntu:xenial"
--command="while true; do : ; done"`
Thanks,
Andrei Budnik
0f1532b294d6d6b1e017468cfde47362f3faa84d
Diff: https://reviews.apache.org/r/60704/diff/1/
Testing
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
8bb03ecd86bfd87dfd27a800910130aec04e0919
src/slave/slave.cpp adbe65fbb7c555b098eaae228c7277402452d8a2
Diff: https://reviews.apache.org/r/60867/diff/2/
Changes: https://reviews.apache.org/r/60867/diff/1-2/
Testing
---
make check
Thanks,
Andrei Budnik
60640e5dbf6c3f8c709351e77ca89f287cf12fc3
src/slave/slave.hpp 8bb03ecd86bfd87dfd27a800910130aec04e0919
src/slave/slave.cpp adbe65fbb7c555b098eaae228c7277402452d8a2
Diff: https://reviews.apache.org/r/60907/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
terminated tasks :)
Fixed.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60867/#review180598
---
On July 17
utor.
Fixed in a separate [patch](https://reviews.apache.org/r/60907/).
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60867/#review180593
--------
05b505fc4c643f56c7141b6b79f334b000470780
Diff: https://reviews.apache.org/r/60539/diff/3/
Testing
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
om the master's view about resource allocations.
Diffs (updated)
-
src/slave/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3
Diff: https://reviews.apache.org/r/60369/diff/8/
Changes: https://reviews.apache.org/r/60369/diff/7-8/
Testing
---
make check
Thanks,
Andrei Budnik
-
src/slave/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3
Diff: https://reviews.apache.org/r/60915/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
ly, visit:
https://reviews.apache.org/r/60598/#review180034
-------
On July 3, 2017, 2:58 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail.
ce you may expect
> > in certain cases for the error to occur.
> >
> > `LOG(INFO)` seems more reasonable.
>
> Andrei Budnik wrote:
> But I see `LOG(ERROR)` below in the code in `supported()`. In addition,
> it looks like it's a real issue when perf is broke
has been called and returned true)
`perf --check` is moved to `Perf::execute()`.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review180223
-----
: https://reviews.apache.org/r/60876/diff/1/
Testing
---
sudo make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
Diff: https://reviews.apache.org/r/60877/diff/1/
Testing
---
sudo make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
er
from the master's view about resource allocations.
Diffs (updated)
-
src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2
Diff: https://reviews.apache.org/r/60369/diff/7/
Changes: https://reviews.apache.org/r/60369/diff/6-7/
Testing
---
make check
Thanks,
Andrei Budnik
Diff: https://reviews.apache.org/r/60867/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
)
<https://reviews.apache.org/r/60539/#comment255748>
Replace constants in the comment with DEFAULT_EXECUTOR_CPUS and
DEFAULT_EXECUTOR_MEM.
- Andrei Budnik
On June 29, 2017, 3:23 p.m., Andrei Budnik
Diff: https://reviews.apache.org/r/60704/diff/1/
Testing (updated)
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60598/#review179643
-----------
On July 3, 2017, 2:58 p.m., Andrei Budnik wrote:
>
> -
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review179868
-----------
On July 3, 2017, 10:57 a.m., Andrei Budnik wrote:
>
> -
en it's the issue that should be fixed, right?
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review179868
---------
/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3
Diff: https://reviews.apache.org/r/60915/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3
Diff: https://reviews.apache.org/r/60915/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
`reserved_resources_full`,
`reserved_resources` and `reserved_resources_allocated`.
Diffs
-
src/slave/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3
Diff: https://reviews.apache.org/r/60915/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
ui_bug3
https://reviews.apache.org/media/uploaded/files/2017/06/28/51553e9d-7fb9-40c0-b47c-b62fc6c37393__ui_bug3.png
Thanks,
Andrei Budnik
> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line184>
> >
> > Is `|| 0` necessary here?
>
> Andrei Budn
> >
> > ```
> > ng-repeat="(role, reservation) in $data"
> > ```
>
> Andrei Budnik wrote:
> If I change this:
> ```html
>
> {{reservation.role}}
>
> {{(state.rese
/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8
3rdparty/libprocess/src/tests/process_tests.cpp
38d787a083a5eb31e922d283f4b4bed2bd62eb0a
Diff: https://reviews.apache.org/r/60008/diff/2/
Testing (updated)
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Thanks,
Andrei
a7262cd97361b55ff31238341657e764df6c9ea5
Diff: https://reviews.apache.org/r/60397/diff/2/
Changes: https://reviews.apache.org/r/60397/diff/1-2/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Needs to be confirmed by Apache CI, e.g., reviewbot.
Thanks,
Andrei Budnik
e9af943b39436f365fe687301febb5c7fbefffc4
3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8
Diff: https://reviews.apache.org/r/60545/diff/1/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Thanks,
Andrei Budnik
---------
On June 29, 2017, 3:23 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
>
://reviews.apache.org/r/60539/diff/1/
Testing
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
Diff: https://reviews.apache.org/r/60369/diff/4/
Changes: https://reviews.apache.org/r/60369/diff/3-4/
Testing
---
make check
Thanks,
Andrei Budnik
0e24b8cb8d1020af515e3d1862e121e1daf82ce9
Diff: https://reviews.apache.org/r/60636/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
ew179531
---
On June 28, 2017, 8:52 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6
```
> > $scope.agent.resource_reservations =
> > _($scope.state.reserved_resources).map(function(role, reservation)) {
> > reservation.role = role
> > return reservation;
> > }
> >
> > ```
>
>
```
> > $scope.agent.resource_reservations =
> > _($scope.state.reserved_resources).map(function(role, reservation)) {
> > reservation.role = role
> > return reservation;
> > }
> >
> > ```
>
>
://reviews.apache.org/r/60397/diff/2-3/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Needs to be confirmed by Apache CI, e.g., reviewbot.
Thanks,
Andrei Budnik
rf::suppported`?
> >
> > Would also be great to include some additional context here, like a
> > pointer to the ticket or mentioning that this is more likely if running
> > within a docker image?
>
> Andrei Budnik wrote:
> Ticket is [MESOS-7160](https
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
this logic, and here in the
> > http handler we just sum `allocatedResources()` across the frameworks.
Fixed.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/
make check
Thanks,
Andrei Budnik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178996
-----------
On June 28, 2017, 12:37 p.m., Andrei Budnik wrote:
>
> -
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
src/tests/reservation_endpoints_tests.cpp
f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/3/
Changes: https://reviews.apache.org/r/60369/diff/2-3/
Testing
---
make check
Thanks,
Andrei Budnik
Line 1739 (original), 1739 (patched)
> > <https://reviews.apache.org/r/60369/diff/2/?file=1764201#file1764201line1739>
> >
> > Nit: Add one blank line below.
Fixed.
- Andrei
---
This is an autom
/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
ui_bug
https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
Thanks,
Andrei Budnik
> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line184>
> >
> > Is `|| 0` necessary here?
>
> Andrei Budn
Thanks,
Andrei Budnik
as a private method (GroupProcess::timedout). The
later method is actually called,
thus causing the error after applying this patch.
Thanks,
Andrei Budnik
t; > Additionally to (or actually instead of) `EXPECT` here,
> > `AWAIT_READY(f);` would carry your intent better, I think. I would actually
> > get rid of call expectations all together and simply focus on future states.
Fixed.
- Andrei
------
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
src/tests/reservation_endpoints_tests.cpp
f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/2/
Changes: https://reviews.apache.org/r/60369/diff/1-2/
Testing
---
make check
Thanks,
Andrei Budnik
://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
Thanks,
Andrei Budnik
llowing error without this flag: `Function call:
error(0x7fff595959d8, @0x7facca60abd0 "Roles { role1 } are not present in the
master's --roles")`
- Andrei
---
This is an automatically generated e-mail. To repl
to the launched mesos-execute
6. check stderr logs of an executor in its sandbox
Thanks,
Andrei Budnik
/1/
Testing
---
sudo make check
Thanks,
Andrei Budnik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60239/#review178379
---
Ship it!
- Andrei Budnik
On June 20, 2017, 12:39 p.m., Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60162/#review178641
---
Ship it!
Ship It!
- Andrei Budnik
On June 16, 2017, 6:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60161/#review178642
---
Ship it!
Ship It!
- Andrei Budnik
On June 16, 2017, 6:23
and
handled by the caller.
Diffs
-
src/tests/environment.cpp a7262cd97361b55ff31238341657e764df6c9ea5
Diff: https://reviews.apache.org/r/60397/diff/1/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Needs to be confirmed by Apache CI, e.g., reviewbot.
Thanks,
Andrei
Thanks,
Andrei Budnik
efault value.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178801
---
On June 22, 2017, 3:26 p.m., Andrei B
failures in os::subprocess().
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review178826
---
On June 26, 2017, 8:07 p.m., Andr
/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Needs to be confirmed by Apache CI, e.g., reviewbot.
Thanks,
Andrei Budnik
-58f556397724__Resource_Reservations.png
Thanks,
Andrei Budnik
7490a3c
src/tests/reservation_endpoints_tests.cpp
f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
Diff: https://reviews.apache.org/r/59375/diff/1/
Testing
---
Thanks,
Andrei Budnik
found"
- so, a user of tests might be confused with this mixed message: was the
container disappeared or was there some kind of misconfiguration error?
I would suggest message like "Wait for container failed: {error}{stdout}".
- Andrei Budnik
On May 8, 2
avoid code
copy-paste. And use lambda to make logical 'not':
container_does_not_exist = lambda data: not container_exists(data)
src/cli_new/lib/cli/tests/tests.py
Lines 60 (patched)
<https://reviews.apache.org/r/58720/#comment249132>
Consider using lambda function 'command'
tps://reviews.apache.org/r/58720/#comment249121>
I would prefer os.linesep to '\n' here and everywhere to avoid extra
constant.
- Andrei Budnik
On May 8, 2017, 5:27 p.m., Armand Grillet wrote:
>
> ---
> This is an automatica
tps://reviews.apache.org/r/58720/#comment249266>
Please, use Task.task_id instead of self.task_id:
flags["name"] = "task-{id}".format(id=Task.task_id)
Task.task_id += 1
Otherwise every instance of Task(Executable) will have same task_id.
- Andrei Budnik
tps://reviews.apache.org/r/58720/#comment249267>
container_does_not_exist = lambda data: not self.__container_exists(data)
- Andrei Budnik
On May 24, 2017, 1:28 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically g
tps://reviews.apache.org/r/58720/#comment249164>
Is it possible to run multiple tasks? What will be in case of task-id
collision?
It's possible to omit str() in '.format(id=str(random.random()))'. Also,
random.random() returns floating point number in the range [0.0, 1.0).
- Andrei
tps://reviews.apache.org/r/58720/#comment249167>
"{}:{}".format(DEFAULT_MASTER_IP, DEFAULT_MASTER_PORT)
- Andrei Budnik
On May 8, 2017, 5:27 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generate
tps://reviews.apache.org/r/58720/#comment249322>
you can remove this extra str()
src/cli_new/lib/cli/tests/base.py
Lines 312 (patched)
<https://reviews.apache.org/r/58720/#comment249321>
you can remove this extra str()
- Andrei Budnik
On May 24, 2017, 1:28 p.m., Armand G
/
Changes: https://reviews.apache.org/r/59375/diff/1-2/
Testing
---
Added checks for task status updates caused by task health update.
make check (fedora 25, mac os 10.12)
Thanks,
Andrei Budnik
"HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0"
--verbose
I've run this test multiple times for a while both on mac os and linux
(gru1.hw.ca1.mesosphere.com).
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
5c31f948b5ba470e7c007c39e1c0c903451477e2
src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4
src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
Diff: https://reviews.apache.org/r/59375/diff/1/
Testing
---
Thanks,
Andrei Budnik
status updates caused by task health update.
make check (fedora 25, mac os 10.12)
Thanks,
Andrei Budnik
Diff: https://reviews.apache.org/r/59375/diff/1/
Testing (updated)
---
Added checks for task status updates caused by task health update.
make check (fedora 25, mac os 10.12)
Thanks,
Andrei Budnik
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/59375/#review175482
-----------
On May 19, 2017, 9:07 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatic
> On May 23, 2017, 3:59 p.m., Andrei Budnik wrote:
> > src/cli_new/lib/cli/tests/base.py
> > Lines 52 (patched)
> > <https://reviews.apache.org/r/58720/diff/6/?file=1711168#file1711168line52>
> >
> > I would prefer os.linesep to '\n' here and
NoTaskKillingCapability/0"
--verbose
I've run this test multiple times for a while both on mac os and linux
(gru1.hw.ca1.mesosphere.com).
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
ce condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
mes for a while both on mac os and Fedora linux.
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
FAILURE)` in similar cases in other
> > executors.
Fixed.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176771
-
mes for a while both on mac os and Fedora linux.
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
---
make check
Thanks,
Andrei Budnik
: mesos
Description (updated)
---
See summary.
Diffs
-
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
Diff: https://reviews.apache.org/r/59837/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
on
a wrong method (GroupProcess::expired),
which has the same signature as a private method (GroupProcess::timedout). The
later method is actually called,
thus causing the error after applying this patch.
Thanks,
Andrei Budnik
is actually called,
thus causing the error after applying this patch.
Thanks,
Andrei Budnik
is actually called,
thus causing the error after applying this patch.
Thanks,
Andrei Budnik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60088/#review178092
---
LGTM
- Andrei Budnik
On June 14, 2017, 3:17 p.m., Armand
)
<https://reviews.apache.org/r/59605/#comment249793>
The justification of the use of cout/cerr in some places described in the
related ticket [#MESOS-7586](https://issues.apache.org/jira/browse/MESOS-7586).
- Andrei Budnik
On May 29, 2017, 2:59 p.m., Andrei Budnik
logging of flag warnings in the default executor.
Diffs
-
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
Diff: https://reviews.apache.org/r/59837/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure
> --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0"
> --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora
> linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
h
to a binary is invalid. SIGABRT causes coredumps.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review178952
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62018/#review185394
---
Ship it!
Ship It!
- Andrei Budnik
On Sept. 14, 2017, 8:34
1 - 100 of 590 matches
Mail list logo
