Description
---
This was noted by coverity in CID 146.
Diffs
-
src/linux/cgroups.cpp 5f10470a46e838f82e8463b09eeeb9488a351b9a
Diff: https://reviews.apache.org/r/72370/diff/1/
Testing
---
None: not a functional change.
Thanks,
Andrei Budnik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72442/#review220586
---
Ship it!
Ship It!
- Andrei Budnik
On Апрель 27, 2020, 2:57
`connect` increased, so we added
this log message to help in debugging.
Diffs
-
src/executor/executor.cpp 213f38ed9217144f32f9eeb2ef22afb054279d9b
Diff: https://reviews.apache.org/r/72475/diff/1/
Testing
---
None: not a functional change.
Thanks,
Andrei Budnik
213f38ed9217144f32f9eeb2ef22afb054279d9b
Diff: https://reviews.apache.org/r/72475/diff/2/
Changes: https://reviews.apache.org/r/72475/diff/1-2/
Testing
---
None: not a functional change.
Thanks,
Andrei Budnik
ived status update TASK_FAILED for task 'a'
message: 'Executor terminated'
source: SOURCE_AGENT
reason: REASON_EXECUTOR_TERMINATED
```
# This patch applied
Task successfully finished.
Thanks,
Andrei Budnik
/isolator.cpp
Lines 666 (patched)
<https://reviews.apache.org/r/72516/#comment309580>
Since the isolator doesn’t remove the checkpoint directory on unmount
failure (`_cleanup`), wouldn’t the info entry get restored on the agent restart
(`_recover`)?
- Andrei Budnik
On Май 15, 2020, 12:41 п.п.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72516/#review220869
---
Ship it!
Ship It!
- Andrei Budnik
On Май 26, 2020, 1:41 д.п
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72523/#review220870
---
Ship it!
Ship It!
- Andrei Budnik
On Май 18, 2020, 2:48 д.п
09feb689b225f87ae08b2050f21380e289b3e897
Diff: https://reviews.apache.org/r/72575/diff/1/
Testing
---
`make check`
Thanks,
Andrei Budnik
t;
> Added URI to failure messages in URI fetcher plugins.
>
>
> Diffs
> -
>
> src/uri/fetchers/curl.cpp 1796620cb5d1245eb2ac448b6cb821b8d57c4b49
> src/uri/fetchers/docker.cpp 09feb689b225f87ae08b2050f21380e289b3e897
>
>
> Diff: https://reviews.apache.org/r/72575/diff/2/
>
>
> Testing
> ---
>
> `make check`
>
>
> Thanks,
>
> Andrei Budnik
>
>
/diff/1/
Testing
---
1. `sudo make check`
2. launched the agent with the latest Seccomp profile
Thanks,
Andrei Budnik
tps://reviews.apache.org/r/72681/#comment310100>
Does it make sense to add `CHECK(volumeState->pre_provisioned())`?
- Andrei Budnik
On Июль 16, 2020, 5 д.п., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mai
etc.)? An instance of this class will be passed
to the Mesos containerizer.
- Andrei Budnik
On Июль 17, 2020, 8:58 д.п., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
olumeId` (of type "const
reference to...") by reference? Can these arguments be allocated on the stack?
- Andrei Budnik
On Авг. 3, 2020, 6:58 п.п., Greg Mann wrote:
>
> ---
> This is an automatically generated e
5c31f948b5ba470e7c007c39e1c0c903451477e2
src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4
src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
Diff: https://reviews.apache.org/r/59375/diff/1/
Testing
---
Thanks,
Andrei Budnik
Diff: https://reviews.apache.org/r/59375/diff/1/
Testing
---
Thanks,
Andrei Budnik
Diff: https://reviews.apache.org/r/59375/diff/1/
Testing (updated)
---
Added checks for task status updates caused by task health update.
make check (fedora 25, mac os 10.12)
Thanks,
Andrei Budnik
/
Changes: https://reviews.apache.org/r/59375/diff/1-2/
Testing
---
Added checks for task status updates caused by task health update.
make check (fedora 25, mac os 10.12)
Thanks,
Andrei Budnik
status updates caused by task health update.
make check (fedora 25, mac os 10.12)
Thanks,
Andrei Budnik
tically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59375/#review175482
-------
On May 19, 2017, 9:07 p.m., Andrei Budnik wrote:
>
> ---
> This is an
tps://reviews.apache.org/r/58720/#comment249121>
I would prefer os.linesep to '\n' here and everywhere to avoid extra
constant.
- Andrei Budnik
On May 8, 2017, 5:27 p.m., Armand Grillet wrote:
>
> ---
> This is an
ntainer_exists() to avoid code
copy-paste. And use lambda to make logical 'not':
container_does_not_exist = lambda data: not container_exists(data)
src/cli_new/lib/cli/tests/tests.py
Lines 60 (patched)
<https://reviews.apache.org/r/58720/#comment249132>
Consider u
und"
- so, a user of tests might be confused with this mixed message: was the
container disappeared or was there some kind of misconfiguration error?
I would suggest message like "Wait for container failed: {error}{stdout}".
- Andrei Budnik
On May 8, 2
tps://reviews.apache.org/r/58720/#comment249164>
Is it possible to run multiple tasks? What will be in case of task-id
collision?
It's possible to omit str() in '.format(id=str(random.random()))'. Also,
random.random() returns floating point number in the range [0.0, 1.
tps://reviews.apache.org/r/58720/#comment249167>
"{}:{}".format(DEFAULT_MASTER_IP, DEFAULT_MASTER_PORT)
- Andrei Budnik
On May 8, 2017, 5:27 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generate
tps://reviews.apache.org/r/58720/#comment249266>
Please, use Task.task_id instead of self.task_id:
flags["name"] = "task-{id}".format(id=Task.task_id)
Task.task_id += 1
Otherwise every instance of Task(Executable) will have same task_id.
- Andrei Budnik
tps://reviews.apache.org/r/58720/#comment249267>
container_does_not_exist = lambda data: not self.__container_exists(data)
- Andrei Budnik
On May 24, 2017, 1:28 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically g
tps://reviews.apache.org/r/58720/#comment249322>
you can remove this extra str()
src/cli_new/lib/cli/tests/base.py
Lines 312 (patched)
<https://reviews.apache.org/r/58720/#comment249321>
you can remove this extra str()
- Andrei Budnik
On May 24, 2017, 1:28 p.m., Armand G
lter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0"
--verbose
I've run this test multiple times for a while both on mac os and linux
(gru1.hw.ca1.mesosphere.com).
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
> On May 23, 2017, 3:59 p.m., Andrei Budnik wrote:
> > src/cli_new/lib/cli/tests/base.py
> > Lines 52 (patched)
> > <https://reviews.apache.org/r/58720/diff/6/?file=1711168#file1711168line52>
> >
> > I would prefer os.linesep to '\n'
)
<https://reviews.apache.org/r/59605/#comment249793>
The justification of the use of cout/cerr in some places described in the
related ticket [#MESOS-7586](https://issues.apache.org/jira/browse/MESOS-7586).
- Andrei Budnik
On May 29, 2017, 2:59 p.m., Andrei Budnik
Test.NoTaskKillingCapability/0"
--verbose
I've run this test multiple times for a while both on mac os and linux
(gru1.hw.ca1.mesosphere.com).
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
ux.
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
ultiple times for a while both on mac os and Fedora linux.
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
EXIT_FAILURE)` in similar cases in other
> > executors.
Fixed.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176771
ultiple times for a while both on mac os and Fedora linux.
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
logging of flag warnings in the default executor.
Diffs
-
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
Diff: https://reviews.apache.org/r/59837/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
en to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure
> --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0"
> --verbose
>
> I've run this test multiple times for a while both on mac os and Fedora
> linux. Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>
: mesos
Description (updated)
---
See summary.
Diffs
-
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
Diff: https://reviews.apache.org/r/59837/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
---
make check
Thanks,
Andrei Budnik
on
a wrong method (GroupProcess::expired),
which has the same signature as a private method (GroupProcess::timedout). The
later method is actually called,
thus causing the error after applying this patch.
Thanks,
Andrei Budnik
actually called,
thus causing the error after applying this patch.
Thanks,
Andrei Budnik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60088/#review178092
---
LGTM
- Andrei Budnik
On June 14, 2017, 3:17 p.m., Armand
is actually called,
thus causing the error after applying this patch.
Thanks,
Andrei Budnik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60239/#review178379
---
Ship it!
- Andrei Budnik
On June 20, 2017, 12:39 p.m., Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60162/#review178641
---
Ship it!
Ship It!
- Andrei Budnik
On June 16, 2017, 6:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60161/#review178642
---
Ship it!
Ship It!
- Andrei Budnik
On June 16, 2017, 6:23
-58f556397724__Resource_Reservations.png
Thanks,
Andrei Budnik
7490a3c
src/tests/reservation_endpoints_tests.cpp
f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
eady anticipated and
handled by the caller.
Diffs
-
src/tests/environment.cpp a7262cd97361b55ff31238341657e764df6c9ea5
Diff: https://reviews.apache.org/r/60397/diff/1/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Needs to be confirmed by Apache CI, e.g., reviewbo
Thanks,
Andrei Budnik
ed as a
default value.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178801
---
On June 22, 2017, 3:26 p.m.
e.org/r/60397/diff/1/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Needs to be confirmed by Apache CI, e.g., reviewbot.
Thanks,
Andrei Budnik
failures in os::subprocess().
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review178826
---
On June 26, 2017, 8:07 p.m., Andr
s `abort()` when path
to a binary is invalid. SIGABRT causes coredumps.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review178952
-------
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
src/tests/reservation_endpoints_tests.cpp
f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/2/
Changes: https://reviews.apache.org/r/60369/diff/1-2/
Testing
---
make check
Thanks,
Andrei Budnik
://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
Thanks,
Andrei Budnik
getting following error without this flag: `Function call:
error(0x7fff595959d8, @0x7facca60abd0 "Roles { role1 } are not present in the
master's --roles")`
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review178867
--
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
src/tests/reservation_endpoints_tests.cpp
f710a188a7875c1cb847e39276b4b65332703ca5
Diff: https://reviews.apache.org/r/60369/diff/3/
Changes: https://reviews.apache.org/r/60369/diff/2-3/
Testing
---
make check
Thanks,
Andrei Budnik
gt; Line 1739 (original), 1739 (patched)
> > <https://reviews.apache.org/r/60369/diff/2/?file=1764201#file1764201line1739>
> >
> > Nit: Add one blank line below.
Fixed.
- Andrei
---
This is an a
/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
ui_bug
https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
Thanks,
Andrei Budnik
> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line184>
> >
> > Is `|| 0` necessary here?
>
> Andrei Budn
Thanks,
Andrei Budnik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178996
-----------
On June 28, 2017, 12:37 p.m., Andrei Budnik wrote:
>
> -
t;
> > Additionally to (or actually instead of) `EXPECT` here,
> > `AWAIT_READY(f);` would carry your intent better, I think. I would actually
> > get rid of call expectations all together and simply focus on future states.
Fixed.
- Andrei
-----
private method (GroupProcess::timedout). The
later method is actually called,
thus causing the error after applying this patch.
Thanks,
Andrei Budnik
> >
> > ```
> > ng-repeat="(role, reservation) in $data"
> > ```
>
> Andrei Budnik wrote:
> If I change this:
> ```html
>
> {{reservation.role}}
>
> {{(state.rese
/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
ui_bug3
https://reviews.apache.org/media/uploaded/files/2017/06/28/51553e9d-7fb9-40c0-b47c-b62fc6c37393__ui_bug3.png
Thanks,
Andrei Budnik
> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line184>
> >
> > Is `|| 0` necessary here?
>
> Andrei Budn
/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8
3rdparty/libprocess/src/tests/process_tests.cpp
38d787a083a5eb31e922d283f4b4bed2bd62eb0a
Diff: https://reviews.apache.org/r/60008/diff/2/
Testing (updated)
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Thanks,
Andrei
://reviews.apache.org/r/60539/diff/1/
Testing
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c
Diff: https://reviews.apache.org/r/60369/diff/4/
Changes: https://reviews.apache.org/r/60369/diff/3-4/
Testing
---
make check
Thanks,
Andrei Budnik
---------
On June 29, 2017, 3:23 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
>
e9af943b39436f365fe687301febb5c7fbefffc4
3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8
Diff: https://reviews.apache.org/r/60545/diff/1/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Thanks,
Andrei Budnik
ests/environment.cpp a7262cd97361b55ff31238341657e764df6c9ea5
Diff: https://reviews.apache.org/r/60397/diff/2/
Changes: https://reviews.apache.org/r/60397/diff/1-2/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Needs to be confirmed by Apache CI, e.g., reviewbot.
Thanks,
Andrei Budnik
f/3/
Changes: https://reviews.apache.org/r/60397/diff/2-3/
Testing
---
1. make check (mac os x 10.12, fedora 25)
2. internal CI
Needs to be confirmed by Apache CI, e.g., reviewbot.
Thanks,
Andrei Budnik
y `perf::suppported`?
> >
> > Would also be great to include some additional context here, like a
> > pointer to the ticket or mentioning that this is more likely if running
> > within a docker image?
>
> Andrei Budnik wrote:
> Ticket is [MESOS-7160](
sting
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
make check
Thanks,
Andrei Budnik
ramework` struct that contains this logic, and here in the
> > http handler we just sum `allocatedResources()` across the frameworks.
Fixed.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179499
-
0e24b8cb8d1020af515e3d1862e121e1daf82ce9
Diff: https://reviews.apache.org/r/60636/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
he.org/r/60370/#review179531
---
On June 28, 2017, 8:52 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
```
> > $scope.agent.resource_reservations =
> > _($scope.state.reserved_resources).map(function(role, reservation)) {
> > reservation.role = role
> > return reservation;
> > }
> >
> > ```
>
>
```
> > $scope.agent.resource_reservations =
> > _($scope.state.reserved_resources).map(function(role, reservation)) {
> > reservation.role = role
> > return reservation;
> > }
> >
> > ```
>
>
Diff: https://reviews.apache.org/r/60704/diff/1/
Testing (updated)
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60598/#review179643
-------
On July 3, 2017, 2:58 p.m., Andrei Budnik wrote:
>
>
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review179868
-------
On July 3, 2017, 10:57 a.m., Andrei Budnik wrote:
>
>
t available, then it's the issue that should be fixed, right?
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review179868
---------
ay expect
> > in certain cases for the error to occur.
> >
> > `LOG(INFO)` seems more reasonable.
>
> Andrei Budnik wrote:
> But I see `LOG(ERROR)` below in the code in `supported()`. In addition,
> it looks like it's a real issue when perf is broke
il. To reply, visit:
https://reviews.apache.org/r/60598/#review180034
-----------
On July 3, 2017, 2:58 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generat
0f1532b294d6d6b1e017468cfde47362f3faa84d
Diff: https://reviews.apache.org/r/60704/diff/1/
Testing
---
make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
ed()` has been called and returned true)
`perf --check` is moved to `Perf::execute()`.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review180223
---
On July 11, 2017, 9:25
)
<https://reviews.apache.org/r/60539/#comment255748>
Replace constants in the comment with DEFAULT_EXECUTOR_CPUS and
DEFAULT_EXECUTOR_MEM.
- Andrei Budnik
On June 29, 2017, 3:23 p.m., Andrei Budnik wrote:
>
> ---
Diff: https://reviews.apache.org/r/60867/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
er
from the master's view about resource allocations.
Diffs (updated)
-
src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2
Diff: https://reviews.apache.org/r/60369/diff/7/
Changes: https://reviews.apache.org/r/60369/diff/6-7/
Testing
---
make check
Thanks,
Andrei Budnik
Diff: https://reviews.apache.org/r/60876/diff/1/
Testing
---
sudo make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
1ae40
Diff: https://reviews.apache.org/r/60877/diff/1/
Testing
---
sudo make check (mac os x, fedora 25)
Thanks,
Andrei Budnik
slave/slave.hpp 8bb03ecd86bfd87dfd27a800910130aec04e0919
src/slave/slave.cpp adbe65fbb7c555b098eaae228c7277402452d8a2
Diff: https://reviews.apache.org/r/60867/diff/2/
Changes: https://reviews.apache.org/r/60867/diff/1-2/
Testing
---
make check
Thanks,
Andrei Budnik
e/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3
src/slave/slave.hpp 8bb03ecd86bfd87dfd27a800910130aec04e0919
src/slave/slave.cpp adbe65fbb7c555b098eaae228c7277402452d8a2
Diff: https://reviews.apache.org/r/60907/diff/1/
Testing
---
make check
Thanks,
Andrei Budnik
clude terminated tasks :)
Fixed.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60867/#review180598
---
On Ju
1 - 100 of 592 matches
Mail list logo
