Thanks,
Greg Mann
/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224
Diff: https://reviews.apache.org/r/34317/diff/
Testing
---
make check
Thanks,
Greg Mann
://reviews.apache.org/r/34318/diff/
Testing
---
make check
Thanks,
Greg Mann
Diff: https://reviews.apache.org/r/34319/diff/
Testing
---
make check
Thanks,
Greg Mann
://reviews.apache.org/r/34319/diff/
Testing
---
make check
Thanks,
Greg Mann
fe00aa56f587b247659ac9a722179b3809a8fe25
Diff: https://reviews.apache.org/r/34318/diff/
Testing
---
make check
Thanks,
Greg Mann
796526f59c25898ef6db2b828b0e2bb7b172ba25
src/tests/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224
Diff: https://reviews.apache.org/r/34317/diff/
Testing
---
make check
Thanks,
Greg Mann
/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25
Diff: https://reviews.apache.org/r/34318/diff/
Testing
---
make check
Thanks,
Greg Mann
/libprocess/src/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25
Diff: https://reviews.apache.org/r/34318/diff/
Testing
---
make check
Thanks,
Greg Mann
/stout/include/stout/os.hpp
d2ca4be90edb134465751d093b61e84fd6b16f1c
Diff: https://reviews.apache.org/r/34319/diff/
Testing
---
make check
Thanks,
Greg Mann
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34319/#review84054
---
On May 17, 2015, 1:40 p.m., Greg Mann wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34319/#review84553
---
On May 17, 2015, 1:40 p.m., Greg Mann wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34317/#review84556
---
On May 17, 2015, 4:54 a.m., Greg Mann wrote:
---
This is an automatically
/include/stout/os.hpp
8ee02ef97692d06cf31c9b0cda6829df12548be8
Diff: https://reviews.apache.org/r/34319/diff/
Testing
---
make check
Thanks,
Greg Mann
bd58f94c53ab25c1ae9b8d9eeae5a887faf1fe80
src/tests/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224
src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17
Diff: https://reviews.apache.org/r/34317/diff/
Testing
---
make check
Thanks,
Greg Mann
? And I see you've been replacing hasenv with getenv, I
think why not just remove hasenv all together?
Greg Mann wrote:
Good call! I think that os::getenv().isSome() eliminates the need for
os::hasenv. I can remove it and update the patches.
Done.
- Greg
src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17
Diff: https://reviews.apache.org/r/34317/diff/
Testing
---
make check
Thanks,
Greg Mann
, and
removed os::hasenv
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
d2ca4be90edb134465751d093b61e84fd6b16f1c
Diff: https://reviews.apache.org/r/34319/diff/
Testing
---
make check
Thanks,
Greg Mann
e3de3cd6b536aaaf59784360aed546512dd04dc9
3rdparty/libprocess/src/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25
Diff: https://reviews.apache.org/r/34318/diff/
Testing
---
make check
Thanks,
Greg Mann
On May 20, 2015, 5:49 p.m., Timothy Chen wrote:
src/examples/balloon_framework.cpp, line 207
https://reviews.apache.org/r/34317/diff/1/?file=962096#file962096line207
Why not Optionstring value = os::getenv(MESOS_BUILD_DIR)?
Greg Mann wrote:
I think that in the case of a re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34317/#review84551
---
On May 17, 2015, 4:54 a.m., Greg Mann wrote
/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224
src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17
Diff: https://reviews.apache.org/r/34317/diff/
Testing
---
make check
Thanks,
Greg Mann
GTEST_FILTER=ExamplesTest.JavaLog bin/mesos-tests.sh --verbose
--gtest_repeat=100 2/dev/null | grep \[
Thanks,
Greg Mann
---
Thanks,
Greg Mann
may fail only infrequently, and the bug is made worse by verbose
logging, so to verify correctness (or reproduce the bug before patching) try:
GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaLog bin/mesos-tests.sh --verbose
--gtest_repeat=100 2/dev/null | grep \[
Thanks,
Greg Mann
---
This test may fail only infrequently, and the bug is made worse by verbose
logging, so to verify correctness (or reproduce the bug before patching) try:
GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaFramework bin/mesos-tests.sh --verbose
--gtest_repeat=100 2/dev/null | grep \[
Thanks,
Greg Mann
,
Greg Mann
in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and
the LinuxFilesystemIsolatorTest.* tests, so those should all pass.
Thanks,
Greg Mann
, MESOS-3294, MESOS-3295
This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and
the LinuxFilesystemIsolatorTest.* tests, so those should all pass.
Thanks,
Greg Mann
://reviews.apache.org/r/37684/#review96068
---
On Aug. 21, 2015, 7:15 p.m., Greg Mann wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
, MESOS-3294, MESOS-3295
This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and
the LinuxFilesystemIsolatorTest.* tests, so those should all pass.
Thanks,
Greg Mann
,
Greg Mann
) via --with-glog=..., with gflags
not installed
4. using system glog (built without gflags) via --with-glog=..., with gflags
installed
5. using system glog (built with gflags) via --with-glog=..., with gflags
installed
Test suite passes in all cases.
Thanks,
Greg Mann
in all cases.
Thanks,
Greg Mann
--with-glog=..., with gflags
not installed
4. using system glog (built without gflags) via --with-glog=..., with gflags
installed
5. using system glog (built with gflags) via --with-glog=..., with gflags
installed
Test suite passes in all cases.
Thanks,
Greg Mann
---
On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37493
/dev/null | grep \[
Thanks,
Greg Mann
.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37415/#review95264
---
On Aug. 13, 2015, 4:49 p.m., Greg Mann wrote
idea to add a todo here that captures
what you wrote within the JIRA issue already;
TODO(*): Ideally, we would inspect the status of the driver and its
associated tasks via the Java API and wait until their teardown is complete
to exit.
Greg Mann wrote:
You are correct
=100 2/dev/null | grep \[
Thanks,
Greg Mann
without gflags) via --with-glog=..., with gflags
installed
5. using system glog (built with gflags) via --with-glog=..., with gflags
installed
Test suite passes in all cases.
Thanks,
Greg Mann
-website-container
Thanks,
Greg Mann
c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6
Diff: https://reviews.apache.org/r/39494/diff/
Testing
---
Viewed in the Mesos Website Container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review103437
---
Ship it!
Ship It!
- Greg Mann
On Oct. 21, 2015, 2:37 a.m
-----
On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
Thanks,
Greg Mann
-----
On Oct. 21, 2015, 5:53 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39453/
> -
/diff/
Testing
---
https://gist.github.com/greggomann/b5b35a164a006bec9357
Thanks,
Greg Mann
g/r/38399/#comment164570>
s/maintenance machine(s)/maintain machine(s)/
- Greg Mann
On Sept. 23, 2015, 5:16 a.m., Zhiwei Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
were added to
`reservation_tests.cpp` to validate the authentication of framework reserve and
unreserve operations using ACLs. `make check` was run to test after all patches
were applied.
Thanks,
Greg Mann
/
Testing
---
This is the fourth in a chain of 5 patches. Added new reservation endpoints
tests to validate authorization of reserve and unreserve operations using ACLs.
`make check` was run to test after all patches were applied.
Thanks,
Greg Mann
and unreserve operations via ACLs. `make check` was
used to test after all patches were applied.
Thanks,
Greg Mann
/37002/
Diffs (updated)
-
include/mesos/authorizer/authorizer.proto
86bbb45f9d91b4098a262e3e50a793f3bb39497e
Diff: https://reviews.apache.org/r/39985/diff/
Testing
---
This is the first in a chain of 5 patches. `make check` was used to test at the
end of the chain.
Thanks,
Greg
all patches were applied.
Thanks,
Greg Mann
many other tests
(check `src/tests/sorter_tests.cpp`, for example), so it's clear that the
original parsing continues to work correctly.
Thanks,
Greg Mann
-------
On Nov. 9, 2015, 4:48 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> ---
o reply, visit:
https://reviews.apache.org/r/39018/#review105607
---
On Nov. 9, 2015, 5:39 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> -
reservation tests were added to
`reservation_tests.cpp` to validate the authentication of framework reserve and
unreserve operations using ACLs. `make check` was run to test after all patches
were applied.
Thanks,
Greg Mann
`src/tests/sorter_tests.cpp`, for example), so it's clear that the
original parsing continues to work correctly.
Thanks,
Greg Mann
to test after
all patches were applied.
Thanks,
Greg Mann
and unreserve operations via ACLs. `make check` was
used to test after all patches were applied.
Thanks,
Greg Mann
#39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
There is one more patch with documentation changes forthcoming.
Thanks,
Greg Mann
of Review #39989.
Thanks,
Greg Mann
that this chain of patches touches many of the same files as another chain
beginning with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
(https://github.com/mesosphere/mesos-website-container).
Thanks,
Greg Mann
beginning with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
of this chain begins on
top of Review #39989.
There is one more patch with documentation changes forthcoming.
Thanks,
Greg Mann
and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
as another chain
beginning with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
There is one more patch with documentation changes forthcoming.
Thanks,
Greg Mann
. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
files as another chain
beginning with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann
of the same files as another chain
beginning with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
files as another chain
beginning with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
One additional patch with documentation is forthcoming.
Thanks,
Greg Mann
additional patch with documentation is forthcoming.
Thanks,
Greg Mann
f5ed75fcd0785fde38058917354fcf6d668dcccb
Diff: https://reviews.apache.org/r/40271/diff/
Testing
---
Viewed with the Mesos Website Container
(https://github.com/mesosphere/mesos-website-container).
Thanks,
Greg Mann
-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann
files as another chain
beginning with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
There is one more patch with documentation changes forthcoming.
Thanks,
Greg Mann
for the
authorization of reserve and unreserve operations via ACLs. `make check` was
used to test after all patches were applied.
Thanks,
Greg Mann
patches were applied.
Thanks,
Greg Mann
://reviews.apache.org/r/39988/diff/
Testing
---
This is the fourth in a chain of 5 patches. Added new reservation endpoints
tests to validate authorization of reserve and unreserve operations using ACLs.
`make check` was run to test after all patches were applied.
Thanks,
Greg Mann
reservation tests were added to
`reservation_tests.cpp` to validate the authentication of framework reserve and
unreserve operations using ACLs. `make check` was run to test after all patches
were applied.
Thanks,
Greg Mann
to test at the
end of the chain.
Note: documentation for these changes is included in
https://reviews.apache.org/r/40271/
Thanks,
Greg Mann
of reserve and unreserve operations via ACLs. `make check` was
used to test after all patches were applied.
Thanks,
Greg Mann
upport into the comments/docs when MESOS-3903 is being
addressed.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/#review106393
---
that this chain of patches touches many of the same files as another chain
beginning with Review #39985 and ending with Review #39989, which is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
to those files.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review106397
---
On Nov. 13, 2015, 7
eviews.apache.org/r/40169/#review106396
---
On Nov. 13, 2015, 6:30 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> ---
ly, visit:
https://reviews.apache.org/r/39985/#review106509
---
On Nov. 13, 2015, 11:11 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To re
.
Note: documentation for these changes is included in
https://reviews.apache.org/r/40271/
Thanks,
Greg Mann
reservation tests were added to
`reservation_tests.cpp` to validate the authentication of framework reserve and
unreserve operations using ACLs. `make check` was run to test after all patches
were applied.
Thanks,
Greg Mann
/39988/diff/
Testing
---
This is the fourth in a chain of 5 patches. Added new reservation endpoints
tests to validate authorization of reserve and unreserve operations using ACLs.
`make check` was run to test after all patches were applied.
Thanks,
Greg Mann
/diff/
Testing
---
This is the fifth in a chain of 5 patches. New reservation tests were added to
`reservation_tests.cpp` to validate the authentication of framework reserve and
unreserve operations using ACLs. `make check` was run to test after all patches
were applied.
Thanks,
Greg
. `make check` was used to test after
all patches were applied.
Thanks,
Greg Mann
and unreserve operations via ACLs. `make check` was
used to test after all patches were applied.
Thanks,
Greg Mann
---
This is the last in a chain of 7 patches.
This documentation was tested by viewing with the Mesos Website Container
(https://github.com/mesosphere/mesos-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann
is currently
in review as well. To avoid conflicts, the beginning of this chain begins on
top of Review #39989.
Thanks,
Greg Mann
1 - 100 of 3535 matches
Mail list logo