Review Request 34319: Update callers of os::getenv() in stout.

2015-05-16 Thread Greg Mann
Thanks, Greg Mann

Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-16 Thread Greg Mann
/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224 Diff: https://reviews.apache.org/r/34317/diff/ Testing --- make check Thanks, Greg Mann

Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-16 Thread Greg Mann
://reviews.apache.org/r/34318/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-16 Thread Greg Mann
, Greg Mann

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-16 Thread Greg Mann
Diff: https://reviews.apache.org/r/34319/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-16 Thread Greg Mann
/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25 Diff: https://reviews.apache.org/r/34318/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-16 Thread Greg Mann
/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25 Diff: https://reviews.apache.org/r/34318/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-16 Thread Greg Mann
://reviews.apache.org/r/34319/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-16 Thread Greg Mann
fe00aa56f587b247659ac9a722179b3809a8fe25 Diff: https://reviews.apache.org/r/34318/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-16 Thread Greg Mann
796526f59c25898ef6db2b828b0e2bb7b172ba25 src/tests/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224 Diff: https://reviews.apache.org/r/34317/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-17 Thread Greg Mann
/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25 Diff: https://reviews.apache.org/r/34318/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-16 Thread Greg Mann
de6f1b104a765a8e53934154e78872b03695b24c src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 src/tests/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224 Diff: https://reviews.apache.org/r/34317/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-16 Thread Greg Mann
3rdparty/libprocess/src/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25 Diff: https://reviews.apache.org/r/34318/diff/ Testing --- make check Thanks, Greg Mann

Review Request 34325: Refactored os::getenv() to return an Option.

2015-05-16 Thread Greg Mann
Thanks, Greg Mann

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-17 Thread Greg Mann
/libprocess/src/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25 Diff: https://reviews.apache.org/r/34318/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-17 Thread Greg Mann
/stout/include/stout/os.hpp d2ca4be90edb134465751d093b61e84fd6b16f1c Diff: https://reviews.apache.org/r/34319/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84054 --- On May 17, 2015, 1:40 p.m., Greg Mann wrote

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-20 Thread Greg Mann
--- On May 17, 2015, 4:54 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84553 --- On May 17, 2015, 1:40 p.m., Greg Mann wrote

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/#review84556 --- On May 17, 2015, 4:54 a.m., Greg Mann wrote: --- This is an automatically

Re: Review Request 34319: Refactored os::getenv() to return an option and removed os::hasenv()

2015-06-04 Thread Greg Mann
/include/stout/os.hpp 8ee02ef97692d06cf31c9b0cda6829df12548be8 Diff: https://reviews.apache.org/r/34319/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34317: Updated callers of os::getenv() in /src and removed calls to os::hasenv()

2015-05-25 Thread Greg Mann
bd58f94c53ab25c1ae9b8d9eeae5a887faf1fe80 src/tests/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224 src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17 Diff: https://reviews.apache.org/r/34317/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-25 Thread Greg Mann
? And I see you've been replacing hasenv with getenv, I think why not just remove hasenv all together? Greg Mann wrote: Good call! I think that os::getenv().isSome() eliminates the need for os::hasenv. I can remove it and update the patches. Done. - Greg

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-25 Thread Greg Mann
d2ca4be90edb134465751d093b61e84fd6b16f1c Diff: https://reviews.apache.org/r/34319/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-25 Thread Greg Mann
src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17 Diff: https://reviews.apache.org/r/34317/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34319: Refactored os::getenv() to return an option and removed os::hasenv()

2015-05-25 Thread Greg Mann
, and removed os::hasenv Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be90edb134465751d093b61e84fd6b16f1c Diff: https://reviews.apache.org/r/34319/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-25 Thread Greg Mann
e3de3cd6b536aaaf59784360aed546512dd04dc9 3rdparty/libprocess/src/profiler.cpp fe00aa56f587b247659ac9a722179b3809a8fe25 Diff: https://reviews.apache.org/r/34318/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-25 Thread Greg Mann
On May 20, 2015, 5:49 p.m., Timothy Chen wrote: src/examples/balloon_framework.cpp, line 207 https://reviews.apache.org/r/34317/diff/1/?file=962096#file962096line207 Why not Optionstring value = os::getenv(MESOS_BUILD_DIR)? Greg Mann wrote: I think that in the case of a re

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/#review84551 --- On May 17, 2015, 4:54 a.m., Greg Mann wrote

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-25 Thread Greg Mann
/anonymous_tests.cpp 12d4eb438c3d5f539ebf22bb159a98ef9141e224 src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17 Diff: https://reviews.apache.org/r/34317/diff/ Testing --- make check Thanks, Greg Mann

Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog

2015-08-12 Thread Greg Mann
GTEST_FILTER=ExamplesTest.JavaLog bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann

Review Request 37420: Added note regarding glog and gflags to documentation

2015-08-12 Thread Greg Mann
--- Thanks, Greg Mann

Review Request 37414: Add sleep to TestLog.java

2015-08-12 Thread Greg Mann
may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try: GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaLog bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann

Review Request 37415: Fix flaky ExamplesTest.JavaFramework

2015-08-12 Thread Greg Mann
--- This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try: GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaFramework bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann

Review Request 37592: Added a defaultWindow to metrics based on LIBPROCESS_STATISTICS_WINDOW

2015-08-18 Thread Greg Mann
, Greg Mann

Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
, MESOS-3294, MESOS-3295 This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
://reviews.apache.org/r/37684/#review96068 --- On Aug. 21, 2015, 7:15 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
, MESOS-3294, MESOS-3295 This patch solves bugs in MesosContainerizerLaunchTest.ROOT_ChangeRootfs and the LinuxFilesystemIsolatorTest.* tests, so those should all pass. Thanks, Greg Mann

Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.

2015-08-21 Thread Greg Mann
, Greg Mann

Re: Review Request 37493: Detect gflags when present and link when building Python module

2015-08-18 Thread Greg Mann
) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann

Re: Review Request 37493: Detect gflags when present and link when building Python module

2015-08-18 Thread Greg Mann
in all cases. Thanks, Greg Mann

Re: Review Request 37493: Detect gflags when present and link when building Python module

2015-08-17 Thread Greg Mann
--with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann

Re: Review Request 37493: Detect gflags when present and link when building Python module

2015-08-17 Thread Greg Mann
--- On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493

Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog

2015-08-13 Thread Greg Mann
/dev/null | grep \[ Thanks, Greg Mann

Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework

2015-08-13 Thread Greg Mann
--gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann

Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework

2015-08-13 Thread Greg Mann
. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95264 --- On Aug. 13, 2015, 4:49 p.m., Greg Mann wrote

Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework

2015-08-13 Thread Greg Mann
idea to add a todo here that captures what you wrote within the JIRA issue already; TODO(*): Ideally, we would inspect the status of the driver and its associated tasks via the Java API and wait until their teardown is complete to exit. Greg Mann wrote: You are correct

Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework

2015-08-13 Thread Greg Mann
=100 2/dev/null | grep \[ Thanks, Greg Mann

Review Request 37493: Detect gflags when present and link when building Python module

2015-08-14 Thread Greg Mann
without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
-website-container Thanks, Greg Mann

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 Diff: https://reviews.apache.org/r/39494/diff/ Testing --- Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container Thanks, Greg Mann

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review103437 --- Ship it! Ship It! - Greg Mann On Oct. 21, 2015, 2:37 a.m

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
----- On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39494/ > ---

Re: Review Request 39493: Added `yum update nss` to CentOS 6.6 install docs.

2015-10-23 Thread Greg Mann
Thanks, Greg Mann

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Greg Mann
----- On Oct. 21, 2015, 5:53 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39453/ > -

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Greg Mann
/diff/ Testing --- https://gist.github.com/greggomann/b5b35a164a006bec9357 Thanks, Greg Mann

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-11-10 Thread Greg Mann
g/r/38399/#comment164570> s/maintenance machine(s)/maintain machine(s)/ - Greg Mann On Sept. 23, 2015, 5:16 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-09 Thread Greg Mann
were added to `reservation_tests.cpp` to validate the authentication of framework reserve and unreserve operations using ACLs. `make check` was run to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-09 Thread Greg Mann
/ Testing --- This is the fourth in a chain of 5 patches. Added new reservation endpoints tests to validate authorization of reserve and unreserve operations using ACLs. `make check` was run to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-09 Thread Greg Mann
and unreserve operations via ACLs. `make check` was used to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-09 Thread Greg Mann
/37002/ Diffs (updated) - include/mesos/authorizer/authorizer.proto 86bbb45f9d91b4098a262e3e50a793f3bb39497e Diff: https://reviews.apache.org/r/39985/diff/ Testing --- This is the first in a chain of 5 patches. `make check` was used to test at the end of the chain. Thanks, Greg

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

2015-11-09 Thread Greg Mann
all patches were applied. Thanks, Greg Mann

Re: Review Request 39018: Added JSON parsing for Resources.

2015-11-09 Thread Greg Mann
many other tests (check `src/tests/sorter_tests.cpp`, for example), so it's clear that the original parsing continues to work correctly. Thanks, Greg Mann

Re: Review Request 39018: Added JSON parsing for Resources.

2015-11-09 Thread Greg Mann
------- On Nov. 9, 2015, 4:48 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39018/ > ---

Re: Review Request 39018: Added JSON parsing for Resources.

2015-11-08 Thread Greg Mann
o reply, visit: https://reviews.apache.org/r/39018/#review105607 --- On Nov. 9, 2015, 5:39 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39018/ > -

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-08 Thread Greg Mann
reservation tests were added to `reservation_tests.cpp` to validate the authentication of framework reserve and unreserve operations using ACLs. `make check` was run to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 39018: Added JSON parsing for Resources.

2015-11-08 Thread Greg Mann
(check `src/tests/sorter_tests.cpp`, for example), so it's clear that the original parsing continues to work correctly. Thanks, Greg Mann

Re: Review Request 39018: Added JSON parsing for Resources.

2015-11-08 Thread Greg Mann
`src/tests/sorter_tests.cpp`, for example), so it's clear that the original parsing continues to work correctly. Thanks, Greg Mann

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

2015-11-08 Thread Greg Mann
to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-08 Thread Greg Mann
and unreserve operations via ACLs. `make check` was used to test after all patches were applied. Thanks, Greg Mann

Review Request 40118: [1/6] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

2015-11-12 Thread Greg Mann
#39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Review Request 40169: [4/6] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

2015-11-12 Thread Greg Mann
with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Review Request 40256: [6/6] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-11-12 Thread Greg Mann
and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. There is one more patch with documentation changes forthcoming. Thanks, Greg Mann

Review Request 40168: [3/6] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-11-12 Thread Greg Mann
of Review #39989. Thanks, Greg Mann

Re: Review Request 40167: [2/7] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

2015-11-12 Thread Greg Mann
that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

2015-11-12 Thread Greg Mann
of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-11-12 Thread Greg Mann
with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-11-12 Thread Greg Mann
(https://github.com/mesosphere/mesos-website-container). Thanks, Greg Mann

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-11-12 Thread Greg Mann
beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-11-12 Thread Greg Mann
of this chain begins on top of Review #39989. There is one more patch with documentation changes forthcoming. Thanks, Greg Mann

Review Request 40167: [2/6] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

2015-11-12 Thread Greg Mann
in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40167: [2/7] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

2015-11-12 Thread Greg Mann
and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-11-12 Thread Greg Mann
, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-11-12 Thread Greg Mann
as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. There is one more patch with documentation changes forthcoming. Thanks, Greg Mann

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-11-12 Thread Greg Mann
. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

2015-11-12 Thread Greg Mann
files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. One additional patch with documentation is forthcoming. Thanks, Greg Mann

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

2015-11-12 Thread Greg Mann
of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. Thanks, Greg Mann

Re: Review Request 40118: [1/6] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

2015-11-12 Thread Greg Mann
files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. One additional patch with documentation is forthcoming. Thanks, Greg Mann

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

2015-11-12 Thread Greg Mann
additional patch with documentation is forthcoming. Thanks, Greg Mann

Review Request 40271: Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-11-12 Thread Greg Mann
f5ed75fcd0785fde38058917354fcf6d668dcccb Diff: https://reviews.apache.org/r/40271/diff/ Testing --- Viewed with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container). Thanks, Greg Mann

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-11-12 Thread Greg Mann
-website-container). `make check` was run after all patches in the chain were applied. Thanks, Greg Mann

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-11-12 Thread Greg Mann
files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989. There is one more patch with documentation changes forthcoming. Thanks, Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-12 Thread Greg Mann
for the authorization of reserve and unreserve operations via ACLs. `make check` was used to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-11-12 Thread Greg Mann
patches were applied. Thanks, Greg Mann

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-12 Thread Greg Mann
://reviews.apache.org/r/39988/diff/ Testing --- This is the fourth in a chain of 5 patches. Added new reservation endpoints tests to validate authorization of reserve and unreserve operations using ACLs. `make check` was run to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-12 Thread Greg Mann
reservation tests were added to `reservation_tests.cpp` to validate the authentication of framework reserve and unreserve operations using ACLs. `make check` was run to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-12 Thread Greg Mann
to test at the end of the chain. Note: documentation for these changes is included in https://reviews.apache.org/r/40271/ Thanks, Greg Mann

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-12 Thread Greg Mann
of reserve and unreserve operations via ACLs. `make check` was used to test after all patches were applied. Thanks, Greg Mann

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

2015-11-13 Thread Greg Mann
upport into the comments/docs when MESOS-3903 is being addressed. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/#review106393 ---

  1   2   3   4   5   6   7   8   9   10   >