Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review86687 --- >From our last conversation, it sounds like you want to change the a

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 28, 2015, 2:53 p.m., Marco Massenzio wrote: > > Folks - this thing has been out for almost four months now, we should > > really get it moving. > > > > @alexdr - can you please address Nik's comments (Nik - you got late to the > > party :) but that's ok) > > > > @till - I think Alex

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 28, 2015, 11:53 p.m., Marco Massenzio wrote: > > Folks - this thing has been out for almost four months now, we should > > really get it moving. > > > > @alexdr - can you please address Nik's comments (Nik - you got late to the > > party :) but that's ok) > > > > @till - I think Alex

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 28, 2015, 2:53 p.m., Marco Massenzio wrote: > > Folks - this thing has been out for almost four months now, we should > > really get it moving. > > > > @alexdr - can you please address Nik's comments (Nik - you got late to the > > party :) but that's ok) > > > > @till - I think Alex

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review85734 --- Patch looks great! Reviews applied: [32198, 32163, 30612] All test

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 21, 2015, 10:37 a.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 1829-1836 > > > > > > I don't think we should not have tests and asserts in SetUp(). Are all > > theses tasks and setup used

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 21, 2015, 7:37 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 1829-1836 > > > > > > I don't think we should not have tests and asserts in SetUp(). Are all > > theses tasks and setup used

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 13, 2015, 11:19 a.m., Adam B wrote: > > src/master/http.cpp, lines 279-288 > > > > > > One thing I'm not 100% clear about from this description: Are each of > > these levels strict subsets of the json hierar

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated May 29, 2015, 4:47 p.m.) Review request for mesos, Adam B, Joerg Schad

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 13, 2015, 9:19 a.m., Adam B wrote: > > src/master/http.cpp, line 322 > > > > > > What about completed frameworks? Should they use this endpoint too, or > > would they get their own? Right now we would like

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review85628 --- Ship it! Folks - this thing has been out for almost four months now

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review84734 --- Last high level comment - if Adam and/or Till don't agree, feel free

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review84372 --- Patch looks great! Reviews applied: [32198, 32163, 30612] All test

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 18, 2015, 1:18 p.m., Till Toenshoff wrote: > > src/master/http.cpp, line 312 > > > > > > `const`? > > Alexander Rojas wrote: > Cannot be const because the operator `[]` provides no const overload > (com

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review84314 --- src/master/http.cpp

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 13, 2015, 11:19 a.m., Adam B wrote: > > src/master/http.cpp, lines 279-288 > > > > > > One thing I'm not 100% clear about from this description: Are each of > > these levels strict subsets of the json hierar

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 18, 2015, 3:18 p.m., Till Toenshoff wrote: > > src/master/http.cpp, line 312 > > > > > > `const`? Cannot be const because the operator `[]` provides no const overload (common problem on the std library) >

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated May 19, 2015, 10:42 a.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review84146 --- Patch looks great! Reviews applied: [32198, 32163, 30612] All test

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review82935 --- This one may be entirely outdated - sry for that in advance sr

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated May 18, 2015, 2:56 p.m.) Review request for mesos, Adam B, Joerg Schad

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review83958 --- What about a /master/frameworks/{framework}/executors endpoint too?

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review83122 --- Question about completed tasks/frameworks, and some minor nits. sr

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review82279 --- Patch looks great! Reviews applied: [32198, 32163, 30612] All test

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated May 1, 2015, 8:56 p.m.) Review request for mesos, Ben Mahler, Marco Ma