Re: Review Request 35717: Add reservations support to master's state.json

[Michael Park]

> On June 26, 2015, 6:44 p.m., Ben Mahler wrote:
> > src/common/http.cpp, line 84
> > 
> >
> > How about calling this 'roleResources' to be clear that this is a role 
> > breakdown, rather than say, a type, name, etc breakdown?
> > 
> > If the type was `hashmap` we could just call the 
> > argument `resources`, but in-lieu of this, `roleResources` helps the reader 
> > more than `resourcesMap`. :)

I commented about this in the initial review as well: 
https://reviews.apache.org/r/35717/#comment141259

@hasodent's point was that the `std::string` could be any key, as opposed to 
`role`-specific. I'm fine with keeping this `role`-specific until we need to 
generalize it though.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89538
---


On June 22, 2015, 11:37 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 22, 2015, 11:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Adam B]

> On June 26, 2015, 11:44 a.m., Ben Mahler wrote:
> > I made a minor naming comment, which I'll get cleaned up for you.
> > 
> > Is there a plan to consistently add reserved and unreserved to the other 
> > resources? e.g. used and offered.
> > Curious if you thought about how to express volumes as well?

MPark and I discussed whether we wanted to further break these down, but the 
primary use case we considered was operators that want to query what 
reservations already exist and what resources are left unreserved, then script 
a request to update the reservations. We decided to leave the aggregate for now 
and break down used/offered/available when a need arises.
We also discussed whether to include unreserved resources as just another `*` 
role along with the rest of the role-reservations, but decided that we liked 
the explicitness of naming it `unreserved` rather than requiring the user to 
know about our special `*` role name.

How to express volumes is more related to the stringification of an individual 
(diskinfo) resource, rather than the map/list of resources reserved by role. 
Good question though. We'll want to make sure these are expressed somehow 
before the feature goes GA.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89538
---


On June 22, 2015, 4:37 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 22, 2015, 4:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89538
---


I made a minor naming comment, which I'll get cleaned up for you.

Is there a plan to consistently add reserved and unreserved to the other 
resources? e.g. used and offered.
Curious if you thought about how to express volumes as well?


src/common/http.cpp (line 84)


How about calling this 'roleResources' to be clear that this is a role 
breakdown, rather than say, a type, name, etc breakdown?

If the type was `hashmap` we could just call the argument 
`resources`, but in-lieu of this, `roleResources` helps the reader more than 
`resourcesMap`. :)


- Ben Mahler


On June 22, 2015, 11:37 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 22, 2015, 11:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89457
---

Ship it!


Ship It!

- Michael Park


On June 22, 2015, 11:37 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 22, 2015, 11:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89456
---

Ship it!


Ship It!

- Adam B


On June 22, 2015, 4:37 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 22, 2015, 4:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Adam B]

> On June 24, 2015, 3:24 a.m., Adam B wrote:
> > src/common/http.cpp, line 84
> > 
> >
> > I wonder if you could templatize this to work for modeling any 
> > hashmap, where T is an already modeled type.

I'm not sure what other hashmaps we'd model in JSON. We can always templatize 
it when we run across the next hashmap type. Dropping this issue so I can 
commit the patch as is.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89146
---


On June 22, 2015, 4:37 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 22, 2015, 4:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89146
---


Looks great! Just a couple of questions, but I think this is very close to 
shippable.


src/common/http.cpp (line 84)


I wonder if you could templatize this to work for modeling any 
hashmap, where T is an already modeled type.



src/master/http.cpp (line 235)


Since this is an API change, we may want to document that the "resources" 
field in state.json now also includes persistent volumes (and dynamic 
reservations). This could be covered by 
https://issues.apache.org/jira/browse/MESOS-2123



src/master/http.cpp (lines 236 - 239)


I wonder if users would want to know about used vs. offered vs. available 
reserved resources, or if they just want to know about the reservations in 
aggregate, no matter the current status of those resources.
I think we're probably fine just listing the resources by role, regardless 
of status.


- Adam B


On June 22, 2015, 4:37 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 22, 2015, 4:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88779
---


Patch looks great!

Reviews applied: [35717]

All tests passed.

- Mesos ReviewBot


On June 22, 2015, 11:37 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 22, 2015, 11:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/
---

(Updated June 22, 2015, 11:37 a.m.)


Review request for mesos, Adam B and Michael Park.


Bugs: MESOS-692
https://issues.apache.org/jira/browse/MESOS-692


Repository: mesos


Description
---

Add reservations support to master's state.json


Diffs (updated)
-

  src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
  src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
  src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
  src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 

Diff: https://reviews.apache.org/r/35717/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 35717: Add reservations support to master's state.json

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88709
---


Patch looks great!

Reviews applied: [35717]

All tests passed.

- Mesos ReviewBot


On June 21, 2015, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 21, 2015, 6:07 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[haosdent huang]

> On June 21, 2015, 5:56 p.m., Michael Park wrote:
> > src/common/http.cpp, line 88
> > 
> >
> > `s/key/role/`
> 
> haosdent huang wrote:
> I think use key may be more general. Because this method not only could 
> be used to generate "role -> resources" json, also could be used to generate 
> "principal -> resources" json. Or other any keys.
> 
> Michael Park wrote:
> Ok, sounds good to me.

Thank you for your fast reply!


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
---


On June 21, 2015, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 21, 2015, 6:07 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88707
---

Ship it!



src/master/http.cpp (line 234)


No need to make a copy here. If we just want a shorter name, let's alias it 
with a const-ref.

`const Resources& totalResources = slave.totalResources;`


- Michael Park


On June 21, 2015, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 21, 2015, 6:07 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[Michael Park]

> On June 21, 2015, 5:56 p.m., Michael Park wrote:
> > src/common/http.cpp, line 88
> > 
> >
> > `s/key/role/`
> 
> haosdent huang wrote:
> I think use key may be more general. Because this method not only could 
> be used to generate "role -> resources" json, also could be used to generate 
> "principal -> resources" json. Or other any keys.

Ok, sounds good to me.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
---


On June 21, 2015, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 21, 2015, 6:07 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[haosdent huang]

> On June 21, 2015, 5:56 p.m., Michael Park wrote:
> > src/common/http.cpp, line 88
> > 
> >
> > `s/key/role/`

I think use key may be more general. Because this method not only could be used 
to generate "role -> resources" json, also could be used to generate "principal 
-> resources" json. Or other any keys.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
---


On June 21, 2015, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 21, 2015, 6:04 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35717: Add reservations support to master's state.json

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/
---

(Updated June 21, 2015, 6:04 p.m.)


Review request for mesos and Adam B.


Bugs: MESOS-692
https://issues.apache.org/jira/browse/MESOS-692


Repository: mesos


Description
---

Add reservations support to master's state.json


Diffs (updated)
-

  src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
  src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
  src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
  src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 

Diff: https://reviews.apache.org/r/35717/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 35717: Add reservations support to master's state.json

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/
---

(Updated June 21, 2015, 6:02 p.m.)


Review request for mesos and Adam B.


Bugs: MESOS-692
https://issues.apache.org/jira/browse/MESOS-692


Repository: mesos


Description
---

Add reservations support to master's state.json


Diffs (updated)
-

  src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
  src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
  src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
  src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 

Diff: https://reviews.apache.org/r/35717/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 35717: Add reservations support to master's state.json

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
---


Thanks for doing this! Looks good to me overall.


src/common/http.cpp (line 88)


`s/key/role/`



src/master/http.cpp (line 234)


This is a bug from before, we should use `slave.totalResources` here 
instead.


- Michael Park


On June 21, 2015, 5:35 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> ---
> 
> (Updated June 21, 2015, 5:35 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>