Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 11:55 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 10:21 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
> On Oct. 19, 2015, 10:09 p.m., Michael Park wrote: > > docs/configuration.md, line 1445 > > > > > > `\Could not chown work directory\` -- is this intentional? If yes, what > > does it do...? good catch! copy & pa

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103170 --- docs/configuration.md (line 1442)

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103163 --- Ship it! Ship It! - Guangya Liu On 十月 19, 2015, 9:27 p.m., Marc

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 9:27 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 9:23 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
> On Oct. 19, 2015, 7:35 p.m., Michael Park wrote: > > Thanks for doing this! It's definitely clearer (at least to me) as to what > > this flag is controlling. > > > > A few general comments here: > > (1) We should be using ``` in some of the cases instead of `'` right? It > > seems to be a bi

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
> On Oct. 19, 2015, 7:27 p.m., Kapil Arya wrote: > > src/slave/paths.cpp, lines 427-429 > > > > > > Why not use the same `LOG(WARNING)` statement? That way the entire > > message will appear together instead of bein

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103146 --- Thanks for doing this! It's definitely clearer (at least to me) as

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103148 --- Ship it! Gave it a go :) docs/configuration.md (line 1441)

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103142 --- Patch looks great! Reviews applied: [39447] All tests passed. -

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 7:06 p.m.) Review request for mesos and Ben Mahler. C