Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/ --- (Updated Feb. 10, 2016, 3:56 p.m.) Review request for mesos, Michael Park and

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review118721 --- Patch looks great! Reviews applied: [43422, 42908] Passed

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-10 Thread Michael Park
> On Feb. 10, 2016, 2:04 a.m., Michael Park wrote: > > src/tests/master_quota_tests.cpp, lines 993-1000 > > > > > > Did we not need these before for some reason? > > Alexander Rukletsov wrote: > We did, it was

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-10 Thread Alexander Rukletsov
> On Feb. 5, 2016, 3:11 a.m., Till Toenshoff wrote: > > src/tests/master_quota_tests.cpp, line 901 > > > > > > I feel this comment as-is does not add much. > > > > Either removing it or supplying a

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-10 Thread Alexander Rukletsov
> On Feb. 10, 2016, 2:04 a.m., Michael Park wrote: > > src/tests/master_quota_tests.cpp, lines 993-1000 > > > > > > Did we not need these before for some reason? We did, it was a bug. I believe you mean we should

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review118551 --- src/tests/master_quota_tests.cpp (lines 990 - 991)

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review117954 --- lgtm src/tests/master_quota_tests.cpp (line 901)

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review117981 --- Patch looks great! Reviews applied: [42908] Passed command:

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Klaus Ma
> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocator > > to do the `rescindOffer`? It

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/ --- (Updated Jan. 29, 2016, 10:34 a.m.) Review request for mesos, Michael Park and

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Alexander Rukletsov
> On Jan. 29, 2016, 8:42 a.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocator > > to do the `rescindOffer`? It

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review116908 --- src/tests/master_quota_tests.cpp (line 957)

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Klaus Ma
> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocator > > to do the `rescindOffer`? It