Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 15, 2016, 10:59 a.m.) Review request for mesos, Adam B and

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review123411 --- Patch looks great! Reviews applied: [44570] Passed command:

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-14 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review123404 --- Fix it, then Ship it! include/mesos/mesos.proto (line 440)

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-14 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 14, 2016, 12:06 p.m.) Review request for mesos, Adam B and

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review123401 --- Fix it, then Ship it! Just fix the v1 comments, and then I

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-14 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 14, 2016, 11:46 a.m.) Review request for mesos, Adam B and

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-14 Thread Adam B
> On March 9, 2016, 7:33 a.m., James DeFelice wrote: > > src/master/validation.cpp, line 379 > > > > > > this is exactly the type of thing that I'd expect to be documented in > > the protobuf I believe this is

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review123399 --- Looks good. Just update the comments and error string.

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-14 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 14, 2016, 10:37 a.m.) Review request for mesos, Adam B and

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review123300 --- Sorry for the misunderstanding. As far as (sandbox)

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-12 Thread Adam B
> On March 9, 2016, 10:31 p.m., Adam B wrote: > > src/master/validation.cpp, line 381 > > > > > > It may be sufficient to only check `if (task.has_owner() && > > task.has_executor())` since a custom executor should

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122921 --- Patch looks great! Reviews applied: [44570] Passed command:

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 10, 2016, 1:49 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Jan Schlicht
> On March 10, 2016, 7:31 a.m., Adam B wrote: > > src/master/validation.cpp, line 381 > > > > > > It may be sufficient to only check `if (task.has_owner() && > > task.has_executor())` since a custom executor should

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Jan Schlicht
> On March 10, 2016, 9:22 a.m., Klaus Ma wrote: > > include/mesos/mesos.proto, line 443 > > > > > > Also added in v1 APIs? Oh sure, good catch! - Jan ---

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122897 --- include/mesos/mesos.proto (line 443)

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122887 --- We may need to do some discovery on whether an executor could

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122743 --- Patch looks great! Reviews applied: [44570] Passed command:

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-09 Thread Jan Schlicht
> On March 9, 2016, 4:33 p.m., James DeFelice wrote: > > include/mesos/mesos.proto, line 442 > > > > > > what if it's specified in both places, two different ways? I think > > there's room for a little more

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 9, 2016, 4:48 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-09 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122725 --- include/mesos/mesos.proto (line 442)

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 9, 2016, 4 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/ --- (Updated March 9, 2016, 3:51 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122721 --- Does it a typo in Description? s/archived/achieved