Re: Review Request 45186: Implemented user specified system config files support.

2016-03-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review125311 --- I am discarding these patches because they should be supported by

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review125287 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Guangya Liu
> On 三月 23, 2016, 6:51 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233 > > > > > > Put this check to the block of > > if (flags.system_config_files.isSome()

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Guangya Liu
> On 三月 23, 2016, 6:46 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205 > > > > > > what about: > > > > foreach ( > > const string& file, > >

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Gilbert Song
> On March 22, 2016, 11:46 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205 > > > > > > what about: > > > > foreach ( > > const string& file, > >

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Gilbert Song
> On March 22, 2016, 11:51 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233 > > > > > > Put this check to the block of > > if (flags.system_config_files.isSo

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review125026 --- Patch looks great! Reviews applied: [45183, 45184, 45185, 45186]

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review124976 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines

Re: Review Request 45186: Implemented user specified system config files support.

2016-03-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review124964 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines