Re: Review Request 45186: Implemented user specified system config files support.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review125311
---



I am discarding these patches because they should be supported by network 
isolator. Thanks for reviewing guys!

- Gilbert Song


On March 22, 2016, 5:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated March 22, 2016, 5:20 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45186: Implemented user specified system config files support.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review125287
---




src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 207)


We should use the path::absolute method here



src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 219)


Also log when we cannot find it.


- Timothy Chen


On March 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated March 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45186: Implemented user specified system config files support.

[Guangya Liu]

> On 三月 23, 2016, 6:51 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233
> > 
> >
> > Put this check to the block of 
> > if (flags.system_config_files.isSome()) {
> > } ?
> 
> Gilbert Song wrote:
> It can be a case that any of the four default sys config files missing on 
> the host for some os env, so we check all files which will be bind mounted 
> here.

Just curious for which system/os does the four default sys config files will 
not exist?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review124976
---


On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated 三月 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45186: Implemented user specified system config files support.

[Guangya Liu]

> On 三月 23, 2016, 6:46 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205
> > 
> >
> > what about:
> > 
> > foreach (
> > const string& file,
> > strings::split(flags.system_config_files.get(), ",")) {
> 
> Gilbert Song wrote:
> Thanks for mentioning this. We are currently supporting both formats. We 
> may prefer the original one here since that format is used around this part 
> of codes.

Yes, but we did have patches 
https://reviews.apache.org/r/44653/diff/5#index_header to address such issue, 
so it would be great if we can follow this format ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review124964
---


On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated 三月 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45186: Implemented user specified system config files support.

[Gilbert Song]

> On March 22, 2016, 11:46 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205
> > 
> >
> > what about:
> > 
> > foreach (
> > const string& file,
> > strings::split(flags.system_config_files.get(), ",")) {

Thanks for mentioning this. We are currently supporting both formats. We may 
prefer the original one here since that format is used around this part of 
codes.


> On March 22, 2016, 11:46 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 221
> > 
> >
> > I thihk that we also need to make sure the file exist before put it to 
> > systemConfig, otherwise, the bind mount will be failed.

They are checked together in the loop below. Yes, we should be careful about 
this.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review124964
---


On March 22, 2016, 5:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated March 22, 2016, 5:20 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45186: Implemented user specified system config files support.

[Gilbert Song]

> On March 22, 2016, 11:51 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233
> > 
> >
> > Put this check to the block of 
> > if (flags.system_config_files.isSome()) {
> > } ?

It can be a case that any of the four default sys config files missing on the 
host for some os env, so we check all files which will be bind mounted here.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review124976
---


On March 22, 2016, 5:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated March 22, 2016, 5:20 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45186: Implemented user specified system config files support.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review125026
---



Patch looks great!

Reviews applied: [45183, 45184, 45185, 45186]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated March 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45186: Implemented user specified system config files support.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review124976
---




src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 231 - 233)


Put this check to the block of 
if (flags.system_config_files.isSome()) {
} ?


- Guangya Liu


On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated 三月 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45186: Implemented user specified system config files support.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review124964
---




src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 204 - 205)


what about:

foreach (
const string& file,
strings::split(flags.system_config_files.get(), ",")) {



src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 221)


I thihk that we also need to make sure the file exist before put it to 
systemConfig, otherwise, the bind mount will be failed.


- Guangya Liu


On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> ---
> 
> (Updated 三月 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>