Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-12-09 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review158737
---


Ship it!




Ship It!

- Joseph Wu


On Nov. 23, 2016, 10:34 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Nov. 23, 2016, 10:34 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test SchedulerTest.Teardown to
> be parametrized by both ContentType and SSL configuration,
> and renames it to SchedulerSSLTest.RunTaskAndTeardown.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp c031823843a8ae5ecbccf60b9edf83ec1afcc5e6 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> All testing was done on CentOS 7:
> 
> `make check` ran and all tests passed.
> 
> `3rdparty/libprocess/libprocess-tests --gtest_repeat=-1 
> --gtest_break_on_failure` ran for several hundred repetitions with no 
> failures.
> 
> `3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest*" 
> --gtest_repeat=-1 --gtest_break_on_failure` ran for about 1,000 repetitions 
> without failing.
> 
> `3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.SocketEOF/*" 
> --gtest_repeat=-1 --gtest_break_on_failure` ran for about 4,000 repetitions 
> without failing.
> 
> `3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.Endpoints/*" 
> --gtest_repeat=-1 --gtest_break_on_failure` ran for about 10,000 repetitions 
> without failing.
> 
> `bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure` ran for 
> several hundred repetitions with no failures.
> 
> `bin/mesos-tests.sh --gtest_filter="*SchedulerSSLTest*" --gtest_repeat=-1 
> --gtest_break_on_failure` ran for about 2,000 repetitions without failing.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-11-23 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Nov. 23, 2016, 6:34 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test SchedulerTest.Teardown to
be parametrized by both ContentType and SSL configuration,
and renames it to SchedulerSSLTest.RunTaskAndTeardown.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp c031823843a8ae5ecbccf60b9edf83ec1afcc5e6 

Diff: https://reviews.apache.org/r/50857/diff/


Testing (updated)
---

All testing was done on CentOS 7:

`make check` ran and all tests passed.

`3rdparty/libprocess/libprocess-tests --gtest_repeat=-1 
--gtest_break_on_failure` ran for several hundred repetitions with no failures.

`3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest*" 
--gtest_repeat=-1 --gtest_break_on_failure` ran for about 1,000 repetitions 
without failing.

`3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.SocketEOF/*" 
--gtest_repeat=-1 --gtest_break_on_failure` ran for about 4,000 repetitions 
without failing.

`3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.Endpoints/*" 
--gtest_repeat=-1 --gtest_break_on_failure` ran for about 10,000 repetitions 
without failing.

`bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure` ran for several 
hundred repetitions with no failures.

`bin/mesos-tests.sh --gtest_filter="*SchedulerSSLTest*" --gtest_repeat=-1 
--gtest_break_on_failure` ran for about 2,000 repetitions without failing.


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-11-23 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Nov. 23, 2016, 6:26 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test SchedulerTest.Teardown to
be parametrized by both ContentType and SSL configuration,
and renames it to SchedulerSSLTest.RunTaskAndTeardown.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp c031823843a8ae5ecbccf60b9edf83ec1afcc5e6 

Diff: https://reviews.apache.org/r/50857/diff/


Testing (updated)
---

All testing was done on CentOS 7:

`make check` ran and all tests passed.

`3rdparty/libprocess/libprocess-tests --gtest_repeat=-1 
--gtest_break_on_failure` ran for several hundred repetitions with no failures.

`3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest*" 
--gtest_repeat=-1 --gtest_break_on_failure` ran for about 1,000 repetitions 
without failing.

`3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.Endpoints/*" 
--gtest_repeat=-1 --gtest_break_on_failure` ran for about 10,000 repetitions 
without failing.

`bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure` ran for several 
hundred repetitions with no failures.

`bin/mesos-tests.sh --gtest_filter="*SchedulerSSLTest*" --gtest_repeat=-1 
--gtest_break_on_failure` ran for about 2,000 repetitions without failing.


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-11-22 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Nov. 22, 2016, 7:56 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test SchedulerTest.Teardown to
be parametrized by both ContentType and SSL configuration,
and renames it to SchedulerSSLTest.RunTaskAndTeardown.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp c031823843a8ae5ecbccf60b9edf83ec1afcc5e6 

Diff: https://reviews.apache.org/r/50857/diff/


Testing (updated)
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`

More testing details are included at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-11-22 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Nov. 22, 2016, 7:53 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description (updated)
---

This patch modifies the test SchedulerTest.Teardown to
be parametrized by both ContentType and SSL configuration,
and renames it to SchedulerSSLTest.RunTaskAndTeardown.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp c031823843a8ae5ecbccf60b9edf83ec1afcc5e6 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-11-16 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Nov. 16, 2016, 7:21 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Fixed v1 namespace.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

Modified a scheduler test to run with SSL enabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp c031823843a8ae5ecbccf60b9edf83ec1afcc5e6 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-11-15 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Nov. 16, 2016, 1:15 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description (updated)
---

Modified a scheduler test to run with SSL enabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp c031823843a8ae5ecbccf60b9edf83ec1afcc5e6 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-10-26 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review153967
---



Patch looks great!

Reviews applied: [45991, 45995, 45996, 45999, 46094, 46146, 40266, 51049, 
50621, 40410, 40411, 40413, 40268, 40512, 50736, 51065, 52938, 50737, 50969, 
50857]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 26, 2016, 10:40 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Oct. 26, 2016, 10:40 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 6e876a7184204407c8ba4cb2300e095c29a6c8fb 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> The test was run in repetition as follows:
> 
> `GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-10-26 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Oct. 26, 2016, 10:40 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 6e876a7184204407c8ba4cb2300e095c29a6c8fb 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-10-25 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Oct. 25, 2016, 9:43 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 6e876a7184204407c8ba4cb2300e095c29a6c8fb 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-10-17 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Oct. 17, 2016, 6:58 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-09-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review149959
---



Bad patch!

Reviews applied: [50857, 50969, 50737, 51065, 50736, 40512, 40268, 40413, 
40411, 40410, 50621, 51049, 40266, 46146, 46094, 45999, 45996, 45995, 45991]

Failed command: ./support/apply-review.sh -n -r 51065

Error:
2016-09-22 07:31:18 URL:https://reviews.apache.org/r/51065/diff/raw/ 
[3636/3636] -> "51065.patch" [1]
error: patch failed: 3rdparty/libprocess/include/process/ssl/gtest.hpp:363
error: 3rdparty/libprocess/include/process/ssl/gtest.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15358/console

- Mesos ReviewBot


On Sept. 21, 2016, 10:20 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Sept. 21, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> The test was run in repetition as follows:
> 
> `GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-09-21 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Sept. 21, 2016, 10:20 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-09-20 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Sept. 20, 2016, 8:47 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-09-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Sept. 19, 2016, 8:23 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 

Diff: https://reviews.apache.org/r/50857/diff/


Testing (updated)
---

The test was run in repetition as follows:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-09-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review148799
---



Bad patch!

Reviews applied: [50857, 50969, 50737, 51065, 50736, 40512, 40268, 40413, 
40411, 40410, 50621, 51049, 40266, 46146, 46094, 45999, 45996, 45995, 45991]

Failed command: ./support/apply-review.sh -n -r 51065

Error:
2016-09-13 23:07:26 URL:https://reviews.apache.org/r/51065/diff/raw/ 
[3635/3635] -> "51065.patch" [1]
error: patch failed: 3rdparty/libprocess/include/process/ssl/gtest.hpp:363
error: 3rdparty/libprocess/include/process/ssl/gtest.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15236/console

- Mesos ReviewBot


On Sept. 13, 2016, 6:13 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Sept. 13, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> This test is currently flaky in the SSL-enabled configurations and I've seen 
> it produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try:
> 
> `GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-09-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Sept. 13, 2016, 6:13 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Made use of the new metrics singleton.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

This test is currently flaky in the SSL-enabled configurations and I've seen it 
produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review145833
---



Patch looks great!

Reviews applied: [45991, 45995, 45996, 45999, 46094, 46146, 40266, 51049, 
50621, 40410, 40411, 40413, 40268, 40512, 50736, 51065, 50737, 50969, 50857]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 15, 2016, 8:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Aug. 15, 2016, 8:18 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> This test is currently flaky in the SSL-enabled configurations and I've seen 
> it produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try:
> 
> `GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-15 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Aug. 15, 2016, 8:18 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

This test is currently flaky in the SSL-enabled configurations and I've seen it 
produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Aug. 13, 2016, 7:16 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 

Diff: https://reviews.apache.org/r/50857/diff/


Testing (updated)
---

This test is currently flaky in the SSL-enabled configurations and I've seen it 
produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Aug. 13, 2016, 6:16 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

This test is currently flaky in the SSL-enabled configurations and will produce 
a segfault on my OSX machine after 50-100 repetitions. To reproduce, try:

`GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Aug. 13, 2016, 1:41 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

This test is currently flaky in the SSL-enabled configurations and will produce 
a segfault on my OSX machine after 50-100 repetitions. To reproduce, try:

`GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-12 Thread Greg Mann 


> On Aug. 11, 2016, 7:48 p.m., Joseph Wu wrote:
> > src/tests/scheduler_tests.cpp, line 1643
> > 
> >
> > This is already called in `MesosTest::SetUp()`.

AFAICT this isn't called in `MesosTest::SetUp()` anywhere. If I remove this 
line, the test fails because the keys/certs haven't been written.


> On Aug. 11, 2016, 7:48 p.m., Joseph Wu wrote:
> > src/tests/scheduler_tests.cpp, lines 1657-1668
> > 
> >
> > Since we're already reinitializing in the `SetUp`, we don't need to 
> > reinitialize in `TearDown`.
> > 
> > Instead, change this cleanup to `TearDownTestCase`.

We have to reinitialize conditionally to clear the environment for non-SSL 
iterations. If we make this a `TearDownTestCase`, we won't successfully 
alternate between enabled/disabled SSL.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review145549
---


On Aug. 12, 2016, 11:03 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Aug. 12, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> This test is currently flaky in the SSL-enabled configurations and will 
> produce a segfault on my OSX machine after 50-100 repetitions. To reproduce, 
> try:
> 
> `GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Aug. 12, 2016, 11:03 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Addressed Joseph's comments.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

This test is currently flaky in the SSL-enabled configurations and will produce 
a segfault on my OSX machine after 50-100 repetitions. To reproduce, try:

`GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-12 Thread Greg Mann 


> On Aug. 10, 2016, 11:19 p.m., Joseph Wu wrote:
> > src/tests/scheduler_tests.cpp, line 1633
> > 
> >
> > `::tr1` ?

gtest uses the tr1 tuple. If I attempt `std::tuple` I get this at compile time:

```
../../src/tests/scheduler_tests.cpp:1556:138: error: no viable conversion from 
'internal::CartesianProductHolder2, 
ValueArray2 >' to 
'::testing::internal::ParamGenerator'
::testing::internal::ParamGenerator 
gtest_ContentTypeAndSSLConfigSchedulerSSLTest_EvalGenerator_() { return 
::testing::Combine( ::testing::Values(ContentType::PROTOBUF, 
ContentType::JSON), ::testing::Values( true, false)); } int 
gtest_ContentTypeAndSSLConfigSchedulerSSLTest_dummy_ = 
::testing::UnitTest::GetInstance()->parameterized_test_registry(). 
GetTestCasePatternHolder( "SchedulerSSLTest", 
"../../src/tests/scheduler_tests.cpp", 1565)->AddTestCaseInstantiation( 
"ContentTypeAndSSLConfig", 
_ContentTypeAndSSLConfigSchedulerSSLTest_EvalGenerator_, 
"../../src/tests/scheduler_tests.cpp", 1565);

 
^
../3rdparty/gmock-1.7.0/gtest/include/gtest/internal/gtest-param-util.h:164:3: 
note: candidate constructor not viable: no known conversion from 
'internal::CartesianProductHolder2, 
ValueArray2 >' to 'const 
testing::internal::ParamGenerator > 
&' for 1st argument
  ParamGenerator(const ParamGenerator& other) : impl_(other.impl_) {}
  ^
../3rdparty/gmock-1.7.0/gtest/include/gtest/internal/gtest-param-util-generated.h:4841:3:
 note: candidate template ignored: could not match 'std::tr1::tuple' against 
'std::__1::tuple'
  operator ParamGenerator< ::std::tr1::tuple >() const {
  ^
../../src/tests/scheduler_tests.cpp:1589:29: error: no matching function for 
call to 'get'
  ContentType contentType = std::tr1::get<0>(GetParam());
^~~~
../3rdparty/gmock-1.7.0/gtest/include/gtest/internal/gtest-tuple.h:923:1: note: 
candidate template ignored: could not match 'std::tr1::tuple' against 
'std::__1::tuple'
get(tuple& t) {
^
../3rdparty/gmock-1.7.0/gtest/include/gtest/internal/gtest-tuple.h:929:1: note: 
candidate template ignored: could not match 'std::tr1::tuple' against 
'std::__1::tuple'
get(const tuple& t) {
^
2 errors generated.
make[3]: *** [tests/mesos_tests-scheduler_tests.o] Error 1
```

We make use of `std::tr1::tuple` elsewhere in the tests for this reason; see 
the hierarchical allocator tests and the sorter tests.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review145428
---


On Aug. 12, 2016, 11:03 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Aug. 12, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> This test is currently flaky in the SSL-enabled configurations and will 
> produce a segfault on my OSX machine after 50-100 repetitions. To reproduce, 
> try:
> 
> `GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-11 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review145549
---



Still hunting down the rogue `ConnectionProcess` that sometimes crashes the 
test during finalization...


src/tests/scheduler_tests.cpp (line 1526)


This is already called in `MesosTest::SetUp()`.



src/tests/scheduler_tests.cpp (lines 1540 - 1551)


Since we're already reinitializing in the `SetUp`, we don't need to 
reinitialize in `TearDown`.

Instead, change this cleanup to `TearDownTestCase`.


- Joseph Wu


On Aug. 10, 2016, 3:37 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Aug. 10, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> This test is currently flaky in the SSL-enabled configurations and will 
> produce a segfault on my OSX machine after 50-100 repetitions. To reproduce, 
> try:
> 
> `GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review145466
---



Patch looks great!

Reviews applied: [45991, 45995, 45996, 45999, 46094, 46146, 40266, 50621, 
40410, 40411, 40413, 40268, 40512, 50736, 50737, 50969, 50857]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 10, 2016, 10:37 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Aug. 10, 2016, 10:37 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> This test is currently flaky in the SSL-enabled configurations and will 
> produce a segfault on my OSX machine after 50-100 repetitions. To reproduce, 
> try:
> 
> `GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-10 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review145428
---




src/tests/scheduler_tests.cpp (line 1516)


`::tr1` ?



src/tests/scheduler_tests.cpp (line 1534)


`None()`



src/tests/scheduler_tests.cpp (line 1545)


`None()`


- Joseph Wu


On Aug. 10, 2016, 3:37 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> ---
> 
> (Updated Aug. 10, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> ---
> 
> This test is currently flaky in the SSL-enabled configurations and will 
> produce a segfault on my OSX machine after 50-100 repetitions. To reproduce, 
> try:
> 
> `GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
> bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-10 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Aug. 10, 2016, 10:37 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Summary (updated)
-

Modified a scheduler test to run with SSL enabled.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

This test is currently flaky in the SSL-enabled configurations and will produce 
a segfault on my OSX machine after 50-100 repetitions. To reproduce, try:

`GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann