Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review112442
---

Ship it!


Great. I'm fixing the pointer style as I commit.


src/tests/common/http_tests.cpp (line 87)


`s/IPAddress */IPAddress* /`



src/tests/slave_tests.cpp (lines 2206 - 2209)


`s/IPAddress */IPAddress* /`


- Adam B


On Dec. 29, 2015, 10:44 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 29, 2015, 10:44 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 29, 2015, 6:44 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review112192
---

Ship it!


LGTM, just some minor cleanup nits.


src/tests/common/http_tests.cpp (line 103)


Nit: `const` does not look related to this change and we do not have style 
guidelines pertaining to it too. Can we remove all the `const` related changes 
in this review ?



src/tests/slave_tests.cpp (line 2247)


Kill this redundant line. You already have specified your intentions of 
checking if the Virtual IPs are set in the `DiscoveryInfo` object a few lines 
before:

```// Check the virtual IPs are set in the `DiscoveryInfo` object.```



src/tests/slave_tests.cpp (line 2258)


Kill this line. This made sense when we were having both i.e.

`EXPECT_SOME` and `EXPECT_EQ` instead of having them in one call now.

This alone should suffice:
```// Check the ports are set in the `DiscoveryInfo` object.```



src/tests/slave_tests.cpp (line 2259)


We generally try to make each review a self containing single atomic 
change. It looks like that these port related cleanup changes are not related 
to this review and should have been part of a separate cleanup patch.

This is fine for now but keep this in mind for future patches.


- Anand Mazumdar


On Dec. 23, 2015, 2:10 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 23, 2015, 2:10 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review112205
---


Patch looks great!

Reviews applied: [41380, 41381]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 29, 2015, 6:44 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 29, 2015, 6:44 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 23, 2015, 2:10 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111718
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Dec. 23, 2015, 2:10 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 23, 2015, 2:10 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111703
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Dec. 22, 2015, 11:48 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 22, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 22, 2015, 11:48 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 20, 2015, 1:56 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
  src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111399
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Dec. 20, 2015, 1:56 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 20, 2015, 1:56 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111370
---



src/tests/slave_tests.cpp (line 2238)


Put a blank line above this comment line.
Put a space after the `//` so it reads `// Verify`.
s/retrived/retrieved/
s/one/ones/



src/tests/slave_tests.cpp (lines 2247 - 2251)


EXPECT_SOME_EQ here too. Since this was your own test that we just 
committed, let's fix it ourselves now.


- Adam B


On Dec. 18, 2015, 11:58 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 18, 2015, 11:58 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

> On Dec. 19, 2015, 5:49 a.m., Artem Harutyunyan wrote:
> > src/tests/slave_tests.cpp, lines 2242-2246
> > 
> >
> > How about using EXPECT_SOME_EQ here?

This is much cleaner.


> On Dec. 19, 2015, 5:49 a.m., Artem Harutyunyan wrote:
> > src/tests/slave_tests.cpp, lines 2254-2259
> > 
> >
> > Ditto as above. But please submit a follow up patch if you decide to 
> > switch these (and possible other) occurences as well.

Will raise a JIRA and a followup patch to change this. Thanks.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111362
---


On Dec. 19, 2015, 7:58 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 19, 2015, 7:58 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111367
---


Patch looks great!

Reviews applied: [41380, 41381]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 19, 2015, 7:58 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 19, 2015, 7:58 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

> On Dec. 19, 2015, 10:10 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 2248-2253
> > 
> >
> > EXPECT_SOME_EQ here too. Since this was your own test that we just 
> > committed, let's fix it ourselves now.

Ok. will do.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111370
---


On Dec. 20, 2015, 1:56 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 20, 2015, 1:56 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111362
---



src/tests/common/http_tests.cpp (line 101)


Since Task instances are exported through state endpoints on both the slave 
and the master you might as well query those to actually verify that 
DiscoverInfo is always available to consumers. 

See, please 
https://github.com/apache/mesos/blob/master/src/tests/health_check_tests.cpp#L254-L278
 for an example.



src/tests/slave_tests.cpp (lines 2242 - 2246)


How about using EXPECT_SOME_EQ here?



src/tests/slave_tests.cpp (lines 2253 - 2257)


Ditto as above. But please submit a follow up patch if you decide to switch 
these (and possible other) occurences as well.


- Artem Harutyunyan


On Dec. 17, 2015, 3:15 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 17, 2015, 3:15 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 19, 2015, 7:58 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
  src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

> On Dec. 17, 2015, 11:21 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, line 2240
> > 
> >
> > Do you want to verify that the vips are set as expected too?

The vips are part of the DiscoveryInfo and we are already comparing the JSON 
retrieved and the DiscoveryInfo set:
EXPECT_EQ(JSON::Object(JSON::protobuf(discovery)), discoveryObject);

Were you suggesting doing an explicit comparison?


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review110940
---


On Dec. 17, 2015, 3:32 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 17, 2015, 3:32 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 17, 2015, 10:43 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 17, 2015, 11:15 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review110940
---


Errors in one of the tests, but only minor suggestions otherwise.


src/tests/common/http_tests.cpp (lines 78 - 79)


Can you make these different? Just in case we run into a bug where we 
report each one as the other, or something equally tricksy



src/tests/common/http_tests.cpp (lines 148 - 150)


There's that nesting again..



src/tests/slave_tests.cpp (lines 2197 - 2199)


s/port1/port2/?
And you call `port2->set_number()` twice. I assume the second one should 
have been the `port2->set_instance_port()`?



src/tests/slave_tests.cpp (line 2240)


Do you want to verify that the vips are set as expected too?


- Adam B


On Dec. 16, 2015, 7:32 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 16, 2015, 7:32 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review03
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Dec. 17, 2015, 11:15 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 17, 2015, 11:15 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 17, 2015, 3:32 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review110484
---


Bad patch!

Reviews applied: [41380]

Failed command: ./support/apply-review.sh -n -r 41380

Error:
 2015-12-15 12:29:45 URL:https://reviews.apache.org/r/41380/diff/raw/ 
[1208/1208] -> "41380.patch" [1]
error: patch failed: include/mesos/mesos.proto:1566
error: include/mesos/mesos.proto: patch does not apply
error: patch failed: include/mesos/v1/mesos.proto:1565
error: include/mesos/v1/mesos.proto: patch does not apply

- Mesos ReviewBot


On Dec. 15, 2015, 3:37 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 15, 2015, 3:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 15, 2015, 9:11 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 15, 2015, 11:30 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Changes
---

Convert the repeat Vip field to an optional Vips field


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 16, 2015, 12:29 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan

Review Request 41381: Added unit test cases to test the new vip and instance_port fields

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs
-

  src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan