[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
dongjoon-hyun commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#discussion_r333283788 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala

[GitHub] [spark] cloud-fan commented on issue #26076: [SPARK-29419][SQL] Fix Encoder thread-safety bug in createDataset(Seq)

2019-10-09 Thread GitBox
cloud-fan commented on issue #26076: [SPARK-29419][SQL] Fix Encoder thread-safety bug in createDataset(Seq) URL: https://github.com/apache/spark/pull/26076#issuecomment-540259061 > reducing the cost of .copy() by refactoring the ExpressionEncoder class That sounds like a good idea

[GitHub] [spark] wangyum commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-09 Thread GitBox
wangyum commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals URL: https://github.com/apache/spark/pull/25018#issuecomment-540369275 Thank you @HyukjinKwon I added another test case.

[GitHub] [spark] cloud-fan commented on issue #19424: [SPARK-22197][SQL] push down operators to data source before planning

2019-10-09 Thread GitBox
cloud-fan commented on issue #19424: [SPARK-22197][SQL] push down operators to data source before planning URL: https://github.com/apache/spark/pull/19424#issuecomment-540257605 @rafaelkyrdan limit pushdown has not been supported yet.

[GitHub] [spark] wangyum commented on a change in pull request #26014: [SPARK-29349][SQL] Support FETCH_PRIOR in Thriftserver fetch request

2019-10-09 Thread GitBox
wangyum commented on a change in pull request #26014: [SPARK-29349][SQL] Support FETCH_PRIOR in Thriftserver fetch request URL: https://github.com/apache/spark/pull/26014#discussion_r10328 ## File path:

[GitHub] [spark] JoshRosen edited a comment on issue #26076: [SPARK-29419][SQL] Fix Encoder thread-safety bug in createDataset(Seq)

2019-10-09 Thread GitBox
JoshRosen edited a comment on issue #26076: [SPARK-29419][SQL] Fix Encoder thread-safety bug in createDataset(Seq) URL: https://github.com/apache/spark/pull/26076#issuecomment-540211354 > But if we would like to fix all these problems, all public APIs accepting `Encoder` will need the

[GitHub] [spark] JoshRosen edited a comment on issue #26076: [SPARK-29419][SQL] Fix Encoder thread-safety bug in createDataset(Seq)

2019-10-09 Thread GitBox
JoshRosen edited a comment on issue #26076: [SPARK-29419][SQL] Fix Encoder thread-safety bug in createDataset(Seq) URL: https://github.com/apache/spark/pull/26076#issuecomment-540211354 > But if we would like to fix all these problems, all public APIs accepting `Encoder` will need the

[GitHub] [spark] zsxwing opened a new pull request #26077: [SPARK-29413][CORE] A better parmap method signature

2019-10-09 Thread GitBox
zsxwing opened a new pull request #26077: [SPARK-29413][CORE] A better parmap method signature URL: https://github.com/apache/spark/pull/26077 ### What changes were proposed in this pull request? This PR updates the `parmap` method signature to return the same type of `input` to

[GitHub] [spark] HyukjinKwon commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'

2019-10-09 Thread GitBox
HyukjinKwon commented on issue #26053: [SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case' URL: https://github.com/apache/spark/pull/26053#issuecomment-540272697 retest this please This is an automated

[GitHub] [spark] liucht-inspur commented on a change in pull request #25994: [SPARK-29323][WEBUI] Add tooltip for The Executors Tab's column names in the Spark history server Page

2019-10-09 Thread GitBox
liucht-inspur commented on a change in pull request #25994: [SPARK-29323][WEBUI] Add tooltip for The Executors Tab's column names in the Spark history server Page URL: https://github.com/apache/spark/pull/25994#discussion_r333292223 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
HyukjinKwon commented on issue #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#issuecomment-540272481 Seems fine. This is an automated message from the

[GitHub] [spark] cloud-fan commented on a change in pull request #26071: [SPARK-29412][SQL] refine the document of v2 session catalog config

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #26071: [SPARK-29412][SQL] refine the document of v2 session catalog config URL: https://github.com/apache/spark/pull/26071#discussion_r02564 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala

[GitHub] [spark] HyukjinKwon removed a comment on issue #25820: [SPARK-29101][SQL] Fix count API for csv file when DROPMALFORMED mode is selected

2019-10-09 Thread GitBox
HyukjinKwon removed a comment on issue #25820: [SPARK-29101][SQL] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25820#issuecomment-540358900 This issue exists in Spark 2.4 as well. Let me open a backporting PR.

[GitHub] [spark] HyukjinKwon commented on issue #25820: [SPARK-29101][SQL] Fix count API for csv file when DROPMALFORMED mode is selected

2019-10-09 Thread GitBox
HyukjinKwon commented on issue #25820: [SPARK-29101][SQL] Fix count API for csv file when DROPMALFORMED mode is selected URL: https://github.com/apache/spark/pull/25820#issuecomment-540358900 This issue exists in Spark 2.4 as well. Let me open a backporting PR.

[GitHub] [spark] dongjoon-hyun commented on issue #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
dongjoon-hyun commented on issue #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#issuecomment-540218055 Gentle ping, @gatorsmile , @srowen , @dbtsai , @viirya , @yuecong . **Brief Summary** 1. Apache Spark has

[GitHub] [spark] viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#discussion_r333281688 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala

[GitHub] [spark] dongjoon-hyun commented on issue #24851: [SPARK-27303][GRAPH] Add Spark Graph API

2019-10-09 Thread GitBox
dongjoon-hyun commented on issue #24851: [SPARK-27303][GRAPH] Add Spark Graph API URL: https://github.com/apache/spark/pull/24851#issuecomment-540247560 Thank you for updating, @s1ck . I'll take a look tonight~ This is an

[GitHub] [spark] dongjoon-hyun closed pull request #26075: [WIP][K8S] Spark operator

2019-10-09 Thread GitBox
dongjoon-hyun closed pull request #26075: [WIP][K8S] Spark operator URL: https://github.com/apache/spark/pull/26075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] dongjoon-hyun commented on issue #26075: [WIP][K8S] Spark operator

2019-10-09 Thread GitBox
dongjoon-hyun commented on issue #26075: [WIP][K8S] Spark operator URL: https://github.com/apache/spark/pull/26075#issuecomment-540297020 Thanks, @nrchakradhar . For me, this seems to dumped from that repo by the author. I took a look. The current status is difficult to be

[GitHub] [spark] viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#discussion_r333259908 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala

[GitHub] [spark] viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#discussion_r333261862 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala

[GitHub] [spark] viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#discussion_r333261862 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-09 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r333262295 ## File path:

[GitHub] [spark] zsxwing closed pull request #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature

2019-10-09 Thread GitBox
zsxwing closed pull request #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature URL: https://github.com/apache/spark/pull/26077 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] zsxwing commented on issue #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature

2019-10-09 Thread GitBox
zsxwing commented on issue #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature URL: https://github.com/apache/spark/pull/26077#issuecomment-540236633 Closing my PR. This is an automated message from the

[GitHub] [spark] zsxwing commented on a change in pull request #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature

2019-10-09 Thread GitBox
zsxwing commented on a change in pull request #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature URL: https://github.com/apache/spark/pull/26077#discussion_r333264618 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@

[GitHub] [spark] dongjoon-hyun commented on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-09 Thread GitBox
dongjoon-hyun commented on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-540251763 Unfortunately, Jenkins is down. Let's wait until Jenkins is back.

[GitHub] [spark] HyukjinKwon commented on issue #26041: [SPARK-29403][INFRA][R] Uses Arrow R 0.14.1 in AppVeyor for now

2019-10-09 Thread GitBox
HyukjinKwon commented on issue #26041: [SPARK-29403][INFRA][R] Uses Arrow R 0.14.1 in AppVeyor for now URL: https://github.com/apache/spark/pull/26041#issuecomment-540256081 I am merging this to keep our AppVeyor build alive for now ..

[GitHub] [spark] dongjoon-hyun closed pull request #26073: [SPARK-29416][CORE][ML][SQL][MESOS][TESTS] Use .sameElements to compare arrays, instead of .deep (gone in 2.13)

2019-10-09 Thread GitBox
dongjoon-hyun closed pull request #26073: [SPARK-29416][CORE][ML][SQL][MESOS][TESTS] Use .sameElements to compare arrays, instead of .deep (gone in 2.13) URL: https://github.com/apache/spark/pull/26073 This is an automated

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26041: [SPARK-29403][INFRA][R] Uses Arrow R 0.14.1 in AppVeyor for now

2019-10-09 Thread GitBox
HyukjinKwon commented on a change in pull request #26041: [SPARK-29403][INFRA][R] Uses Arrow R 0.14.1 in AppVeyor for now URL: https://github.com/apache/spark/pull/26041#discussion_r333282310 ## File path: appveyor.yml ## @@ -57,6 +57,8 @@ build_script: environment:

[GitHub] [spark] HyukjinKwon closed pull request #26041: [SPARK-29403][INFRA][R] Uses Arrow R 0.14.1 in AppVeyor for now

2019-10-09 Thread GitBox
HyukjinKwon closed pull request #26041: [SPARK-29403][INFRA][R] Uses Arrow R 0.14.1 in AppVeyor for now URL: https://github.com/apache/spark/pull/26041 This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] nrchakradhar commented on issue #26075: [WIP][K8S] Spark operator

2019-10-09 Thread GitBox
nrchakradhar commented on issue #26075: [WIP][K8S] Spark operator URL: https://github.com/apache/spark/pull/26075#issuecomment-540270821 This is same as https://github.com/radanalyticsio/spark-operator. This is an automated

[GitHub] [spark] liucht-inspur commented on issue #25994: [SPARK-29323][WEBUI] Add tooltip for The Executors Tab's column names in the Spark history server Page

2019-10-09 Thread GitBox
liucht-inspur commented on issue #25994: [SPARK-29323][WEBUI] Add tooltip for The Executors Tab's column names in the Spark history server Page URL: https://github.com/apache/spark/pull/25994#issuecomment-540284189 @srowen Thanks again, I have finished the change.

[GitHub] [spark] dongjoon-hyun commented on issue #26075: [WIP][K8S] Spark operator

2019-10-09 Thread GitBox
dongjoon-hyun commented on issue #26075: [WIP][K8S] Spark operator URL: https://github.com/apache/spark/pull/26075#issuecomment-540300821 Definitely, +1 for @holdenk 's comment. This is an automated message from the Apache

[GitHub] [spark] dongjoon-hyun edited a comment on issue #26075: [WIP][K8S] Spark operator

2019-10-09 Thread GitBox
dongjoon-hyun edited a comment on issue #26075: [WIP][K8S] Spark operator URL: https://github.com/apache/spark/pull/26075#issuecomment-540297020 Thanks, @nrchakradhar . For me, this seems to be dumped from that repo by the author. I took a look. The current status is difficult to be

[GitHub] [spark] holdenk commented on issue #26075: [WIP][K8S] Spark operator

2019-10-09 Thread GitBox
holdenk commented on issue #26075: [WIP][K8S] Spark operator URL: https://github.com/apache/spark/pull/26075#issuecomment-540299867 I think before putting in work on this PR getting buy-in from the `dev@` list might be a good next first step.

[GitHub] [spark] yaooqinn commented on issue #25648: [SPARK-28947][K8S] Status logging not happens at an interval for liveness

2019-10-09 Thread GitBox
yaooqinn commented on issue #25648: [SPARK-28947][K8S] Status logging not happens at an interval for liveness URL: https://github.com/apache/spark/pull/25648#issuecomment-540321431 retest this please This is an automated

[GitHub] [spark] abellina opened a new pull request #26078: SPARK-29151: Support fractional resources for task resource scheduling

2019-10-09 Thread GitBox
abellina opened a new pull request #26078: SPARK-29151: Support fractional resources for task resource scheduling URL: https://github.com/apache/spark/pull/26078 ### What changes were proposed in this pull request? This PR adds the ability for tasks to request fractional

[GitHub] [spark] PingHao commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-10-09 Thread GitBox
PingHao commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#issuecomment-540235341 > > > @PingHao - Both the issue- stuck executor, core dump - might be due to the same reasons. Will debug and fix it.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
dongjoon-hyun commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#discussion_r333270410 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL] Add JSON serialization for external Rows

2019-10-09 Thread GitBox
HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL] Add JSON serialization for external Rows URL: https://github.com/apache/spark/pull/26013#discussion_r333285090 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ## @@

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL] Add JSON serialization for external Rows

2019-10-09 Thread GitBox
HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL] Add JSON serialization for external Rows URL: https://github.com/apache/spark/pull/26013#discussion_r333285090 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ## @@

[GitHub] [spark] yaooqinn commented on issue #26068: [SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership

2019-10-09 Thread GitBox
yaooqinn commented on issue #26068: [SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership URL: https://github.com/apache/spark/pull/26068#issuecomment-540330063 test this please This is an

[GitHub] [spark] shivusondur commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-09 Thread GitBox
shivusondur commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#discussion_r22463 ## File path: docs/sql-ref-syntax-aux-show-tables.md ## @@ -38,10 +38,13 @@ SHOW

[GitHub] [spark] zsxwing commented on a change in pull request #26072: [SPARK-29413][CORE] Rewrite ThreadUtils.parmap to avoid TraversableLike, gone in 2.13

2019-10-09 Thread GitBox
zsxwing commented on a change in pull request #26072: [SPARK-29413][CORE] Rewrite ThreadUtils.parmap to avoid TraversableLike, gone in 2.13 URL: https://github.com/apache/spark/pull/26072#discussion_r333249219 ## File path:

[GitHub] [spark] zsxwing commented on issue #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature

2019-10-09 Thread GitBox
zsxwing commented on issue #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature URL: https://github.com/apache/spark/pull/26077#issuecomment-540216275 @srowen could you help test whether this compiles with Scala 2.13?

[GitHub] [spark] srowen commented on a change in pull request #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature

2019-10-09 Thread GitBox
srowen commented on a change in pull request #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature URL: https://github.com/apache/spark/pull/26077#discussion_r333254145 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@

[GitHub] [spark] srowen commented on issue #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
srowen commented on issue #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#issuecomment-540222491 (I don't have any opinion on this - don't know Prometheus)

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-09 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r333262518 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-09 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r333262965 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature

2019-10-09 Thread GitBox
dongjoon-hyun commented on a change in pull request #26077: [SPARK-29413][CORE][FOLLOWUP] A better parmap method signature URL: https://github.com/apache/spark/pull/26077#discussion_r333274284 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@

[GitHub] [spark] viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
viirya commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#discussion_r333281562 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL] Add JSON serialization for external Rows

2019-10-09 Thread GitBox
HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL] Add JSON serialization for external Rows URL: https://github.com/apache/spark/pull/26013#discussion_r333285090 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ## @@

[GitHub] [spark] dongjoon-hyun edited a comment on issue #26075: [WIP][K8S] Spark operator

2019-10-09 Thread GitBox
dongjoon-hyun edited a comment on issue #26075: [WIP][K8S] Spark operator URL: https://github.com/apache/spark/pull/26075#issuecomment-540297020 Thanks, @nrchakradhar . For me, this seems to dumped from that repo by the author. I took a look. The current status is difficult to be

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels

2019-10-09 Thread GitBox
dongjoon-hyun commented on a change in pull request #26060: [SPARK-29400][CORE] Improve PrometheusResource to use labels URL: https://github.com/apache/spark/pull/26060#discussion_r333270955 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL] Add JSON serialization for external Rows

2019-10-09 Thread GitBox
HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL] Add JSON serialization for external Rows URL: https://github.com/apache/spark/pull/26013#discussion_r333285090 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ## @@

[GitHub] [spark] HyukjinKwon commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-09 Thread GitBox
HyukjinKwon commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals URL: https://github.com/apache/spark/pull/25018#issuecomment-540277064 retest this please

[GitHub] [spark] dongjoon-hyun closed pull request #26067: [SPARK-28989][SQL][FollowUp] Update ANSI mode related config names in comments

2019-10-09 Thread GitBox
dongjoon-hyun closed pull request #26067: [SPARK-28989][SQL][FollowUp] Update ANSI mode related config names in comments URL: https://github.com/apache/spark/pull/26067 This is an automated message from the Apache Git

[GitHub] [spark] beliefer commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
beliefer commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#discussion_r332897164 ## File path:

[GitHub] [spark] shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-09 Thread GitBox
shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-539857077 Thanks @zhengruifeng I will add metrics for `TrainValidationSplitModel` too.

[GitHub] [spark] cloud-fan commented on issue #26006: [SPARK-29279][SQL] Merge SHOW NAMESPACES and SHOW DATABASES code path

2019-10-09 Thread GitBox
cloud-fan commented on issue #26006: [SPARK-29279][SQL] Merge SHOW NAMESPACES and SHOW DATABASES code path URL: https://github.com/apache/spark/pull/26006#issuecomment-539853093 LGTM except one code style nit. We may need to wait for a few days until Jenkins is back online.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide

2019-10-09 Thread GitBox
HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide URL: https://github.com/apache/spark/pull/26045#discussion_r332858140 ## File path: docs/sql-pyspark-pandas-with-arrow.md ## @@ -219,3 +219,14

[GitHub] [spark] xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332858356 ## File path:

[GitHub] [spark] LantaoJin commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-09 Thread GitBox
LantaoJin commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution URL: https://github.com/apache/spark/pull/25960#issuecomment-539848420 Retest this please.

[GitHub] [spark] xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332858483 ## File path:

[GitHub] [spark] xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332858591 ## File path:

[GitHub] [spark] xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
xuanyuanking commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332858396 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala

[GitHub] [spark] TomokoKomiyama opened a new pull request #26065: [SPARK-29404][DOCS] Add an explanation about the executor color changed in sql documentation

2019-10-09 Thread GitBox
TomokoKomiyama opened a new pull request #26065: [SPARK-29404][DOCS] Add an explanation about the executor color changed in sql documentation URL: https://github.com/apache/spark/pull/26065 ### What changes were proposed in this pull request? Add an explanation about changing

[GitHub] [spark] cloud-fan commented on a change in pull request #26006: [SPARK-29279][SQL] Merge SHOW NAMESPACES and SHOW DATABASES code path

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #26006: [SPARK-29279][SQL] Merge SHOW NAMESPACES and SHOW DATABASES code path URL: https://github.com/apache/spark/pull/26006#discussion_r332842678 ## File path:

[GitHub] [spark] gatorsmile commented on issue #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
gatorsmile commented on issue #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#issuecomment-539861146 cc @cloud-fan This is an automated

[GitHub] [spark] gengliangwang opened a new pull request #26067: [SPARK-28989][SQL][FollowUp]

2019-10-09 Thread GitBox
gengliangwang opened a new pull request #26067: [SPARK-28989][SQL][FollowUp] URL: https://github.com/apache/spark/pull/26067 ### What changes were proposed in this pull request? Update ANSI mode related config names in comments as "spark.sql.ansi.enabled" ### Why are

[GitHub] [spark] MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql

2019-10-09 Thread GitBox
MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql URL: https://github.com/apache/spark/pull/26055#discussion_r332894006 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/interval.sql ## @@ -0,0 +1,330 @@

[GitHub] [spark] MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql

2019-10-09 Thread GitBox
MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql URL: https://github.com/apache/spark/pull/26055#discussion_r332893419 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/interval.sql ## @@ -0,0 +1,330 @@

[GitHub] [spark] LantaoJin commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-09 Thread GitBox
LantaoJin commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution URL: https://github.com/apache/spark/pull/25960#issuecomment-539874433 Retest this please.

[GitHub] [spark] cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332873523 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#discussion_r332884196 ## File path:

[GitHub] [spark] MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql

2019-10-09 Thread GitBox
MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql URL: https://github.com/apache/spark/pull/26055#discussion_r332887389 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/interval.sql ## @@ -0,0 +1,330 @@

[GitHub] [spark] MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql

2019-10-09 Thread GitBox
MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql URL: https://github.com/apache/spark/pull/26055#discussion_r332896030 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/interval.sql ## @@ -0,0 +1,330 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#discussion_r332920772 ## File path:

[GitHub] [spark] MaxGekk opened a new pull request #26066: [SPARK-24640][SQL][FOLLOWUP] Update the SQL migration guide about `size(NULL)`

2019-10-09 Thread GitBox
MaxGekk opened a new pull request #26066: [SPARK-24640][SQL][FOLLOWUP] Update the SQL migration guide about `size(NULL)` URL: https://github.com/apache/spark/pull/26066 ### What changes were proposed in this pull request? The commit

[GitHub] [spark] cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332879712 ## File path:

[GitHub] [spark] MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql

2019-10-09 Thread GitBox
MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql URL: https://github.com/apache/spark/pull/26055#discussion_r332882613 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/interval.sql ## @@ -0,0 +1,330 @@

[GitHub] [spark] TomokoKomiyama edited a comment on issue #26065: [SPARK-29404][DOCS] Add an explanation about the executor color changed in WebUI documentation

2019-10-09 Thread GitBox
TomokoKomiyama edited a comment on issue #26065: [SPARK-29404][DOCS] Add an explanation about the executor color changed in WebUI documentation URL: https://github.com/apache/spark/pull/26065#issuecomment-539897581 I trimmed `docs/img/AllJobsPageDetail2.png` to narrow the margin(space).

[GitHub] [spark] beliefer commented on issue #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
beliefer commented on issue #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#issuecomment-539912303 Impala and BigQuery support `OFFSET`.

[GitHub] [spark] liucht-inspur commented on issue #25994: [SPARK-29323][WEBUI] Add tooltip for The Executors Tab's column names in the Spark history server Page

2019-10-09 Thread GitBox
liucht-inspur commented on issue #25994: [SPARK-29323][WEBUI] Add tooltip for The Executors Tab's column names in the Spark history server Page URL: https://github.com/apache/spark/pull/25994#issuecomment-539879996 @srowen ok,thank you ! I have finished this change, two changes:

[GitHub] [spark] cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332874883 ## File path:

[GitHub] [spark] MaxGekk commented on issue #26051: [SPARK-24640][SQL] Return `NULL` from `size(NULL)` by default

2019-10-09 Thread GitBox
MaxGekk commented on issue #26051: [SPARK-24640][SQL] Return `NULL` from `size(NULL)` by default URL: https://github.com/apache/spark/pull/26051#issuecomment-539886252 Here is the PR https://github.com/apache/spark/pull/26066 which updates the SQL migration guide.

[GitHub] [spark] cloud-fan closed pull request #26066: [SPARK-24640][SQL][FOLLOWUP] Update the SQL migration guide about `size(NULL)`

2019-10-09 Thread GitBox
cloud-fan closed pull request #26066: [SPARK-24640][SQL][FOLLOWUP] Update the SQL migration guide about `size(NULL)` URL: https://github.com/apache/spark/pull/26066 This is an automated message from the Apache Git Service.

[GitHub] [spark] cloud-fan commented on issue #26066: [SPARK-24640][SQL][FOLLOWUP] Update the SQL migration guide about `size(NULL)`

2019-10-09 Thread GitBox
cloud-fan commented on issue #26066: [SPARK-24640][SQL][FOLLOWUP] Update the SQL migration guide about `size(NULL)` URL: https://github.com/apache/spark/pull/26066#issuecomment-539899944 thanks, merging to master! This is an

[GitHub] [spark] MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql

2019-10-09 Thread GitBox
MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql URL: https://github.com/apache/spark/pull/26055#discussion_r332901122 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/interval.sql ## @@ -0,0 +1,330 @@

[GitHub] [spark] beliefer commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
beliefer commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#discussion_r332930317 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332872887 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332876461 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#discussion_r332877019 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#discussion_r332883042 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
cloud-fan commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#discussion_r332886173 ## File path:

[GitHub] [spark] TomokoKomiyama commented on issue #26065: [SPARK-29404][DOCS] Add an explanation about the executor color changed in WebUI documentation

2019-10-09 Thread GitBox
TomokoKomiyama commented on issue #26065: [SPARK-29404][DOCS] Add an explanation about the executor color changed in WebUI documentation URL: https://github.com/apache/spark/pull/26065#issuecomment-539897581 I trimmed `docs/img/AllJobsPageDetail2.png` to remove the space. [ Before ]

[GitHub] [spark] MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql

2019-10-09 Thread GitBox
MaxGekk commented on a change in pull request #26055: [SPARK-29368][SQL][TEST] Port interval.sql URL: https://github.com/apache/spark/pull/26055#discussion_r332888975 ## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/interval.sql ## @@ -0,0 +1,330 @@

[GitHub] [spark] beliefer commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression

2019-10-09 Thread GitBox
beliefer commented on a change in pull request #25416: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression URL: https://github.com/apache/spark/pull/25416#discussion_r332897164 ## File path:

[GitHub] [spark] yaooqinn opened a new pull request #26068: [SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership

2019-10-09 Thread GitBox
yaooqinn opened a new pull request #26068: [SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership URL: https://github.com/apache/spark/pull/26068 ### What changes were proposed in this pull request? In this change, we give

  1   2   3   >