[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
sarutak commented on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633417531 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633429823 **[Test build #123077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123077/testReport)** for PR 28633 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28634: [SPARK-31810][TEST] Fix test where spark conf was modified using incorrect api

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28634: URL: https://github.com/apache/spark/pull/28634#issuecomment-633430139 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28634: [SPARK-31810][TEST] Fix test where spark conf was modified using incorrect api

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28634: URL: https://github.com/apache/spark/pull/28634#issuecomment-633429669 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429756482 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -320,12 +324,23 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28634: [SPARK-31810][TEST] Fix test where spark conf was modified using incorrect api

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28634: URL: https://github.com/apache/spark/pull/28634#issuecomment-633429669 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633430366 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633430366 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633414076 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] keypointt commented on pull request #28629: [SPARK-31769] Add MDC support for driver threads

2020-05-25 Thread GitBox
keypointt commented on pull request #28629: URL: https://github.com/apache/spark/pull/28629#issuecomment-633392395 Add a test case? This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] HyukjinKwon opened a new pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon opened a new pull request #28633: URL: https://github.com/apache/spark/pull/28633 ### What changes were proposed in this pull request? This PR proposes to set the alias, and class name in its `ExpressionInfo` for `struct`. - Class name in `ExpressionInfo` - from:

[GitHub] [spark] AmplabJenkins commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633404768 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk commented on pull request #28630: [WIP][SPARK-31806][SQL][TESTS] Check reading date/timestamp from legacy parquet: dictionary encoding, w/o Spark version

2020-05-25 Thread GitBox
MaxGekk commented on pull request #28630: URL: https://github.com/apache/spark/pull/28630#issuecomment-633405668 @cloud-fan @mswit-databricks @HyukjinKwon Please, review this PR. This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #28553: [SPARK-31734][ML][PySpark] Add weight support in ClusteringEvaluator

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28553: URL: https://github.com/apache/spark/pull/28553#issuecomment-633414094 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633414667 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633414667 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
SparkQA removed a comment on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633357514 **[Test build #123071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123071/testReport)** for PR 28627 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633414674 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28630: [SPARK-31806][SQL][TESTS] Check reading date/timestamp from legacy parquet: dictionary encoding, w/o Spark version

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28630: URL: https://github.com/apache/spark/pull/28630#issuecomment-633414056 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633414084 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633414764 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633414636 **[Test build #123072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123072/testReport)** for PR 28633 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633414764 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
SparkQA commented on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633414635 **[Test build #123071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123071/testReport)** for PR 28627 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28553: [SPARK-31734][ML][PySpark] Add weight support in ClusteringEvaluator

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28553: URL: https://github.com/apache/spark/pull/28553#issuecomment-633414094 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28630: [SPARK-31806][SQL][TESTS] Check reading date/timestamp from legacy parquet: dictionary encoding, w/o Spark version

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28630: URL: https://github.com/apache/spark/pull/28630#issuecomment-633414056 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633407168 **[Test build #123072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123072/testReport)** for PR 28633 at commit

[GitHub] [spark] viirya commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
viirya commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429758596 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -312,6 +312,10 @@ case object

[GitHub] [spark] SparkQA commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633413383 **[Test build #123074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123074/testReport)** for PR 28633 at commit

[GitHub] [spark] SparkQA commented on pull request #28553: [SPARK-31734][ML][PySpark] Add weight support in ClusteringEvaluator

2020-05-25 Thread GitBox
SparkQA commented on pull request #28553: URL: https://github.com/apache/spark/pull/28553#issuecomment-633413387 **[Test build #123073 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123073/testReport)** for PR 28553 at commit

[GitHub] [spark] SparkQA commented on pull request #28630: [SPARK-31806][SQL][TESTS] Check reading date/timestamp from legacy parquet: dictionary encoding, w/o Spark version

2020-05-25 Thread GitBox
SparkQA commented on pull request #28630: URL: https://github.com/apache/spark/pull/28630#issuecomment-633413390 **[Test build #123075 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123075/testReport)** for PR 28630 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633414769 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] huaxingao commented on a change in pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-25 Thread GitBox
huaxingao commented on a change in pull request #28595: URL: https://github.com/apache/spark/pull/28595#discussion_r429765422 ## File path: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ## @@ -562,4 +562,20 @@ trait HasBlockSize extends Params {

[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
SparkQA commented on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633419679 **[Test build #123076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123076/testReport)** for PR 28627 at commit

[GitHub] [spark] wangyum commented on a change in pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

2020-05-25 Thread GitBox
wangyum commented on a change in pull request #28626: URL: https://github.com/apache/spark/pull/28626#discussion_r429753348 ## File path: sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala ## @@ -156,4 +158,74 @@ class ExpressionInfoSuite

[GitHub] [spark] SparkQA commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633407168 **[Test build #123072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123072/testReport)** for PR 28633 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633404768 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429760455 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -312,6 +312,10 @@ case object

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429756482 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -320,12 +324,23 @@ object

[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633420266 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-633420266 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
maropu commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633426646 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] prakharjain09 opened a new pull request #28634: [SPARK-31810][TEST] Fix test where spark conf was modified using incorrect api

2020-05-25 Thread GitBox
prakharjain09 opened a new pull request #28634: URL: https://github.com/apache/spark/pull/28634 ### What changes were proposed in this pull request? Use the correct API in AlterTableRecoverPartition tests to modify the `RDD_PARALLEL_LISTING_THRESHOLD` conf. ### Why are the

[GitHub] [spark] hvanhovell commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
hvanhovell commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429802509 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -312,6 +312,10 @@ case object

[GitHub] [spark] SparkQA removed a comment on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-25 Thread GitBox
SparkQA removed a comment on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-633437134 **[Test build #123078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123078/testReport)** for PR 28621 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-633454093 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-633454093 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-25 Thread GitBox
SparkQA commented on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-633453976 **[Test build #123078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123078/testReport)** for PR 28621 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429808596 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -312,6 +312,10 @@ case object

[GitHub] [spark] prakharjain09 edited a comment on pull request #28634: [SPARK-31810][TEST] Fix AlterTableRecoverPartitions test using incorrect api to modify RDD_PARALLEL_LISTING_THRESHOLD

2020-05-25 Thread GitBox
prakharjain09 edited a comment on pull request #28634: URL: https://github.com/apache/spark/pull/28634#issuecomment-633481802 cc - @srowen @cloud-fan @Dooyoung-Hwang This is an automated message from the Apache Git Service.

[GitHub] [spark] prakharjain09 commented on pull request #28634: [SPARK-31810][TEST] Fix AlterTableRecoverPartitions test using incorrect api to modify RDD_PARALLEL_LISTING_THRESHOLD

2020-05-25 Thread GitBox
prakharjain09 commented on pull request #28634: URL: https://github.com/apache/spark/pull/28634#issuecomment-633481802 cc - @srowen @cloud-fan This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] beliefer commented on pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-25 Thread GitBox
beliefer commented on pull request #28551: URL: https://github.com/apache/spark/pull/28551#issuecomment-633493077 cc @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] gaborgsomogyi opened a new pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
gaborgsomogyi opened a new pull request #28635: URL: https://github.com/apache/spark/pull/28635 ### What changes were proposed in this pull request? When loading DataFrames from JDBC datasource with Kerberos authentication, remote executors (yarn-client/cluster etc. modes) fail to

[GitHub] [spark] SparkQA commented on pull request #28630: [SPARK-31806][SQL][TESTS] Check reading date/timestamp from legacy parquet: dictionary encoding, w/o Spark version

2020-05-25 Thread GitBox
SparkQA commented on pull request #28630: URL: https://github.com/apache/spark/pull/28630#issuecomment-633529870 **[Test build #123075 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123075/testReport)** for PR 28630 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28551: URL: https://github.com/apache/spark/pull/28551#issuecomment-633543877 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429800396 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -320,12 +324,23 @@ object

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429805322 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -434,6 +449,11 @@ case class

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429805059 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -312,6 +312,10 @@ case object

[GitHub] [spark] AmplabJenkins commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633536412 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633413383 **[Test build #123074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123074/testReport)** for PR 28633 at commit

[GitHub] [spark] SparkQA commented on pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-25 Thread GitBox
SparkQA commented on pull request #28551: URL: https://github.com/apache/spark/pull/28551#issuecomment-633543378 **[Test build #123083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123083/testReport)** for PR 28551 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28551: URL: https://github.com/apache/spark/pull/28551#issuecomment-633543877 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
maropu commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429787806 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -320,12 +324,23 @@ object CreateStruct

[GitHub] [spark] SparkQA commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633461749 **[Test build #123080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123080/testReport)** for PR 28633 at commit

[GitHub] [spark] gaborgsomogyi commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
gaborgsomogyi commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633511928 Apart from manual testing I've tried to add docker integration test (failed) and tried out the following: * Set up an active directory docker => not yet supported,

[GitHub] [spark] SparkQA removed a comment on pull request #28630: [SPARK-31806][SQL][TESTS] Check reading date/timestamp from legacy parquet: dictionary encoding, w/o Spark version

2020-05-25 Thread GitBox
SparkQA removed a comment on pull request #28630: URL: https://github.com/apache/spark/pull/28630#issuecomment-633413390 **[Test build #123075 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123075/testReport)** for PR 28630 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633455287 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633455287 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633511059 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
SparkQA removed a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633510744 **[Test build #123081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123081/testReport)** for PR 28635 at commit

[GitHub] [spark] SparkQA commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
SparkQA commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633512184 **[Test build #123081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123081/testReport)** for PR 28635 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633512192 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633512198 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
gaborgsomogyi commented on a change in pull request #28635: URL: https://github.com/apache/spark/pull/28635#discussion_r429886742 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/MSSQLConnectionProvider.scala ## @@ -0,0 +1,94 @@

[GitHub] [spark] SparkQA commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633535658 **[Test build #123074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123074/testReport)** for PR 28633 at commit

[GitHub] [spark] gaborgsomogyi commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
gaborgsomogyi commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633543073 cc @HeartSaVioR This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] gaborgsomogyi edited a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
gaborgsomogyi edited a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633511928 Apart from manual testing I've tried to add docker integration test (failed) and tried out the following: * Set up an active directory docker => not yet

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-633437651 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
HyukjinKwon commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429796543 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -312,6 +312,10 @@ case object

[GitHub] [spark] SparkQA commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
SparkQA commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633454615 **[Test build #123079 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123079/testReport)** for PR 28633 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-633454104 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-25 Thread GitBox
HyukjinKwon commented on pull request #28551: URL: https://github.com/apache/spark/pull/28551#issuecomment-633541832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] AmplabJenkins commented on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-633437651 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-25 Thread GitBox
SparkQA commented on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-633437134 **[Test build #123078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123078/testReport)** for PR 28621 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633462469 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633462469 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
SparkQA commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633510744 **[Test build #123081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123081/testReport)** for PR 28635 at commit

[GitHub] [spark] SparkQA commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
SparkQA commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633525575 **[Test build #123082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123082/testReport)** for PR 28635 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28633: URL: https://github.com/apache/spark/pull/28633#issuecomment-633536412 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #28626: [SPARK-28481][SQL] More expressions should extend NullIntolerant

2020-05-25 Thread GitBox
maropu commented on a change in pull request #28626: URL: https://github.com/apache/spark/pull/28626#discussion_r429811184 ## File path: sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala ## @@ -156,4 +158,74 @@ class ExpressionInfoSuite

[GitHub] [spark] AmplabJenkins commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-633511059 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28630: [SPARK-31806][SQL][TESTS] Check reading date/timestamp from legacy parquet: dictionary encoding, w/o Spark version

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28630: URL: https://github.com/apache/spark/pull/28630#issuecomment-633530671 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] hvanhovell commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
hvanhovell commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429792739 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -312,6 +312,10 @@ case object

[GitHub] [spark] SparkQA commented on pull request #28553: [SPARK-31734][ML][PySpark] Add weight support in ClusteringEvaluator

2020-05-25 Thread GitBox
SparkQA commented on pull request #28553: URL: https://github.com/apache/spark/pull/28553#issuecomment-633442641 **[Test build #123073 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123073/testReport)** for PR 28553 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28553: [SPARK-31734][ML][PySpark] Add weight support in ClusteringEvaluator

2020-05-25 Thread GitBox
SparkQA removed a comment on pull request #28553: URL: https://github.com/apache/spark/pull/28553#issuecomment-633413387 **[Test build #123073 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123073/testReport)** for PR 28553 at commit

[GitHub] [spark] attilapiros commented on a change in pull request #28606: [MINOR][YARN]False report isAllNodeBlacklisted when RM is having issue

2020-05-25 Thread GitBox
attilapiros commented on a change in pull request #28606: URL: https://github.com/apache/spark/pull/28606#discussion_r429795946 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala ## @@ -103,7 +103,14 @@

[GitHub] [spark] AmplabJenkins commented on pull request #28553: [SPARK-31734][ML][PySpark] Add weight support in ClusteringEvaluator

2020-05-25 Thread GitBox
AmplabJenkins commented on pull request #28553: URL: https://github.com/apache/spark/pull/28553#issuecomment-633443120 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28553: [SPARK-31734][ML][PySpark] Add weight support in ClusteringEvaluator

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28553: URL: https://github.com/apache/spark/pull/28553#issuecomment-633443120 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] hvanhovell commented on a change in pull request #28633: [SPARK-31808][SQL] Makes struct function's output name and class name pretty

2020-05-25 Thread GitBox
hvanhovell commented on a change in pull request #28633: URL: https://github.com/apache/spark/pull/28633#discussion_r429802771 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -434,6 +449,11 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28630: [SPARK-31806][SQL][TESTS] Check reading date/timestamp from legacy parquet: dictionary encoding, w/o Spark version

2020-05-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28630: URL: https://github.com/apache/spark/pull/28630#issuecomment-633530671 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   >