LuciferYang commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967243275
##
pom.xml:
##
@@ -1139,37 +1139,38 @@
org.scalatest
scalatest_${scala.binary.version}
-3.3.0-SNAP3
+3.2.13
Review
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967333759
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##
@@ -923,7 +966,11 @@ trait CheckAnalysis extends PredicateHelper with
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967333176
##
sql/core/src/test/resources/sql-tests/results/join-lateral.sql.out:
##
@@ -323,14 +322,10 @@ SELECT * FROM t1, LATERAL (SELECT rand(0) FROM t2)
struct<>
-- !query
gengliangwang commented on PR #37847:
URL: https://github.com/apache/spark/pull/37847#issuecomment-1242311085
@huaxingao Thanks for the ping. I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun commented on code in PR #37733:
URL: https://github.com/apache/spark/pull/37733#discussion_r967366412
##
docs/monitoring.md:
##
@@ -1207,12 +1207,12 @@ This is the component with the largest amount of
instrumented metrics
- namespace=ExecutorAllocationManager
dongjoon-hyun commented on PR #37848:
URL: https://github.com/apache/spark/pull/37848#issuecomment-1242347363
cc @huaxingao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
roczei commented on code in PR #37679:
URL: https://github.com/apache/spark/pull/37679#discussion_r967420952
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##
@@ -286,7 +284,7 @@ class SessionCatalog(
def dropDatabase(db: String,
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967336318
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##
@@ -923,7 +966,11 @@ trait CheckAnalysis extends PredicateHelper with
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967333176
##
sql/core/src/test/resources/sql-tests/results/join-lateral.sql.out:
##
@@ -323,14 +322,10 @@ SELECT * FROM t1, LATERAL (SELECT rand(0) FROM t2)
struct<>
-- !query
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967340825
##
core/src/main/resources/error/error-classes.json:
##
@@ -327,6 +327,83 @@
],
"sqlState" : "42000"
},
+ "INVALID_SUBQUERY_EXPRESSION" : {
+
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967340575
##
core/src/main/resources/error/error-classes.json:
##
@@ -327,6 +327,83 @@
],
"sqlState" : "42000"
},
+ "INVALID_SUBQUERY_EXPRESSION" : {
+
huaxingao commented on PR #37846:
URL: https://github.com/apache/spark/pull/37846#issuecomment-1242313810
The test failure doesn't seem to be related to this PR. I will merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
LuciferYang commented on code in PR #37843:
URL: https://github.com/apache/spark/pull/37843#discussion_r967265692
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##
@@ -393,4 +384,20 @@ private String joinListToString(
}
Bahigac commented on PR #35220:
URL: https://github.com/apache/spark/pull/35220#issuecomment-1242201044
> ### What changes were proposed in this pull request?
>
>
>
> This PR improves `SimplifyCasts` to combine into one cast if they are both
`NumericType` and can safely
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967338829
##
core/src/main/resources/error/error-classes.json:
##
@@ -327,6 +327,83 @@
],
"sqlState" : "42000"
},
+ "INVALID_SUBQUERY_EXPRESSION" : {
+
huaxingao commented on PR #37846:
URL: https://github.com/apache/spark/pull/37846#issuecomment-1242324401
@zzcclp Could you please update the PR description to fill all the required
information?
--
This is an automated message from the Apache Git Service.
To respond to the message,
huaxingao commented on PR #37847:
URL: https://github.com/apache/spark/pull/37847#issuecomment-1242325279
@zzcclp Could you please update the PR description to fill all the required
information? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on PR #37468:
URL: https://github.com/apache/spark/pull/37468#issuecomment-1242332651
Thank you, @steveloughran and @attilapiros .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
huaxingao commented on PR #37847:
URL: https://github.com/apache/spark/pull/37847#issuecomment-1242332923
Merged to 3.3. Thanks @zzcclp for fixing this! Please remember to update the
PR description.
Thanks @revans2 @tgravescs for reviewing!
--
This is an automated message from the
roczei commented on PR #37679:
URL: https://github.com/apache/spark/pull/37679#issuecomment-1242406713
> we should also update `V2SessionCatalog.defaultNamespace`
@cloud-fan, for example this change will be good?
```
diff --git
LuciferYang commented on code in PR #37826:
URL: https://github.com/apache/spark/pull/37826#discussion_r967405666
##
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile,
LuciferYang commented on code in PR #37826:
URL: https://github.com/apache/spark/pull/37826#discussion_r967405666
##
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile,
srowen commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967248466
##
pom.xml:
##
@@ -1139,37 +1139,38 @@
org.scalatest
scalatest_${scala.binary.version}
-3.3.0-SNAP3
+3.2.13
Review Comment:
dongjoon-hyun closed pull request #37848: [SPARK-40389][SQL][FollowUp][3.3] Fix
a test failure in SQLQuerySuite
URL: https://github.com/apache/spark/pull/37848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tgravescs commented on code in PR #37826:
URL: https://github.com/apache/spark/pull/37826#discussion_r967392150
##
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile,
LuciferYang commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967250684
##
pom.xml:
##
@@ -1109,7 +1109,7 @@
org.scala-lang.modules
scala-xml_${scala.binary.version}
-1.2.0
+2.1.0
Review
LuciferYang commented on code in PR #37843:
URL: https://github.com/apache/spark/pull/37843#discussion_r967260907
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##
@@ -393,4 +384,20 @@ private String joinListToString(
}
gengliangwang commented on code in PR #37841:
URL: https://github.com/apache/spark/pull/37841#discussion_r967326002
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala:
##
@@ -77,12 +77,6 @@ class ExpressionTypeCheckingSuite
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967332227
##
core/src/main/resources/error/error-classes.json:
##
@@ -327,6 +327,83 @@
],
"sqlState" : "42000"
},
+ "INVALID_SUBQUERY_EXPRESSION" : {
+
LuciferYang commented on PR #37843:
URL: https://github.com/apache/spark/pull/37843#issuecomment-1242204716
Yes, there are other cases. I am sorting out the test data and hope to fix
them all in this one
--
This is an automated message from the Apache Git Service.
To respond to
ahshahid commented on PR #37824:
URL: https://github.com/apache/spark/pull/37824#issuecomment-1242223041
> Agree with @peter-toth that we should do all ordering in the 2nd pass, in
a bottom-up way.
I suppose @cloud-fan @peter-toth you want to code the change...? Or you
want me to
wankunde commented on PR #37533:
URL: https://github.com/apache/spark/pull/37533#issuecomment-1242234794
I'm sorry for the late reply, I have updated the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967339252
##
core/src/main/resources/error/error-classes.json:
##
@@ -327,6 +327,83 @@
],
"sqlState" : "42000"
},
+ "INVALID_SUBQUERY_EXPRESSION" : {
+
dongjoon-hyun closed pull request #37468: [SPARK-40034][SQL]
PathOutputCommitters to support dynamic partitions
URL: https://github.com/apache/spark/pull/37468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun commented on PR #37468:
URL: https://github.com/apache/spark/pull/37468#issuecomment-1242329502
Merged to master for Apache Spark 3.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dongjoon-hyun commented on code in PR #37733:
URL: https://github.com/apache/spark/pull/37733#discussion_r967367956
##
docs/monitoring.md:
##
@@ -1207,12 +1207,12 @@ This is the component with the largest amount of
instrumented metrics
- namespace=ExecutorAllocationManager
dtenedor commented on code in PR #37840:
URL: https://github.com/apache/spark/pull/37840#discussion_r967378293
##
sql/core/src/test/resources/sql-tests/results/join-lateral.sql.out:
##
@@ -323,14 +322,10 @@ SELECT * FROM t1, LATERAL (SELECT rand(0) FROM t2)
struct<>
-- !query
huaxingao commented on PR #37847:
URL: https://github.com/apache/spark/pull/37847#issuecomment-1242312672
I will merge this PR since the test failure is not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
huaxingao commented on PR #37847:
URL: https://github.com/apache/spark/pull/37847#issuecomment-1242312241
Thanks @gengliangwang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
huaxingao commented on PR #37846:
URL: https://github.com/apache/spark/pull/37846#issuecomment-1242334119
Merged to 3.2. Thanks @zzcclp for fixing this! Also thanks @tgravescs
@revans2 @wangyum for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the
huaxingao closed pull request #37847: [SPARK-40280][SQL][FOLLOWUP][3.3] Fix
'ParquetFilterSuite' issue
URL: https://github.com/apache/spark/pull/37847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
huaxingao closed pull request #37846: [SPARK-40280][SQL][FOLLOWUP][3.2] Fix
'ParquetFilterSuite' issue
URL: https://github.com/apache/spark/pull/37846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gengliangwang opened a new pull request, #37848:
URL: https://github.com/apache/spark/pull/37848
### What changes were proposed in this pull request?
Fix a test failure in SQLQuerySuite on branch-3.3. It's from the backport of
https://github.com/apache/spark/pull/37832 since
dtenedor commented on PR #37841:
URL: https://github.com/apache/spark/pull/37841#issuecomment-1242354926
cc @dtenedor myself for context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dongjoon-hyun closed pull request #37716: [SPARK-40269][CORE] Randomize the
orders of peer in BlockManagerDecommissioner
URL: https://github.com/apache/spark/pull/37716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
LuciferYang commented on code in PR #37826:
URL: https://github.com/apache/spark/pull/37826#discussion_r967386144
##
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile,
LuciferYang commented on code in PR #37826:
URL: https://github.com/apache/spark/pull/37826#discussion_r967405666
##
common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java:
##
@@ -85,14 +84,6 @@ public static DB initLevelDB(File dbFile,
dongjoon-hyun closed pull request #37802: [SPARK-40350][Kubernetes] Use spark
config to configure the parameters of volcano podgroup
URL: https://github.com/apache/spark/pull/37802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjoon-hyun commented on PR #37802:
URL: https://github.com/apache/spark/pull/37802#issuecomment-1242559032
Let me close this PR for now. We can continue our discussion on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun commented on PR #37813:
URL: https://github.com/apache/spark/pull/37813#issuecomment-1242562694
Merged to branch-3.3. Thank you, @wangyum and @cloud-fan .
I added comment during backporting.
- https://github.com/apache/spark/pull/37813#discussion_r967496771
--
This is
dongjoon-hyun closed pull request #37813: [SPARK-40228][SQL][3.3] Do not
simplify multiLike if child is not a cheap expression
URL: https://github.com/apache/spark/pull/37813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wangyum closed pull request #37849: [SPARK-40401][CORE] Remove the support of
deprecated `spark.akka.*` configs
URL: https://github.com/apache/spark/pull/37849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun opened a new pull request, #37849:
URL: https://github.com/apache/spark/pull/37849
### What changes were proposed in this pull request?
This PR aims to remove the support of `spark.akka.*` configs.
### Why are the changes needed?
- Apache Spark 2.0+ is not
wangyum commented on PR #37849:
URL: https://github.com/apache/spark/pull/37849#issuecomment-1242622789
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dongjoon-hyun commented on code in PR #37813:
URL: https://github.com/apache/spark/pull/37813#discussion_r967496771
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -1075,6 +1075,16 @@ object CollapseProject extends Rule[LogicalPlan]
dongjoon-hyun commented on code in PR #37813:
URL: https://github.com/apache/spark/pull/37813#discussion_r967496771
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -1075,6 +1075,16 @@ object CollapseProject extends Rule[LogicalPlan]
dongjoon-hyun closed pull request #37808: [SPARK-39830][SQL][TESTS][3.3] Add a
test case to read ORC table that requires type promotion
URL: https://github.com/apache/spark/pull/37808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun closed pull request #37730: [SPARK-39915][SQL][3.3]
Dataset.repartition(N) may not create N partitions Non-AQE part
URL: https://github.com/apache/spark/pull/37730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjoon-hyun commented on PR #37849:
URL: https://github.com/apache/spark/pull/37849#issuecomment-1242574665
cc @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
fanyilun commented on PR #37803:
URL: https://github.com/apache/spark/pull/37803#issuecomment-1242604703
Thanks, driver pod template already supports ports definition. It works for
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun closed pull request #37603: [SPARK-40168][CORE] Handle
`SparkException` during shuffle block migration
URL: https://github.com/apache/spark/pull/37603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
srowen commented on PR #37806:
URL: https://github.com/apache/spark/pull/37806#issuecomment-1242549952
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
srowen closed pull request #37806: [MINOR][SQL] Print stacktrace when
NoClassDefFoundError in HiveDelegationToken
URL: https://github.com/apache/spark/pull/37806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
srowen commented on PR #37820:
URL: https://github.com/apache/spark/pull/37820#issuecomment-1242550304
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
srowen closed pull request #37820: [MINOR][PS][DOCS] Fix note in missing pandas
URL: https://github.com/apache/spark/pull/37820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zzcclp commented on PR #37846:
URL: https://github.com/apache/spark/pull/37846#issuecomment-1242578594
> @zzcclp Could you please update the PR description to fill all the
required information?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the
zzcclp commented on PR #37847:
URL: https://github.com/apache/spark/pull/37847#issuecomment-1242578672
> @zzcclp Could you please update the PR description to fill all the
required information? Thanks!
Done.
--
This is an automated message from the Apache Git Service.
To respond
huaxingao commented on PR #37847:
URL: https://github.com/apache/spark/pull/37847#issuecomment-1242307565
@gengliangwang
This test failed.
```
[info] - SPARK-40389: Don't eliminate a cast which can cause overflow ***
FAILED *** (227 milliseconds)
[info] "The value
dongjoon-hyun commented on PR #37848:
URL: https://github.com/apache/spark/pull/37848#issuecomment-1242353212
Thank you, @gengliangwang and @huaxingao . I tested this manually.
Merged to branch-3.3 to recover the branch.
--
This is an automated message from the Apache Git Service.
To
roczei commented on code in PR #37679:
URL: https://github.com/apache/spark/pull/37679#discussion_r967420952
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##
@@ -286,7 +284,7 @@ class SessionCatalog(
def dropDatabase(db: String,
LuciferYang opened a new pull request, #37844:
URL: https://github.com/apache/spark/pull/37844
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
###
LuciferYang commented on PR #37604:
URL: https://github.com/apache/spark/pull/37604#issuecomment-1241543683
@plokhotnyuk Let me learn about
[jsoniter-scala](https://github.com/plokhotnyuk/jsoniter-scala) first
--
This is an automated message from the Apache Git Service.
To
dongjoon-hyun commented on PR #37468:
URL: https://github.com/apache/spark/pull/37468#issuecomment-1241563463
BTW, when is the ETA for Apache Hadoop 3.3.5, @steveloughran ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
LuciferYang commented on PR #37843:
URL: https://github.com/apache/spark/pull/37843#issuecomment-1241538954
will add more similar case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
LuciferYang commented on PR #37844:
URL: https://github.com/apache/spark/pull/37844#issuecomment-1241573384
Test API compatibility first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cloud-fan commented on code in PR #36027:
URL: https://github.com/apache/spark/pull/36027#discussion_r966724740
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -1095,7 +1095,11 @@ private[hive] object HiveClientImpl extends Logging {
cloud-fan commented on code in PR #37841:
URL: https://github.com/apache/spark/pull/37841#discussion_r966737035
##
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala:
##
@@ -124,12 +126,16 @@ class AnalysisException protected[sql] (
plan:
peter-toth commented on PR #37824:
URL: https://github.com/apache/spark/pull/37824#issuecomment-1241638796
> > I think we could simply move the ordering logic from
`BinaryComparison.preCanonicalized` to
`Canonicalize.reorderCommutativeOperators` (and rename it to
`reorderOperators`) and
beliefer commented on code in PR #37830:
URL: https://github.com/apache/spark/pull/37830#discussion_r966770205
##
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##
@@ -184,68 +184,56 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
peter-toth commented on code in PR #36027:
URL: https://github.com/apache/spark/pull/36027#discussion_r966793263
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -1095,7 +1095,11 @@ private[hive] object HiveClientImpl extends Logging {
peter-toth commented on code in PR #36027:
URL: https://github.com/apache/spark/pull/36027#discussion_r966809657
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -1095,7 +1095,11 @@ private[hive] object HiveClientImpl extends Logging {
zhengruifeng commented on code in PR #37845:
URL: https://github.com/apache/spark/pull/37845#discussion_r966813948
##
python/pyspark/pandas/tests/test_stats.py:
##
@@ -257,6 +257,32 @@ def test_skew_kurt_numerical_stability(self):
self.assert_eq(psdf.skew(),
peter-toth commented on code in PR #36027:
URL: https://github.com/apache/spark/pull/36027#discussion_r966809657
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -1095,7 +1095,11 @@ private[hive] object HiveClientImpl extends Logging {
cloud-fan commented on code in PR #36027:
URL: https://github.com/apache/spark/pull/36027#discussion_r966824596
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -1095,7 +1095,11 @@ private[hive] object HiveClientImpl extends Logging {
cloud-fan commented on code in PR #37830:
URL: https://github.com/apache/spark/pull/37830#discussion_r966829229
##
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##
@@ -487,12 +488,12 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
AmplabJenkins commented on PR #37819:
URL: https://github.com/apache/spark/pull/37819#issuecomment-1241842477
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AmplabJenkins commented on PR #37817:
URL: https://github.com/apache/spark/pull/37817#issuecomment-1241842534
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wangyum commented on code in PR #36850:
URL: https://github.com/apache/spark/pull/36850#discussion_r966887563
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:
##
@@ -205,10 +205,14 @@ object ConstantPropagation extends Rule[LogicalPlan]
beliefer commented on code in PR #37830:
URL: https://github.com/apache/spark/pull/37830#discussion_r966946241
##
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##
@@ -504,7 +505,7 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
SelfImpr001 commented on code in PR #37732:
URL: https://github.com/apache/spark/pull/37732#discussion_r967056734
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala:
##
@@ -76,8 +76,19 @@ object Literal {
val decimal = Decimal(d)
srowen commented on PR #37817:
URL: https://github.com/apache/spark/pull/37817#issuecomment-1241962781
Oh, remove the type ignore comment:
```
annotations failed mypy checks:
python/pyspark/sql/pandas/conversion.py:298: error: unused "type: ignore"
comment
Found 1 error in 1
srowen commented on code in PR #37732:
URL: https://github.com/apache/spark/pull/37732#discussion_r967060213
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala:
##
@@ -76,8 +76,19 @@ object Literal {
val decimal = Decimal(d)
srowen commented on PR #37845:
URL: https://github.com/apache/spark/pull/37845#issuecomment-1241970409
Hm, does another library or method in Spark do this? It feels weird to have
a method that computes "mostly a correlation" ignoring data
--
This is an automated message from the Apache
wangyum closed pull request #37732: [SPARK-40253] [SQL] Fixed loss of precision
for writing 0.00 specific…
URL: https://github.com/apache/spark/pull/37732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
srowen commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967068327
##
pom.xml:
##
@@ -1139,37 +1139,38 @@
org.scalatest
scalatest_${scala.binary.version}
-3.3.0-SNAP3
+3.2.13
Review Comment:
srowen commented on PR #37839:
URL: https://github.com/apache/spark/pull/37839#issuecomment-1241972895
Again - not a typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
srowen closed pull request #37839: correct typo in rdd-programming-guide.md
URL: https://github.com/apache/spark/pull/37839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tgravescs commented on PR #37847:
URL: https://github.com/apache/spark/pull/37847#issuecomment-1241976659
thanks for fixing @zzcclp I should have built it on these before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tgravescs commented on PR #37846:
URL: https://github.com/apache/spark/pull/37846#issuecomment-1241976737
thanks for fixing @zzcclp I should have built it on these before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
EnricoMi commented on code in PR #37407:
URL: https://github.com/apache/spark/pull/37407#discussion_r967091275
##
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##
@@ -618,6 +618,46 @@ pivotValue
: expression (AS? identifier)?
;
1 - 100 of 130 matches
Mail list logo
