Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55793191
Thanks! I've merged this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55793986
Great! Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55687685
Now that #2385 has been merged, this looks like it will be ready to merge
as soon as you rebase it on top of master.
---
If your project is set up for it, you can
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55693317
Ok, just merged with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55504491
SQL LGTM.
@JoshRosen is this ready to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1592#discussion_r17514641
--- Diff: python/pyspark/context.py ---
@@ -36,6 +37,65 @@
from py4j.java_collections import ListConverter
+__all__ = [JavaStackTrace,
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1592#discussion_r17514658
--- Diff: python/pyspark/rdd.py ---
@@ -704,7 +651,8 @@ def collect(self):
Return a list that contains all of the elements in
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1592#discussion_r17514679
--- Diff: python/pyspark/sql.py ---
@@ -1624,15 +1636,40 @@ def count(self):
return self._jschema_rdd.count()
def collect(self):
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55507731
@staple @marmbrus Aside from my comments on moving the traceback functions
into their own file, this looks good to me.
---
If your project is set up for it, you can
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55516200
Thanks for taking a look, guys.
Hmm, it looks like the duplicate __all__ variables result from a recent
merge. I went ahead and created a separate PR for
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55306732
@staple The Jenkins pull request builder is in an odd state of flux right
now. I've manually re-triggered your build (I should have self-service retest
this please
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55306927
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/71/consoleFull)
for PR 1592 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55307181
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20165/consoleFull)
for PR 1592 at commit
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55307274
@JoshRosen Great, thanks for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55321104
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/71/consoleFull)
for PR 1592 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55321504
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20165/consoleFull)
for PR 1592 at commit
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55227656
Thanks!, I'm not getting any more NPEs now. I went ahead and merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55235315
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/67/consoleFull)
for PR 1592 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55244823
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/67/consoleFull)
for PR 1592 at commit
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55283908
Hi, the failing test was CheckpointSuite / 'recovery with file input
stream'. This test passed when I ran the tests locally, and it sometimes fails
spuriously according
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55283980
I'm assuming I don't have permission to ask jenkins to run a test myself,
right?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55216993
I just merged #2323 to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-55003590
Great! I'll go ahead and merge once #2323 is in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-54900606
#2323 seems to fix the Kryo error for me. Let me know if you have further
issues after updating this to master.
---
If your project is set up for it, you can reply to
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-54760558
Hmm, that kryo error is unfortunate. We'll probably need to add a special
serializer in SparkSqlSerializer to work around this.
---
If your project is set up for it,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-54694556
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-54252457
Hey @staple if you have time to update this would be great to include it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-51014567
Hi folks Iâve merged with the most recent code (pushed to my branch), but
for some reason with the most recent merge I am getting NPEs in Kryo for
schemas containing
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50978374
This seems to have captured a bunch of unrelated changes during the rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50981508
Sorry, I'm away from home and had limited time / access to try and do the
merge last night - which I didn't finish, and as you mentioned messed up the
included commits.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50947257
@staple could you rebase this pr to PR-1598? it gets very close to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50722408
@staple Could you hold it one more days until we merge the changes in #1598
about serialization between Java and Python?
---
If your project is set up for it, you can
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50722658
Sure, no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50577338
Sure, Iâm fine with reworking based on other changes (it seems that some
merge conflicts have already cropped up in master since I submitted my PR last
week). I think
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50577608
Yeah, I'm hoping to merge #1346 as soon as it passes Jenkins, so I'd wait
for that.
I also thought Iâd add a couple of notes on what I had in mind with
this
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50577874
Sure, added the notes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50705813
Hi, I've updated the patch to work with the new code in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50576177
Thanks for working on this! We'll need to coordinate merging with #1346
and related PRs. (cc @yhuai)
@JoshRosen can you look at the other pyspark changes?
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1592#issuecomment-50196980
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1421#issuecomment-49085915
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1421#issuecomment-49086561
QA tests have started for PR 1421. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16691/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1421#issuecomment-49099033
QA results for PR 1421:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
43 matches
Mail list logo
