Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14650
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88572655
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88570905
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,21 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88570567
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -412,10 +412,8 @@ private[deploy] class SparkSubmitArguments(args:
Se
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88570120
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88570035
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88570021
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88541234
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88541269
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88540981
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -412,10 +412,8 @@ private[deploy] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88541166
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88541878
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,21 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88218822
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84299435
--- Diff:
mesos/src/test/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArgumentsSuite.scala
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84299382
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -412,10 +412,9 @@ private[deploy] class SparkSubmitArguments(args:
Se
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84299319
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84297878
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84185028
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84185062
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -412,10 +412,9 @@ private[deploy] class SparkSubmitArguments(args:
Se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84185107
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,22 @@ private[spark] object Utils extends Logging {
path
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84184293
--- Diff: core/src/main/scala/org/apache/spark/util/Executable.scala ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84185216
--- Diff:
mesos/src/test/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArgumentsSuite.scala
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84184970
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r84185141
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -65,16 +55,20 @@ class SparkSubmitSuite
}
/** Returns
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r80014437
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,20 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r80009663
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,20 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r80008539
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -73,37 +94,55 @@ private[mesos] class
MesosCluster
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r80007760
--- Diff:
core/src/main/scala/org/apache/spark/util/SparkConfigParseUtils.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r80006932
--- Diff:
core/src/main/scala/org/apache/spark/util/SparkConfigParseUtils.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r80006906
--- Diff:
core/src/main/scala/org/apache/spark/util/SparkConfigParseUtils.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r80006086
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -88,6 +82,22 @@ class SparkSubmitSuite
fail(s"Search string '$s
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79896950
--- Diff:
core/src/main/scala/org/apache/spark/util/SparkConfigParseUtils.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79895876
--- Diff:
core/src/main/scala/org/apache/spark/util/SparkConfigParseUtils.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79895825
--- Diff:
core/src/main/scala/org/apache/spark/util/SparkConfigParseUtils.scala ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79893858
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -73,37 +94,55 @@ private[mesos] class
MesosCluster
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79893424
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -88,6 +82,22 @@ class SparkSubmitSuite
fail(s"Search string '$s
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79892035
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,20 @@ private[spark] object Utils extends Logging {
path
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79891759
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,20 @@ private[spark] object Utils extends Logging {
path
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79891251
--- Diff: core/src/main/scala/org/apache/spark/util/Executable.scala ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79799725
--- Diff: core/src/main/scala/org/apache/spark/util/Executable.scala ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79791918
--- Diff: core/src/main/scala/org/apache/spark/util/Executable.scala ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79789580
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -18,23 +18,43 @@
package org.apache.spark.depl
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79417214
--- Diff: core/src/main/scala/org/apache/spark/util/Executable.scala ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79417055
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -18,23 +18,43 @@
package org.apache.spark.depl
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79376216
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -40,12 +40,12 @@ import org.apache.ivy.plugins.matcher.GlobPatternMatcher
i
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79376168
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -73,37 +94,55 @@ private[mesos] class
MesosCluster
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79376179
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -18,23 +18,43 @@
package org.apache.spark.depl
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79362014
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -73,37 +94,55 @@ private[mesos] class
MesosCluster
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79360414
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -40,12 +40,12 @@ import org.apache.ivy.plugins.matcher.GlobPatternMatcher
i
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79360333
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -18,23 +18,43 @@
package org.apache.spark.depl
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79359869
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -27,28 +27,18 @@ import org.scalatest.{BeforeAndAfterEach, Matchers}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79359765
--- Diff: core/src/main/scala/org/apache/spark/util/Executable.scala ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79348228
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -73,37 +94,55 @@ private[mesos] class
MesosCluster
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79349262
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -18,23 +18,43 @@
package org.apache.spark.depl
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79348879
--- Diff: core/src/main/scala/org/apache/spark/util/Executable.scala ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79347621
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -40,12 +40,12 @@ import org.apache.ivy.plugins.matcher.GlobPatternMatcher
i
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79348038
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -27,28 +27,18 @@ import org.scalatest.{BeforeAndAfterEach, Matchers}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75592117
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75591574
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
}
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75551679
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75551246
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75549841
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75549695
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75549255
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75548282
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75547546
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -102,7 +115,9 @@ private[mesos] class
MesosClusterD
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75547461
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
}
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75547368
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -73,6 +82,10 @@ private[mesos] class
MesosClusterDi
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75531364
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75531050
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75530884
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -102,7 +115,9 @@ private[mesos] class
MesosCluste
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75530859
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -102,7 +115,9 @@ private[mesos] class
MesosCluste
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75530775
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,26 @@ private[spark] object Utils extends Logging {
path
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r75530239
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -73,6 +82,10 @@ private[mesos] class
MesosCluster
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/14650
[SPARK-17062][MESOS] add conf option to mesos dispatcher
## What changes were proposed in this pull request?
Adds --conf option to set spark configuration properties in mesos
dispacther.
Pro
75 matches
Mail list logo