Re: [Rosegarden-user] Guitar MIDI Controller to Notation
On 1/24/23 10:43, mark_at_yahoo via Rosegarden-user wrote: On 1/21/23 08:54, mark_at_yahoo via Rosegarden-user wrote: Only vaguely related: Has there ever been any interest in adding a guitar tablature editor to Rosegarden? On 1/21/23 11:03 PM, david wrote: I think adding it to RG while maintaining the ability to also display/edit it *as a score* would be really tough. On 1/22/23 1:52 AM, mark_at_yahoo via Rosegarden-user wrote: I'm envisioning it as a new/separate tablature editor window, like the matrix and event editors vs notation. On second thought, although I still like the tablature editor idea, a better design might be to integrate tablature directly into the notation editor. Each normal standard notation staff could have an optional tablature staff directly above (or below) it. Likewise, if the user was only interested in tablature, the standard staff could be disabled/hidden. I've only played with Musescore very casually/briefly (and only version 3, not the radically revamped new version 4 which doesn't run on my current system) and it has this capability. Sort of. Tablature staves can be created and positioned at will but they're completely disconnected from any standard notation staff -- notes entered in tablature don't appear in standard and vice-versa (the latter being the previously mentioned A.I. problem). Maybe there's a way to link them but if so it wasn't obvious to me. MuseScore instructions on doing tablature: https://musescore.org/en/handbook/3/tablature I think when I did it, I changed an existing staff to tablature, since my goal was to convert an existing score into tab. That turned the staff into tablature, replacing the score, and I wasn't editing anything in MuseScore. I think if you create your score/tab using the New Score Wizard, maybe MuseScore links them? In any case, there's no reason why Rosegarden couldn't have something like this, done correctly with live linking between the staves. Well, no reason except for the need to find someone with the ability to implement it and the willingness to volunteer a few hundred hours of software development effort to do so. ;) And then even more to review, validate, test, integrate, and accept it into the Rosegarden codebase. Any volunteers? ;) That's always the problem! -- David W. Jones gn...@hawaii.rr.com authenticity, honesty, community http://dancingtreefrog.com "My password is the last 8 digits of π." ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Guitar MIDI Controller to Notation
On 1/21/23 08:54, mark_at_yahoo via Rosegarden-user wrote: Only vaguely related: Has there ever been any interest in adding a guitar tablature editor to Rosegarden? On 1/21/23 11:03 PM, david wrote: I think adding it to RG while maintaining the ability to also display/edit it *as a score* would be really tough. On 1/22/23 1:52 AM, mark_at_yahoo via Rosegarden-user wrote: I'm envisioning it as a new/separate tablature editor window, like the matrix and event editors vs notation. On second thought, although I still like the tablature editor idea, a better design might be to integrate tablature directly into the notation editor. Each normal standard notation staff could have an optional tablature staff directly above (or below) it. Likewise, if the user was only interested in tablature, the standard staff could be disabled/hidden. I've only played with Musescore very casually/briefly (and only version 3, not the radically revamped new version 4 which doesn't run on my current system) and it has this capability. Sort of. Tablature staves can be created and positioned at will but they're completely disconnected from any standard notation staff -- notes entered in tablature don't appear in standard and vice-versa (the latter being the previously mentioned A.I. problem). Maybe there's a way to link them but if so it wasn't obvious to me. In any case, there's no reason why Rosegarden couldn't have something like this, done correctly with live linking between the staves. Well, no reason except for the need to find someone with the ability to implement it and the willingness to volunteer a few hundred hours of software development effort to do so. ;) And then even more to review, validate, test, integrate, and accept it into the Rosegarden codebase. Any volunteers? ;) ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Guitar MIDI Controller to Notation
Thanks. Works perfectly. Just pushed to master. Our standard (and pretty much the standard across open source projects these days) is to rely on git to track down authorship and actual copyright. No need to add a copyright notice to each file. After a while it gets hard to find the code if we do. I think we need to move the AUTHORS info from the website to the source base as well. It's on my mental TODO. Ted. On 1/22/23 5:24 AM, mark_at_yahoo via Rosegarden-user wrote: On 1/21/23 1:57 PM, Ted Felix wrote: If you have time to make this change against master, I'd appreciate it. Then I can merge it right away. Thanks. The attached patch against the latest master I have should apply cleanly unless there's been changes in the two files since then. Also feel free to remove my fork's extra copyright lines. Hope this is what you were looking for. "Works for me" as the canonical saying goes. ;) ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Guitar MIDI Controller to Notation
On 1/21/23 1:57 PM, Ted Felix wrote:
If you have time to make this change against master, I'd appreciate
it. Then I can merge it right away. Thanks.
The attached patch against the latest master I have should apply cleanly
unless there's been changes in the two files since then. Also feel free
to remove my fork's extra copyright lines.
Hope this is what you were looking for. "Works for me" as the canonical
saying goes. ;)
diff --git a/src/gui/dialogs/EventFilterDialog.cpp b/src/gui/dialogs/EventFilterDialog.cpp
index 55fa9836c..4b545c5f5 100644
--- a/src/gui/dialogs/EventFilterDialog.cpp
+++ b/src/gui/dialogs/EventFilterDialog.cpp
@@ -3,7 +3,8 @@
/*
Rosegarden
A MIDI and audio sequencer and musical notation editor.
-Copyright 2000-2022 the Rosegarden development team.
+Copyright 2000-2023 the Rosegarden development team.
+Modifications and additions Copyright (c) 2023 Mark R. Rubin aka "thanks4opensource" aka "thanks4opensrc"
This file is Copyright 2003-2006
D. Michael McIntyre
@@ -285,28 +286,38 @@ EventFilterDialog::populateDurationCombos()
settings.endGroup();
}
+void
+EventFilterDialog::resetValuesToAll()
+{
+m_pitchFromSpinBox ->setValue( 0);
+m_pitchToSpinBox ->setValue(127);
+m_velocityFromSpinBox->setValue( 0);
+m_velocityToSpinBox ->setValue(127);
+
+m_noteDurationFromComboBox->setCurrentIndex(m_noteDurationToComboBox
+ ->count()
+- 1);
+m_noteDurationToComboBox ->setCurrentIndex(0);
+}
+
void
EventFilterDialog::slotToggleAll()
{
RG_DEBUG << "EventFilterDialog::slotToggleAll()";
-m_pitchFromSpinBox ->setValue(0);
-m_pitchToSpinBox ->setValue(127);
-m_velocityFromSpinBox ->setValue(0);
-m_velocityToSpinBox ->setValue(127);
-m_noteDurationFromComboBox ->setCurrentIndex(11); // hard coded; should be variable
-m_noteDurationToComboBox ->setCurrentIndex(0); // 0 = unlimited; 11 = 0
+resetValuesToAll();
+m_notePitchIncludeComboBox ->setCurrentIndex(0);
+m_noteVelocityIncludeComboBox->setCurrentIndex(0);
+m_noteDurationIncludeComboBox->setCurrentIndex(0);
}
void
EventFilterDialog::slotToggleNone()
{
RG_DEBUG << "EventFilterDialog::slotToggleNone()";
-m_pitchFromSpinBox ->setValue(0);
-m_pitchToSpinBox ->setValue(0);
-m_velocityFromSpinBox ->setValue(0);
-m_velocityToSpinBox ->setValue(0);
-m_noteDurationFromComboBox ->setCurrentIndex(11);
-m_noteDurationToComboBox ->setCurrentIndex(11);
+resetValuesToAll();
+m_notePitchIncludeComboBox ->setCurrentIndex(1);
+m_noteVelocityIncludeComboBox->setCurrentIndex(1);
+m_noteDurationIncludeComboBox->setCurrentIndex(1);
}
void
diff --git a/src/gui/dialogs/EventFilterDialog.h b/src/gui/dialogs/EventFilterDialog.h
index 2f80c40e0..4eb93bef9 100644
--- a/src/gui/dialogs/EventFilterDialog.h
+++ b/src/gui/dialogs/EventFilterDialog.h
@@ -3,7 +3,8 @@
/*
Rosegarden
A MIDI and audio sequencer and musical notation editor.
-Copyright 2000-2022 the Rosegarden development team.
+Copyright 2000-2023 the Rosegarden development team.
+Modifications and additions Copyright (c) 2023 Mark R. Rubin aka "thanks4opensource" aka "thanks4opensrc"
This file is Copyright 2003-2006
D. Michael McIntyre
@@ -132,6 +133,8 @@ protected slots:
private:
+void resetValuesToAll();
+
//-[ data members ]-
QGridLayout* layout;
___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Guitar MIDI Controller to Notation
On 1/21/23 11:03 PM, david wrote: On 1/21/23 08:54, mark_at_yahoo via Rosegarden-user wrote: Only vaguely related: Has there ever been any interest in adding a guitar tablature editor to Rosegarden? Tuxguitar lets you specify the player's ability level, which is kind of nice. How does that work? You give it something like a numeric level, 1==beginner, 5==expert, and it has A.I. that spits out open-position "cowboy chords" vs ones with nice voice leading all up and down the neck? Impressive if so. I think adding it to RG while maintaining the ability to also display/edit it *as a score* would be really tough. I'm envisioning it as a new/separate tablature editor window, like the matrix and event editors vs notation. One of Rosegarden's great strengths is its live updates across the editors (except the event editor which doesn't change until it regains focus -- maybe someone can fix that someday). So creating or moving a note to a fret number and string in the tablature editor would change it in notation/matrix/event because that's deterministic. Creating/moving/changing a note in notation/matrix/event would need some kind of A.I. to choose among the multiple correct fret/string choices, but at simplest that could be the closest correct-pitch position to any existing notes around the same time, or if moving instead of creating, the closest to the note's pre-move fret. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Guitar MIDI Controller to Notation
On 1/21/23 08:54, mark_at_yahoo via Rosegarden-user wrote: On 1/21/23 4:09 AM, Ted Felix wrote: I've been working with Mike Knott on post-processing MIDI from a guitar controller into notation. I've created a page on the wiki documenting the process: https://www.rosegardenmusic.com/wiki/doc:guitar_midi_controller_to_notation Only vaguely related: Has there ever been any interest in adding a guitar tablature editor to Rosegarden? It wouldn't be a simple task as it would require A.I. and/or metadata saved in the .rg file to specify what string and fret to use for each note out of the multiple possible same-pitch choices (e.g. the same A is on fret 2 of the G string and fret 7 of the D string) so that chords and melodies are "fingerable". As I no longer (pathetically attempt to) play guitar I'm not likely to take it on as a project, but it would be a very nice addition to Rosegarden if someone else would contribute it. I've been satisfied with exporting the RG as a MusicXML file, importing it into Musescore, and setting Musescore to do tablature. That lets me do things like specify open/alternate tunings. Another option is Tuxguitar, but Musescore does a better job of printing. Tuxguitar lets you specify the player's ability level, which is kind of nice. I don't know if Musescore can to that. I haven't done much tablature lately. I think adding it to RG while maintaining the ability to also display/edit it *as a score* would be really tough. -- David W. Jones gn...@hawaii.rr.com authenticity, honesty, community http://dancingtreefrog.com "My password is the last 8 digits of π." ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Guitar MIDI Controller to Notation
'looks good to me. A useful bit of documentation Chuck. On 21/01/2023 12:09 pm, Ted Felix wrote: I've been working with Mike Knott on post-processing MIDI from a guitar controller into notation. I've created a page on the wiki documenting the process: https://www.rosegardenmusic.com/wiki/doc:guitar_midi_controller_to_notation It's just three steps: - Remove Spurious Notes - Quantize - Remove Marks If anyone is interested, please review and let me know if there's anything that can be improved. Thanks. Ted. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Guitar MIDI Controller to Notation
On 1/21/23 1:54 PM, mark_at_yahoo via Rosegarden-user wrote: I thought I'd fixed that in my branch's [b8d3cb], which in turn was merged into master as Merge Request #66. Is it still not working? I vaguely recalled recent work on that, but couldn't place it. I was going to dig and figure it out. Wait ... I see. The commit fixed the bug which had lowest and highest reversed (among other things), but "Include all" doesn't reset the three "Include/Exclude" buttons to "Include". That should be an easy change. I think the durations also don't select "shortest" to "longest". One of those ends up being a value instead. That needs to be fixed as well. If you have time to make this change against master, I'd appreciate it. Then I can merge it right away. Thanks. Ted. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
Re: [Rosegarden-user] Guitar MIDI Controller to Notation
On 1/21/23 4:09 AM, Ted Felix wrote: I've been working with Mike Knott on post-processing MIDI from a guitar controller into notation. I've created a page on the wiki documenting the process: https://www.rosegardenmusic.com/wiki/doc:guitar_midi_controller_to_notation From the wiki page: > The Event Filter dialog's “Include All” button doesn't. It needs > to set lowest duration to “shortest” and all the dropdowns > to “include”. I thought I'd fixed that in my branch's [b8d3cb], which in turn was merged into master as Merge Request #66. Is it still not working? Wait ... I see. The commit fixed the bug which had lowest and highest reversed (among other things), but "Include all" doesn't reset the three "Include/Exclude" buttons to "Include". That should be an easy change. Only vaguely related: Has there ever been any interest in adding a guitar tablature editor to Rosegarden? It wouldn't be a simple task as it would require A.I. and/or metadata saved in the .rg file to specify what string and fret to use for each note out of the multiple possible same-pitch choices (e.g. the same A is on fret 2 of the G string and fret 7 of the D string) so that chords and melodies are "fingerable". As I no longer (pathetically attempt to) play guitar I'm not likely to take it on as a project, but it would be a very nice addition to Rosegarden if someone else would contribute it. ___ Rosegarden-user mailing list Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-user
