[Ryu-devel] [PATCH 1/4] neutron-ofswitch-agent: neutron agent for ofswitch ML2 mechanism driver

2014-02-06 Thread YAMAMOTO Takashi
From: fumihiko kakuma Like ryu-manager, this agent serves Ryu applications and acts an OpenFlow controller to control switches. The neutron agent logic, which we will push to the neutron repo, is implemented as a Ryu application. Implements: OpenStack blueprint ryu-ml2-driver https://blueprints

[Ryu-devel] [PATCH 0/4] neutron ofswitch agent

2014-02-06 Thread YAMAMOTO Takashi
this is ryu part of neutron ofswitch agent. cf. https://blueprints.launchpad.net/neutron/+spec/ryu-ml2-driver this set is after changes i posted today. Esp. "run_tests.sh: add of-config-cli to PYLINT_INCLUDE". (logically independent, but touches the same lines) YAMAMOTO Takashi (3): run_tests.s

[Ryu-devel] [PATCH 2/4] run_tests.sh: add neutron-ofswitch-agent to PYLINT_INCLUDE

2014-02-06 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- run_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run_tests.sh b/run_tests.sh index 458da62..a6fbbef 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -90,7 +90,7 @@ run_tests() { run_pylint() { echo "Running pylint ..." PYLI

[Ryu-devel] [PATCH 3/4] setup.cfg: add neutron-ofswitch-agent to console_scrpits

2014-02-06 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/setup.cfg b/setup.cfg index 6e6527f..1075ef4 100644 --- a/setup.cfg +++ b/setup.cfg @@ -47,5 +47,6 @@ setup-hooks = [entry_points] console_scripts = +neutron-ofswitch-agent = ryu.cmd.ofs_neut

[Ryu-devel] [PATCH 4/4] neutron-ofswitch-agent man page

2014-02-06 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- doc/source/conf.py| 3 +++ doc/source/man/neutron_ofswitch_agent.rst | 20 2 files changed, 23 insertions(+) create mode 100644 doc/source/man/neutron_ofswitch_agent.rst diff --git a/doc/source/conf.py b/doc/sourc

[Ryu-devel] [PATCH] sw test tool: remove unnecessary debug code

2014-02-06 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/tests/switch/tester.py |2 -- 1 file changed, 2 deletions(-) diff --git a/ryu/tests/switch/tester.py b/ryu/tests/switch/tester.py index 519a763..8556b52 100644 --- a/ryu/tests/switch/tester.py +++ b/ryu/tests/switch/tester.py @@ -877,8 +877,6 @@ class

[Ryu-devel] [PATCH] sw test tool: correct error message

2014-02-06 Thread watanabe.fumitaka
When test tool receives a malformed packet(length value is unusual, for example), detecting differences between expected and received is a failure. In this case, 'Internal error.' is not suitable as a log message and should notify tool receives a malformed packet. Signed-off-by: WATANABE Fumit

Re: [Ryu-devel] About restAPI question for more actions at one flow entry

2014-02-06 Thread Yuichi Ito
Hi, the bug has been fixed in current version. please try Ryu 3.6. thanks. On Fri, 7 Feb 2014 12:16:44 +0800 jalee wrote: > Hi Yuichi, > Do you have fix version can resolve ofctl_rest bug? > Thanks, > > Jalee > > > -Original Message- > From: Yuichi Ito [mailto:[email protected]]

[Ryu-devel] [PATCH] ofproto_v1_3_parser: add a comment about extensions support

2014-02-06 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_3_parser.py | 26 ++ 1 file changed, 26 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_3_parser.py b/ryu/ofproto/ofproto_v1_3_parser.py index 64fc319..079cb66 100644 --- a/ryu/ofproto/ofproto_v1_3_parser.py ++

Re: [Ryu-devel] About restAPI question for more actions at one flow entry

2014-02-06 Thread jalee
Hi Yuichi, Do you have fix version can resolve ofctl_rest bug? Thanks, Jalee -Original Message- From: Yuichi Ito [mailto:[email protected]] Sent: Thursday, January 23, 2014 12:03 PM To: jalee Cc: [email protected] Subject: Re: [Ryu-devel] About restAPI question for mor

Re: [Ryu-devel] [PATCH] sw test tool: correct the comparison method to treat instructions as the set

2014-02-06 Thread Simon Horman
On Fri, Feb 07, 2014 at 12:41:50PM +0900, Yuichi Ito wrote: > according to OF spec, the instruction is treated as the set. > this means that the order of instructions which flow_stat message returns is > inconstant. > this patch corrects the comparison method of instructions by sorting in a > par

Re: [Ryu-devel] [PATCH] sw test tool: FIX: permit the order different of lists in the case of comparison

2014-02-06 Thread Yuichi Ito
On Fri, 7 Feb 2014 10:04:22 +0900 Simon Horman wrote: > On Fri, Feb 07, 2014 at 09:48:09AM +0900, FUJITA Tomonori wrote: >> On Fri, 07 Feb 2014 09:42:45 +0900 >> Yuichi Ito wrote: >> >>> some switches return the instruction list of flow_mod messages in the >>> different order. >>> >>> for examp

[Ryu-devel] [PATCH 3/3] pbb: add a comment

2014-02-06 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/lib/packet/pbb.py | 1 + 1 file changed, 1 insertion(+) diff --git a/ryu/lib/packet/pbb.py b/ryu/lib/packet/pbb.py index 6e655e9..7892436 100644 --- a/ryu/lib/packet/pbb.py +++ b/ryu/lib/packet/pbb.py @@ -52,6 +52,7 @@ class itag(packet_base.PacketBase):

[Ryu-devel] [PATCH 1/3] run_tests.sh: add of-config-cli to PYLINT_INCLUDE

2014-02-06 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- run_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run_tests.sh b/run_tests.sh index 89153a2..458da62 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -90,7 +90,7 @@ run_tests() { run_pylint() { echo "Running pylint ..." PYLI

[Ryu-devel] [PATCH 2/3] of_config_cli: remove a unused import

2014-02-06 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/cmd/of_config_cli.py | 1 - 1 file changed, 1 deletion(-) diff --git a/ryu/cmd/of_config_cli.py b/ryu/cmd/of_config_cli.py index 04596ac..15f10c7 100755 --- a/ryu/cmd/of_config_cli.py +++ b/ryu/cmd/of_config_cli.py @@ -33,7 +33,6 @@ import lxml.etree as ET

[Ryu-devel] [PATCH] sw test tool: correct the comparison method to treat instructions as the set

2014-02-06 Thread Yuichi Ito
according to OF spec, the instruction is treated as the set. this means that the order of instructions which flow_stat message returns is inconstant. this patch corrects the comparison method of instructions by sorting in a particular order before comparison. Signed-off-by: Yuichi Ito --- ryu/

Re: [Ryu-devel] [PATCH] sw test tool: FIX: permit the order different of lists in the case of comparison

2014-02-06 Thread YAMAMOTO Takashi
> some switches return the instruction list of flow_mod messages in the > different order. > > for example, when a flow entry was installed with the instructions as: > > [ > OFPInstructionMeter(meter_id=1), > OFPInstructionActions(actions=[OFPActionOutput(port=2)]) > ] > > the flow_

Re: [Ryu-devel] [PATCH] sw test tool: FIX: permit the order different of lists in the case of comparison

2014-02-06 Thread Yuichi Ito
On Fri, 7 Feb 2014 11:37:51 +0900 (JST) YAMAMOTO Takashi wrote: >> some switches return the instruction list of flow_mod messages in the >> different order. >> >> for example, when a flow entry was installed with the instructions as: >> >> [ >> OFPInstructionMeter(meter_id=1), >> OFPI

Re: [Ryu-devel] [PATCH] ofctl_v1_3: let action group can be converted to string

2014-02-06 Thread watanabe.fumitaka
Looks good to me. On Fri, 7 Feb 2014 00:06:33 +0800 Wei-Li Tang wrote: > Signed-off-by: Wei-Li Tang > --- > ryu/lib/ofctl_v1_3.py |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ryu/lib/ofctl_v1_3.py b/ryu/lib/ofctl_v1_3.py > index eb9585b..39d1366 100644 > --- a

Re: [Ryu-devel] [PATCH] sw test tool: FIX: permit the order different of lists in the case of comparison

2014-02-06 Thread Yuichi Ito
I will correct the description and repost later. please do not mind this patch. On Fri, 07 Feb 2014 09:42:45 +0900 Yuichi Ito wrote: > some switches return the instruction list of flow_mod messages in the > different order. > > for example, when a flow entry was installed with the instructions

Re: [Ryu-devel] [PATCH] sw test tool: FIX: permit the order different of lists in the case of comparison

2014-02-06 Thread Yuichi Ito
On Fri, 07 Feb 2014 09:48:09 +0900 (JST) FUJITA Tomonori wrote: > On Fri, 07 Feb 2014 09:42:45 +0900 > Yuichi Ito wrote: > >> some switches return the instruction list of flow_mod messages in the >> different order. >> >> for example, when a flow entry was installed with the instructions as: >

Re: [Ryu-devel] [PATCH] sw test tool: FIX: permit the order different of lists in the case of comparison

2014-02-06 Thread Simon Horman
On Fri, Feb 07, 2014 at 09:48:09AM +0900, FUJITA Tomonori wrote: > On Fri, 07 Feb 2014 09:42:45 +0900 > Yuichi Ito wrote: > > > some switches return the instruction list of flow_mod messages in the > > different order. > > > > for example, when a flow entry was installed with the instructions a

Re: [Ryu-devel] [PATCH] sw test tool: FIX: permit the order different of lists in the case of comparison

2014-02-06 Thread FUJITA Tomonori
On Fri, 07 Feb 2014 09:42:45 +0900 Yuichi Ito wrote: > some switches return the instruction list of flow_mod messages in the > different order. > > for example, when a flow entry was installed with the instructions as: > > [ > OFPInstructionMeter(meter_id=1), > OFPInstructionActions(

[Ryu-devel] [PATCH] sw test tool: FIX: return the transaction id when flow entries were deleted

2014-02-06 Thread Yuichi Ito
OfTester._test_initialize() expects the transaction id as a return value of TargetSw.del_test_flow() for checking the error. but this method at current version does not return the transaction id. this patch gets del_test_flow() to return the transaction id. Signed-off-by: Yuichi Ito --- ryu/te

[Ryu-devel] [PATCH] sw test tool: FIX: permit the order different of lists in the case of comparison

2014-02-06 Thread Yuichi Ito
some switches return the instruction list of flow_mod messages in the different order. for example, when a flow entry was installed with the instructions as: [ OFPInstructionMeter(meter_id=1), OFPInstructionActions(actions=[OFPActionOutput(port=2)]) ] the flow_stats message may retu

Re: [Ryu-devel] [PATCH] of12: fix InstructionWriteMetadata json decoder

2014-02-06 Thread FUJITA Tomonori
On Fri, 7 Feb 2014 08:48:30 +0900 FUJITA Tomonori wrote: > Signed-off-by: FUJITA Tomonori > --- > ryu/ofproto/ofproto_v1_2_parser.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied. -- Managing the Pe

[Ryu-devel] [PATCH] of12: fix InstructionWriteMetadata json decoder

2014-02-06 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori --- ryu/ofproto/ofproto_v1_2_parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_2_parser.py b/ryu/ofproto/ofproto_v1_2_parser.py index 359e93c..7e44617 100644 --- a/ryu/ofproto/ofproto_v1_2_parser.py +++ b/ryu/ofpro

Re: [Ryu-devel] [PATCH 1/7] test_ofp_pktinfilter: simplify

2014-02-06 Thread FUJITA Tomonori
On Thu, 6 Feb 2014 15:47:33 +0900 YAMAMOTO Takashi wrote: > stop inheriting RyuApp class to make the implementation of > other tests (tests.cmd.test_manager) easiler. > this module is for packet_in_filter decorator and does not > start ryu app anyway. > > Signed-off-by: YAMAMOTO Takashi > ---

Re: [Ryu-devel] [PATCH] sw test tool: fix wrong match(ipv6_exthdr) value of test file

2014-02-06 Thread FUJITA Tomonori
On Thu, 06 Feb 2014 17:11:56 +0900 "watanabe.fumitaka" wrote: > The value of match(ipv6_exthdr) of the > of13/match/39_IPV6_EXTHDR.json test file is wrong. > The correct value matching to a ipv6(ext_hdrs=[hop_opts,auth]) > is ipv6_exthdr=001000100=68. > This patch corrects it. > > > Signed-of

Re: [Ryu-devel] [PATCH] sw test tool: fix wrong instruction(write metadata) value of test files

2014-02-06 Thread FUJITA Tomonori
On Thu, 06 Feb 2014 17:10:23 +0900 "watanabe.fumitaka" wrote: > The value of instruction(write metadata) of the test file is wrong. > In the table-miss test of of13/match/02_METADATA* test files, > metadata=255 or 240(mask=0xf0) is specified as match. > In order to make it table-miss, it needed

[Ryu-devel] [PATCH] ofctl_v1_3: let action group can be converted to string

2014-02-06 Thread Wei-Li Tang
Signed-off-by: Wei-Li Tang --- ryu/lib/ofctl_v1_3.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/lib/ofctl_v1_3.py b/ryu/lib/ofctl_v1_3.py index eb9585b..39d1366 100644 --- a/ryu/lib/ofctl_v1_3.py +++ b/ryu/lib/ofctl_v1_3.py @@ -173,7 +173,7 @@ def action_to_str(act

Re: [Ryu-devel] Ryu Controller -Group table and Openvswitch

2014-02-06 Thread Alex Tang
Hi, The error message is incomplete, can you provide more details? By the way, group features are not yet supported in the most recent release of OVS (2.0.0). You need to build it from their git repo in order to use group-related commands in OVS. 2014-02-06 21:41 GMT+08:00 bernard niyonteze : >

[Ryu-devel] Ryu Controller -Group table and Openvswitch

2014-02-06 Thread bernard niyonteze
Dear Colleagues , I am new in openflow , and I am not sure if it's possible to use group table features using Ryu controller and Openvswitch. I really want to use group table features but I don't know if it can be done using Ryu controller and Openvswitch. I am trying but I got the following er

[Ryu-devel] [PATCH] sw test tool: fix wrong match(ipv6_exthdr) value of test file

2014-02-06 Thread watanabe.fumitaka
The value of match(ipv6_exthdr) of the of13/match/39_IPV6_EXTHDR.json test file is wrong. The correct value matching to a ipv6(ext_hdrs=[hop_opts,auth]) is ipv6_exthdr=001000100=68. This patch corrects it. Signed-off-by: WATANABE Fumitaka --- ryu/tests/switch/of13/match/39_IPV6_EXTHDR.json |

[Ryu-devel] [PATCH] sw test tool: fix wrong instruction(write metadata) value of test files

2014-02-06 Thread watanabe.fumitaka
The value of instruction(write metadata) of the test file is wrong. In the table-miss test of of13/match/02_METADATA* test files, metadata=255 or 240(mask=0xf0) is specified as match. In order to make it table-miss, it needed to write metadata except 255. Signed-off-by: WATANABE Fumitaka --- r