On Mon, 2022-10-31 at 17:56 -0600, Paul Kasemir wrote:
>
> One more try, can I please get a developer to review:
> https://github.com/sigrokproject/libsigrok/pull/144
There seems to be confusion or uncertainty how to do a review. So
let me outline how it could be done.
In the specific case of PR
On Tue, 2022-11-29 at 09:05 +, Jon Escombe wrote:
>
> On 28/11/2022 23:18, Paul Kasemir wrote:
>
> >Anyone please. What can I do to get my changes reviewed and merged?
>
> [ ... ]
>
> Can only echo everyone else's sentiments, is such a shame that so
> many contributions for new h/w support are
On Fri, 2022-11-18 at 08:05 +, Tony Abbey wrote:
>
> That's a hell of a rant Gerhard, but doesn't answer how a user like myself
> can actually help. [ ... ]
> Can you give me a link to the steps needed to review/approve new code?
> I'm sure many of us would like to help if we knew how, otherwis
> Out of interest, have you tried getting in touch with maintainers on IRC
also?
I have many times, but my connection always times out when using the
browser chat and so I don't know if anyone ever sees or responds to my
requests.
--
Engineering Power - A glowing pool of excellence.
Lets take a
On 28/11/2022 23:18, Paul Kasemir wrote:
Anyone please. What can I do to get my changes reviewed and merged?
Out of interest, have you tried getting in touch with maintainers on IRC
also? Seems a bit unlikely that would be more productive than the
mailing list, but who knows..
Can only ech
Anyone please. What can I do to get my changes reviewed and merged?
On Sat, Nov 19, 2022 at 3:01 PM Paul Kasemir wrote:
> Hmm, it sounds like there is a problem with the project as a whole if
> folks who submit patches can't get them merged. Contributor instructions
> specifically call out sendi
Hmm, it sounds like there is a problem with the project as a whole if folks
who submit patches can't get them merged. Contributor instructions
specifically call out sending patches to the IRC or mailing list, which I
have done, so unless there is another way that is preferred, using the IRC
or ML s
That's a hell of a rant Gerhard, but doesn't answer how a user like myself
can actually help. What is a 'maintainer' for instance?
Can you give me a link to the steps needed to review/approve new code?
I'm sure many of us would like to help if we knew how, otherwise its just a
request for features
On Tue, 2022-11-15 at 08:41 +, Steen Huib (TT-CS/XCT1.2) wrote:
>
> I can see your point and I was thinking about a solution. Are
> there any automated tests or can we create automated tests (not
> specifically on one location as you would need all equipment)
> to secure quality?
Can you also
On Mon, 2022-11-14 at 08:58 -0700, Paul Kasemir wrote:
>
> Getting back to the main point of this thread. Can we get the link MSO-19
> changes reviewed and merged? There is already an unofficial approval
> from @mkj. Not sure how many approvals are needed, but sounds like one more
> approval would
(not me).
>>>> Tony
>>>>
>>>> https://sigrok.org/gitweb/?p=libsigrok.git;a=summary
>>>>
>>>> On Sun, 9 Oct 2022 at 05:30, Chris Dreher
>>>> wrote:
>>>>
>>>>> Guys, Paul has been asking for a PR for 3 weeks.
*Subject:* Re: [sigrok-devel] Can we finally merge
link-mso19 hardware support [PR-144].
Is someone out there? Anyone? I would really like to
get the mso19 support merged, or at least some
comments on
t;> Guys, Paul has been asking for a PR for 3 weeks. Can someone help him?
>>>>
>>>> -Chris
>>>> --------------
>>>> *From:* Paul Kasemir
>>>> *Sent:* Saturday, October 8, 2022 1:41 PM
>>>> *To:* sigrok-devel
Getting back to the main point of this thread. Can we get the link MSO-19
changes reviewed and merged? There is already an unofficial approval
from @mkj. Not sure how many approvals are needed, but sounds like one more
approval would be good.
https://github.com/sigrokproject/libsigrok/pull/144
--
On Tue, 2022-11-08 at 17:23 -0800, Scott Shawcroft wrote:
>
> Has there been any discussion of using a plug-in system for
> decoders and hardware support? That’d remove the need to have
> them all in one repo. We’d just need a pr for the plug-in
> system itself.
Considering that the current userb
Has there been any discussion of using a plug-in system for decoders and
hardware support? That’d remove the need to have them all in one repo. We’d
just need a pr for the plug-in system itself.
Thanks,
Scott
On Tue, Nov 8, 2022, at 4:49 AM, Valerio Messina via sigrok-devel wrote:
> On 11/8/22
On 11/8/22 7:38 AM, Gerhard Sittig wrote:
I don't believe that doing a review requires commit access to a repo
Gerhard I certainly don't want to take control of the project, I'm only
sorry if this excellent project dies.
From the list comments it is evident that what is missing in this
project
On Tue, 2022-11-01 at 10:07 +0100, Valerio Messina wrote:
>
> Should appoint at least two new reviewer with the right of commit,
> or this good project will dead or fork
Fine, if you say it helps: I assign to you the task to review
these submissions. Now go and do it.
And no, I don't believe that
On 11/1/22 9:57 AM, Jorge Solla wrote:
Lots of commits pending :(
Also mine has been hanging there for months.
Unfortunately project seems to bedead?
The situation has been like this for months, current maintenancers
evidently have no time and/or desire to continue development.
Should app
>>> *Sent:* Saturday, October 8, 2022 1:41 PM
>>> *To:* sigrok-devel@lists.sourceforge.net <
>>> sigrok-devel@lists.sourceforge.net>
>>> *Subject:* Re: [sigrok-devel] Can we finally merge link-mso19 hardware
>>> support [PR-144].
>>>
>>&g
> *Sent:* Saturday, October 8, 2022 1:41 PM
>> *To:* sigrok-devel@lists.sourceforge.net <
>> sigrok-devel@lists.sourceforge.net>
>> *Subject:* Re: [sigrok-devel] Can we finally merge link-mso19 hardware
>> support [PR-144].
>>
>> Is someone out there? Anyon
r a PR for 3 weeks. Can someone help him?
>
> -Chris
> --
> *From:* Paul Kasemir
> *Sent:* Saturday, October 8, 2022 1:41 PM
> *To:* sigrok-devel@lists.sourceforge.net <
> sigrok-devel@lists.sourceforge.net>
> *Subject:* Re: [sigrok-devel
Guys, Paul has been asking for a PR for 3 weeks. Can someone help him?
-Chris
From: Paul Kasemir
Sent: Saturday, October 8, 2022 1:41 PM
To: sigrok-devel@lists.sourceforge.net
Subject: Re: [sigrok-devel] Can we finally merge link-mso19 hardware support
[PR-144
Is someone out there? Anyone? I would really like to get the mso19 support
merged, or at least some comments on the PR. Pretty please.
https://github.com/sigrokproject/libsigrok/pull/144
Thanks,
Paul
On Mon, Sep 26, 2022 at 4:20 PM Paul Kasemir wrote:
> Come on guys. Can I please get a review
Come on guys. Can I please get a review for this and merge? I'm a bit
disappointed in the lack of ability to get things reviewed and merged...
Please review https://github.com/sigrokproject/libsigrok/pull/144
Thanks,
Paul
On Wed, Sep 21, 2022 at 9:46 AM Paul Kasemir wrote:
> Why has nobody loo
Why has nobody looked at this yet? Can I get a little help merging this so
I don't have to keep rebasing it forever?
Pretty please review this:
https://github.com/sigrokproject/libsigrok/pull/144
Thanks,
Paul
On Wed, Sep 14, 2022 at 9:23 AM Paul Kasemir wrote:
> I made this PR a long time ago.
I made this PR a long time ago. I've rebased and retested the change and it
still works.
https://github.com/sigrokproject/libsigrok/pull/144
Thanks,
Paul
--
Engineering Power - A glowing pool of excellence.
Lets take a swim.
___
sigrok-devel mailing l
27 matches
Mail list logo
