On Wed, May 9, 2012 at 11:17 AM, Andrew Lunn wrote:
> Replace the deprecated master->transfer with transfer_one_message()
> and allow the SPI subsystem handle all the queuing of messages.
>
> Signed-off-by: Andrew Lunn
Looks good,
Acked-by: Linus Walleij
Thanks
just learned to appreciate.
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discu
uint64_t csena1:1;
> + uint64_t csena2:1;
> + uint64_t csena3:1;
> + uint64_t clkdiv:13;
> + uint64_t reserved_29_63:35;
> +#endif
This boggles my mind, but I see there are many drivers doing this,
> Signed-off-by: Steven King
Looks good to me, the PM runtime stuff could have been in a separate patch
but that's no big deal to me.
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
Live Security Virtual Co
MA2
So must be on ARCH_PRIMA2, but:
grep -r PRIMA2 arch/arm/configs/
So no defconfig can be used to compile this.
If I could just reproduce it, I could fix it...
Barry pls submit a defconfig for the PRIMA2 so we can
compile it and test for regressions.
Yours,
Linus Walleij
to populate empty functions to prevent crashing.
> This patch prevents the call to prepare/unprepare if not populated.
>
> Cc: Linus Walleij
> Signed-off-by: Shubhrajyoti D
Great!
Acked-by: Linus Wallei
ueuing in the driver.
However it seems like the i.MX driver is using bitbanging, which means
you could test Guennadi Liakhovetski's patch converting the bitbang
driver to the central queue.
See subject "[PATCH] spi: bitbang: convert to using core message queue",
consider providing
rgets to optimize and correct this routine. Tested for SPEAr.
>
> Signed-off-by: Viresh Kumar
> Tested-by: Vinit Kamalaksha Shenoy
Looks good to me.
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
Live Securit
if requested freq is higher
> than max possible. But should program it to max possible.
>
> Reported-by: Vinit Kamalaksha Shenoy
> Signed-off-by: Viresh Kumar
Looks reasonable and mostly harmless :-)
Acked-by: Linus Walleij
Yours,
Linus Walleij
---
On Wed, Apr 11, 2012 at 10:56 PM, Guennadi Liakhovetski
wrote:
> Hi Grant
> On Tue, 20 Mar 2012, Grant Likely wrote:
>
>> On Mon, 19 Mar 2012 00:33:14 +0100, Linus Walleij
>> wrote:
>> > On Sat, Mar 17, 2012 at 12:39 AM, Guennadi Liakhovetski
>> > wrote:
.
>
> Also error print message is incorrect, that prints "range is from 1 to
> 16".
>
> Fix both these issues.
>
> Signed-off-by: Vinit Shenoy
> ---
> V1->V2:
> - Fixed the check:
> if (pl022->vendor->max_bpw >= 32)
> - Re-written
On Mon, Apr 2, 2012 at 12:43 PM, Russell King - ARM Linux
wrote:
> On Mon, Apr 02, 2012 at 11:14:28AM +0100, Mark Brown wrote:
>> On Mon, Apr 02, 2012 at 12:39:11AM +0200, Linus Walleij wrote:
>>
>> > Mark: as Rabin says the v1 patch is probably fine, are you pushing this
On Sun, Apr 1, 2012 at 11:27 PM, Mark Brown
wrote:
> On Sun, Apr 01, 2012 at 09:22:50PM +0200, Linus Walleij wrote:
>
>> Combined with the PL022 patch this causes a power regression since
>> the PL022 is hereafter always on.
>
> I guess this code isn't in mainline,
On Sun, Apr 1, 2012 at 9:39 PM, Rabin Vincent wrote:
> On Mon, Apr 2, 2012 at 00:52, Linus Walleij wrote:
>> Combined with the PL022 patch this causes a power regression since
>> the PL022 is hereafter always on.
>
> How can there be a "power regression" here?
much the
same things then nothing is really lost...
And I do like the change, if for nothing else so for the fact that it
eventually pushes to power domains what belongs there, so:
Acked-by: Linus Walleij
But to the defence: power domain code was not in the kernel
when the AMBA "vcore" regula
drivers cannot even
probe) without these regulators in place, so they get enabled by
the AMBA bus code.
So we need something that not just removes stuff from the
AMBA bus, but also adds a better power domain mechanism
and fixes up taking the above regulators.
That said I'm a
; Signed-off-by: Viresh Kumar
Looks reasonable!
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.s
This is great stuff!
Acked-by: Linus Walleij
(Since I've never really used the bitbang driver I wouldn't trust me to
do any deeper review.)
Quick thought:
> +static int spi_bitbang_dummy_prepare(struct spi_master *master)
> +{
> + return 0;
(...)
> +
use the central
message queue, Guennadi can you look into that since you're using it?
The spi-pl022.c and also Samsung spi-s3c64xx.c is converted showing
examples on how go about with that.
Yours,
Linus Walleij
--
Thi
On Wed, Feb 22, 2012 at 10:05 AM, Linus Walleij
wrote:
> From: Linus Walleij
>
> This rips the message queue in the PL022 driver out and pushes
> it into (optional) common infrastructure. Drivers that want to
> use the message pumping thread will need to define the new
> pe
On Wed, Feb 15, 2012 at 11:48 PM, Mark Brown
wrote:
> Convert the s3c64xx driver to using the new message queue factored out of
> the pl022 driver by Linus Walleij, saving us a nice block of code and
> getting the benefits of improvements implemented in the core.
>
> Signed-off
From: Linus Walleij
This rips the message queue in the PL022 driver out and pushes
it into (optional) common infrastructure. Drivers that want to
use the message pumping thread will need to define the new
per-messags transfer methods and leave the deprecated transfer()
method as NULL.
Most of
On Fri, Feb 3, 2012 at 3:03 PM, Linus Walleij
wrote:
> From: Linus Walleij
>
> This rips the message queue in the PL022 driver out and pushes
> it into (optional) common infrastructure. Drivers that want to
> use the message pumping thread will need to define the new
> pe
On Wed, Feb 15, 2012 at 11:48 PM, Mark Brown
wrote:
> Convert the s3c64xx driver to using the new message queue factored out of
> the pl022 driver by Linus Walleij, saving us a nice block of code and
> getting the benefits of improvements implemented in the core.
>
> Signed-off
From: Linus Walleij
This rips the message queue in the PL022 driver out and pushes
it into (optional) common infrastructure. Drivers that want to
use the message pumping thread will need to define the new
per-messags transfer methods and leave the deprecated transfer()
method as NULL.
Most of
y removing the
> non-queued interface. Thoughts?
OK I'll post v2 soon with these changes.
Thanks,
Linus Walleij
--
Try before you buy = See our experts in action!
The most comprehensive online learning library
modes based on transfer size so we do need
> different logic.
Yes atleast for now, I looked at the per-transfer pump we have
but I cannot right now figure out if that part can also be genericizied
so lets do it piecemal.
Fix
From: Linus Walleij
This rips the message queue in the PL022 driver out and pushes
it into (optional) common infrastructure. Drivers that want to
use the message pumping thread will need to select the symbol
SPI_MASTER_QUEUE and implement three methods in place for the
current transfer() method
From: Linus Walleij
This splits the spi_register_master() function in two parts,
easing the addition of a queued master and making the code
somewhat easier to read.
Cc: Mark Brown
Signed-off-by: Linus Walleij
---
drivers/spi/spi.c | 74
priority elevation for
a certain PL022 port can be requested from platform data.
Cc: Mark Brown
Acked-by: Viresh Kumar
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c| 77 +--
include/linux/amba/pl022.h |3
From: Linus Walleij
This is a patch series based on a suggestion from Mark Brown
to make the message queueing found in PL022 more general.
[1/3] is just the same minor update to the PL022 driver
that was discussed before (I hope this can atleast go in).
[2/3] refactors the master registration
On Wed, Jan 25, 2012 at 3:02 PM, Mark Brown wrote:
> On Tue, Jan 24, 2012 at 10:14:32PM +0100, Linus Walleij wrote:
>> This switches the PL022 worker to a kthread in order to get
>> hold of a mechanism to control the message pump priority. On
>> low-latency systems elevatin
priority elevation for
a certain PL022 port can be requested from platform data.
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c| 77 +--
include/linux/amba/pl022.h |3 ++
2 files changed, 55 insertions(+), 25
On Wed, Jan 18, 2012 at 1:30 PM, Russell King - ARM Linux
wrote:
> On Wed, Jan 18, 2012 at 01:13:29PM +0100, Linus Walleij wrote:
>> We usually merge drivers for microwire, TI, Motorola ... etc into
>> drivers/spi as well. It's a good enough fit, the differences are very
>
On Wed, Jan 18, 2012 at 1:13 PM, Linus Walleij wrote:
> On Wed, Jan 18, 2012 at 12:13 AM, Russell King - ARM Linux
> wrote:
>
>> The SSP interface is more than just SPI (it's microwire and TI format,
>> and I have a working ASoC driver for the Assabet.)
>
> We usu
top of your patch
stack so as not to disrupt addition of new functionality. It'd be nice
if you could make the branch available once you push that stuff
to -next.
Yours,
Linus Walleij
--
Keep Your Developer Skills Current wi
cross transfers found in jornada720_ssp is probably
not going to play well with the SPI subsystem so this has
been replaced by a mutex.
Cc: Kristoffer Ericson
Cc: Nicolas Pitre
Cc: Russell King
Signed-off-by: Linus Walleij
---
arch/arm/include/asm/hardware/ssp.h| 28 --
arch/
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Grant,
can you please pull in my PL022 patch stack that has been floated
on the list recently into your SPI for-next branch?
Thanks!
Linus Walleij
The following changes since commit caca6a03d365883564885f2c1da3e88dcf65d139:
Linux 3.2-rc3
tered.
>
> Fix this by registering devices as direct children of the bus master.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Linus Walleij
Thanks,
Linus Walleij
--
Systems Optimization Self Assessment
Improv
No I just added them to my branch and waited for Grant to get
back online.
The patches and ACKs are accumulated on this branch:
git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-stericsson.git pl022
If you want to make a huge bundle to send to Grant, please pull
this into your
I would have put the patch in and see if somebody screams ...
Linus Walleij
--
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
di
ce the pattern is clearly visible.
I agree with this. I will go forward in the same manner with
Ux500 for the time being.
Thanks,
Linus Walleij
--
Cloud Services Checklist: Pricing and Packaging Optimization
This white pap
or the day one of these devices turn up in two platforms:
one using central clock management and one using
distributed clock management ...
Yours,
Linus Walleij
--
All the data continuously generated in your IT i
ster->dev;
Just my €0.01...
Yours,
Linus Walleij
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity,
affected transfer but since we're in master mode it's very
> difficult to trigger errors at present and this code is much simpler.
>
> Signed-off-by: Mark Brown
Looks good to me:
Acked-by: Linus Walleij
(Cc:i
On Tue, Nov 22, 2011 at 9:28 AM, Viresh Kumar wrote:
> On 11/22/2011 1:55 PM, Linus WALLEIJ wrote:
>> if (list_empty(&pl022->queue) || !pl022->running) {
>> + if (pl022->busy) {
>> + pm_runtime_put(&pl022->adev->
autosuspend timeout, the call to resume the device can return
immediately rather than needing to risk sleeping in order to resume
the device.
Reviewed-by: Viresh Kumar
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Add Viresh's Reviewed-by
---
drivers/spi/spi
: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 72 ---
1 files changed, 37 insertions(+), 35 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 13988a3..1cff8ad 100644
--- a/drivers
From: Virupax Sadashivpetimath
Make sure we clear the enable bit when the block is not used.
This will save some energy in certain hardware versions.
Reviewed-by: Viresh Kumar
Signed-off-by: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Move this patch af
s now.
Signed-off-by: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Use local dev pointer instead of copy/paste bug &adev->dev
---
drivers/spi/spi-pl022.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/
.
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Moved this patch before the block disable patch at request from
Viresh.
- Insert blank line...
---
drivers/spi/spi-pl022.c | 26 +-
1 files changed, 17 insertions(+), 9 deletions(-)
diff --
From: Chris Blair
For interrupt mode transfers, start with only TX interrupts enabled
to reduce the overall number of interrupts received. Once TX is
complete, enable RX interrupts to complete the transfer.
Reviewed-by: Viresh Kumar
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
From: Jonas Aaberg
The driver build complains with newer compilers unless you
initialize this struct properly.
Reviewed-by: Viresh Kumar
Signed-off-by: Jonas Aaberg
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Add Viresh's Reviewed-by
---
drivers/spi/spi-pl022.c |2 +-
: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 72 ---
1 files changed, 37 insertions(+), 35 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 13988a3..1cff8ad 100644
--- a/drivers
On Wed, Nov 9, 2011 at 11:55 AM, Viresh Kumar wrote:
> On 11/9/2011 4:09 PM, Linus WALLEIJ wrote:
>>
>> - amba_vcore_enable(pl022->adev);
>> - amba_pclk_enable(pl022->adev);
>> - load_ssp_default_config(pl022);
>> - amba_pclk_disable(pl022-&g
autosuspend timeout, the call to resume the device can return
immediately rather than needing to risk sleeping in order to resume
the device.
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c| 20 ++--
include/linux/amba/pl022.h |4
2
.
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 33 +++--
1 files changed, 19 insertions(+), 14 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index bffad2a..2e3522d 100644
--- a/drivers/spi/spi-pl022.c
From: Virupax Sadashivpetimath
Make sure we clear the enable bit when the block is not used.
This will save some energy in certain hardware versions.
Signed-off-by: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |5 +
1 files changed, 5 insertions
s now.
Signed-off-by: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index fa3eaae..bffad2a 100644
--- a/drivers/spi/spi-pl022.c
+++ b/dr
From: Jonas Aaberg
The driver build complains with newer compilers unless you
initialize this struct properly.
Signed-off-by: Jonas Aaberg
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-pl022
From: Linus Walleij
This set consists of the previously submitted patches [1/6]
thru [4/6] rebased on top of v3.2-rc1 and two new patches
from Chris [5/6] and [6/6].
There is a pending clk_enable fix in Russell's tree but I don't
think these patches collide with that fix.
Chri
From: Chris Blair
For interrupt mode transfers, start with only TX interrupts enabled
to reduce the overall number of interrupts received. Once TX is
complete, enable RX interrupts to complete the transfer.
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c
On Thu, Nov 3, 2011 at 4:55 PM, Ulf Hansson wrote:
> Make sure we enable the clock before leaving probe.
>
> Signed-off-by: Ulf Hansson
> ---
>
> Changes in v2:
> -Remove runtime_idle
Looking good
Acked-by: Linus Walleij
Please put this v2 in Rus
I'm not planning to
> apply it yet because it depends on two branches in my tree (amba and clk).
We can fixup that in the aftermath of the merge window, no
hurries.
Yours,
Linus Walleij
--
The demand for IT
tches are merged, so put this in Russell's
patch tracker so he can put it on his AMBA PM branch.
But looks correct.
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
The demand for IT networking professionals continues to
On Thu, Oct 6, 2011 at 9:03 AM, Linus Walleij
wrote:
> From: Chris Blair
>
> The PL022 is used in performance-critical applications where we
> need soft realtime response from the SPI data pipe. Elevating the
> workqueue to realtime has been proven to improve response times
s now.
Signed-off-by: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 0a1d8ed..29dc70f 100644
--- a/drivers/spi/spi-pl022.c
+++ b/dr
From: Virupax Sadashivpetimath
Make sure we clear the enable bit when the block is not used.
This will save some energy in certain hardware versions.
Signed-off-by: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |7 ++-
1 files changed, 6
From: Jonas Aaberg
The driver build complains with newer compilers unless you
initialize this struct properly.
Signed-off-by: Jonas Aaberg
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-pl022
2011/10/5 Dave Martin :
> Signed-off-by: Dave Martin
> ---
> drivers/spi/spi-pl022.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Acked-by: Linus Walleij
Thanks,
Linus Walleij
--
[Commit message written by me]
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 4761b31..debdaeb 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022
From: Chris Blair
For interrupt mode transfers, start with only TX interrupts enabled
to reduce the overall number of interrupts received. Once TX is
complete, enable RX interrupts to complete the transfer.
Signed-off-by: Chris Blair
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c
On Wed, Sep 21, 2011 at 3:10 PM, Russell King - ARM Linux
wrote:
> On Tue, Sep 20, 2011 at 10:45:41PM +0200, Linus Walleij wrote:
>> > Grant can you please apply this patch? Right now linux-next is
>> > breaking because of this missing patch...
>>
>> Ping on t
On Mon, Sep 5, 2011 at 2:45 PM, Linus Walleij wrote:
> On Sun, Aug 28, 2011 at 9:26 PM, Peter Huewe wrote:
>
>> This patch fixes a build error, introduced by commit (67fc8b9f, "PM: add
>> runtime PM support to core Primecell driver") which unfortunately was a
>>
I'm not sure how this patch could have been tested back then, if it
> doesn't even compile ;)
Grant can you please apply this patch? Right now linux-next is
breaking because of this missing patch...
Thanks,
Linus Walleij
-
tive_freq() routine
>> - Allocate/free DMA channels as and when required.
>>
>
> Grant,
>
> Did you already pushed this patchset?
> There are few concerns on PATCH 6/6 and i am not sure if there are any
> decisions
> on it.
> @Linus: What do you say?
I agre
pend' undeclared here
> (not in a function)
>
> The build failure appears e.g. for the u8500 and realview defconfig.
>
> LinuxVersion: linux next-20110826
>
> Signed-off-by: Peter Huewe
Acked-by: Linus Walleij
Thanks!
Linus Walleij
---
setup).
> Tell me 1 reason why using strings, in this case, would be better ?
I have no other reasons than the above.
People like Russell (clkdevice) and Liam Girdwood (regulator)
who I know are smarter than me and have worked with
2011/8/10 Jassi Brar :
> On Wed, Aug 10, 2011 at 5:24 PM, Linus Walleij
> wrote:
>>> Linus W, was there anything you said wouldn't work with the scheme ?
>>> Please tell now on the record.
>>
>> It would *work* but the current proposal is *not elegant* IM
ecases we have today. mem2mem could
use the old request function and doesn't need anything
like this.
Pros: well established design pattern, channels tied to
devices, intuitive for anyone who used clock or
regulator frameworks.
If the majority is happy with this scheme I can even
try impl
2011/8/10 viresh kumar :
> On 08/10/2011 01:40 AM, Linus Walleij wrote:
>>
>> They all work perfectly well on top of v3.1-rc1, please use
>> mainline kernel tags as patch base if you can.
>
> Sure, can take care of this. But i have a doubt here,
> What if a patch
red.
Excellent work Viresh, apart from the small comment on 4/6
they all look good.
I also tested them all on the U300, works perfectly.
Please fixup 4/6 and respin with my:
Tested-by: Linus Walleij
So that Grant can pick them up.
> I have rebased them on linux-next/master over following
tems we mainly use IRQ-driven traffic. I need to have these
tests added I believe :-/
If you fix this up it will be much appreciated!
Thanks,
Linus Walleij
--
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The
.
> Which gives following crash logs:
What happens if you replace it with GFP_NOWAIT?
That should work for everybody.
Or you could remove the tasklet allover and replace it with a workqueue.
> Is DMA mode working in your case?
Yes, magi
From: Linus Walleij
The remove function in the PL022 driver cannot abort the remove
function any way, so restructure the code so as not to make that
assumption. Remove will now proceed no matter whether it can
stop the transfer queue or not.
Reported-by: Russell King
Signed-off-by: Linus
On Thu, Jun 16, 2011 at 2:22 PM, Grant Likely wrote:
> On Thu, Jun 16, 2011 at 10:14:54AM +0200, Linus Walleij wrote:
>> From: Linus Walleij
>>
>> The U300 just defined the fill level limits for the FIFOs to
>> 1 item out of habit. It can easily handle four.
>>
From: Linus Walleij
The U300 just defined the fill level limits for the FIFOs to
1 item out of habit. It can easily handle four.
Signed-off-by: Linus Walleij
---
arch/arm/mach-u300/spi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-u300/spi.c b
From: Linus Walleij
The platform configuration can select custom FIFO watermarks, but
these may conflict the actual FIFO size of the PL022 variant if
set too high. So strengthen the sanity checks to deny any
conflicting settings.
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 48
]
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index ac7c727..48fa8b0 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -40,6 +40,7
From: Linus Walleij
Configure the DMA burstsize from the FIFO trigger level supplied
with the controller configuration data. This is based on a patch
from Virupax, but I rewrote it differently.
Reported-by: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c
On Mon, Jun 13, 2011 at 5:08 PM, Grant Likely wrote:
> On Mon, Jun 13, 2011 at 04:23:46PM +0530, Virupax Sadashivpetimath wrote:
>> Return error on out of range cpsdvsr value.
>>
>> Acked-by: Linus Walleij
>> Signed-off-by: Virupax Sadashivpetimath
>>
>
&
t;periphid = periphid;
dev->dev.platform_data = pdata;
ret = amba_device_register(dev, &iomem_resource);
if (ret) {
kfree(dev);
return ERR_PTR(ret);
}
return dev;
}
I'd recommend coming up with some clev
or
> not, and how much work is needed. I would like some comments from Hartley and
> Ryan also.
Sure.
Thanks,
Linus Walleij
--
vRanger cuts backup time in half-while increasing security.
With the market-leading sol
x27;s IMO at first sight no more deviant than our "PL023"
variants that still use the same pl022 driver.
Is there some inexepensive hardware with EP93xx I can get to fix this
myself?
Yours,
Linus Walleij
--
vRang
2011/5/19 Vitaly Wool :
> On Thu, May 19, 2011 at 7:36 PM, Linus Walleij
> wrote:
>>>
>>> just out of curiosity: is it a busy wait? Looks like it is...
>>
>> Yep that's the polling mode part. IRQ and DMA mode should
>> be the norm I guess.
>>
This relaxes the cpu in the polling busy-wait loop.
Reported-by: Vitaly Wool
Signed-off-by: Linus Walleij
---
drivers/spi/amba-pl022.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
index 18667de..8a2b88a 100644
message->state = STATE_ERROR;
>> + goto out;
>> + }
>> + }
>
> just out of curiosity: is it a busy wait? Looks like it is...
Yep that's the polling mode
From: Magnus Templing
This adds the missing handling of polling timeouts and deletes
our last todo.
Signed-off-by: Magnus Templing
Reviewed-by: Srinidhi Kasagar
[Fixups from review by Wolfram Sang]
Signed-off-by: Linus Walleij
---
drivers/spi/amba-pl022.c | 23 +++
1
message->state = STATE_ERROR;
>> + goto out;
>> + }
>> readwriter(pl022);
>> + }
What about we move readerwriter() above if (time_after...) then it atleast
gets one chance to run even if we'r
This driver has no TODO, and is now used on several platforms:
ARM, U300, Ux500, SPEAr and more. So drop the EXPERIMENTAL
requirement.
Signed-off-by: Linus Walleij
---
drivers/spi/Kconfig |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/Kconfig b/drivers
101 - 200 of 310 matches
Mail list logo
