With device core now able to setup the default pin configuration,
the pin configuration code based on the deprecated Samsung specific
gpio bindings is removed.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
.../devicetree/bindings/spi/spi-samsung.txt|8 +--
drivers/spi
On 14 August 2012 03:14, Guenter Roeck li...@roeck-us.net wrote:
Hi all,
looking through SPI master drivers, I noticed that the following drivers call
spi_master_get() in their suspend and resume functions. Yet, there is no
matching call to spi_master_put(), meaning the reference count will
On 13 July 2012 16:58, Kukjin Kim kgene@samsung.com wrote:
Thomas Abraham wrote:
On 13 July 2012 04:08, Kukjin Kim kgene@samsung.com wrote:
Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems occur
following build error with s3c6400_defconfig.
drivers/spi/spi
On 13 July 2012 19:12, Kukjin Kim kgene@samsung.com wrote:
Thomas Abraham wrote:
On 13 July 2012 16:58, Kukjin Kim kgene@samsung.com wrote:
Thomas Abraham wrote:
On 13 July 2012 04:08, Kukjin Kim kgene@samsung.com wrote:
Thomas, the DMACH_DT_PROP is available only on pl330
On 11 July 2012 23:30, Thomas Abraham thomas.abra...@linaro.org wrote:
On 11 July 2012 23:19, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote:
Changes since v4:
- Includes the missing gpio request for slave select line gpio
On 12 July 2012 18:32, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Thu, Jul 12, 2012 at 06:11:05PM +0900, Kukjin Kim wrote:
And Mark, this touches various samsung stuff in arch/arm/ so if you're ok,
I'd like to pick this up in samsung tree. We don't want to see conflicts...
On 13 July 2012 04:08, Kukjin Kim kgene@samsung.com wrote:
Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems occur
following build error with s3c6400_defconfig.
drivers/spi/spi-s3c64xx.c: In function 's3c64xx_spi_get_dmares':
drivers/spi/spi-s3c64xx.c:1098: error:
and replaced with call to gpio_set_value in the driver.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |2 -
drivers/spi/spi
Add support for device based discovery.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
.../devicetree/bindings/spi/spi-samsung.txt| 113 +++
drivers/spi/spi-s3c64xx.c
On 11 July 2012 17:17, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote:
The set_level callback in the controller data, which is used to configure
the slave select line, cannot be supported when migrating the driver to
device
Changes since v4:
- Includes the missing gpio request for slave select line gpio as suggested
by Mark Brown.
Changes since v3:
- Fixed the build breakage after applying 3rd patch in this series (which
had dependency on the 6th patch). This was reported by Doug Anderson.
Changes since v2:
-
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
drivers/spi/spi-s3c64xx.c |4
1 files changed, 0
and replaced with call to gpio_set_value in the driver.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |2 -
drivers/spi/spi
The platform data pointer that is passed to the spi gpio setup functions
is not used. Hence, this parameter is removed from all the spi gpio setup
functions.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
---
arch/arm/mach-exynos
-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
arch/arm/mach-exynos/clock-exynos4.c | 18 ++--
arch/arm/mach-exynos/setup-spi.c | 25
arch/arm/mach-s3c24xx
Add support for device based discovery.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
.../devicetree/bindings/spi/spi-samsung.txt| 113
drivers/spi/spi-s3c64xx.c
With the spi controller hardware configuration moved into the driver data, there
are no more default hardware configuration data that is passed through platform
data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to
these changes.
Signed-off-by: Thomas Abraham thomas.abra
On 11 July 2012 19:01, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote:
Based on your comments to add the gpio request, only two patches 5/6
and 6/6 in this series have changed since. I have cc'ed you in the
other 4 patches
On 11 July 2012 23:19, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote:
Changes since v4:
- Includes the missing gpio request for slave select line gpio as suggested
by Mark Brown.
These looked OK (and have had quite
With the spi controller hardware configuration moved into the driver data, there
are no more default hardware configuration data that is passed through platform
data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to
these changes.
Signed-off-by: Thomas Abraham thomas.abra
and replaced with call to gpio_set_value in the driver.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |2 --
drivers/spi/spi
Add support for device based discovery.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
.../devicetree/bindings/spi/spi-samsung.txt| 113
drivers/spi/spi-s3c64xx.c
.html
Thomas Abraham (6):
spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro
spi: s3c64xx: move controller information into driver data
ARM: Samsung: Remove pdev pointer parameter from spi gpio setup functions
ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function
spi: s3c64xx
-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
arch/arm/mach-exynos/clock-exynos4.c | 18 ++--
arch/arm/mach-exynos/setup-spi.c | 25
arch/arm/mach-s3c24xx
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
drivers/spi/spi-s3c64xx.c |4
1 files changed, 0
The platform data pointer that is passed to the spi gpio setup functions
is not used. Hence, this paremeter is removed from all the spi gpio setup
functions.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
---
arch/arm/mach-exynos
On 10 July 2012 20:08, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote:
The set_level callback in the controller data, which is used to configure
the slave select line, cannot be supported when migrating the driver to
device
On 10 July 2012 22:27, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote:
In non-dt case, the platform code supplying the gpio number (slave
select line) is responsible for requesting the gpio during the
machine_init call. So
On 1 June 2012 18:09, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Fri, Jun 01, 2012 at 10:47:44AM +0800, Thomas Abraham wrote:
1. There is one instance of 'struct platform_device' for each of the
spi controller instances (0/1/2) named s3c64xx-spi (in
arch/arm/plat-samsung/devs.c
On 30 May 2012 15:28, Olof Johansson o...@lixom.net wrote:
On Sun, May 20, 2012 at 2:21 AM, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote:
- s3c64xx_spi0_set_platdata(s3c64xx_spi0_pdata, 0, 1
Hi Olof,
On 30 May 2012 15:23, Olof Johansson o...@lixom.net wrote:
Hi,
Some comments below.
On Tue, May 8, 2012 at 3:04 PM, Thomas Abraham
thomas.abra...@linaro.org wrote:
Platform data is used to specify controller hardware specific information
such as the tx/rx fifo level mask and bit
On 30 May 2012 17:34, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, May 30, 2012 at 12:28:55AM -0700, Olof Johansson wrote:
On Sun, May 20, 2012 at 2:21 AM, Mark Brown
This dev_name also isn't equivalent to dev_name() which makes matters
more confusing than they need to be.
On 30 May 2012 18:13, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, May 30, 2012 at 06:05:31PM +0800, Thomas Abraham wrote:
On 30 May 2012 17:34, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
Right, and there's no problem at all with using the name. The thing
On 24 May 2012 12:48, Kukjin Kim kgene@samsung.com wrote:
Thomas Abraham wrote:
Platform data is used to specify controller hardware specific information
such as the tx/rx fifo level mask and bit offset of rx fifo level. Such
information is not suitable to be supplied from device tree
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
---
drivers/spi/spi-s3c64xx.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/spi
The platform data pointer that is passed to the spi gpio setup functions
is not used. Hence, this paremeter is removed from all the spi gpio setup
functions.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
---
arch/arm/mach-exynos
and replaced with call to gpio_set_value in the driver.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
---
arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |2 --
drivers/spi/spi-s3c64xx.c|8
2
With the spi controller hardware configuration moved into the driver data, there
are no more default hardware configuration data that is passed through platform
data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to
these changes.
Signed-off-by: Thomas Abraham thomas.abra
Add support for device based discovery.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
---
.../devicetree/bindings/spi/spi-samsung.txt| 113
drivers/spi/spi-s3c64xx.c | 277
-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
---
arch/arm/mach-exynos/clock-exynos4.c | 18 +-
arch/arm/mach-exynos/setup-spi.c | 25 ---
arch/arm/mach-s3c24xx/clock-s3c2416.c|2 +-
arch/arm/mach
On 9 May 2012 16:52, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote:
With the addition of platform specific driver data in the spi-s3c64xx
driver, the device name of spi controllers are changed. Accordingly,
update
On 9 May 2012 17:07, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote:
+- gpios: The gpio specifier for clock, mosi and miso interface lines (in no
+ particular order). The format of the gpio specifier depends on the gpio
On 9 May 2012 22:33, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, May 09, 2012 at 10:22:26PM +0800, Thomas Abraham wrote:
On 9 May 2012 18:55, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
Yes, that's the normal way of handling this and is actually what the
code
On 9 May 2012 22:28, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Wed, May 09, 2012 at 09:40:26PM +0800, Thomas Abraham wrote:
On 9 May 2012 16:52, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
This should've been squashed into the patch that updated to use driver
data
On 10 May 2012 00:47, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Thu, May 10, 2012 at 12:39:29AM +0800, Thomas Abraham wrote:
On 9 May 2012 22:32, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
Yeah, I know. I'm saying we should try to come up with a binding
...@linaro.org
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/mach-s3c64xx/mach-crag6410.c|2 +-
arch/arm/plat-samsung/devs.c | 50 -
arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |6 +-
3 files changed, 23 insertions
With the addition of platform specific driver data in the spi-s3c64xx
driver, the device name of spi controllers are changed. Accordingly,
update the device name of spi clocks instances.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/mach-exynos/clock-exynos4.c | 18
The platform data pointer that is passed to the spi gpio setup functions
is not used. Hence, this paremeter is removed from all the spi gpio setup
functions.
Cc: Jaswinder Singh jaswinder.si...@linaro.org
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/mach-exynos/setup
for the sclk_spi clock.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/mach-exynos/clock-exynos4.c | 48 -
1 files changed, 40 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-exynos/clock-exynos4.c
b/arch/arm/mach-exynos/clock-exynos4.c
index
Add support for clock instances for each spi controller.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/mach-exynos/clock-exynos5.c | 98
arch/arm/mach-exynos/include/mach/regs-clock.h |4 +
2 files changed, 102 insertions(+), 0
Add support for device based discovery.
Cc: Jaswinder Singh jaswinder.si...@linaro.org
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
.../devicetree/bindings/spi/spi-samsung.txt| 113
drivers/spi/spi-s3c64xx.c | 277 +---
2
51 matches
Mail list logo
