[PATCH] Enhanced access logging, added ICAP logging, bug #2459 fix version2

2009-07-10 Thread Tsantilas Christos
Changes over the v1 patch: changes: - src/AccessLogEntry.h: struct IpAddress - IpAddress - access log code: * adaptation:: to adapt:: * icap::total_time - icap::tt * icap::size - icap::st * icap::size - icap::st * int the case of use of

Re: [PATCH] Enhanced access logging, added ICAP logging, bug #2495 fix.

2009-07-10 Thread Tsantilas Christos
Hi Amos, I post the new patch. I think I made most of the changes you are requested. I did not do the following changes: ** Please make fqdncache_entry / ipcache_entry public classes instead of functional structs. Some gcc complain and doxygen won't document their functions properly.

Re: [PATCH] Enhanced access logging, added ICAP logging, bug #2495 fix.

2009-07-10 Thread Tsantilas Christos
I am committing a version 3 of the patch. Amos Jeffries wrote: Tsantilas Christos wrote: Alex Rousskov wrote: On 07/09/2009 12:06 AM, Amos Jeffries wrote: Tsantilas Christos wrote: ** Please make fqdncache_entry / ipcache_entry public classes instead of functional structs. Some gcc

[PATCH] chunked requests

2009-07-07 Thread Tsantilas Christos
Hi all, Alex ask me to separate chunked request patch from icap access logging patch as requested by Amos. This is the chunked request patch developed by Alex. Christos === modified file 'src/HttpMsg.cc' --- src/HttpMsg.cc 2009-02-02 12:50:23 + +++ src/HttpMsg.cc 2009-07-06 20:28:38

[PATCH] Enhanced access logging, added ICAP logging, bug #2495 fix.

2009-07-07 Thread Tsantilas Christos
This is the second part of the 3p1-plus patch. This patch include: - Enhanced access logging (Hs, sh, sh, pt, tt, icap::total_time, and icap::last_h) - ICAP logging (see icap_log and log_icap in squid.conf as well as http://wiki.squid-cache.org/Features/AdaptationLog). - ICAP

Re: linking fs code problems in trunk

2009-03-31 Thread Tsantilas Christos
Hi, I am attaching a new patch, which: - Add the files fs/Module.cc,h similar to esi/Module.cc - Build a new library libfs.a - The fs/aufs/StoreFSaufs.cc, fs/diskd/StoreFSdiskd.cc and fs/ufs/StoreFSufs.cc now contain just fake pointers - The FS::Init() method used to build ufs, aufs and

Re: linking fs code problems in trunk

2009-03-31 Thread Tsantilas Christos
Alex Rousskov wrote: * Do we really need those static *_foo variables in fs/*/StoreFs*.cc files? They are unused, right? Why not delete them? Not really needed. It is just to have something inside fs/*/StoreFs*.cc files. These files can completely removed, but it will break the way we are

Re: linking fs code problems in trunk

2009-03-31 Thread Tsantilas Christos
Amos Jeffries wrote: Two notes: * please make the new Namespace CamelCased properly. for now: namespace Fs done. * the comments about creating libfs in src/fs/Makefile.am can now die too. done * please add any TODOs about COSS either to the new file as a code comment, or the COSS

linking fs code problems in trunk

2009-03-28 Thread Tsantilas Christos
Hi all, Currently the fs related subsystem is broken in trunk, because of the known linking problems. I am proposing the attached patch which: - modifies the configure.in script to define in autoconf.h file the HAVE_FS_UFS, HAVE_FS_AUFS, HAVE_FS_DISKD and HAVE_FS_COSS if the modules

Re: current state of bzr repository

2009-03-25 Thread Tsantilas Christos
Amos Jeffries wrote: - src/Debug.h The HERE macro is wrong. The original one was not bad Original one sometimes left strings with confidential build info in other peoples cache.log We spent a long while covering the possibilities to get the current one. If you'd like to trace down

Re: current state of bzr repository

2009-03-24 Thread Tsantilas Christos
Sorry Amos I did not found the time for the changes. The day does not have enough hours I will have time tomorrow.

current state of bzr repository

2009-03-23 Thread Tsantilas Christos
Hi all, Currently the squid-trunk in bzr repository can not run, and can not compile at all. I am attaching a patch which shows some of the problems and proposes possible fixes: - src/ip/IpIntercept.h file the PfInterception method has wrong definition - src/ip/IpIntercept.cc

Re: /bzr/squid3/trunk/ r9573: SourceLayout: acl/, take 1

2009-03-14 Thread Tsantilas Christos
Hi, maybe the use of static libraries is not good idea. Currently I am not able to correctly linking the squid3. The linker will not include in main executable file important obj's. For example will not include the acl/Source.o file (included in library acl/libacls.a). This is because there

Re: /bzr/squid3/trunk/ r9532: Regression Fix: Bug 2586: Memory leaks on reconfigure

2009-02-24 Thread Tsantilas Christos
Alex Rousskov wrote: On 02/23/2009 05:28 PM, Amos Jeffries wrote: Sigh, another design flaw in the current config handling. Exactly how are they in use, and which ones? NP: reconfigure and shutdown both call the free-up after all client connections are supposed to be dead. And all non-memory

Re: Squid 3.1.0.2 problem with ICAP Posst method data

2009-02-12 Thread Tsantilas Christos
Hi, Your icap response is wrong. The Encapsulated header: Encapsulated: req-hdr=0, null-body=536 Should be something like: Encapsulated: req-hdr=0, req-body=536 Regards, Christos Moshe Beeri wrote: Hi All, I am interfacing disturbing problem with squid 3.1 ICAP. I seems that

Re: Major memory leak in DeferredRead

2009-02-11 Thread Tsantilas Christos
Hi Amos, Is there any definitely lost record? Amos Jeffries wrote: We seem to have tracked the major leak ( ~1MB per request) down to these: mem_obj-delayRead(DeferredRead(DeferReader, this, CommRead(fd, buf, len, callback))); Which generate: ==21688== 1,251,224 bytes in 12,031

Re: Memory leak in ICAPXaction

2009-02-11 Thread Tsantilas Christos
Hi Amos, Amos Jeffries wrote: Further to the major memory leaks found by Steinar H. Gunderson This is also popping out, and very confusing since ICAPXaction global is only created once right? it is the new PconnPool line. It is create only once. It says its reachable because the time

votes..

2009-02-11 Thread Tsantilas Christos
May I ask, about the votes, which is the procedure? Who is giving access to bundlebuggy? Or it is something I do not need it?

Re: votes..

2009-02-11 Thread Tsantilas Christos
Robert Collins wrote: On Wed, 2009-02-11 at 23:20 +0200, Tsantilas Christos wrote: May I ask, about the votes, which is the procedure? Who is giving access to bundlebuggy? Or it is something I do not need it? I can add users, but I don't consider myself the decider - rather the community here

Re: /bzr/squid3/trunk/ r9485: Author: Brad Smith b...@comstyle.com

2009-02-07 Thread Tsantilas Christos
Hi, Why we need autoconf 2.62 to build squid3? It builds well at least with autoconf 2.61 and 2.59 I am using Amos Jeffries wrote: revno: 9485 committer: Amos Jeffries squ...@treenet.co.nz branch nick: trunk timestamp: Sat

Re: [MERGE] First string-fix merge

2009-01-31 Thread Tsantilas Christos
Hi Francesco, I have some problems trying to compile the string-fix branch. with --enable-icap-client I am getting: ICAPOptions.cc: In member function ‘bool ICAPOptions::TransferList::matches(const String) const’: ICAPOptions.cc:179: error: passing ‘const String’ as ‘this’ argument of

Re: /bzr/squid3/trunk/ r9462: The idnsSentQueryVC function called as AsyncCall. There is the possibility

2009-01-28 Thread Tsantilas Christos
Henrik Nordstrom wrote: ons 2009-01-28 klockan 20:26 +0200 skrev Tsantilas Christos: My question is which is the normal procedure about applying such patches? Should I open a bug report about possible bug? I am just applying the patch and you are deciding if it should be applied to squid

Re: bzr commit fail

2009-01-27 Thread Tsantilas Christos
Thank you Henrik, it is OK now. Henrik Nordstrom wrote: lör 2009-01-24 klockan 19:16 +0200 skrev Tsantilas Christos: I am trying to commit on squid3 trunk but I am getting the folllowing error: bzr: ERROR: Cannot lock LockDir(chroot-141862124:///bzr/squid3/trunk/.bzr/branch/lock

bzr commit fail

2009-01-24 Thread Tsantilas Christos
Hi , I am trying to commit on squid3 trunk but I am getting the folllowing error: bzr: ERROR: Cannot lock LockDir(chroot-141862124:///bzr/squid3/trunk/.bzr/branch/lock): Permission denied: /bzr/squid3/trunk/.bzr/branch/lock/l5wgxq43jg.tmp:[Errno 13] Permission denied:

Re: Buffer/String split, take2

2009-01-22 Thread Tsantilas Christos
Kinkie wrote: On Wed, Jan 21, 2009 at 7:19 PM, Tsantilas Christos chtsa...@users.sourceforge.net wrote: Hi all, I believe that the DC design is better than Universal Buffer because of many reasons. My sense is that the Universal Buffer will be very complex and will not have the desired results

Re: Buffer/String split, take2

2009-01-21 Thread Tsantilas Christos
Hi all, I believe that the DC design is better than Universal Buffer because of many reasons. My sense is that the Universal Buffer will be very complex and will not have the desired results, because the real problems exist in other subsystems (eg parsers). But if choosing the DC design

RE: ICAP, bypassing respmod depending reqmod result

2008-12-02 Thread Tsantilas Christos
Moshe Beeri wrote: Hi, I am trying to add extension to ICAP layer in squid 3.0 STABLE 10. Our service works both in respmod and reqmod, in some cases we know right after reqmod that the data should passed directly to the client. in those cases we like to be more efficient by not

Re: Time for a Bug Hunt

2008-12-01 Thread Tsantilas Christos
Amos Jeffries wrote: Hey everybody, We still have a few open RC bugs which should be solvable given a few days each with a dedicated researcher. They are all blocking 3.1 release and some are causing major headaches to users of 3.0. 2305 - auth assertions (under refcounting?) 2424 -

Re: penging v3.1 patches

2008-10-10 Thread Tsantilas Christos
Alex Rousskov wrote: On Fri, 2008-10-10 at 21:02 +1300, Amos Jeffries wrote: .. http://www.squid-cache.org/bugs/show_bug.cgi?id=2055 I have worked on this in February, but the feature implementation is still incomplete. I have documented the latest state and suggested the way

Re: [MERGE] Connection pinning version 2

2008-09-30 Thread Tsantilas Christos
Amos Jeffries wrote: Went to build and run test this tonight. src/tests/stub_HttpRequest.cc appears to be missing the stub function: bool HttpRequest::inheritProperties(const HttpMsg *aMsg) { fatal(Not implemented); return false; } same for src/tests/stub_HttpReply.cc Lets waiting

Re: [MERGE] Connection pinning patch

2008-09-22 Thread Tsantilas Christos
Alex Rousskov wrote: On Mon, 2008-09-22 at 00:07 +0800, Adrian Chadd wrote: Its a 900-odd line patch; granted, a lot of it is boiler plate for config parsing and management, but I recall the issues connection pinning had when it was introduced and I'd hate to try and be the one debugging

Re: [MERGE] Connection pinning patch

2008-09-22 Thread Tsantilas Christos
Alex Rousskov wrote: On Sat, 2008-09-20 at 20:48 +0300, Tsantilas Christos wrote: This patch fixes the bug 1632 (http://www.squid-cache.org/bugs/show_bug.cgi?id=1632) It is based on the original squid2.5 connection pinning patch developed by Henrik (http://devel.squid-cache.org/projects.html

Re: [MERGE] Connection pinning patch

2008-09-21 Thread Tsantilas Christos
3.1 I can try to maintain a connection pinning patch for squid 3.1 as workaround/solution for the people need this feature. Regards, Christos Adrian 2008/9/21 Tsantilas Christos [EMAIL PROTECTED]: Hi all, This patch fixes the bug 1632 (http://www.squid-cache.org/bugs/show_bug.cgi?id

Re: astyle

2008-09-13 Thread Tsantilas Christos
Amos Jeffries wrote: Finally got around to running it myself on just src/*.* For me md5checker detects bungled files. I haven't looked further than those files to see if other directories are bunged as well. md5checker.sh assures us the printable byte order is identical, yes? This script

Re: astyle

2008-08-20 Thread Tsantilas Christos
Jeffries wrote: Alex Rousskov wrote: On Mon, 2008-01-07 at 23:55 +0200, Tsantilas Christos wrote: Alex Rousskov wrote: On Sat, 2008-01-05 at 13:05 +0200, Tsantilas Christos wrote: ... I suggest removing break-blocks both because of the above bug and because it is trying to detect unrelated

Re: Proxy-Authenticate/Proxy-Authorization headers

2008-05-03 Thread Tsantilas Christos
Henrik Nordstrom wrote: On fre, 2008-05-02 at 19:51 +0300, Tsantilas Christos wrote: According to the rfc standard the Proxy-Authenticate and Proxy-Authorization are hop-by-hop headers but in practice there are cases where these headers should forwarded. Currently squid2.6 and squid3.0

Proxy-Authenticate/Proxy-Authorization headers

2008-05-02 Thread Tsantilas Christos
Hi all, According to the rfc standard the Proxy-Authenticate and Proxy-Authorization are hop-by-hop headers but in practice there are cases where these headers should forwarded. Currently squid2.6 and squid3.0 forward these headers, but squid3-trunk does not. Does make sense to have a

Re: Chunk encoding

2008-04-25 Thread Tsantilas Christos
Alex Rousskov wrote: On Wed, 2008-04-23 at 21:51 +0200, Henrik Nordstrom wrote: ons 2008-04-23 klockan 07:57 +0200 skrev Maliling List, Westerhold, Axel: 'Will not work' comes down to will not work through ICAP when then responding server incorrectly uses Chunked enconding on HTTP 1.0 from

Re: client_side and comm_close

2008-04-20 Thread Tsantilas Christos
Maybe it can be easier: Just keeping the comm_close as is and in AsyncCallsQueue just cancels/not execute asyncCall's for which the fd_table[fd].flags.closing is set. We only need a way to identify comm_close handlers and the asyncCall which will do the actual close of the socket. Alex

Re: client_side and comm_close

2008-04-19 Thread Tsantilas Christos
Hi all, I think we have two different problems here, the client_side code and the comm_close in async calls. If I am not wrong the bug which triggered this discussion is the bug2309 which is squid3.0 bug where AsyncCalls does not exists. The problem here is the client side code which the true

Re: client_side and comm_close

2008-04-17 Thread Tsantilas Christos
Hi all, Alex Rousskov wrote: In reply to comment #8 for bug #2309 comm_read assertion failed: ccb-active == false http://www.squid-cache.org/bugs/show_bug.cgi?id=2309 Note to the one looking into this bug: The assert happens if a comm_read() is called while there already is a comm_read()

Re: [Bug 2311] SQUID crashes/ restarts when ICAP enabled on respmod for HTTP body size greater than 100kb

2008-04-17 Thread Tsantilas Christos
Alex Rousskov wrote: On Thu, 2008-04-17 at 11:54 -0600, Alex Rousskov wrote: Short-term: surround the parsing call with try/catch. Handle the parsing exception by committing the buffer as if there was no error and aborting the transaction. Do it in v3.0 and v3.1. This should be OK because

Re: [PATCH] Re: pconn.cc assert index = 0, async call queue madness

2008-04-09 Thread Tsantilas Christos
Hi Henrik, Henrik Nordstrom wrote: tis 2008-04-08 klockan 12:55 -0600 skrev Alex Rousskov: BTW, if somebody commits that patch, please polish the reason phrase in the cancel() call to something more specific. The submitted pach didn't work for two reasons. In fact this cancellation of comm

Re: Suggested 3.0 merge candidates

2008-04-08 Thread Tsantilas Christos
Alex Rousskov wrote: On Tue, 2008-04-08 at 17:04 +0200, Henrik Nordstrom wrote: tis 2008-04-08 klockan 13:23 +1200 skrev Amos Jeffries: +1. I'm just waiting on you all to agree that its tested enough. If you want to do the merge yourself Henrik, I'm okay with that. Doesn't matter for me who

Re: [PATCH] Re: pconn.cc assert index = 0, async call queue madness

2008-04-08 Thread Tsantilas Christos
Henrik Nordstrom wrote: So any proposals on how we would go about fixing comm_read_cancel? Hmm.. on reading that code commio_cancel_callback looks a bit odd in trunk. Why is callback set to NULL twice, and what is really the purpose of this function now that the actual callback is in an

Re: [MERGE-3.0] Support large response headers

2008-04-07 Thread Tsantilas Christos
mΓ₯n 2008-04-07 klockan 06:06 -0400 skrev Tsantilas Christos: It is easy. I just opened 3-4 pages to wikipedia.org, some clicks on links on those pages and then waiting for some minutes. If I try to go to a new wikipedia page I am getting the assertion.. Seems to work fine here

Re: [MERGE-3.0] Support large response headers

2008-04-07 Thread Tsantilas Christos
+0300 skrev Tsantilas Christos: I will do some tests. Henrik are you still using the bzr tree here: http://www.henriknordstrom.net/bzr/squid3/hno/largeresp/ Yes. It's up to date. And so is the largeresp-3.0 branch at the same location with the 3.0 backport. bzr cbranch http

Re: [MERGE-3.0] Support large response headers

2008-04-07 Thread Tsantilas Christos
mΓ₯n 2008-04-07 klockan 05:02 -0400 skrev Tsantilas Christos: This test sometimes gives me an assertion in pconn.cc (assert(index = 0) , pconn.cc:89 line), possibly when a connection to a web server expired. Maybe it is not related with your patch, but I am not getting this error using

Re: [MERGE-3.0] Support large response headers

2008-04-07 Thread Tsantilas Christos
It is a strange bug. I am able to reproduce it again and again only while browsing wikipedia site and only if I have set the following debug info: debug_options 26,9 85,9 33,9 87,9 44,9 If I change something in this line the bug disappeared. I can not get good debug info :-( Here are some logs

Re: [MERGE-3.0] Support large response headers

2008-04-07 Thread Tsantilas Christos
-04-07 klockan 22:21 +0200 skrev Henrik Nordstrom: mån 2008-04-07 klockan 22:54 +0300 skrev Tsantilas Christos: It is a strange bug. I am able to reproduce it again and again only while browsing wikipedia site and only if I have set the following debug info: debug_options 26,9 85,9 33,9 87,9

Re: [MERGE-3.0] Support large response headers

2008-04-06 Thread Tsantilas Christos
I will do some tests. Henrik are you still using the bzr tree here: http://www.henriknordstrom.net/bzr/squid3/hno/largeresp/ Regards, Christos Alex Rousskov wrote: On Sun, 2008-04-06 at 02:41 +0200, Henrik Nordstrom wrote: Updated 3.0 patch. Had forgot to merge one related changeset from

Re: async-calls squid3/src Debug.h,1.10.4.4,1.10.4.5...

2008-03-17 Thread Tsantilas Christos
Hi Alex, Alex Rousskov wrote: On Sun, 2008-03-16 at 15:43 +, chtsanti wrote: Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src ... The xThrow function is similar to the old Throw function but in addition adds an extra check to see if the carrent call can handle exceptions or

Re: Robustness project adjustments

2008-03-13 Thread Tsantilas Christos
Hi all, Alex Rousskov wrote: Hello, This email describes upcoming changes in the Squid3 robustness project. The Squid3 robustness project has two related goals: ... The current design has been disculeassed at the London meeting, and a few adjustments were requested. This

Re: Time for squid 3.0 STABLE2 ?

2008-02-27 Thread Tsantilas Christos
Hi all, Henrik Nordstrom wrote: On Thu, 2008-02-28 at 01:04 +1300, Amos Jeffries wrote: * Close more bugs? http://www.squid-cache.org/bugs/show_bug.cgi?id=2127 Is closed and verified by the reporter. About bug 2127, my understanding is that there are references about two bugs

Re: a simple formatter

2008-02-21 Thread Tsantilas Christos
Hi all, I believe, I solved (most of?) the problems in astyle. I am attaching the new version of the formatter.pl I test it only using the astyle version 1.21. This version does simpler hooks than the previous versions. The input filter: 1) Converts patterns unsigned int aparam:1;

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-16 Thread Tsantilas Christos
Hi Adrian, Adrian Chadd wrote: On Sat, Feb 16, 2008, Tsantilas Christos wrote: . PS. I actually believe that it must exists a squid external utility library which will be used by both squid and modules. But OK this looks difficult right now... Its been talked about

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-16 Thread Tsantilas Christos
Adrian Chadd wrote: Hey, I'm happy if Squid development was aligned with what our diverse group of users wants. But thats a discussion going on the squid-core list; OK men no problem, you can do yours discussions in squid-core list... I was just answered an email which has my mail address in

Re: eCAP: expose Squid or link with eCAP lib?

2008-02-15 Thread Tsantilas Christos
Hi, Alex Rousskov wrote: 1) Expose Squid internals: Publish/install Squid headers and libraries to give direct access to Squid resources. This approach will most likely require installing pretty much all headers because the module may need to use many Squid

Re: a simple formatter

2008-02-13 Thread Tsantilas Christos
Alex Rousskov wrote: On Wed, 2008-02-13 at 20:35 +0200, Tsantilas Christos wrote: Alex Rousskov wrote: On Wed, 2008-02-13 at 13:52 +1300, Amos Jeffries wrote: Or is it possible to omit the src/tools.cc src/stat.cc files from astyle until they can be cleaned manually to work better. I bet

Re: two xasserts in squid3

2008-02-11 Thread Tsantilas Christos
Alex Rousskov wrote: On Sun, 2008-02-10 at 20:51 +0200, Tsantilas Christos wrote: Maybe it was better if the files lib/assert.c and include/assert.h removed and the assert macro defined in squid.h file like squid2.6 does... It looks like Array, MemPool, and splay files are using assert

two xasserts in squid3

2008-02-10 Thread Tsantilas Christos
Hi all, There is something which confuse me. The xassert function implemented in squid3 in two places, in the file src/debug.cc and in the lib/assert.c file. Also the assert macro declared in src/Debug.h file and in the include/assert.h file. Is there any reason for these two implementations

Re: a simple formatter

2008-02-07 Thread Tsantilas Christos
,.cci and .c extensions and ignore all other files. I am re-sending the fixed script . In this version also I removed the --break-blocks astyle option. Formated code looks better without it. -- Christos #!/usr/bin/perl # # Author: Tsantilas Christos # email: [EMAIL PROTECTED] # # Distributed under

a simple formatter

2008-02-06 Thread Tsantilas Christos
Hi all, I wrote a small perl script which fixes (some of) the astyle problems. Before use it, you must adjust the $ASTYLE_BIN variable at the beggining of the formatter.pl file. I am running it using the following command: # find . -name *.cc -exec formater.pl \{\} \; but it can take

Re: cvs commit: squid3/src String.cc

2008-01-23 Thread Tsantilas Christos
Hi Amos, squid crashes after this patch, something is wrong. After reverting to a previews version of String.cc all are OK again . Amos Jeffries wrote: amosjeffries2008/01/22 20:06:20 MST Modified files: src String.cc Log: Reduce call duplication in

Re: bug 1208: internal redirect

2008-01-21 Thread Tsantilas Christos
Hi Amos, Amos Jeffries wrote: There are other reasons, but disagreement on actually making an architecture appears to me to be one of the big ones. As I can understand the major disagreement has to do with AsyncCalls. Squid3 has architecture and

Re: astyle

2008-01-07 Thread Tsantilas Christos
Alex Rousskov wrote: On Sat, 2008-01-05 at 13:05 +0200, Tsantilas Christos wrote: ... I suggest removing break-blocks both because of the above bug and because it is trying to detect unrelated blocks, classes, etc. which smells too much like AI to me. The --brackets=linux (-l) option

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-07 Thread Tsantilas Christos
The problem was different: With classic comm code of squid3 when the comm_close for a fd called then: 1) fd marked as closing, read and write handlers called with COMM_ERR_CLOSING 2) comm_close handlers called 3) the fd closed and the fdc_table[fd] initialized. Using async calls (current

Re: bzr VCS feedback

2008-01-07 Thread Tsantilas Christos
Gonzalo Arana wrote: CVS used only 4K, while bzr used more than 80M (it devastated my workstation). It was not so bad But in the other hand 80M are not huge amount in these days .. Since I am not a core squid developer, I know that I don't have a vote on this, but I have to say

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-06 Thread Tsantilas Christos
Hi Henrik, It is not a cbdata problem. An example is in the HttpStateData::sendComplete method which is going to execute an commSetTimeout(fd ...) Now there are cases in which this method scheduled for execution sometime in the future but before it is executed the squid code closes the fd

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-06 Thread Tsantilas Christos
Adrian Chadd wrote: .. I read that as the code is broken and needs to be fixed. I think not so broken because there are solutions or workarounds off the problems. I think the last changes fix the problem (however I want to look more on this to be sure there are not any other problems).

Re: async-calls squid3/src comm.cc,1.81.4.16,1.81.4.17

2008-01-06 Thread Tsantilas Christos
Adrian Chadd wrote: On Sun, Jan 06, 2008, Tsantilas Christos wrote: Adrian Chadd wrote: .. I read that as the code is broken and needs to be fixed. I think not so broken because there are solutions or workarounds off the problems. I think the last changes fix the problem (however I want

Re: bzr VCS feedback

2008-01-02 Thread Tsantilas Christos
Hi Rob, The first feeling is good. I like it. In general the idea of decentralized repositories looks good. In INSTALL file of bzr says that requires python 2.4. I am using it with python 2.5 and looks OK. Is the python version a problem? Is the bazaar repository currently auto-synchronized

Re: VCS for squid3 development?

2007-12-28 Thread Tsantilas Christos
Hi Robert, Which are the required steps from developers? Will we open our computers a morning and find all our development branches in the new system :-) ? What about the sourceforge developers repository? Will be hosted in the squid main server? Regards, Christos PS. I am only use cvs and

Re: VCS for squid3 development?

2007-12-28 Thread Tsantilas Christos
OK, this is good, we will have time to learn the new system. Henrik Nordström wrote: fre 2007-12-28 klockan 16:16 +0200 skrev Tsantilas Christos: Hi Robert, Which are the required steps from developers? Will we open our computers a morning and find all our development branches in the new

Re: VCS for squid3 development?

2007-12-28 Thread Tsantilas Christos
Robert Collins wrote: What about the sourceforge developers repository? Because bzr is natively distributed we don't need to have a dedicated developers repository like we have with CVS - anyone using bzr will get their own copy of the repository automatically; they can commit there as

Re: 3-HEAD IPv6 updates

2007-12-20 Thread Tsantilas Christos
Alex Rousskov wrote: On Sat, 2007-12-15 at 12:56 +0200, Tsantilas Christos wrote: void ICAPModXact::inheritVirginProperties(HttpRequest newR, const HttpRequest oldR) { newR.client_addr = oldR.client_addr; -newR.client_port = oldR.client_port; - newR.my_addr = oldR.my_addr

Re: building async-calls

2007-12-17 Thread Tsantilas Christos
Hi Adrian, As I am seeing squid3 spends time in EventScheduler::schedule method. This method did not affected by the new AsyncCall code. Also this method is similar with squid 2.6 eventAdd function. The only I can say is that possibly we are scheduling a huge number of events in squid3. If the

Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Hi Adrian, I commit some changes to async-calls branch and now compiles (but does not link) without ICAP client enabled. Currently you have to enable ICAP client to build async-calls. The reason is that the src/ICAP/AsyncJob.o used in AsyncCalls but built only as part of ICAP client library.

Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Adrian Chadd wrote: On Sun, Dec 16, 2007, Tsantilas Christos wrote: Currently you have to enable ICAP client to build async-calls. The reason is that the src/ICAP/AsyncJob.o used in AsyncCalls but built only as part of ICAP client library. OK Adrian I fixed this too. You can build the async

Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Adrian Chadd wrote: On Sun, Dec 16, 2007, Tsantilas Christos wrote: Yes this is true. An AsyncCall class instanced for every async callback. And the comm code is going to register one of these per comm events? Yes. Have you benchmarked what that'll do to performance? :) Maybe has some

Re: 3-HEAD IPv6 updates

2007-12-15 Thread Tsantilas Christos
Hi Amos, Just a small patch to allow ICAP compile and run with the newly added IPV6 changes. First tests looks good. Regards, Christos Amos Jeffries wrote: I'm done now. Welcome to IPv6 everyone ;-) ... Index: client_side_request.cc

preserve cvs history of moved files.

2007-10-14 Thread Tsantilas Christos
Hi Henrik, Under a branch I am planning to work at the sourceforge CVS repository I want to move files from one directory to an other. Should I try to preserve cvs history of these files? I think just a copy of the corresponding history file (file.c,v) to the new location will do the work. Do we

Re: preserve cvs history of moved files.

2007-10-14 Thread Tsantilas Christos
/TextException.cc and src/ICAP/TextException.h should moved under the src/ directory. But also it is good to keep their cvs history. Is there any way? Regards, Christos Tsantilas Christos wrote: Hi Henrik, Under a branch I am planning to work at the sourceforge CVS repository I want to move files

Re: [Fwd: Re: cvs commit: squid3/src HttpHeader.cc HttpHeaderTools.cc Store.h SwapDir.h cache_cf.cc cf.data.pre client_side.cc client_side.h protos.h store_dir.cc structs.h]

2007-09-29 Thread Tsantilas Christos
Oops.. I just saw that I sent this mail to squid-cvs mailing list :-( Sorry . Henrik Nordstrom wrote: Forwarded Message From: Tsantilas Christos [EMAIL PROTECTED] To: Henrik Nordstrom [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Re: cvs commit: squid3/src

Re: cvs commit: squid3 configure.in

2007-09-07 Thread Tsantilas Christos
Loadable dynamics modules maybe are not so important for existing features of squid3 (HTCP,ICAP or SNMP), but they are important to allow people/companies to extend squid. The eCAP interface sounds really a good idea. Also maybe there are others parts of squid which can extended in such way (eg

squid3 download page

2007-08-31 Thread Tsantilas Christos
Hi all, At the squid3 download page (http://www.squid-cache.org/Versions/v3/3.0/) the squid-3.0.PRE7 link points to the squid-3.0.PRE5 Release Notes (http://www.squid-cache.org/Versions/v3/3.0/squid-3.0.PRE5-RELEASENOTES.html) -- Christos

Re: squid-3 ?

2007-08-28 Thread Tsantilas Christos
Hi Rob, Robert Collins wrote: Whats this summer you speak of? I was speaking for Greek summer, the period of the year in Greece with warm sunny days and better evenings, drinking wine, bears and ouzo near the sea. But, this summer was strange men, the sun looked sick behind the smoke of

Re: squid 3.0 and c-icap

2007-08-28 Thread Tsantilas Christos
Hi Forest, Alex has right here, squid3 does not support more than one service per request or response. The icap_class configuration parameter does not complains if you put more than one services per request/response but only the first of them will be used. The same if you use multiple

Re: squid 3.0 and c-icap

2007-08-24 Thread Tsantilas Christos
Alex Rousskov wrote: My understanding is that Squid3 supports no more than one ICAP service per message. If you can apply one service to the HTTP request and another service to the response, then you can have up to two ICAP services per transaction. Does Squid2 support multiple ICAP

Re: squid 3.0 and c-icap

2007-08-22 Thread Tsantilas Christos
Hi Forest, JXu wrote: Hi I installed Squid 3.0 and c-icap server. It works find and I made srv_clamav work. My question is how can I make the other service srv_echo and srv_url_check work? Just change the icap_service configuration parameter in your squid.conf file to point to the

Re: squid-3 ?

2007-08-16 Thread Tsantilas Christos
Hi all, Alex Rousskov wrote: The primary idea behind RC1 is to bring in users who are ignoring PRE releases because there were so many PREs. We need more testers than a handful of folks running PREs on busy sites. RC1 release to attract testers is a good idea. The only comment I have is that

Re: cvs commit: squid3/src HttpHdrContRange.cc Makefile.in MemObject.cc access_log.cc cache_cf.cc client_side.cc client_side_reply.cc stmem.cc

2007-08-14 Thread Tsantilas Christos
Hi , Henrik Nordstrom wrote: hno 2007/08/13 12:25:14 MDT Modified files: src HttpHdrContRange.cc Makefile.in MemObject.cc access_log.cc cache_cf.cc client_side.cc client_side_reply.cc

Re: Squid 3 build error using Visual Studio

2007-08-14 Thread Tsantilas Christos
Hi Guido , Guido Serassio wrote: I have learned at university (more than 15 years ago ...) Assembler, Fortran, C and Pascal, but never C++. or any similar language. Sometimes I am feeling to old to start thinks too, but Guido if you are thinking like that now, what are we going to do after 15

Re: StoreIOBuffer field types

2007-08-14 Thread Tsantilas Christos
Hi Amos, Amos Jeffries wrote: One of them was unsafe use of a variable typed 'size_t' setting up StoreIOBUffer local variable The constructor using it is: StoreIOBuffer(size_t aLength, int64_t anOffset, char *someData) : length (aLength), offset (anOffset), data (someData)

Re: Squid3: schedule and naming

2007-08-08 Thread Tsantilas Christos
Hi Amos, Amos Jeffries wrote: I just spent the afternoon going over Christos full patch for squid3-largeobj and only found a few very minor things. Though I still don't know squid well enough to tell if there is anything missed out. Did you use it to download large files? Did you do some

Re: squid3-largeobj squid3/src HttpHdrRange.cc...

2007-08-07 Thread Tsantilas Christos
At the end I just put quick_abort_min and quick_abort_max to its original behavior. They are storing values in kilobytes and if the units are missing kilobytes are the default. It is very easy to change it and also is easy to make parser to not require spaces between value and units. But a problem

Re: squid3-largeobj squid3/src HttpHdrRange.cc...

2007-08-01 Thread Tsantilas Christos
Henrik Nordstrom wrote: On tis, 2007-07-31 at 21:09 +, chtsanti wrote: Please avoid casting unless needed. The compiler automatically promotes to larger types when needed, and will tell you if you try to do the reverse.. So stop casting things to (int64_t). OK. Sometimes I am using

squid3 and http 0.9 protocol

2007-06-03 Thread Tsantilas Christos
Hi all, I am done some tests and saw that squid3 does not support http 0.9 protocol. Is this something important for squid3? Is the 0.9 http version still in use? Regards, Christos

Re: SqString

2007-05-24 Thread Tsantilas Christos
Hi there, Before SqString patch applied, squid3 looked stable, I had days to see a problem. The SqString had unpredicted effects in squid3 like the bug 1970. And maybe there are other issues not appeared yet. It was not enough analyzed before applied. Regards, Christos PS. Last

Re: cvs commit: squid3/src/ICAP ICAPConfig.cc ICAPConfig.h ....

2007-05-18 Thread Tsantilas Christos
Hi Amos Amos Jeffries wrote: Does ICAP really not build without a const version of the operator[]? Strangly it does for me. Oh well, adding anyway. May be because of different versions of g++. I am using g++ 4.1.2 here . This change is more of a problem. To me it looks like the latter

<    1   2   3   4   5   6   7   >