[SSSD] [sssd PR#138][comment] IPA: Skip conflict entries associated with sudo rules

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules jhrozek commented: """ Hi Justin, thank you very much for th epatches and sorry the review took so long. In general I like the approach, an extra parameter is probabl

[SSSD] [sssd PR#138][+Changes requested] IPA: Skip conflict entries associated with sudo rules

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#138][comment] IPA: Skip conflict entries associated with sudo rules

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules jhrozek commented: """ Hi Justin, thank you very much for th epatches and sorry the review took so long. In general I like the approach, an extra parameter is probabl

[SSSD] [sssd PR#112][+Accepted] FAILOVER: Improve port status log messages

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I'm sorry this review stalled. I think the current patch is fine. About the duplicate messages -- the messages from get_server_status and get_port_statu

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-01-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ There is a bug when looking up keys for a user from a trusted domain: ``` ==3945== Invalid read of size 8 ==3945==at 0x4100FE: sss_dp_callback_destructor (responder_

[SSSD] [sssd PR#127][+Changes requested] ssh: use cache_req

2017-01-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ On Tue, Feb 07, 2017 at 12:50:23AM -0800, lslebodn wrote: > On (03/02/17 00:39), Jakub Hrozek wrote: > >On Thu, Feb 02, 2017 at 12:48:11PM -0800, lsl

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ On Tue, Feb 07, 2017 at 02:56:00AM -0800, Pavel Březina wrote: > Try now. thanks, that case is now fixed. I'll run a couple of more tests before acking. """

[SSSD] [sssd PR#149][opened] Fix subdomain discovery if sssd.conf domain name is different from joined domain name

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/149 Author: jhrozek Title: #149: Fix subdomain discovery if sssd.conf domain name is different from joined domain name Action: opened PR body: """ Please see the commit message for problem description and a way to reproduce the issu

[SSSD] [sssd PR#149][+Accepted] Fix subdomain discovery if sssd.conf domain name is different from joined domain name

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/149 Title: #149: Fix subdomain discovery if sssd.conf domain name is different from joined domain name Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#85][+Accepted] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() jhrozek commented: """ If @sumit-bose agrees the use-case he brought up in one of the previous comments is covered, then I think the patches can be pushed. I tested the

[SSSD] [sssd PR#145][comment] Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/145 Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case jhrozek commented: """ check the body of sysdb_sudo_add_lowered_users -- it just returns with EOK if the dom

[SSSD] [sssd PR#108][+Accepted] Partially revert "CONFIG: Use default config when none provided"

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/108 Title: #108: Partially revert "CONFIG: Use default config when none provided" Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#108][comment] Partially revert "CONFIG: Use default config when none provided"

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/108 Title: #108: Partially revert "CONFIG: Use default config when none provided" jhrozek commented: """ I'm sorry it took so long to review this PR. I agree with the patch so I'm adding Accepted. The use-case of sssd be

[SSSD] [sssd PR#127][+Accepted] ssh: use cache_req

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#127][-Changes requested] ssh: use cache_req

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#138][+Changes requested] IPA: Skip conflict entries associated with sudo rules

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ The code looks good to me now but I found one regression - if you set default_domain_suffix to the AD domain and try to look up a host, the ssh responder will query the AD domain.

[SSSD] [sssd PR#112][-Changes requested] FAILOVER: Improve port status log messages

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ On Tue, Jan 31, 2017 at 12:18:44AM -0800, fidencio wrote: > Looking at the patches I see this can be a completely new library instead of > being pa

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ * master: 1c7f9a676088ecee4c14df14b8688b391fb32a05 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#112][-Accepted] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#112][+Pushed] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#112][closed] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Author: justin-stephenson Title: #112: FAILOVER: Improve port status log messages Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/112/head:pr112 git checkout pr112

[SSSD] [sssd PR#127][+Changes requested] ssh: use cache_req

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ I'm afraid this is still not fixed correctly. Please check this gdb session when I requested an IPA host with a default_domain_suffix pointing to a Windows domain: ``` 0x0

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ pam_srv_test doesn't like being run under valgrind: http://sssd-ci.duckdns.org/logs/job/61/71/rhel7/ci-build-debug/ci-make-check-valgrind.log """ See the full

[SSSD] [sssd PR#138][comment] IPA: Skip conflict entries associated with sudo rules

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules jhrozek commented: """ I also ran IPA upstream automated tests in addition to some manual testing and no new regressions were found -> ACK Thank you for the patch!

[SSSD] [sssd PR#138][+Accepted] IPA: Skip conflict entries associated with sudo rules

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#145][opened] Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case

2017-02-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/145 Author: jhrozek Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case Action: opened PR body: """ I guess because different versions of sssd placed differ

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ There are some Coverity warnings: ``` Error: UNINIT (CWE-457): sssd-1.15.1/src/p11_child/p11_child_nss.c:112: var_decl: Declaring variable "key_id_str" without ini

[SSSD] [sssd PR#138][-Changes requested] IPA: Skip conflict entries associated with sudo rules

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#149][comment] Fix subdomain discovery if sssd.conf domain name is different from joined domain name

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/149 Title: #149: Fix subdomain discovery if sssd.conf domain name is different from joined domain name jhrozek commented: """ * master: e947a871f7d3cfc4389e981a147fe10bedca0569 """ See the full comment at https:/

[SSSD] [sssd PR#149][+Pushed] Fix subdomain discovery if sssd.conf domain name is different from joined domain name

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/149 Title: #149: Fix subdomain discovery if sssd.conf domain name is different from joined domain name Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email

[SSSD] [sssd PR#149][-Accepted] Fix subdomain discovery if sssd.conf domain name is different from joined domain name

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/149 Title: #149: Fix subdomain discovery if sssd.conf domain name is different from joined domain name Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#149][closed] Fix subdomain discovery if sssd.conf domain name is different from joined domain name

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/149 Author: jhrozek Title: #149: Fix subdomain discovery if sssd.conf domain name is different from joined domain name Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/149/head:pr149

[SSSD] [sssd PR#85][-Accepted] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#85][closed] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/85 Author: celestian Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/85/head:pr85 git checkout pr85

[SSSD] [sssd PR#85][+Pushed] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() jhrozek commented: """ master: * 0b7ded15e53b3f31f1570c366f04bc41e5761929 * f1e3364a72eb75673d10cf8c97ba8f1d7a385405 * 3ee411625aee19afda7477bb1

[SSSD] [sssd PR#127][closed] ssh: use cache_req

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Author: pbrezina Title: #127: ssh: use cache_req Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/127/head:pr127 git checkout pr127 ___

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ Well, I *just* pushed the patches: 0b7ded1..a8191ce That's why I leave the accepted flag for quite some time before pushing..feel free to just remove it next time if you plan on

[SSSD] [sssd PR#149][comment] Fix subdomain discovery if sssd.conf domain name is different from joined domain name

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/149 Title: #149: Fix subdomain discovery if sssd.conf domain name is different from joined domain name jhrozek commented: """ Hmm, if the bug exists there, then yes. But I thought the bug was introduced during the sssd-1-14 ad sudoma

[SSSD] [sssd PR#145][comment] Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/145 Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case jhrozek commented: """ Yes, both cases should be added. The change of behaviour is the duplicate detection -- ev

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ On Thu, Feb 02, 2017 at 12:48:11PM -0800, lslebodn wrote: > On (02/02/17 08:33), Jakub Hrozek wrote: > >On Thu, Feb 02, 2017 at 08:29:15AM -0800, lsl

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ On Thu, Feb 02, 2017 at 08:29:15AM -0800, lslebodn wrote: > On (02/02/17 08:14), Jakub Hrozek wrote: > >On Tue, Jan 31, 2017 at 12:18:44AM -0800, fide

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ On Mon, Jan 23, 2017 at 03:20:47AM -0800, Pavel Březina wrote: > On 01/20/2017 09:01 PM, Jakub Hrozek wrote: > > On Fri, Jan 20, 2017 at 04:

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-01-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ I will review this as these changes make the requested changes to the files provider code on review easier. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ On Fri, Jan 20, 2017 at 04:05:47AM -0800, Pavel Březina wrote: > @lslebodn Asked me to address my comments in separate patches. I wrote > patches for mo

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-01-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ I haven't read the patches, I just realized we might want to have a ticket and not just a downstream bugzilla. "&quo

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-01-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ https://fedorahosted.org/sssd/ticket/3282 """ See the full comment at https://github.com/S

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-01-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/139#issuecomment-275914396 _

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ @mrniranjan @lslebodn it seems that this patch set got a bit stuck. Are the major issues the pep8 warnings and the whitespace issues? If yes, can @mr

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2017-02-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it jhrozek commented: """ On Tue, Feb 21, 2017 at 01:02:45AM -0800, lslebodn wrote: > On (20/02/17 14:43), fidencio wrote: > >Can we have this one pushed by @sumit-

[SSSD] [sssd PR#66][+Pushed] Minor Dynamic DNS fixes

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#66][closed] Minor Dynamic DNS fixes

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Author: justin-stephenson Title: #66: Minor Dynamic DNS fixes Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/66/head:pr66 git checkout pr66

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes jhrozek commented: """ * master: * d694d4fdcc81f24c2f9e3bb5a0dbe0a52498f196 * fccd8f9ab7a0ac9868c43ea0e8c3af142b2809fa """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it jhrozek commented: """ Actually, let's push this PR now, there is a test so we won't regress """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#70][+Pushed] check_duplicate: check name member before using it

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it jhrozek commented: """ master: 454cf0c3808a9f6a0c9f79e9796e17c58907ee6c 08bf6b4a281ef4308119dccbba4e86cf28b505d2

[SSSD] [sssd PR#161][+Accepted] pam_sss: check conversation callback

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/161 Title: #161: pam_sss: check conversation callback Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#155][+Pushed] MONITOR: Don't return an error in case we fail to register a service

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#155][closed] MONITOR: Don't return an error in case we fail to register a service

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/155 Author: fidencio Title: #155: MONITOR: Don't return an error in case we fail to register a service Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/155/head:pr155 git checkout

[SSSD] [sssd PR#155][comment] MONITOR: Don't return an error in case we fail to register a service

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service jhrozek commented: """ * master: 86bcc81a665dde4799d67ab7ea2bbd23608e7dab """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#155][-Accepted] MONITOR: Don't return an error in case we fail to register a service

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#160][+Pushed] Fix files provider reallocation logic

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/160 Title: #160: Fix files provider reallocation logic Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#160][closed] Fix files provider reallocation logic

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/160 Author: jhrozek Title: #160: Fix files provider reallocation logic Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/160/head:pr160 git checkout pr160

[SSSD] [sssd PR#160][comment] Fix files provider reallocation logic

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/160 Title: #160: Fix files provider reallocation logic jhrozek commented: """ * master: fc91d72f32660712f7c9e872e00deb91f188fea3 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#156][+Pushed] FILES: Remove unnecessary check

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Title: #156: FILES: Remove unnecessary check Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#156][comment] FILES: Remove unnecessary check

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Title: #156: FILES: Remove unnecessary check jhrozek commented: """ * master: 1f49be4429c17475b789e9089ce4d0ae48315e74 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#156][closed] FILES: Remove unnecessary check

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Author: lslebodn Title: #156: FILES: Remove unnecessary check Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/156/head:pr156 git checkout pr156

[SSSD] [sssd PR#161][+Pushed] pam_sss: check conversation callback

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/161 Title: #161: pam_sss: check conversation callback Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#161][closed] pam_sss: check conversation callback

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/161 Author: sumit-bose Title: #161: pam_sss: check conversation callback Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/161/head:pr161 git checkout pr161

[SSSD] [sssd PR#161][comment] pam_sss: check conversation callback

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/161 Title: #161: pam_sss: check conversation callback jhrozek commented: """ Fixed upstream: * master: 0965a77c4ff0b358d24582955cb7ae375ebaa0d2 * sssd-1-14: ba8e3f2850e5a328bc3e732b471280fc4fa49c53 * sssd-1-13: cc8c28ad26ae8dbd7e8bee1de

[SSSD] [sssd PR#156][comment] FILES: Remove unnecessary check

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Title: #156: FILES: Remove unnecessary check jhrozek commented: """ No, I meant the one in save_group, but you're right the check for \0 is strange. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#137][+Changes requested] Initial pkinit support

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#163][opened] Enable the files domain for all sssd configurations

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/163 Author: jhrozek Title: #163: Enable the files domain for all sssd configurations Action: opened PR body: """ This patch is a prerequisite for Fedora-26 feature: https://fedoraproject.org/wiki/Changes/SSSDCacheForLocalUsers Adds a

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ There is a small issue where `sss_authtok_set_sc` is used before it's defined, which would break bisect. btw I'm battling a bit with the downstream tests, it looks like saying

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ On Fri, Feb 17, 2017 at 03:59:51AM -0800, Pavel Březina wrote: > Hi, I prepared few trivial commits for you to squash if you agree: &g

[SSSD] [sssd PR#152][synchronized] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Author: jhrozek Title: #152: Add a tevent wrapper around libcurl's asynchronous interface Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/152/head:pr152 git checkout pr152

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ Per Pavel's request I moved the headers parameter to the send function so every request can run with different headers. "&quo

[SSSD] [sssd PR#152][synchronized] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Author: jhrozek Title: #152: Add a tevent wrapper around libcurl's asynchronous interface Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/152/head:pr152 git checkout pr152

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ I also added more comments per Pavel's request. If there are more areas that need to be commented better, please point them out and

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ OK, apart from the issue with the patch compilation, I found one more with manual testing -- it looks like changing the expired password of a newly created IPA user is not wo

[SSSD] [sssd PR#137][+Changes requested] Initial pkinit support

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#164][opened] Remove unused import of run_shell from tests

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/164 Author: jhrozek Title: #164: Remove unused import of run_shell from tests Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/164

[SSSD] [sssd PR#166][edited] Please see the commit message for commit description.

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/166 Author: jhrozek Title: #166: Please see the commit message for commit description. Action: edited Changed field: title Original value: """ Please see the commit message for com

[SSSD] [sssd PR#168][opened] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Author: jhrozek Title: #168: DOC: Deprecate README, add README.md Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/168/head

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md jhrozek commented: """ I'm not sure why the centos CI reports failure. I ran our internal CI and it passed: http://sssd-ci.duckdns.org/logs/job/63/44/summary.html """

[SSSD] [sssd PR#168][synchronized] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Author: jhrozek Title: #168: DOC: Deprecate README, add README.md Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/168/head:pr168 git checkout pr168 From

[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations jhrozek commented: """ On Fri, Feb 24, 2017 at 04:41:48AM -0800, Pavel Březina wrote: > Typo in last commit message: > ``` > This functionality is only enabled in

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md jhrozek commented: """ On Fri, Feb 24, 2017 at 06:17:16AM -0800, lslebodn wrote: > On (24/02/17 02:43), Jakub Hrozek wrote: > >I'm not sure why the centos CI reports failur

[SSSD] [sssd PR#152][synchronized] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Author: jhrozek Title: #152: Add a tevent wrapper around libcurl's asynchronous interface Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/152/head:pr152 git checkout pr152

[SSSD] [sssd PR#168][synchronized] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Author: jhrozek Title: #168: DOC: Deprecate README, add README.md Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/168/head:pr168 git checkout pr168 From

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ On Thu, Feb 23, 2017 at 03:10:12AM -0800, lslebodn wrote: > lslebodn commented on this pull request. > > > > > @@ -32

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md jhrozek commented: """ ok, new patch pushed here """ See the full comment at https://github.com/SSSD/sssd/pull/168#issuecomment-282330721

[SSSD] [sssd PR#168][synchronized] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Author: jhrozek Title: #168: DOC: Deprecate README, add README.md Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/168/head:pr168 git checkout pr168 From

[SSSD] [sssd PR#163][synchronized] Enable the files domain for all sssd configurations

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/163 Author: jhrozek Title: #163: Enable the files domain for all sssd configurations Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/163/head:pr163 git checkout pr163 From

  1   2   3   4   5   6   7   8   9   10   >