URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
Thank you for the careful review. I pushed the whole lot into master:
0e7047c1533e5e424b28959488e8ffa91613abd9
89e53f7139b134360fda9e43d47ebfb89fcaac92
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
Ack, thank you. Good job :-)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/106#issuecomment-279976416
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/62/60/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/106#issuecomment-279973347
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
Hopefully these patches implement a safer method of waiting for the update. I
tested the code by modifying the update to start a tevent timer event and then,
before the event fired, I
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
> I hope this wouldn't be an issue because the inotify code doesn't call the
> callbacks immediately but with a tevent timer (by default immediate tevent
> action) which IIRC waits until
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
I hope this wouldn't be an issue because the inotify code doesn't call the
callbacks immediately but with a tevent timer (by default immediate tevent
action) which IIRC waits until the
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
Hi, those changes looks good. I have just one comment -- what happens if both
groups and passwd are being updated? I see that both will trigger
files_account_info_finished(), this looks
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/62/54/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/106#issuecomment-279363621
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
With some help from Pavel, I fixed a memory issue we had in the sbus code. I
think the patches are now ready for review. One thing I will submit separately
is automatic enablement of the
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
Yes. Inconsistent sounds good.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/106#issuecomment-275063633
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
On Mon, Jan 23, 2017 at 03:20:47AM -0800, Pavel Březina wrote:
> On 01/20/2017 09:01 PM, Jakub Hrozek wrote:
> > On Fri, Jan 20, 2017 at 04:05:47AM -0800, Pavel Březina wrote:
> >>
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
On Fri, Jan 20, 2017 at 04:05:47AM -0800, Pavel Březina wrote:
> @lslebodn Asked me to address my comments in separate patches. I wrote
> patches for most of the above expect changing the
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
@lslebodn Asked me to address my comments in separate patches. I wrote patches
for most of the above expect changing the `sf_` prefix and removing logic that
disables domain during
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
**UTIL: Add a generic inotify module**
```c
if ((debug_level & SSSDBG_TRACE_LIBS) == false) {
return;
}
^ use DEBUG_IS_SET(SSSDBG_TRACE_LIBS)
```
**D-Bus
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
All the python-related comments should be fixed and pep8 shouldn't report any
more errors.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/106#issuecomment-271395952
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
On Mon, Jan 09, 2017 at 03:17:24AM -0800, Pavel Březina wrote:
> So far it looks good and I have only very few comments. I didn't read the
> code thoroughly yet.
>
> *NSS: Skip disabled
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
so the solution would be to convert ent.py to not use dir internally either and
I'm fine doing that if you think it would help
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
Yes, but as I said in the comment (in the part you quoted out),
assert_passwd_by_name won't work, because it expects dir and uses dir in its
control directory:
```
Traceback (most recent
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
lslebodn commented:
"""
On (09/01/17 07:44), Jakub Hrozek wrote:
>jhrozek commented on this pull request.
>
>
>
>> +contents = self._read_contents()
>+kindex = self._get_named_line(key, contents)
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
So far it looks good and I have only very few comments. I didn't read the code
thoroughly yet.
*NSS: Skip disabled domains during requests*
Rename to cache_req: please, because the
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
lslebodn commented:
"""
I slowly started to fix python3 issues in integration tests. There are mostly
issues with bytes/unicode.
Here is a patch which fixes issues in your patches
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
lslebodn commented:
"""
I had some inline comments to the python tests. And do not forget to run `pep8
src/tests/intg/*.py` after changes.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
OK, ready for review, @pbrezina
There is still a commit that generates the default configuration. We already
have a PR #108 that reverts this functionality -- I guess it would be best to
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
I hope you noticed the earlier comment that says "I just set the Changes
Requested label so that it's clear to reviewers new patch set is coming up.."
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
lslebodn commented:
"""
I hope you noticed that this PR need to be rebased (due to refactoring of nss
responder)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/106#issuecomment-268347295
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
I just set the Changes Requested label so that it's clear to reviewers new
patch set is coming up..
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
I though it will be a small change, but if it is going to affect the code more
widely, I'll wait.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
On Mon, Dec 12, 2016 at 04:51:31AM -0800, Pavel Březina wrote:
> I will try to do some review in this week.
Thank you, but please note that I will try to implement Simo's
suggestion to use
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
pbrezina commented:
"""
I will try to do some review in this week.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/106#issuecomment-266423740
___
URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
One suggestion came from simo about using FGETPWENT(3) instead of opening the
NSS module directly.
"""
See the full comment at
30 matches
Mail list logo
