URL: https://github.com/SSSD/sssd/pull/326
Title: #326: IPA: check if IPA hostname is a FQDN
amitkumar50 commented:
"""
@fidencio Thanks for suggestion. Yes indeed That would be Good.. I will do the
change..
"""
See the full comment at
https://github.com/SSSD/sssd/pull/326#issuecomment-321183
URL: https://github.com/SSSD/sssd/pull/345
Author: fidencio
Title: #345: Improve the situation of recurrent failing CI tests
Action: opened
PR body:
"""
Taking a look in our CI the latest issues we had were related to not waiting
enough time in some sleep() that are around the tests code.
Fo
On 08/08/2017 04:51 PM, Fabiano Fidêncio wrote:
People,
There's a test, part of our internal CI, recurrently failing in the
past few weeks:
=== FAILURES ===
_ test_add_remove_user ___
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahost
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
lslebodn commented:
"""
Do we test the same patch? It failed for me 3rd time in a row.
http://vm-058-233.$ABC/logs/job/72/96/summary.txt
"""
See the full comment at
https://github.com/SSSD/
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
fidencio commented:
"""
I'm testing the patch rebased on top of git master. All the times it passed.
Let me actually retest it here, just to be more than sure.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
fidencio commented:
"""
```
[ffidenci@pessoa sssd]$ git checkout t3254_master_krb5_snippet
Switched to branch 't3254_master_krb5_snippet'
Your branch and 'celestian/t3254_master_krb5_snippet
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
fidencio commented:
"""
And it just passed again: http://vm-058-233.$ABC/logs/job/72/97/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/214#issuecomment-321231365
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
lslebodn commented:
"""
Changing hardcoded timeout without explanation "why" is not sufficient
solution. (because you might hide a bug). And purpose of tests is to find bugs.
Therefer NA
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@list
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
lslebodn commented:
"""
Changing hardcoded timeout without explanation "why" is not sufficient
solution. (because you might hide a bug). And purpose of tests is to find bugs.
Therefore N
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
lslebodn commented:
"""
Changing hardcoded timeout without explanation "why" is not sufficient
solution. (because you might hide a bug). And purpose of tests is to find bugs.
Therefore N
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
lslebodn commented:
"""
>I'm testing the patch rebased on top of git master. All the times it passed.
I do the same and it always fails for me. And I trust myself.
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
fidencio commented:
"""
Thanks for implying that you do **not** trust myself.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/214#issuecomment-321234650
__
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
lslebodn commented:
"""
> Thanks for implying that you do not trust myself.
I'm sorry but I cannot verify that you really used the same patch :-( (patches
welcome for improving it in intern
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
lslebodn commented:
"""
> Thanks for implying that you do not trust myself.
I'm sorry but I cannot verify that you really used the same patch :-( (patches
welcome for improving it in interna
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
jhrozek commented:
"""
So are the issues because enumeration hasn't ran yet or because we are in the
middle of enumeration when the test checks?
In general I would expect the enumeration
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
lslebodn commented:
"""
FYI: here is an example why you cannot blindly increase timeout in test.
Lets assume that we have a failing test which should test midpoint refresh for
some entry
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
fidencio commented:
"""
@jhrozek: about the 15 seconds timeout, please, take a look at:
http://vm-058-233.$ABC/logs/job/72/75/debian_testing/ci-build-debug/ci-make-intgcheck.log
and
htt
URL: https://github.com/SSSD/sssd/pull/326
Title: #326: IPA: check if IPA hostname is a FQDN
amitkumar50 commented:
"""
@fidencio sssd-ipa man page ipa_hostname entry:
> ipa_hostname (string)
> Optional. May be set on machines where the hostname(5) does not
> reflect the fully q
URL: https://github.com/SSSD/sssd/pull/326
Title: #326: IPA: check if IPA hostname is a FQDN
fidencio commented:
"""
@amitkumar50: what do you think about "The newly specified hostname must be
fully qualified."?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/326#issuecomment-32
> On 8 Aug 2017, at 16:51, Fabiano Fidêncio wrote:
>
> People,
>
> There's a test, part of our internal CI, recurrently failing in the
> past few weeks:
>
> === FAILURES
> ===
> _ test_add_remove_user
URL: https://github.com/SSSD/sssd/pull/326
Title: #326: IPA: check if IPA hostname is a FQDN
amitkumar50 commented:
"""
@fidencio I am not clear why you used term "newly specified".
Though without it "The hostname must be fully qualified." would be good too.
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/326
Title: #326: IPA: check if IPA hostname is a FQDN
fidencio commented:
"""
@amitkumar50, that's good for me as well. Please, update the PR with the
changes :-)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/326#issuecomment-321253610
__
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
lslebodn commented:
"""
On (09/08/17 12:24), fidencio wrote:
>@jhrozek: about the 15 seconds timeout, please, take a look at:
>http://vm-058-233.$ABC/logs/job/72/75/debian_testing/ci-buil
URL: https://github.com/SSSD/sssd/pull/326
Author: amitkumar50
Title: #326: IPA: check if IPA hostname is a FQDN
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/326/head:pr326
git checkout pr326
From 8a6ab8e2eedcad7a3d
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
fidencio commented:
"""
@lslebodn, I was just pointing to @jhrozek the tests that have been failing (as
he asked).
"""
See the full comment at
https://github.com/SSSD/sssd/pull/345#issu
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
fidencio commented:
"""
Anyways, I do not have any motivation to work further in this PR (and that's
the reason I did not assigned the bug to myself).
I'm closing the PR as rejected.
"""
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorah
URL: https://github.com/SSSD/sssd/pull/345
Author: fidencio
Title: #345: Improve the situation of recurrent failing CI tests
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/345/head:pr345
git checkout pr345
_
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@list
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
mzidek-rh commented:
"""
I think the fact that the increased timeouts helped stabilize the tests is
helpful information. I did not look into the issue itself yet, but it may help
pinpoin
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
lslebodn commented:
"""
>I think the fact that the increased timeouts helped stabilize the tests is
>helpful information. I did not look into the issue itself yet, but it may help
>pinpo
33 matches
Mail list logo
