cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html CheckboxTag.java

2003-09-26 Thread dgraham
dgraham 2003/09/25 23:22:05 Modified:src/share/org/apache/struts/taglib/html CheckboxTag.java Log: Removed the instanceof String check before calling result.toString(). If result is already a String, there is no harm in calling its toString() method. Revision Changes

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html CheckboxTag.java

2003-09-26 Thread dgraham
dgraham 2003/09/25 23:28:05 Modified:src/share/org/apache/struts/taglib/html CheckboxTag.java Log: Refactored the checked logic into a new isChecked() method. Revision ChangesPath 1.21 +32 -21

DO NOT REPLY [Bug 23433] New: - BodyTag.EVAL_BODY_TAG deprecated

2003-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23433. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 23433] - BodyTag.EVAL_BODY_TAG deprecated

2003-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23433. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: struts-chain, wildcards, web services

2003-09-26 Thread Guido García Bernardo
I know axis4struts (http://sourceforge.net/projects/axis4struts/), but I think the project is not active... XML Apache Axis access to Jakarta Struts Applications! Our goal is to provide a standard Axis/SOAP Interface to Struts that allows the same Struts Actions, Business Logic and Data Model

DO NOT REPLY [Bug 23433] - BodyTag.EVAL_BODY_TAG deprecated

2003-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23433. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

RE: Struts vs JSP : Validators

2003-09-26 Thread Edgar P Dollin
Tiles and validator contain functionality not readily available in JSF. Edgar -Original Message- From: Guido García Bernardo [mailto:[EMAIL PROTECTED] Sent: Friday, September 26, 2003 6:41 AM To: Struts Developers List Subject: Struts vs JSP : Validators What do you think

Re: Struts 1.1 unittest suite problem

2003-09-26 Thread Robert Leland
James Mitchell wrote: Sorry for the late response. I finally got some time to take a look at this and after fixing a few problems related to cactus configuration, I finally got the tests to run. Unfortunately, a few minutes and 665 tests later it bombed on the ErrorsTag tests. It seems we

RE: How can I extend a Struts tag?

2003-09-26 Thread Paananen, Tero
Can somebody tell me which is the best way to do this? Oh boy :) There was a long discussion not so long ago about the problems with extending the tags (not limited to the Struts tags, btw) on this list. You're stuck with copy-and-pasteing TextTag.doStartTag() into your new tag, then

RE: How can I extend a Struts tag?

2003-09-26 Thread Joe Germuska
You're stuck with copy-and-pasteing TextTag.doStartTag() into your new tag, then sprinkling your modifications in there. Alternatively, you could refactor TextTag to make it easier to extend, and then submit the refactoring as a request-for-enhancement, and extend the refactored version... Joe

Re: How can I extend a Struts tag?

2003-09-26 Thread Robert Leland
Paananen, Tero wrote: Can somebody tell me which is the best way to do this? Oh boy :) There was a long discussion not so long ago about the problems with extending the tags (not limited to the Struts tags, btw) on this list. If you do want to extend a tag, try to use the nightly source

Re: How can I extend a Struts tag?

2003-09-26 Thread David Cypers
I finally did it (thanks to Chris Gastin for putting me o/t track). But instead of extending the TextTag, i extended the BaseFieldTag. In the constructor, I wrote: public StrutsDateChooserTag() { super(); type = "text"; } Further, I did only override public int doStartTag() throws

RE: How can I extend a Struts tag?

2003-09-26 Thread Paananen, Tero
public int doStartTag() throws JspException { int tempValue = super.doStartTag(); StringBuffer href = new StringBuffer(some stuff); ResponseUtils.write(pageContext, sb.toString()); return tempValue; } This all works fine for me! So you're doing

creating beans.

2003-09-26 Thread khabot zakaria
Hi, How to create a bean corresponding to a tagLib, and how to generate an Action like /logon. Thanks..

DO NOT REPLY [Bug 16810] - Javascript Date validation for datePattern not supported

2003-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16810. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: Struts vs JSP : Validators

2003-09-26 Thread Craig R. McClanahan
Guido García Bernardo wrote: What do you think about Struts validators vs JSF validators ? (advantages, etc) I think you encourage the user to migrate to jsf html tags instead of using the struts ones (at least for new projects), but what about validators? This isn't really an either-or

DO NOT REPLY [Bug 22384] - datePattern not supported by JavaScript

2003-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22384. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 16810] - Javascript Date validation for datePattern not supported

2003-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16810. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 22384] - datePattern not supported by JavaScript

2003-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22384. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-struts/conf/share validator-rules.xml

2003-09-26 Thread rleland
rleland 2003/09/26 09:53:42 Modified:conf/share validator-rules.xml Log: Bug#: 22384 context diff provided by [EMAIL PROTECTED] Modify javascript to honor datapattern option. Revision ChangesPath 1.41 +6 -3 jakarta-struts/conf/share/validator-rules.xml

DO NOT REPLY [Bug 22384] - datePattern not supported by JavaScript

2003-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22384. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

[Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread Robert Leland
Over 99% of commons-validator usage is through struts. In fact it may be 100%. I feel the only way to really promote commons-validator to Beta status is to make the nightly build of struts depend on the 1.1.0 version which has released in August and been designated an Alpha. I propose that this

Re: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread James Mitchell
+1 -- James Mitchell Software Engineer / Struts Evangelist http://www.struts-atlanta.org 678.910.8017 770.822.3359 AIM:jmitchtx - Original Message - From: Robert Leland [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 26, 2003 1:14 PM Subject: [Short Term Plan] Struts

Re: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread David Graham
I agree 100%. +1 to using commons-validator 1.1.0. David --- Robert Leland [EMAIL PROTECTED] wrote: Over 99% of commons-validator usage is through struts. In fact it may be 100%. I feel the only way to really promote commons-validator to Beta status is to make the nightly build of struts

Re: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread James Holmes
+1 Over 99% of commons-validator usage is through struts. In fact it may be 100%. I feel the only way to really promote commons-validator to Beta status is to make the nightly build of struts depend on the 1.1.0 version which has released in August and been designated an Alpha. I propose

cvs commit: jakarta-struts/src/share/org/apache/struts/validator/validwhen ValidWhen.java

2003-09-26 Thread turner
turner 2003/09/26 11:12:24 Modified:src/share/org/apache/struts/validator FieldChecks.java src/share/org/apache/struts/validator/validwhen ValidWhen.java Log: Changed validator signatures to use ActionMessages rather than ActionErrors, was

RE: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread James Turner
+1 here too Also note that in deprecating ActionErrors (whomever did that, it's lost in the bowels of my e-mail archive), it broke all the default validators because they had ActionErrors in their method signatures. I released a fix for it today. James -Original Message- From: James

RE: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread David Graham
Only ActionError was deprecated, not ActionErrors. We still need to use ActionErrors because the ActionForm.validate() method returns an instance of that class. ActionMessage should be used instead of ActionError though. David --- James Turner [EMAIL PROTECTED] wrote: +1 here too Also note

RE: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread James Turner
Ok, color me confused. Why then is are the validator methods being called with an ActionMessages object rather than an ActionErrors object? That's what was breaking things. (This is what happens when you step away to deal with the Real World for a few months...) James -Original

Re: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread Robert Leland
David Graham wrote: Only ActionError was deprecated, not ActionErrors. We still need to use ActionErrors because the ActionForm.validate() method returns an instance of that class. ActionMessage should be used instead of ActionError though. Eventually we'll need to add a method that will allow

Re: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread Sgarlata Matt
Some other suggestions: findErrors() getErrors() getErrorMessages() getActionMessages() I like doValidate(), validateForm(), getActionMessages() and getErrorMessages(). Matt - Original Message - From: Robert Leland [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent:

cvs commit: jakarta-struts/src/share/org/apache/struts/validator Resources.java

2003-09-26 Thread turner
turner 2003/09/26 12:14:06 Modified:src/share/org/apache/struts/validator Resources.java Log: Fix to successfully pass errors to validators Revision ChangesPath 1.22 +5 -5 jakarta-struts/src/share/org/apache/struts/validator/Resources.java Index:

Re: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread Ted Husted
Maybe we can wait until it's time to add a form of validate that will just take a mutable ActionContext and return void, and deprecate it all at once. Robert Leland wrote: David Graham wrote: Only ActionError was deprecated, not ActionErrors. We still need to use ActionErrors because the

Action Chaining

2003-09-26 Thread Derek Richardson
To enable action chaining in an intuitive way, it seems that when the ActionServlet is called, it can look for an attribute in the request that indicates whether it has run before in this request. If the attribute is not there, do everthing and then set the attribute; if the attribute is there,

Struts-el: Page Tag: Why?

2003-09-26 Thread Derek Richardson
The bean:page tag is not one of the tags listed as not being ported into struts-el (http://jakarta.apache.org/struts/faqs/struts-el.html). This means that bean:page can do something struts-el cannot. Will someone point out to me what this is? I wrote a test JSP and cannot find any functionality

Re: Action Chaining

2003-09-26 Thread Sgarlata Matt
There are probably many different solutions to make action chaining more intuitive. However, action chaining is not considered a best practice in the Struts community so effort will not be put forward to make it easier to do. There has been a lot of discussion of action chaining in both the user

RE: Struts-el: Page Tag: Why?

2003-09-26 Thread Karr, David
-Original Message- From: Derek Richardson [mailto:[EMAIL PROTECTED] The bean:page tag is not one of the tags listed as not being ported into struts-el (http://jakarta.apache.org/struts/faqs/struts-el.html). This means that bean:page can do something struts-el cannot. Will

Re: [Short Term Plan] Struts to depend on Validator 1.1.0

2003-09-26 Thread David Graham
--- Ted Husted [EMAIL PROTECTED] wrote: Maybe we can wait until it's time to add a form of validate that will just take a mutable ActionContext and return void, and deprecate it all at once. Well, ActionError was easily replaced with ActionMessage. Also, I updated most references to

Re: Struts vs JSP : Validators

2003-09-26 Thread Ted Husted
In the context of new development You might be thinking of the JSTL tags (struts-el). Since JavaServer Faces is still in the Early Access stage, I don't believe any of us would be recommending JSF for new development that you planned on shipping yourself. The Early Access license says that

Re: creating beans.

2003-09-26 Thread Ted Husted
These types of questions are best asked on the Struts USER list. http://jakarta.apache.org/struts/using.html#Lists khabot zakaria wrote: Hi, How to create a bean corresponding to a tagLib, and how to generate an Action like /logon. Thanks.. -- Ted Husted,

Re: struts-chain, wildcards, web services

2003-09-26 Thread Ted Husted
Don Brown wrote: Regarding wildcards (http://issues.apache.org/bugzilla/show_bug.cgi?id=21813), I decided to hold of on putting them as it seemed a 1.1.1(2?) was around the corner. However, as it looks like it is not, I'd like to put it in this weekend. It sounded to me like this code was

Re: Editable Fields V/S Static Text

2003-09-26 Thread Ted Husted
Chris Gastin wrote: As I can tell from the list I have opened topic that is pretty well beaten. Let me first apologize. I did not realize this was such a political topic in the Struts community. There was a time when we were encouraging people to use the JSTL, and there was a political bent

RE: Action Chaining

2003-09-26 Thread Derek Richardson
I was trying to avoid rehashing old arguments about action chaining. I have heard two arguments: one, it is not supported and can cause strange results and, two, it is indicative of bad design (the argument made below). I disagree that action chaining is always indicative of bad design. See my

RE: Editable Fields V/S Static Text

2003-09-26 Thread Edgar P Dollin
For the first time in many months, there was some visible progress in the area of acceptance of submissions on tags. Thank you David and Robert. I do have some points that I am sure will draw fire, but I have been an idiot on this forum for so long... 1) It is fine that the basic tags in struts

Re: Editable Fields V/S Static Text

2003-09-26 Thread David Graham
--- Ted Husted [EMAIL PROTECTED] wrote: Chris Gastin wrote: As I can tell from the list I have opened topic that is pretty well beaten. Let me first apologize. I did not realize this was such a political topic in the Struts community. There was a time when we were encouraging people

Re: Editable Fields V/S Static Text

2003-09-26 Thread Sgarlata Matt
- Original Message - From: David Graham [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Friday, September 26, 2003 7:52 PM Subject: Re: Editable Fields V/S Static Text However, at this time, we have a Struts-el taglib in circulation. We even have a Struts-faces

RE: Editable Fields V/S Static Text

2003-09-26 Thread David Graham
--- Edgar P Dollin [EMAIL PROTECTED] wrote: For the first time in many months, there was some visible progress in the area of acceptance of submissions on tags. Thank you David and Robert. I do have some points that I am sure will draw fire, but I have been an idiot on this forum for so

Re: Editable Fields V/S Static Text

2003-09-26 Thread David Graham
--- Sgarlata Matt [EMAIL PROTECTED] wrote: - Original Message - From: David Graham [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Friday, September 26, 2003 7:52 PM Subject: Re: Editable Fields V/S Static Text However, at this time, we have a Struts-el

Re: Editable Fields V/S Static Text

2003-09-26 Thread Ted Husted
Sgarlata Matt wrote: Of course if I really want that I should probably just use Velocity, huh? ;) +1. I do =:) -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Editable Fields V/S Static Text

2003-09-26 Thread Sgarlata Matt
- Original Message - From: David Graham [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Friday, September 26, 2003 1:02 AM Subject: Re: Editable Fields V/S Static Text --- Robert Leland [EMAIL PROTECTED] wrote: David Graham wrote: --- Sgarlata Matt [EMAIL

Re: Editable Fields V/S Static Text

2003-09-26 Thread Ted Husted
In the beginning, there was no Jakarta Taglibs, or inkling of something like JSTL. So, Craig bravely put together a useful implementation of some custom tags that did two things. First, they exposed the internals of the Struts Controller framework. Second, they provided some basic

Re: Editable Fields V/S Static Text

2003-09-26 Thread Craig R. McClanahan
Edgar P Dollin wrote: For the first time in many months, there was some visible progress in the area of acceptance of submissions on tags. Thank you David and Robert. Yes, the progress has been heartening. I'll throw some of my own thoughts in on your points below. I do have some points

Re: Action Chaining

2003-09-26 Thread Ted Husted
It is becoming commonplace to use an Action as a front for a server page. This is not what people mean when they talk about Action chaining. Some people start to use the Actions as finely-grained business actions. For example, they want to accomplish a move by forwarding to a copy Action and

RE: Action Chaining

2003-09-26 Thread James Turner
I haven't seen anyone mention the most common use of Action chaining, which is to process the form values from a submit, and use them to prepopulate a second page. Currently, this requires two Actions because there is no officially sanctioned method of instantiating a new form from an Action to

Re: Action Chaining

2003-09-26 Thread Ted Husted
Personally, I would tend to use a coarse-grained bean that contained the properties for both pages. But, AFAIK, calling RequestUtils.createActionForm directly is sanctioned, especially as a way of obtaining a DynaActionForm. -Ted. James Turner wrote: I haven't seen anyone mention the most