subsurface and dark themes

2013-12-23 Thread Tomaz Canabrava
Hullo. I'm a big fan of dark themes and almost all of my last patches are just to address te fact that dark themes are not very good on it yet. After the last one, I'm adding patches to do subtle animations. I hope I'll have a very good bunch of them till christmas. Tomaz

Re: christmas patches.

2013-12-26 Thread Tomaz Canabrava
Em 26/12/2013 08:23, Tomaz Canabrava tcanabr...@kde.org escreveu: Hy Em 26/12/2013 07:03, Patrick Valsecchi patr...@thus.ch escreveu: Hi, About the patch 0001: http://qt-project.org/doc/qt-4.8/qstringlist.html#contains So that would be shorter: const bool foundGoogleMap

Re: christmas patches.

2013-12-26 Thread Tomaz Canabrava
Em 26/12/2013 09:45, Patrick Valsecchi patr...@thus.ch escreveu: Early optimization is root to all evil. Anyway this question is eluded by my one liner replacement. Yes, it is. I do prefer your version. Can you send a patch ( with a sob line)? Tomaz Canabrava tcanabr...@kde.org a écrit

New branch on personal repo

2013-12-26 Thread Tomaz Canabrava
People, Dirk, I'm working insanely on a new branch in my personal repo 'newProfileSystem', that will try to share code between the profile and planner, and also make it better, safer, faster, stronger. so, this is my meta for now. :) Tomaz ___

Re: dive table and pointers

2013-12-26 Thread Tomaz Canabrava
Em 26/12/2013 20:06, Dirk Hohndel d...@hohndel.org escreveu: Tomaz, you asked this on IRC while I was unavailable: There are good reasons why you can't keep pointers to dives around and why you can't simply claim that the position in the dive table represents a specific dive: Things

Re: Editing a weight does not seem to work

2013-12-28 Thread Tomaz Canabrava
Will test this and submit a patch by today / tomorrow. Em 28/12/2013 17:42, Dirk Hohndel d...@hohndel.org escreveu: This should have been fixed a while ago... Please file a bug so I remember to track this down when I'm back home /D --- From my phone Lutz Vieweg l...@5t9.de wrote: On

Re: Fix imperial cylinder sizes in equipment tab

2014-01-03 Thread Tomaz Canabrava
from a Qt perspective, the hability to connect signals with lambdas is pretty userfull too. On Fri, Jan 3, 2014 at 4:07 PM, Lutz Vieweg l...@5t9.de wrote: On 01/03/2014 06:04 PM, Dirk Hohndel wrote: If it makes our code better, I'm all for it. If nothing else, it at least makes it less

Re: Fix imperial cylinder sizes in equipment tab

2014-01-03 Thread Tomaz Canabrava
Broken Hacks. Mentioned, HÁ. *runs* On Fri, Jan 3, 2014 at 5:48 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Jan 3, 2014 at 11:31 AM, Thiago Macieira thi...@macieira.org wrote: Make the constructor explicit by adding the explicit keyword. Oh wow. This is classic No,

bugfixes for 4.0.2

2014-01-06 Thread Tomaz Canabrava
From 8be61d8b2e308b4f33b4496a7ad127bb23d40a31 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Mon, 6 Jan 2014 20:00:10 -0200 Subject: [PATCH 1/2] Added CaseInsensitivity to all of the completers. Just one of the completers had Qt::CaseInsentitive set, setting for all

Re: Ghost effect while editing table cells

2014-01-07 Thread Tomaz Canabrava
Em 07/01/2014 20:04, Dirk Hohndel d...@hohndel.org escreveu: On Tue, 2014-01-07 at 17:46 +0100, Patrick Valsecchi wrote: On 07. 01. 14 17:15, Lubomir I. Ivanov wrote: On 7 January 2014 17:12, Patrick Valsecchi patr...@thus.ch wrote: On 07. 01. 14 16:02, Lubomir I. Ivanov wrote: On 7

Trying to understand the profile.c, please be nice to me. :)

2014-01-09 Thread Tomaz Canabrava
So, On the my tryto make the world better and separate the logic of the profiles I'v come to this: The DiveProfilePlot method will be changed to something similar to this: void DiveDepthTimeModel::setDive(dive* d,const plot_info pInfo) { // We need a way to find out if the dive setted is the

Re: Segfault in latest git version.

2014-01-17 Thread Tomaz Canabrava
Em 17/01/2014 08:09, Robert Helling hell...@atdotde.de escreveu: On 17.01.2014, at 11:01, Tomaz Canabrava tcanabr...@kde.org wrote: Tomaz, This fixes it, Sorry - my mistake. Dirk, can you apply? 0009-Fixed-a-crash.patch___ subsurface

Re: Patches for today.

2014-01-17 Thread Tomaz Canabrava
*texts*. 3 On Fri, Jan 17, 2014 at 4:11 PM, Tomaz Canabrava tcanabr...@kde.org wrote: From 5abefba61883528da8e9aee9a021d724550073d7 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Fri, 17 Jan 2014 17:54:47 -0200 Subject: [PATCH 8/8] Plot the Temperature Text. I Moved

Re: Can you show the heartrate in Subsurface?

2014-01-17 Thread Tomaz Canabrava
I'm going home right now, but I'll update the source and also plot it on screen and send a picture to you all :) On Fri, Jan 17, 2014 at 7:58 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Jan 17, 2014 at 1:55 PM, Tomaz Canabrava tcanabr...@kde.org wrote: if you guys helps

Re: make sure scene exists

2014-01-17 Thread Tomaz Canabrava
it's impossible for the scene to not exists, the first time, item is NULL, so it's not getting into the if, the second + n times, the item is created added to the scene RIGHT on bottom of that method. On Fri, Jan 17, 2014 at 8:40 PM, Dirk Hohndel d...@hohndel.org wrote: I'm puzzled about the

Re: faster representation of pow on some áreas of subsurface?

2014-01-19 Thread Tomaz Canabrava
dunno about the patch, never got into my branch :) On Sun, Jan 19, 2014 at 6:00 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Jan 19, 2014 at 11:29 AM, Tomaz Canabrava tcanabr...@kde.org wrote: I'v replaced the pow() call with the fastPow() that I found

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

2014-01-19 Thread Tomaz Canabrava
The result of this patch is this: http://wstaw.org/m/2014/01/19/plasma-desktopujz493.png it still looks like it deserves some kind of special treatment, but it's way faster now. On Sun, Jan 19, 2014 at 6:37 PM, Tomaz Canabrava tcanabr...@kde.org wrote: Linus, it makes things instant. *NOW* we

Re: sunday patches.

2014-01-19 Thread Tomaz Canabrava
xiu, don't forget my patches. :) On Sun, Jan 19, 2014 at 8:20 PM, Tomaz Canabrava tcanabr...@kde.org wrote: This set of patches improves greatly the uglyness of the new profile. now, fixing the size and placement of the time axis and depth axis should fix the rest

Re: More profile goodness

2014-01-21 Thread Tomaz Canabrava
last forgotten one. On Tue, Jan 21, 2014 at 3:37 PM, Tomaz Canabrava tcanabr...@kde.org wrote: From b2432c22892e30a61bdf4ca17edd24e53c32910f Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Tue, 21 Jan 2014 15:41:04 -0200 Subject: [PATCH 8/8] Remember to clean

Re: More profile goodness

2014-01-21 Thread Tomaz Canabrava
and now, with ceilings. 3 ( works with the preferences too. ) On Tue, Jan 21, 2014 at 3:42 PM, Tomaz Canabrava tcanabr...@kde.org wrote: last forgotten one. On Tue, Jan 21, 2014 at 3:37 PM, Tomaz Canabrava tcanabr...@kde.orgwrote: From 831690f9e4c051a2414c2b1217db6f9cc8b1f420 Mon Sep

Re: Priorities for a non-programmer

2014-01-22 Thread Tomaz Canabrava
Manual, Images, Design, Promotion, Marketing, all of those. :) On Wed, Jan 22, 2014 at 1:15 PM, Pedro Neves nevesdi...@gmail.com wrote: Hi all: I was wondering how can I contribute to the Subsurface project, besides coding... Which areas need attention? Is the manual still a priority?

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

2014-01-22 Thread Tomaz Canabrava
I'll pas that out to somebody else. :) On Wed, Jan 22, 2014 at 2:25 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-01-21 at 20:31 -0800, Linus Torvalds wrote: On Tue, Jan 21, 2014 at 7:49 AM, Dirk Hohndel d...@hohndel.org wrote: On Sun, 2014-01-19 at 14:21 -0800, Linus Torvalds

some patches for today

2014-01-22 Thread Tomaz Canabrava
slow day today. From f59bd425908d65c9c59286988bfba9a10e47df25 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Wed, 22 Jan 2014 15:08:19 -0200 Subject: [PATCH 1/3] Added a MeanDepthItem that has 2 strings. The dirk's implementation of the MeanDepth item was correct

Re: some patches for today

2014-01-22 Thread Tomaz Canabrava
More two. On Wed, Jan 22, 2014 at 5:27 PM, Tomaz Canabrava tcanabr...@kde.org wrote: slow day today. From 044e9a81a8c118136042b1499b7e66c672d0d28e Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Wed, 22 Jan 2014 17:54:24 -0200 Subject: [PATCH 4/5] Simplify the code

Today Patches.

2014-01-23 Thread Tomaz Canabrava
don't think I'll break anything in the near future by changing it. Tomaz From 31b748f382ac9c2705eba211b276383b2b3bc541 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Thu, 23 Jan 2014 15:02:12 -0200 Subject: [PATCH 01/10] Don't recreate the tissues, but instead, reshape

Re: Editable lists

2014-01-26 Thread Tomaz Canabrava
There should be a delete button on the right of the list. Em 26/01/2014 16:44, Willem Ferguson willemfergu...@zoology.up.ac.za escreveu: Several fields in Subsurface have editable lists where one can add items. These include locality, DiveMaster, cylinder and weights by typing a value that has

Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-01-27 Thread Tomaz Canabrava
*I'll step out as a mentor - this year I *do* really wanna participate *on gsoc, as a student. :) On Sun, Jan 26, 2014 at 3:32 PM, Dirk Hohndel d...@hohndel.org wrote: On Sun, 2014-01-26 at 09:49 -0600, Kunda Loves Scribus wrote: Hey all, It's almost time (Feb 3rd) for Projects to

PP Graphs patch

2014-01-27 Thread Tomaz Canabrava
the new profile is starting to get userful. From ee67dfa5a37950bcc35466a061e62b6fbf8a7c59 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Mon, 27 Jan 2014 14:59:50 -0200 Subject: [PATCH] Added Settings Awareness for the PP Graph This commit is rather big, and I forgot

Re: patches for the new profile

2014-02-05 Thread Tomaz Canabrava
QGraphicsView::viewport() On Wed, Feb 5, 2014 at 2:40 PM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 5 February 2014 17:58, Tomaz Canabrava tcanabr...@kde.org wrote: Lubomir, For unknown reasons sceneRect() returns 100 for width I forced that the scene have 100 width / height so

Enabling ToolTips on the new profile.

2014-02-05 Thread Tomaz Canabrava
I'm gonna be irooon like a lin in zin. From 4996e0117684484ed3f693a96d9200734aea8386 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Wed, 5 Feb 2014 14:25:28 -0200 Subject: [PATCH 1/5] Moved the divetooltipitem to it's own file. This is needed so we can share

Re: Enabling ToolTips on the new profile.

2014-02-05 Thread Tomaz Canabrava
last one. On Wed, Feb 5, 2014 at 4:01 PM, Tomaz Canabrava tcanabr...@kde.org wrote: I'm gonna be irooon like a lin in zin. From b68ac2d70a6bb442b53753855bc357e951310886 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Wed, 5 Feb 2014 16:15:59 -0200 Subject

Re: Enabling ToolTips on the new profile.

2014-02-06 Thread Tomaz Canabrava
is not merged yet, this is a followup patch, On Wed, Feb 5, 2014 at 4:17 PM, Tomaz Canabrava tcanabr...@kde.org wrote: last one. On Wed, Feb 5, 2014 at 4:01 PM, Tomaz Canabrava tcanabr...@kde.orgwrote: I'm gonna be irooon like a lin in zin. From

Re: Enabling ToolTips on the new profile.

2014-02-06 Thread Tomaz Canabrava
from the preferences (and find a good spot for show unused tanks). All that said, I pushed the changes after some edits to the commit messages :-) /D On Thu, 2014-02-06 at 12:00 -0200, Tomaz Canabrava wrote: is not merged yet, this is a followup patch, On Wed, Feb 5, 2014 at 4:17 PM

Pàtches for the Settings / Profile.

2014-02-06 Thread Tomaz Canabrava
and I ran I ran so far away... I just ran... I ran all night and day... From f5ef5826d6787246d08e34b88ebbd7c9b218fa93 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Thu, 6 Feb 2014 15:38:32 -0200 Subject: [PATCH 5/5] Process events just after starting the StateMachine

Re: SubsurfaceAbout class cleanup.

2014-02-08 Thread Tomaz Canabrava
I don't mind removing the instance() classes, I created them that way so it was easyer to create them in the correct order ( meaning, no order at all :P ) On Sat, Feb 8, 2014 at 5:50 AM, Boris Barbulovski bbarbulov...@gmail.comwrote: An SubsurfaceAbout class cleanup. Main change is that now

Re: SubsurfaceAbout class cleanup.

2014-02-08 Thread Tomaz Canabrava
not connected to anything else. the way that he did, the widget gets deleted when it``s closed, and created when it`s invoked, not shareable. wich gives us a bit of memory - gain ( tiny bit but appreciated. ) /D On Sat, 2014-02-08 at 09:03 -0200, Tomaz Canabrava wrote: I don't mind removing

Re: segmentation fault with last git version

2014-02-10 Thread Tomaz Canabrava
Lubomir was quicker. Em 10/02/2014 07:57, Tomaz Canabrava tcanabr...@kde.org escreveu: Em 10/02/2014 02:58, Miika Turkia miika.tur...@gmail.com escreveu: I was able to reproduce with debug and normal builds. I start subsurface and close default log file immediately. The graph stays

Re: segmentation fault with last git version

2014-02-10 Thread Tomaz Canabrava
On Mon, Feb 10, 2014 at 1:11 PM, Dirk Hohndel d...@hohndel.org wrote: On Mon, 2014-02-10 at 07:57 -0200, Tomaz Canabrava wrote: Lubomir was quicker. But while Lubomir's patch fixes the crash, it doesn't address the real issue: we should not try to show a profile if there are no dives. We

Proper fix to the 'close' file crash on the new profile.

2014-02-10 Thread Tomaz Canabrava
I didn't cleared the model when closing the file ( because I never closed the file, sigh. ) now it works :) Tomaz From 87f71fe3bdeaff8b2233c1424ed25d3c5533b17b Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Mon, 10 Feb 2014 15:04:27 -0200 Subject: [PATCH 3/3] Do not add

Re: GSOC 2014

2014-02-10 Thread Tomaz Canabrava
On Mon, Feb 10, 2014 at 3:51 PM, Mcl jos...@megvel.me.ke wrote: Hi all, Am planning on taking part in GSOC this year. I have experience in Qt from past involvemein Sqlite database studio. I hope I get a chance to work with you all. Joshua Joshua, While google didn't choosed us yet ( as

Re: MainWindow tied splitterMoved event

2014-02-11 Thread Tomaz Canabrava
On Tue, Feb 11, 2014 at 1:07 PM, Boris Barbulovski bbarbulov...@gmail.comwrote: This patch makes both MainWindow splitters to move the same when one of them is moved by the user. In order to access QSplitter protected member, I had to subclass QSplitter into new class. I know this

Re: SAC and Gas Consumed Calculation

2014-02-11 Thread Tomaz Canabrava
My subsurface-programming-computer is at work compiling 16gbs of software, but it`s easy to do. look for DiveItem on models.cpp and on `data` function add a: if (role == ToolTipRole ){ return tr( text here ); } On Tue, Feb 11, 2014 at 8:00 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue,

Polishments to the new profile.

2014-02-12 Thread Tomaz Canabrava
good new polishments for the new profile. hiding / enabling PP graph now is smoother, animated and fun. ;p From 7e42c62b2b485add9cb3b76c62ae7e652e3644f4 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Wed, 12 Feb 2014 14:41:59 -0200 Subject: [PATCH 5/5] Make the Mean Depth

new-profile fixes

2014-02-14 Thread Tomaz Canabrava
Can I have a dive with heartbeats so I can test my next path? -T From fffd2cbda986952635dca46aae23d81600240f16 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Fri, 14 Feb 2014 22:04:18 -0200 Subject: [PATCH 4/4] Align Right side of Cylinder Pressure Text to the Left

Re: new-profile fixes

2014-02-14 Thread Tomaz Canabrava
Thanks. :) On Fri, Feb 14, 2014 at 10:27 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Feb 14, 2014 at 4:10 PM, Tomaz Canabrava tcanabr...@kde.org wrote: Can I have a dive with heartbeats so I can test my next path? You should have one already. See the thread Can you

new profile: grids and fixes.

2014-02-15 Thread Tomaz Canabrava
Things are pretty pretty now. :) can a few of you take a look and tell me what you think? ( enable / disable pp graphs, move from one dive to another ) From b9cd00b225dcb365d8520dcd82bce3fbaa523d57 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Sat, 15 Feb 2014 22

Beginning of the 'Context Menu' on the new profile

2014-02-17 Thread Tomaz Canabrava
With the Gas Change Event working, the rest's not yet. :) From 77de8cfef44038a122bd1bf72abefd2f8b6940df Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Mon, 17 Feb 2014 19:09:06 -0300 Subject: [PATCH] Make part of the Context Menu work ( Gas Change Event ) The code

Re: latest master

2014-02-17 Thread Tomaz Canabrava
On Mon, Feb 17, 2014 at 7:57 PM, Dirk Hohndel d...@hohndel.org wrote: This does not include the promised whitespace overhaul. Instead I added a few outstanding patches and went down the rabbit hole of trying to track down a crash with Robert's image shift patches. Here's how I can reliably

Re: latest master

2014-02-18 Thread Tomaz Canabrava
dirk, can you test the patch? I couldn`t really understand why it crashed if not static, since we should always have that object. saing that - the correct way to handle that should be from the Settings, no? QSettings s; s.value(lastUsedImageDirectory).toString() or something On Tue, Feb 18,

Re: latest master

2014-02-18 Thread Tomaz Canabrava
I think this happened because of the patch that transformed mainwindow to have an ::instance() method, but didn`t fully fixed the rest of the code. On Tue, Feb 18, 2014 at 9:47 PM, Thiago Macieira thi...@macieira.orgwrote: Em ter 18 fev 2014, às 16:30:01, Dirk Hohndel escreveu: Can someone

Re: Few new things for Subsurface.

2014-02-27 Thread Tomaz Canabrava
crash fix. On Thu, Feb 27, 2014 at 3:41 PM, Tomaz Canabrava tcanabr...@kde.org wrote: From de171a82209f36c626546e0d68d15b541ab87318 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Thu, 27 Feb 2014 16:42:00 -0300 Subject: [PATCH 8/8] Make the ruler Work. (caution

Re: PATCH for Ticket #445 (Adding units to mean depth value)

2014-03-02 Thread Tomaz Canabrava
Em 02/03/2014 09:56, Gopichand Paturi gopichandpat...@gmail.com escreveu: Hello Umair, I think all the bugs listed on that page are for all gsoc 2014 aspirants(as far as I know from my discussion with dirkhh) I'm not sure about the assignment part. And you can always try a new way to do the

Re: RFC: Initial git save format

2014-03-06 Thread Tomaz Canabrava
Linus, I can probably do the Qt UI in about 2h ( learning what need to be done on the UI, of course, never played with libgit. ) So, if this enters on subsurface master, I'll do the UI this weekend. Tomaz On Thu, Mar 6, 2014 at 6:28 PM, Linus Torvalds torva...@linux-foundation.org wrote: So

Re: RFC: Initial git save format

2014-03-07 Thread Tomaz Canabrava
#define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 20 save-git.c: In function 'create_new_commit': save-git.c:580:3: error: too many arguments to function 'git_branch_create' if (git_branch_create(ref, repo, branch, commit, 0, author, Create branch)) ^ can anybody recheck this for me?

Re: RFC: Initial git save format

2014-03-07 Thread Tomaz Canabrava
On Fri, Mar 7, 2014 at 11:34 AM, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.com wrote: On Fri, 7 Mar 2014, Tomaz Canabrava wrote: #define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 20 Debian has a 0.19.0-2 package in 'experimental', which means unavailable for 'unstable

Re: Patch

2014-03-07 Thread Tomaz Canabrava
Rishubh, The git commit is *local* to your machine, you can see if you commited anything to *your* git tree by issying the comand 'git log'. To submit this git commit that you did, if you used a branch, please run the command git format-patch master and send rhe resulting file. if you created

fix colors on the new profile.

2014-03-07 Thread Tomaz Canabrava
2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Sat, 8 Mar 2014 00:25:12 -0300 Subject: [PATCH 6/6] Fixe colors on the new profile. This patch fixes the colors on the new profile, the init of the colors map was not being done, this fixes it. a few problems were spotted on the new profile

Re: Patch

2014-03-08 Thread Tomaz Canabrava
On Sat, Mar 8, 2014 at 3:20 PM, Rishubh Jain rishubhj...@ymail.com wrote: sorry forgot to attach...attached here On Saturday, 8 March 2014 11:48 PM, Rishubh Jain rishubhj...@ymail.com wrote: Hi Dirk I have attached a screen shot with this mail of the new message box...please check if

Re: Technical Discussion on VPM

2014-03-09 Thread Tomaz Canabrava
following e-mails, please answer on the middle of the sentenses that your prase makes sense. ;) Regards, Gopichand. On Sun, Mar 9, 2014 at 6:44 PM, Tomaz Canabrava tcanabr...@kde.orgwrote: On Sun, Mar 9, 2014 at 10:09 AM, Gopichand Paturi gopichandpat...@gmail.com wrote: Hi Robert

Re: [PATCH 3/4] Profile2: use a different image when no profile is visible

2014-03-10 Thread Tomaz Canabrava
On Mon, Mar 10, 2014 at 1:16 PM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 10 March 2014 17:59, Lubomir I. Ivanov neolit...@gmail.com wrote: From: Lubomir I. Ivanov neolit...@gmail.com This patch adds a new image resource named poster.png which, is shown instead of the 3 posters.

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Tomaz Canabrava
On Tue, Mar 11, 2014 at 3:52 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Mar 11, 2014 at 11:35 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: most software that i've used make any preferences dialog modal. one potential user interaction issue here is if the main

Re: Buttons on the profile tool bar

2014-03-11 Thread Tomaz Canabrava
On Tue, Mar 11, 2014 at 4:30 PM, Willem Ferguson willemfergu...@zoology.up.ac.za wrote: On 11/03/2014 20:57, Tomaz Canabrava wrote: A 'Toggle Units' button on the toolbar can simplify this, what you think? Tomaz, I am always very concious of users with screens having less resolution

Re: Bugfixes for today

2014-03-11 Thread Tomaz Canabrava
dirk, looks like master doesn't have f9651adde887ed1a0c4 yet ( the 0002 ) did you applied and pushed those patches? Tomaz On Sun, Mar 9, 2014 at 11:16 AM, Tomaz Canabrava tcanabr...@kde.org wrote: 1 - Fix the ruler leaving artifacts on the profile 2 - Fix the notification area not getting

fix little gray area when loading a dive from a heavy divelog passed as argument.

2014-03-11 Thread Tomaz Canabrava
some bugfixes for today. :) From f45606b22ece4d63e232d7cecbb3de6f1a8aa466 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Tue, 11 Mar 2014 18:54:28 -0300 Subject: [PATCH 4/4] Only anim if not first dive when openning subsurface with a divelog. The animation

Re: 4.1 planning

2014-03-12 Thread Tomaz Canabrava
Em 12/03/2014 13:40, Dirk Hohndel d...@hohndel.org escreveu: On Wed, 2014-03-12 at 16:15 +0100, Robert Helling wrote: On 12.03.2014, at 15:50, Dirk Hohndel d...@hohndel.org wrote: Hi everyone, - if you are working on anything that causes UI changes or string changes, please respond

Re: [PATCH 5/6] Ruler: change how the ruler text drawing works

2014-03-12 Thread Tomaz Canabrava
Em 12/03/2014 14:07, Lubomir I. Ivanov neolit...@gmail.com escreveu: On 12 March 2014 05:21, Dirk Hohndel d...@hohndel.org wrote: On Wed, 2014-03-12 at 00:09 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com A couple of problems with the ruler: - the rotated

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Tomaz Canabrava
Em 15/03/2014 14:46, Linus Torvalds torva...@linux-foundation.org escreveu: On Thu, Mar 13, 2014 at 2:06 PM, Miika Turkia miika.tur...@gmail.com wrote: On Mon, Mar 10, 2014 at 11:34 PM, Linus Torvalds torva...@linux-foundation.org wrote: Yes. We currently have no really good way of

Re: [Patch] Open File Dialog File Location Text Misaligned

2014-03-17 Thread Tomaz Canabrava
it seems that the need to modify the dialog should occour only on mac, so a #ifdef seems necessary ( or a fix on qt itself ) ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: Error during compilation of Libdivecomputer for android

2014-03-17 Thread Tomaz Canabrava
On Mon, Mar 17, 2014 at 2:22 PM, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.com wrote: On Mon, 17 Mar 2014, Lubomir I. Ivanov wrote: On 17 March 2014 18:54, Tomaz Canabrava tcanabr...@kde.org wrote: On Mon, Mar 17, 2014 at 1:05 PM, Anton Lundin gla...@acc.umu.se wrote

Re: Cross-building Subsurface on Linux for Windows

2014-03-17 Thread Tomaz Canabrava
On Mon, Mar 17, 2014 at 3:19 PM, Alberto Corona albco...@gmail.com wrote: On Mon, Mar 17, 2014 at 1:11 PM, Farzana Raisa farzanaahme...@gmail.com wrote: Well, i guess i have came up with a solution for this http://trac.hohndel.org/ticket/436#comment:5 but now i am stuck with this

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Tomaz Canabrava
People, stawp. :) QPen p; p.setCosmetic( true ); THIS. it will make the pen not scale on zoom. On Tue, Mar 18, 2014 at 12:27 PM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 18 March 2014 17:17, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov

Re: subsurface Digest, Vol 28, Issue 130

2014-03-19 Thread Tomaz Canabrava
So new ideas mean while keeping the features of the android version and we can add more which suits sub surface right? Shemil, Please change the way you are subscribed to the subsurface mailing list, it's creating a lot of unecessary noise. 1 - Do not Top post 2 - Do not Bottom Post on an

patches regarding some of the bugs for 4.1 release

2014-03-19 Thread Tomaz Canabrava
That's still one bug that I'm hunging... do not release with that pesky bug on. From b33909135032837dcea6155cb9aa58d674306995 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Wed, 19 Mar 2014 18:29:35 -0300 Subject: [PATCH 7/7] Better handle of Keyboard on the Inline

help on fixing a ghost cylinder bug.

2014-03-20 Thread Tomaz Canabrava
So, I was playing with Dirk's DiveLog and I found a rather serious bug and started digging, and I'm a bit lost on how to solve it. The bug: Create two cylinders and edit them, o2, n2, then save. *some* values makes the cylinder count on the dive go crazy ( I use 32 as the 02 value and it jumps

Re: help on fixing a ghost cylinder bug.

2014-03-20 Thread Tomaz Canabrava
On Thu, Mar 20, 2014 at 6:03 PM, Jan Mulder jlmul...@planet.nl wrote: Not a solution yet, but some more observations. On 20-03-14 17:53, Tomaz Canabrava wrote: So, I was playing with Dirk's DiveLog and I found a rather serious bug and started digging, and I'm a bit lost on how to solve

Re: build errors with save-git.c and upstream libgit2

2014-03-21 Thread Tomaz Canabrava
On Fri, Mar 21, 2014 at 10:23 AM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 21 March 2014 15:19, Lubomir I. Ivanov neolit...@gmail.com wrote: today today i've tried pulling the latest libgit2 and got the following set of errors. i don't find 'git_checkout_opts opts' or '

Re: Qt5 on subsurface-android

2014-03-25 Thread Tomaz Canabrava
Em 25/03/2014 06:17, Venkatesh Shukla IIT BHU venkatesh.shukla.ee...@iitbhu.ac.in escreveu: On Tue, Mar 25, 2014 at 1:25 PM, Robert Helling hell...@atdotde.de wrote: On 25.03.2014, at 06:46, Venkatesh Shukla IIT BHU venkatesh.shukla.ee...@iitbhu.ac.in wrote: Hi, Subsurface on the

Road to 4.2

2014-03-25 Thread Tomaz Canabrava
People, We are in bugfix mode for 4.1, it will be an awesome release, we got picture support, something that was on the todo list for quite a while, a new and almost-identical profile that has smooth animations and it's the base for new graphical stuff that will be incorporated on new versions (

Re: [PATCH 0/5] Some steps to bring back printing support

2014-03-25 Thread Tomaz Canabrava
On Tue, Mar 25, 2014 at 6:47 PM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 25 March 2014 23:34, Lubomir I. Ivanov neolit...@gmail.com wrote: [PATCH 4/5] Print: enable printing with the new profile we again make the already active profile instance re-usable. as mentioned in the patch

Re: [PATCH] Include REMOVE slot

2014-04-02 Thread Tomaz Canabrava
why did you removed that ? :) On Wed, Apr 2, 2014 at 10:51 AM, Lakshman acrlaksh...@gmail.com wrote: Before someone shouts at me, here is the patch that resolves the 'remove' slot warning, because of my stupid mistake of ignoring the comment in tableview class. Thank you, Lakshman

Re: qt creator isn't opening in fedora 20

2014-04-06 Thread Tomaz Canabrava
On Sun, Apr 6, 2014 at 4:35 AM, Farzana Raisa farzanaahme...@gmail.comwrote: I am new to fedora. I have installed qt 5.2.1 in fedora 20. I checked the box launch qt creator after installation. But it is not launching qt creator. When i am trying to open it from tools-qt creator-bin-qt creator

Re: [PATCH] Unexpected Behaviour in preference window.

2014-04-10 Thread Tomaz Canabrava
On Thu, Apr 10, 2014 at 2:19 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-04-08 at 14:11 +0200, Gehad wrote: On 04/07/2014 10:22 PM, Dirk Hohndel wrote: I'd really like to have a prefs variable that tracks the currently active prefs and only reference that anywhere in the

first try to use a unit test based framework

2014-04-14 Thread Tomaz Canabrava
time ( we can also include the gcov tool to get the percent of code that is tested. ) Tomaz From e3bda68cc0e928bca0f26c99ea2943b21bc9bb5e Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Mon, 14 Apr 2014 13:38:21 -0300 Subject: [PATCH 11/11] Rework double-comparisson

Re: first try to use a unit test based framework

2014-04-14 Thread Tomaz Canabrava
Second try, with dirk's input on IRC. On Mon, Apr 14, 2014 at 1:46 PM, Tomaz Canabrava tcanabr...@kde.org wrote: So - CMake has a testing framework called CTest that can generate html reports and it's easy to integrate a new test on it. I created this in cmake *only* because it was what I

Re: first try to use a unit test based framework

2014-04-14 Thread Tomaz Canabrava
two patches that goes on top of the last three ones: 1 - list of files insteaf of grepping to *.c 2 - specify the libdcdevel path On Mon, Apr 14, 2014 at 2:35 PM, Tomaz Canabrava tcanabr...@kde.org wrote: Second try, with dirk's input on IRC. On Mon, Apr 14, 2014 at 1:46 PM, Tomaz

Re: patch: remove interdependencies from the code.

2014-04-16 Thread Tomaz Canabrava
More TODO's on the code: important thing: All the .c files should compile and link against a test app, this isn't happening right now because some of the C stuff depends on GUI ( it was way worse on the gtk version, but it's still bad. ) On Wed, Apr 16, 2014 at 10:57 PM, Tomaz Canabrava

long-waited fixes. ( sorry =D )

2014-04-24 Thread Tomaz Canabrava
dirk, take a look at 01, as I have never ever touched the c part of subsurface before. From 82acd10a9ab2726474ebe50d5f4a7327b23a4e01 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Thu, 24 Apr 2014 12:59:42 -0300 Subject: [PATCH 1/3] Save latitude and longitude

Re: The dive sample structure

2014-04-24 Thread Tomaz Canabrava
On Thu, Apr 24, 2014 at 4:22 PM, Willem Ferguson willemfergu...@zoology.up.ac.za wrote: Here is a consensus structure after correcting my miscalculations and taking the comments of Linus and Thiago. Without using uint16 or uint8 integers in some variables, the size of sample would be 64

Re: [PATCH] Fixing Hotkeys inconsistency for divecomputer/pref/numbering windows

2014-04-25 Thread Tomaz Canabrava
Thanks for your help Gehad. :) On Fri, Apr 25, 2014 at 3:32 PM, Gehad gehadelro...@gmail.com wrote: By this patch i believe that all the windows/popups should have been fixed. -- Regards, Gehad Elrobey ___ subsurface mailing list

Re: Profile toolbox button positions

2014-04-27 Thread Tomaz Canabrava
On Sun, Apr 27, 2014 at 3:22 PM, Willem Ferguson willemfergu...@zoology.up.ac.za wrote: For AFTER V4.1: Is it easily possible to make the display of toolbox buttons conditional? That is, when no helium is used, do not display the He button. When no heart rate data are available, do not

Re: 4.1 Beta on PlanetKDE

2014-04-28 Thread Tomaz Canabrava
of it. ^^ /D --- From my phone Tomaz Canabrava tcanabr...@kde.org wrote: 200+ hits on Subsurface on PlanetKDE today, If anybody is at Planet Gnome, could you please do a post too? :) Tomaz ___ subsurface mailing list subsurface@hohndel.org

Re: Some issues with the globe

2014-05-01 Thread Tomaz Canabrava
On Thu, May 1, 2014 at 1:55 PM, Richard DePas richard.de...@gmail.comwrote: Richard, I don't know if you can build subsurf from sources or not, but I just send two patches that address some of the issues, can you test them please? Tomaz I don't have a way of building from source. I am

Re: say say saaaay

2014-05-01 Thread Tomaz Canabrava
don't offer to edit the coordinates if 1 dive is selected. On Thu, May 1, 2014 at 1:51 PM, Tomaz Canabrava tcanabr...@kde.org wrote: mj feelings, ok, patches to deal with marble. From 60fe23d44277ffb2c07a9bef5023ff220189cbd8 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr

Re: heads up 4.1 and personal down time

2014-05-05 Thread Tomaz Canabrava
Dirk, can you push those from Robert ? I see that you just commited 30 minutes ago. :) I wanna a 'code window' for 4.2 :)) On Mon, May 5, 2014 at 8:55 AM, Robert Helling hell...@atdotde.de wrote: On 04.05.2014, at 19:13, Dirk Hohndel d...@hohndel.org wrote: Hi, I know that Tomaz will be

Re: heads up 4.1 and personal down time

2014-05-05 Thread Tomaz Canabrava
On Mon, May 5, 2014 at 7:33 PM, Dirk Hohndel d...@hohndel.org wrote: On Mon, 2014-05-05 at 19:29 -0300, Tomaz Canabrava wrote: Dirk, can you push those from Robert ? I see that you just commited 30 minutes ago. :) I will push those AFTER 4.1 is released. Right now I am trying to fix #511

Re: what's going on with 4.1

2014-05-07 Thread Tomaz Canabrava
for 4.2 lots of unit tests. ;) On Wed, May 7, 2014 at 7:29 PM, Dirk Hohndel d...@hohndel.org wrote: For those not on IRC... we found more bugs. Fixed them, broke things in the process, fixed those, noticed other bugs, fixed those, broke more things... As you can tell, we're making great

Re: [PATCH] Fix crash on dereferencing dangling pointers

2014-05-08 Thread Tomaz Canabrava
Em 08/05/2014 01:52, Thiago Macieira thi...@macieira.org escreveu: QList::first() returns a reference to an item, but that list was a temporary. The list gets destroyed at the end of the statement (the semi-colon), so we ended up keeping a reference to freed data (i.e., a dangling pointer0 I

On the road to 4.2

2014-05-10 Thread Tomaz Canabrava
People, The road to 4.2 is brigth and clear, let's make an awesome release. ;) Tomaz ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Little Annoyances and fixes

2014-05-10 Thread Tomaz Canabrava
, for the recalque passar longe. 3 Tomaz From d3b1cc36e7d2f314016c8605e8043d86a898bf76 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Sat, 10 May 2014 19:36:44 -0300 Subject: [PATCH 01/12] Added gitrule to ignore build/ directory I'm using CMake as buildsystem ( with qmake

Re: Little Annoyances and fixes

2014-05-11 Thread Tomaz Canabrava
On Sun, May 11, 2014 at 12:00 PM, Tomaz Canabrava tcanabr...@kde.org wrote: On Sun, May 11, 2014 at 10:58 AM, Thiago Macieira thi...@macieira.org wrote: Em dom 11 maio 2014, às 10:00:38, Tomaz Canabrava escreveu: I don't mind the cleanup, but I dislike the fact that you break things

  1   2   3   4   >