Re: subsurface crash when merging .xml files

2017-02-15 Thread Dirk Hohndel
On Wed, Feb 15, 2017 at 05:10:48PM -0800, Linus Torvalds wrote: > On Wed, Feb 15, 2017 at 5:04 PM, Linus Torvalds > wrote: > > > > Trivial patch attached > > .. and pull request on github sent to Dirk. Thank you, this has been pushed to master New daily builds

Re: Some modifications to the Spanish Webpage translation.

2017-02-15 Thread Dirk Hohndel
On Wed, Feb 15, 2017 at 11:28:43PM +0100, Salvador Cuñat wrote: > Hi Pablo. > > On Wed, Feb 15, 2017 at 01:17:09PM -0800, Pablo Wolter wrote: > > > > The goal of this patch is to neutralize the Spanish and make it > > understandable by all Spanish speakers, regardless if they come from > >

Re: Function emitDataChanged() in diveplannermodel.cpp not used consequently

2017-02-15 Thread Rick Walsh
On 16 February 2017 at 16:55, Dirk Hohndel wrote: > On Thu, Feb 16, 2017 at 08:14:34AM +1100, Rick Walsh wrote: > > On 16 February 2017 at 07:34, Stefan Fuchs wrote: > > > > > Hi All, > > > > > > I stumbled across one small thing: > > > > > > In

Re: Function emitDataChanged() in diveplannermodel.cpp not used consequently

2017-02-15 Thread Dirk Hohndel
On Thu, Feb 16, 2017 at 08:14:34AM +1100, Rick Walsh wrote: > On 16 February 2017 at 07:34, Stefan Fuchs wrote: > > > Hi All, > > > > I stumbled across one small thing: > > > > In diveplannermodel.cpp there is a very simple function emitDataChanged() > > but it is not used

Re: subsurface crash when merging .xml files

2017-02-15 Thread Linus Torvalds
On Wed, Feb 15, 2017 at 5:04 PM, Linus Torvalds wrote: > > Trivial patch attached .. and pull request on github sent to Dirk. Linus ___ subsurface mailing list subsurface@subsurface-divelog.org

Re: subsurface crash when merging .xml files

2017-02-15 Thread Linus Torvalds
On Wed, Feb 15, 2017 at 5:01 PM, Linus Torvalds wrote: > > Let me check if just fixing that one line fixes it. Yes, that seems to be the only problem. I didn't actually verify what the end result of the merge looked like, but it didn't crash and seemed generally

Re: subsurface crash when merging .xml files

2017-02-15 Thread Linus Torvalds
On Wed, Feb 15, 2017 at 4:25 PM, Alessandro Volpi wrote: > > After a few seconds after the beginning of the file merge operation > subsurface crashed. I can recreate this. It crashes in strcmp() with a NULL pointer, because of the if (!strcmp(a->dc.model, "planneed

subsurface crash when merging .xml files

2017-02-15 Thread Alessandro Volpi
Hi all. I have tried to simulate what would happen if I try to import NEW DIVES from my SmartTrak log file to my existing .xml subsurface log file. I have got my subsurface data file, named "complete.xml", relying on executable smtk2ssrf_test.AppImage. The "complete.xml" file last dive is # 501

Re: Some modifications to the Spanish Webpage translation.

2017-02-15 Thread Salvador Cuñat
Hi Pablo. On Wed, Feb 15, 2017 at 01:17:09PM -0800, Pablo Wolter wrote: > > The goal of this patch is to neutralize the Spanish and make it > understandable by all Spanish speakers, regardless if they come from > Spain, Chile (as my case) or Mexico for example. > Your changes do not only make

Some modifications to the Spanish Webpage translation.

2017-02-15 Thread Pablo Wolter
Salvador Cuñat has done an extraordinary work on translating Subsurface to Spanish. However, the "flavor" of the Spanish is to tied to Spanish from Spain. Has some words that we do not use in Latin America. The goal of this patch is to neutralize the Spanish and make it understandable by all

Re: Function emitDataChanged() in diveplannermodel.cpp not used consequently

2017-02-15 Thread Rick Walsh
On 16 February 2017 at 07:34, Stefan Fuchs wrote: > Hi All, > > I stumbled across one small thing: > > In diveplannermodel.cpp there is a very simple function emitDataChanged() > but it is not used consequently. Already a few lines below the same code > (which is in fact only one

Function emitDataChanged() in diveplannermodel.cpp not used consequently

2017-02-15 Thread Stefan Fuchs
Hi All, I stumbled across one small thing: In diveplannermodel.cpp there is a very simple function emitDataChanged() but it is not used consequently. Already a few lines below the same code (which is in fact only one line) is again used instead of calling the function. Is there are reason for

Subsurface minimum gas calculation - First version for review

2017-02-15 Thread Stefan Fuchs
Hi Robert, hi Rick, hi All, Am 15.02.2017 um 02:23 schrieb Rick Walsh: > On 15 February 2017 at 06:50, Stefan Fuchs > wrote: > > Hi All, > > Joachim (R.) and I finished our first basic version of the minimum > gas calculation for the planner. >

Re: translations of the website

2017-02-15 Thread Dirk Hohndel
On Wed, Feb 15, 2017 at 02:41:21PM +0100, Jan Mulder wrote: > On 14-02-17 19:00, Dirk Hohndel wrote: > > We don't have the website translated to Dutch - the other languages we all > > have, but in very different stages of maintenance. Spanish is in fantastic > > shape, sometimes even ahead of

Re: translations of the website

2017-02-15 Thread Jan Mulder
On 14-02-17 19:00, Dirk Hohndel wrote: We don't have the website translated to Dutch - the other languages we all have, but in very different stages of maintenance. Spanish is in fantastic shape, sometimes even ahead of English (thank you Salva for catching the link on the home page). Started

Re: translations of the website

2017-02-15 Thread Tomaz Canabrava
On Tue, Feb 14, 2017 at 7:00 PM, Dirk Hohndel wrote: > Hi Everyone, > > I'm very happy how well the change to the content management for the > Subsurface-divelog.org website has worked out. Quite a few people have > contributed content and translations. > > Similar to the