[PATCH 5/6] Remove unused variable

Signed-off-by: Anton Lundin gla...@acc.umu.se --- libdivecomputer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libdivecomputer.c b/libdivecomputer.c index a990a4f..199a21d 100644 --- a/libdivecomputer.c +++ b/libdivecomputer.c @@ -700,7 +700,6 @@ static void event_cb(dc_device_t *device

[PATCH] Remove duplicate tool-tip setting

We set the real tool-tips with setBtnToolTip from maintab.cpp, so this is just duplicate and miss-leading. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/tableview.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/qt-ui/tableview.cpp b/qt-ui/tableview.cpp index 1dbfd89..a07a70d

[PATCH 2/6] Populate the plot info with tts information

Signed-off-by: Anton Lundin gla...@acc.umu.se --- profile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/profile.c b/profile.c index 6c47545..79de828 100644 --- a/profile.c +++ b/profile.c @@ -603,6 +603,7 @@ struct plot_data *populate_plot_entries(struct dive *dive, struct divecomputer

[PATCH 4/6] Parse time on only one place in DLF import

Signed-off-by: Anton Lundin gla...@acc.umu.se --- parse-xml.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/parse-xml.c b/parse-xml.c index a14c3e7..e8589fa 100644 --- a/parse-xml.c +++ b/parse-xml.c @@ -2535,6 +2535,7 @@ int parse_dlf_buffer(unsigned char

[PATCH 6/6] Add the dive start DLF event type

Signed-off-by: Anton Lundin gla...@acc.umu.se --- parse-xml.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/parse-xml.c b/parse-xml.c index df24263..7393429 100644 --- a/parse-xml.c +++ b/parse-xml.c @@ -2604,6 +2604,12 @@ int parse_dlf_buffer(unsigned char *buffer, size_t size

[PATCH 2/7] Lift code out to write_suunto_vyper_settings

This lifts the writing of settings out of the run() method and introduces better error handling when libdivecomputer returns a error. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 113 ++- 1 file changed, 76 insertions

[PATCH 3/7] Lift code out to read_ostc3_settings

This lifts the reading of settings out of the run() method and introduces better error handling when libdivecomputer returns a error. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 451 +++ 1 file changed, 222 insertions

Re: After 4.3 is out...

On 24 December, 2014 - Tomaz Canabrava wrote: On Wed, Dec 24, 2014 at 8:26 AM, Gehad Elrobey gehadelro...@gmail.com wrote: On Mon, Dec 22, 2014 at 10:18 PM, Anton Lundin gla...@acc.umu.se wrote: On 22 December, 2014 - Dirk Hohndel wrote: On Mon, Dec 22, 2014 at 05:57:34PM +0100

Re: [PATCH 16/17] Remove unused strings from ui files

=QTableView name=tableView/ //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH 16/17] Remove unused strings from ui files

On 24 December, 2014 - Dirk Hohndel wrote: On Wed, Dec 24, 2014 at 01:38:34PM +0100, Anton Lundin wrote: Its the title property who have bin serving as some sort of spacer, i guess. We should fix so the add + button takes the approperiate space. Meanwhile you can: diff --git

Re: [PATCH] Added the option of explicitly opening the User Survey form from the help menu

of NO_USERSURVEY, and the row that removes the action from the menu to. I see no motivation to keep a define that removes that from the menu. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http

Re: After 4.3 is out...

-- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Added the option of explicitly opening the User Survey form from the help menu

On 20 December, 2014 - Nikhil Bharadwaj wrote: Anton, This is the final patch. Once instance of NO_USERSURVEY had to be retained. I don't really se why it needs to be there. Can you explain? //Anton Nikhil Bharadwaj On Thu, Dec 18, 2014 at 6:43 PM, Anton Lundin gla...@acc.umu.se

Re: [PATCH 13/17] Free tag lists propperly

On 20 December, 2014 - Miika Turkia wrote: On Thu, Dec 18, 2014 at 9:47 AM, Anton Lundin gla...@acc.umu.se wrote: The previous taglist_free didn't free the divetag, it only freed the tag. This patch causes a crash on my dive log. The crash can be replicated with the test dive test29

Re: [PATCH] Usermanual - additional info for adding user to dialout-group - 2nd try

belongs to which group. There are other ways to change the groups list for your session, but none that i can recommend to non-maniacs =) So, the only sane recommendation is to logout and log back in again. //Anton -- Anton Lundin+46702-161604

Re: After 4.3 is out... CCR

On 18 December, 2014 - Willem Ferguson wrote: On 18/12/2014 09:33, Anton Lundin wrote: On 18 December, 2014 - Willem Ferguson wrote: On 18/12/2014 03:27, Tomaz Canabrava wrote: Tomaz, If it's possible at all, we need to complete the CCR UI. Would you be prepared to help, please? I

Re: [PATCH] Added the option of explicitly opening the User Survey form from the help menu

about when writing a good commit message in README, especially the Contributing: section. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman

Re: [PATCH 03/17] Remove unused dummy widgets in filterwidget

On 18 December, 2014 - Tomaz Canabrava wrote: On Thu, Dec 18, 2014 at 1:14 PM, Miika Turkia miika.tur...@gmail.com wrote: This makes the new filtering unusable so nack from me. miika On Thu, Dec 18, 2014 at 9:47 AM, Anton Lundin gla...@acc.umu.se wrote: Signed-off-by: Anton

Re: Help needed: User manual - DM5 and Uemis/Vyper configuration

On 08 December, 2014 - Miika Turkia wrote: On Sun, Dec 7, 2014 at 11:25 PM, Anton Lundin gla...@acc.umu.se wrote: On 07 December, 2014 - Miika Turkia wrote: On Sun, Dec 7, 2014 at 10:35 PM, Anton Lundin gla...@acc.umu.se wrote: On 07 December, 2014 - Miika Turkia wrote

Re: After 4.3 is out...

-validation-analysis? Tracking o2-cell performance over time to be able to do pre-fail-warnings? Finish off the android downloader code and get that app actually working. Build a android-planner based on the subsurface planner? //Anton - END-OF-IDEAS -- Anton Lundin+46702-161604

Re: [PATCH] Added the option of explicitly opening the User Survey form from the help menu

::on_actionUserSurvey_triggered() +{ +#ifndef NO_USERSURVEY + if(!survey) { + survey = new UserSurvey(); Missing a connection to the parent here. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org

Fixes found with valgind

about how qt actually works, but they doesn't break things horribly and doesn't trigger leaks according to valgrind anylonger =) //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http

[PATCH 14/17] Free global tags list on exit.

Signed-off-by: Anton Lundin gla...@acc.umu.se --- main.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/main.cpp b/main.cpp index 3989cc9..295b9bd 100644 --- a/main.cpp +++ b/main.cpp @@ -5,6 +5,7 @@ #include stdlib.h #include time.h +#include dive.h #include qt-gui.h #include

[PATCH 04/17] Connect TankUseDelegate to its parrent

This plugs a memory leak found with valgrind. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/modeldelegates.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qt-ui/modeldelegates.cpp b/qt-ui/modeldelegates.cpp index 6eac66f..d2bdadc 100644 --- a/qt-ui

[PATCH 17/17] Document found leaks

Signed-off-by: Anton Lundin gla...@acc.umu.se --- equipment.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/equipment.c b/equipment.c index 32f7774..3725b50 100644 --- a/equipment.c +++ b/equipment.c @@ -23,6 +23,7 @@ void add_cylinder_description(cylinder_type_t *type

[PATCH 16/17] Remove unused strings from ui files

This removes unused strings from ui files. These showed up for translation and are quite meaningless to translate. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/listfilter.ui | 6 +- qt-ui/tableview.ui | 6 -- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/qt

[PATCH] Remove debug printf

Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 1 - 1 file changed, 1 deletion(-) diff --git a/file.c b/file.c index 2892f62..04936a5 100644 --- a/file.c +++ b/file.c @@ -724,7 +724,6 @@ int parse_txt_file(const char *filename, const char *csv

Re: Problems compiling marble with Qt5

Sid Any hints? Thanks in advance. I would guess you're missing qtdeclarative5-dev Install that package and you should be fine. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http

[PATCH] Don't try to malloc a zero sized list

If we tried to copy a divecomputer without samples, we where to malloc a zero sized blob. dives/test15.xml triggered this and it was found with valgrind. Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dive.c b/dive.c

Re: [PATCH] Don't try to malloc a zero sized list

On 11 December, 2014 - Linus Torvalds wrote: On Thu, Dec 11, 2014 at 3:31 PM, Anton Lundin gla...@acc.umu.se wrote: If we tried to copy a divecomputer without samples, we where to malloc a zero sized blob. dives/test15.xml triggered this and it was found with valgrind

[PATCH 2/2] Don't rely on malloc to return NULL for zero size

it and look at the first sample. Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.c | 8 1 file changed, 8 insertions(+) diff --git a/dive.c b/dive.c index 8e8330f..4cf532f 100644 --- a/dive.c +++ b/dive.c @@ -602,6 +602,14 @@ void copy_samples(struct divecomputer *s, struct

[PATCH 1/2] Initialize alloc_samples in copy_samples

We rely on alloc_samples in prepare_sample. If alloc_samples weren't initialized prepare_sample would wreak havoc on the samples list. Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dive.c b/dive.c index bb92818..8e8330f 100644

Re: Help needed: User manual - DM5 and Uemis/Vyper configuration

the Stinger, but it's probably only me that have tested it and thats against my Vyper, where it works great. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin

[PATCH] Style cleanup

Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configuredivecomputerthreads.cpp b/configuredivecomputerthreads.cpp index cfe8735..82a6778 100644 --- a/configuredivecomputerthreads.cpp +++ b

[PATCH] When (re)planning use prefs.decopo2 for mod

Use our the decopo2 from preferences for mod/switchdepth calculations when re-planning a dive or planning a dive based on a previous dive. Signed-off-by: Anton Lundin gla...@acc.umu.se --- equipment.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/equipment.c b

[PATCH] Copy all cylinders when (re)planning a dive

-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveplanner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/diveplanner.cpp b/qt-ui/diveplanner.cpp index 84dec0c..fabc11e 100644 --- a/qt-ui/diveplanner.cpp +++ b/qt-ui/diveplanner.cpp @@ -138,7 +138,7 @@ void

Re: deviceid

trip * merge the private trip downloads into the appropriate dives. * vim xml-file , :%s/old_deviceid/new_deviceid/g So, it happens on a quite regular basis for me. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface

[PATCH] Create a subsurface_access for Android too

Signed-off-by: Anton Lundin gla...@acc.umu.se --- android.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/android.cpp b/android.cpp index 1e99a5c..0bb7db0 100644 --- a/android.cpp +++ b/android.cpp @@ -69,6 +69,11 @@ void *subsurface_opendir(const char *path) return (void

Subsurface HiDPI patches and Android

I built a new Subsurface-android for my phone and noted that the HiDPI-patches did some wonders on the usability of Subsurface on Android. Now it's almost usable. There are still a bunch of problems, but some more HiDPI-fixes and its almost working =) //Anton -- Anton Lundin+46702-161604

Re: deviceid

On 21 November, 2014 - boret wrote: Hi Anton. On Viernes, 21 de noviembre de 2014 16:59:30 Anton Lundin escribió: My regular cycle is: * open subsurface * download from the ostc * see how it downloads duplicates of lots of dives, and thus screwing up the nice cleaned gas lists

Re: serial and firmware -- please help

On 21 November, 2014 - Dirk Hohndel wrote: On Fri, Nov 21, 2014 at 11:57:43PM +0100, Anton Lundin wrote: There are some code in configuredivecomputerthreads.cpp that handles Suunto firmware and serial, and HW firmware and serial, that can be re-used / replaced. Btw. that code

Re: [PATCH 3/6] Create events from mouthpiece position

On 20 November, 2014 - Dirk Hohndel wrote: On Thu, Nov 20, 2014 at 07:21:13AM +0100, Anton Lundin wrote: On 19 November, 2014 - Dirk Hohndel wrote: Oh the translators will LOVE this. What the HECK is NC and UN? I guess Not Connected and UNdefined. I was thinking about

Re: [PATCH 4/6] Create gaschange events from Poseidon MkVI logs

On 20 November, 2014 - Dirk Hohndel wrote: On Thu, Nov 20, 2014 at 07:30:20AM +0100, Anton Lundin wrote: @@ -658,6 +662,14 @@ int parse_txt_file(const char *filename, const char *csv) case 39

Re: Søren Reinke: Document more about fields in Poseidon MkVI logs

On 20 November, 2014 - Willem Ferguson wrote: On 19/11/2014 23:14, Anton Lundin wrote: This is based on the great work done by Søren Reinke's on his MKVI Logfile Analyzer. Signed-off-by: Anton Lundin gla...@acc.umu.se Søren has been part of this right from the start, a year ago. If it were

Re: deviceid

that deviceid to the new-style and you're migrated. It will mess up switching back to older versions of Subsurface and download dives from your divecomputer, but hey, who actually downgrades? ... //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing

[PATCH] Adjust Poseidon Mouth piece event strings

After some feedback on the mailing list, these strings where preferred. Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/file.c b/file.c index 0958d20..4b4bf14 100644 --- a/file.c +++ b/file.c @@ -597,23

[PATCH] De-obfuscated Poseidon gaschange event building

After some feedback on the mailing list, bitwise XOR wasn't the preferred way to build the gaschange event. Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file.c b/file.c index 4b4bf14..07774b1 100644 --- a/file.c

[PATCH 1/6] Import NDL from Poseidon MKVI logs

This is based on the great work done by Søren Reinke's on his MKVI Logfile Analyzer. Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/file.c b/file.c index 4fe4d35..a3903dc 100644 --- a/file.c +++ b

[PATCH 2/6] Add support for importing CEILING from MKVI logs

This is based on the great work done by Søren Reinke's on his MKVI Logfile Analyzer. Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/file.c b/file.c index a3903dc..e793152 100644 --- a/file.c +++ b/file.c

[PATCH 5/6] Create more events from Poseidon MkVI logs

This is based on the great work done by Søren Reinke's on his MKVI Logfile Analyzer. Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 29 + 1 file changed, 29 insertions(+) diff --git a/file.c b/file.c index f9475b7..b706566 100644 --- a/file.c +++ b/file.c

[PATCH 4/6] Create gaschange events from Poseidon MkVI logs

This is based on the great work done by Søren Reinke's on his MKVI Logfile Analyzer. Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/file.c b/file.c index 8541427..f9475b7 100644 --- a/file.c +++ b/file.c @@ -11,6

[PATCH v2] Change the OSTC3 macros to have a ; in the end

This changes the OSTC3 READ_SETTING/WRITE_SETTING macros into something that can have a ; in the end which makes some editors auto-indent it better. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 121 --- 1 file changed

Re: [PATCH 3/6] Create events from mouthpiece position

, 2014 at 10:14:21PM +0100, Anton Lundin wrote: This is based on the great work done by Søren Reinke's on his MKVI Logfile Analyzer. Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 21 + 1 file changed, 21 insertions(+) diff --git a/file.c b/file.c

[PATCH] Support different salinity in planner

Depth is often mentioned in a length unit, but what we care about is pressure. When diving in fresh water the pressure is lower than the same depth in salt water. This adds support for using different salinities in planning. Signed-off-by: Anton Lundin gla...@acc.umu.se --- I really don't know

Re: Help with translation Typos

my awesome spelling skills before, but that one was a copy-paste from the OSTC interface documentation =) I blame the Germans! =) //Anton - Its actually called apnoe everywhere in the ostc/ostc3 code base... -- Anton Lundin+46702-161604

Re: path to 4.3 Beta

it (hehe) I've actually figured out how the bootloader works so you can even recover it after a bad flash, but I'm going to take another look at the code and try to get it tested, hopefully with some help. //Anton -- Anton Lundin+46702-161604

[PATCH 6/6] Remove unused unquote function

In previous version of subsurfacesysinfo.cpp which came straight form Qt the unquote function was used to clean strings. Since f59b30ca5ad7 (OS Detection: Use QFile when reading /etc/os-release) its not needed any longer so this removes that function. Signed-off-by: Anton Lundin gla

[PATCH 3/6] Move calculate_string_hash into DC_FIELD_STRING

The calculate_string_hash is only used if DC_FIELD_STRING is defined, so this removes a warning for everybody who doesn't build against a libdivecomputer with DC_FIELD_STRING support. Signed-off-by: Anton Lundin gla...@acc.umu.se --- libdivecomputer.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/6] Remove unused variables and code from seabear-csv

Signed-off-by: Anton Lundin gla...@acc.umu.se --- file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/file.c b/file.c index dfc21e9..fa684dc 100644 --- a/file.c +++ b/file.c @@ -708,7 +708,7 @@ int parse_csv_file(const char *filename, int timef, int depthf, int tempf

[PATCH 5/6] Fill out last_setpoint

There was traces of filling last_setpoint out for any samples that didn't have it. This adds the last bits for it. Signed-off-by: Anton Lundin gla...@acc.umu.se --- profile.c | 4 1 file changed, 4 insertions(+) diff --git a/profile.c b/profile.c index 5bfe7b9..04e74b6 100644

[PATCH 1/6] Reorder initializers to be more c++-strict

c++ have some idea about in what order things should be initialized. This makes us comply with that order. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/maintab.cpp | 4 ++-- qt-ui/models.cpp | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/qt-ui

Re: [PATCH 5/6] Fill out last_setpoint

On 08 November, 2014 - Robert C. Helling wrote: Anton, Am 08.11.2014 um 15:40 schrieb Anton Lundin gla...@acc.umu.se: Ok, but then the last bits if the last_setpoint things should be removed to as attached patch does. Yes indeed my patch should have done that. ACK Still

[PATCH v3] Remove leading spaces in buddy tags

The buddy list generated by the buddy tag logic gets separated by ,space so this trims away any leading spaces from the buddy name. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/models.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qt-ui/models.cpp b/qt-ui

[PATCH] Convert volume calculations into floating point

The basic problem was that for gases containing more than 2147483648 ml of nitrogen the calculations overflowed. This changes the code into using floating point math for that calculation which will be more accurate to. Signed-off-by: Anton Lundin gla...@acc.umu.se --- statistics.c | 4 ++-- 1

Re: Multi-Filter Search in action draft

On 03 November, 2014 - Dirk Hohndel wrote: On Mon, Nov 03, 2014 at 11:50:32PM +0100, Anton Lundin wrote: I haven't had a look at this feature before, but now when i played around with it i can't do anything but agree with Davide, Wow. Awesome work! Completely agree. A couple

Re: OSTC Configuration

On 27 October, 2014 - Dirk Hohndel wrote: On Mon, Oct 27, 2014 at 10:04:57PM +0100, Anton Lundin wrote: On 27 October, 2014 - Anton Lundin wrote: Here is the results of my last little project. This stack of patches adds support for reading and writing the config blocks of the OSTC

Re: messing with the gas / tank handling

the current separate diluent-sensor code we currently carry for the Mk6. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[PATCH 2/6] Set a max value for the custom text in OSTC3

The device supports a up to 60 chars custom text. This limits the LineEdit to that amount, so users see when they reach the max limit. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.ui | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qt-ui

[PATCH 6/6] Cleanup syntax and styling in Configure DC

This cleans up some styling and syntax in the Configure Dive Computer code path. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/configuredivecomputerthreads.cpp b

[PATCH 2/8] Change the OSTC3 copied ui to be sane for OSTC

it has done, so this adds ui for that value. There are also differences in how some values are handled. Ex the OSTC don't have fixed samplerates that you can choose between. You can rather just set your sample rate to X seconds. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui

[PATCH 5/8] Decode configuration data from OSTC

This adds code to decode the configuration blocks from the OSTC. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 250 +++ 1 file changed, 250 insertions(+) diff --git a/configuredivecomputerthreads.cpp b

[PATCH 7/8] Debug code for OSTC CF

This code is to debug the rest of the existing CF's, so we can look at the rest of the values. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 17 + 1 file changed, 17 insertions(+) diff --git a/configuredivecomputerthreads.cpp b

[PATCH 6/8] Decode CF configuration data from OSTC

This adds code to decode the custom functions data. We only decode the relevant CF's. The relevant ones are chosen by which ones have corresponding settings in the OSTC3. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 57

[PATCH 3/8] Change the salinity setting for OSTC

On the OSTC's the salinity is in kg/l and is stored as kg/l * 100 Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 4 ++-- qt-ui/configuredivecomputerdialog.ui | 11 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/qt-ui

[PATCH 2/2] Create a delegate for depth and gas components

This creates a delegate to simplify the handling of gas components and the change depth. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 44 +++ qt-ui/configuredivecomputerdialog.h | 20 2 files changed

[PATCH 1/3] Fix compability with libdivecomputer 0.5.0

hw_ostc_device_fwupdate was introduced after 0.4.2 so ifdef it to libdivecomputer = 0.5.0. The scope of users interested in this feature probably isn't big enough to justify a bump of our dependencies to a unreleased version of libdivecomputer. Signed-off-by: Anton Lundin gla...@acc.umu.se

[PATCH 2/6] Finish off the firmware update code.

This code connects the final parts of the generic firmware update code. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputer.cpp | 22 +- configuredivecomputer.h | 3 +++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git

[PATCH 3/6] Disable update firmware button for OSTC3 for now

We currently don't support update firmware for the OSTC3. Where waiting for support in libdivecomputer for that, so disable that button for now. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 4/9] Switch ConfigureDiveComputerDialog ui style

Almost all of our other classes has the ui class as a class member in the controller code. This switches ConfigureDiveComputerDialog to that model. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 373 +- qt-ui

[PATCH 2/9] Don't allow writing before we got data

Don't allow creation of backup files or writes to the computer before we know we got some data, either from a backup file or from the actual device. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 8 qt-ui/configuredivecomputerdialog.ui | 12

[PATCH 9/9] Fix the type of the for the Suunto max depth

-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/configuredivecomputerdialog.ui b/qt-ui/configuredivecomputerdialog.ui index 51ad633..55c9efe 100644 --- a/qt-ui/configuredivecomputerdialog.ui +++ b

[PATCH] Check that the model is a supported one

This code adds some crude checks to verify that the device is a supported one before we actually read/write from it. This is to white/black-list devices so we don't write or read memory that we don't know anything about. Signed-off-by: Anton Lundin gla...@acc.umu.se

[PATCH 3/7] Add backing stores for Suunto Vyper configurations

This adds varables to store all the settings for the Suunto Vyper family. Signed-off-by: Anton Lundin gla...@acc.umu.se --- devicedetails.cpp | 145 +- devicedetails.h | 52 2 files changed, 196 insertions(+), 1 deletion

[PATCH 6/7] This adds a ui for Suunto Vyper settings

This builds up a ui to use for all the settings for the Suunto Vyper family devices. Some of the fields are pure information, eg, max depth and number of dives, so they are marked read-only. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 7 + qt-ui

[PATCH] Remove unused variables

Signed-off-by: Anton Lundin gla...@acc.umu.se --- profile.c | 5 + qt-ui/profile/diveprofileitem.cpp | 6 +++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/profile.c b/profile.c index 79917d6..4f6517b 100644 --- a/profile.c +++ b/profile.c @@ -824,7

Re: [PATCH 1/7] Initialize everything to zero in devicedetails

On 12 October, 2014 - Anton Lundin wrote: Before this, if you did click save backup xml before you read the data, you would get a xml file full of bogus. This initializes everything to zero. Signed-off-by: Anton Lundin gla...@acc.umu.se --- devicedetails.cpp | 50

[PATCH 4/4] Cleanup traling newlines

And there where quite a few. Signed-off-by: Anton Lundin gla...@acc.umu.se --- devicedetails.cpp | 50 -- 1 file changed, 50 deletions(-) diff --git a/devicedetails.cpp b/devicedetails.cpp index db95cfd..4f4d040 100644 --- a/devicedetails.cpp

[PATCH 3/4] Use unsigned char to store devicesettings.

C++-11 complains allot about narrowing the int value to unsigned char in the setting of these values to the OSTC3. This clears that warning, and any confusion about these values. Future work: Change these structures to use our Subsurface-types instead. Signed-off-by: Anton Lundin gla

[PATCH 2/4] Actually set the setpoints to the OSTC3

The setpoints filled in into the ui where never set on the devicedetails object so they where never propagated to backup or write settings. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qt-ui

<    2   3   4   5   6   7