Re: [9] Review request for 8160986 Bad rendering of Swing UI controls with Metal L on HiDPI display

the first test would not compile since it is "public class bug8160986 " in bug8031573.java ?:-) -yan On 07/27/2016 12:08 AM, Phil Race wrote: Since I noticed it right away, I am sure lots of others will soon enough. -phil. On 07/25/2016 02:19 PM, Sergey Bylokhov wrote: On

Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

/** - * Sets the {@code TreeCellRenderer} to {@code tcr}. This invokes - * {@code updateRenderer}. + * Called when the {@code cellRenderer} property is changed in + * the drawn tree component. * - * @param tcr the new value + * @param tcr the new value of the

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

A meaningful name with some relevance to what the test tests ? -phil. On 07/19/2016 12:03 PM, Pete Brunet wrote: On 7/19/16 1:52 PM, Phil Race wrote: The fix is fine but as I've said elsewhere I really don't like BugXX as test names. Hi Phil, I haven't seen any of your prior comments

Re: RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

The fix is fine but as I've said elsewhere I really don't like BugXX as test names. -phil. On 07/19/2016 11:43 AM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/19/2016 8:50 PM, Pete Brunet wrote: Look at .02 instead. I had an extraneous println left in

Re: [9] Review request for 8160986 Bad rendering of Swing UI controls with Metal L on HiDPI display

I imagine this was all done to maximise performance. Is there any impact on SwingMark - try D3D both on & off .. The change here : http://cr.openjdk.java.net/~alexsch/8160986/webrev.00/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalScrollButton.java.sdiff.html appears to handle only

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

Looks good to me .. +1 -phil. On 08/08/2016 12:48 PM, Alexander Scherbatiy wrote: Just a friendly reminder. Thanks, Alexandr. On 27/06/16 22:17, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8151303/webrev.02 The fix

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

I was not familiar with this "magic caret" but from reading it seems like it has just one use/purpose. In the event that someone has multi-line text that you can navigate around with up/down arrow keys and that text has lines of varying length, you want a "preferred" horizontal position for the

Re: [9] Review request for 8162856 JSlider thumb is twice smaller on HiDPI display

+1 -phil. On 08/08/2016 03:35 AM, Sergey Bylokhov wrote: Looks fine. On 08.08.16 11:01, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8162856/webrev.01/ - the image graphics is scaled before passed it to CachedPainter.paintToImage()

Re: [9] Review request for 8165234 Provide a way to not close toggle menu items on mouse click on component level

Seems fine except for a grammatical issue in the javadoc {@code true}. Setting the property to {@code false} either to {@literal L} I think you mean ".. either on the ..." -phil. On 09/02/2016 05:30 AM, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug:

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

drawPolyline does not seem to be an option here because of the different colours. Filling custom shapes may be overkill. Round looks to me to be the best of these three. -phil. On 9/7/2016 9:19 AM, Alexandr Scherbatiy wrote: On 9/6/2016 6:10 PM, Sergey Bylokhov wrote: It seems that there

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

On 10/27/2016 11:52 AM, Pete Brunet wrote: On 10/27/16 1:47 PM, Pete Brunet wrote: On 10/27/16 1:34 PM, Phil Race wrote: In which case be careful it is not built by the JDK build .. Build team, Is there anything I need to handle here to make sure it isn't? Actually, let me give it a try. I

RFR: 8169518: Suppress Deprecation warnings for deprecated Swing APIs

Bug: https://bugs.openjdk.java.net/browse/JDK-8169518 Webrev: http://cr.openjdk.java.net/~prr/8169518 The last set of deprecation warnings to be suppressed or fixed in desktop - so with this fix we can re-enable javac lint checking of deprecation. I have used JPRT to verify this builds on all

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

I've been testing this by re-enabling deprecation so On 11/02/2016 10:50 PM, Prasanta Sadhukhan wrote: Do we need the suppression in JavaSoundAudioClip.java as I could not find any mention of Applet in that class? In AppletViewer.java shouldn't we need to add "deprecation" to 45

RFR: 8155874: Fix java.desktop deprecation warnings about Class.newInstance

bug: https://bugs.openjdk.java.net/browse/JDK-8155874 Webrev: http://cr.openjdk.java.net/~prr/8155874/ This hits all across the desktop module, hence the cross-post. The Class.newInstance() has been deprecated since it may throw checked exceptions that are not declared.

Re: [9] Review request for 8167176 Exported elements referring to inaccessible types in java.desktop

On 10/18/2016 03:54 AM, Alexandr Scherbatiy wrote: On 10/18/2016 12:42 AM, Philip Race wrote: Hi, First note that any of the alternatives here require an approved CCC before pushing. As I wrote in the bug the fields in JRootPane are not used. Making it a public supertype is no more

RFR: PIT Bug 8167988 : java.nio.file.InvalidPathException if click button in JFileChooser demo of SwingSet2

SQE reports some 35 tests fail as a result of this bug. I am backing out the change that caused it from our PIT and need a reviewer. SQE will verify this before I push. Bug: https://bugs.openjdk.java.net/browse/JDK-8167988 Fix : hg diff

Re: [9] Review request for 8167176 Exported elements referring to inaccessible types in java.desktop

I believe it is equivalent - just a bit more clear to be explicit. At least that is what I found with the deprecation one on the same line. -phil. On 10/19/2016 10:24 AM, Sergey Bylokhov wrote: On 19.10.16 20:05, Phil Race wrote: is it necessary to add "exports" to "-Xli

Re: [9] Review request for 8167176 Exported elements referring to inaccessible types in java.desktop

On 10/19/2016 09:16 AM, Sergey Bylokhov wrote: Did you check this fix on other platforms? For example what about WindowsFileChooserUI.java: DirectoryComboBoxRenderer createDirectoryComboBoxRenderer() Note than DirectoryComboBoxRenderer is not public. I looked at those the other day and I

RFR: 8169887: javax/swing/JEditorPane/8080972/TestJEditor.java, javax/swing/text/View/8080972/TestObjectView.java are failing

Bug: https://bugs.openjdk.java.net/browse/JDK-8169887 webrev : http://cr.openjdk.java.net/~prr/8169887/ 8155874 changed many calls from the deprecated Class.newInstance() to Class.getDeclaredConstructor().newInstance(). However in the cases where the called code may be loaded from a different

Re: [9] Review request for 8169719 WrappedPlainView.modelToView() should return Rectangle2D

The assumption that just because values *can* be non-integral that they *will* be non-integral is not valid. Even if you know that the probability is small, it is not zero. This seems like it could lead to spurious failures of this test. -phil. On 11/15/2016 09:18 AM, Alexandr Scherbatiy

RFR: 8167182: Exported elements referring to inaccessible types in jdk.accessibility

Bug : https://bugs.openjdk.java.net/browse/JDK-8167182 Webrev: http://cr.openjdk.java.net/~prr/8167182/ There are three fields exposed in the accessibility docs which are of types that are not exported :

Re: [9] Review request for 8169719 WrappedPlainView.modelToView() should return Rectangle2D

. Thanks, Alexandr. On 11/15/2016 9:52 PM, Phil Race wrote: The assumption that just because values *can* be non-integral that they *will* be non-integral is not valid. Even if you know that the probability is small, it is not zero. This seems like it could lead to spurious failures of this test

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

This all seems fine. Do other accessbridge files still have the remnants of SCCS ? :- That was purged from all the other JDK files when we moved to mercurial. 33 /* 34 * @(#)AccessBridgeCalls.c 1.25 05/08/22 35 */ If "yes", then I suggest to file a clean-up bug to clean up all of

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

No, we are definitely shipping those. Unless of course you think we should stop shipping JNI headers too ... -phil On 10/27/2016 10:37 AM, Mandy Chung wrote: Should they be kept just in the source and not to be included in the image/include directory? It’s not clear to me if anyone needs

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

+1. I am assuming you made sure AccessBridgeCalls.c is not being compiled during the JDK build as discussed earlier ... -phil. On 10/31/2016 07:36 AM, Pete Brunet wrote: On 10/28/16 8:14 PM, Mandy Chung wrote: On Oct 28, 2016, at 1:59 PM, Philip Race wrote: If it

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

One big problem I see with this is that it means they will only be available under the GPL license as they will not be in an Oracle JDK which strips the GPL So if you are going to do this then these files first need to be dual-licensed because otherwise people can't link their commercial

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

+1 -phil. On 11/28/2016 08:41 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles which are located in the

Re: [9] Review request for 8169922 SwingMark/TextArea: 2-7% regression on Linux, Mac, Windows in 9-b143

I just noticed that you spell the new methods with a single d :eg : getFPMethodOverriden Like the variables that were there before it should be getFPMethodOverridden and checkFPMethodOverridden Also, although rather unlikely to be a problem in practice, since there is nothing in the swing

Re: [9] Review request for 8169922 SwingMark/TextArea: 2-7% regression on Linux, Mac, Windows in 9-b143

821 822 static boolean getFPMethodOverriden(Class cls, String method, 823 FPMethodArgs methodArgs) { 824 FPMethodItem methodItem = new FPMethodItem(cls, method); Where are the definitions of the types FPMethodItem and FPMethodArgs ? 842 methodArgs.getMethodAruments(false), 843

RFR: 8171074 : Test api/javax_swing/UIManager/index.html\#Methods is failing

Bug: https://bugs.openjdk.java.net/browse/JDK-8171074 Webrev: http://cr.openjdk.java.net/~prr/8171074/ Other than the @SuppressWarnings, UIManager.setLookAndFeel(String className) is now reverted to how it was before 8155874 -phil.

Re: [9] Review Request: 8169900 The code which use Applets should be deprecated

Looks OK except for a couple of typo nits below. You can fix those without a new review However you will need a CCC for deprecating the public API AppletInitializer and the Beans.instantiate method which references it 159 * @deprecated It s recommended to use "It is" ? -- 160 * {@link

Re: [9] Review request for 8169922 SwingMark/TextArea: 2-7% regression on Linux, Mac, Windows in 9-b143

Scherbatiy wrote: On 12/16/2016 2:36 AM, Phil Race wrote: I just noticed that you spell the new methods with a single d :eg : getFPMethodOverriden Like the variables that were there before it should be getFPMethodOverridden and checkFPMethodOverridden Here is the updated fix where the typo

RFR: 8171363: [PIT] Four Windows-specific tests fail with InaccessibleObjectException when calling Field.setAccessible()

Bug: https://bugs.openjdk.java.net/browse/JDK-8171363 Webrev: http://cr.openjdk.java.net/~prr/8171363/ this is mostly about jtreg syntax. A few tests fail due to the updated module system spec. jtreg needs to allow them to access package private fields. ":open" is added on the tests that do

RFR: 8043773: Deprecate JComponent.AccessibleJComponent.AccessibleFocusHandler

webrev: http://cr.openjdk.java.net/~prr/8043773/ bug : https://bugs.openjdk.java.net/browse/JDK-8043773 This just deprecates the un-used, un-needed inner classs. A CCC was approved ages ago however the fix was never pushed and I can't find any evidence a code review was even submitted. Since

Re: [9] Review request for 8176883 Enable antialiasing for Metal L icons on HiDPI display

SwingUtilities2.getAndSetAntialisingHintForScaledGraphics() sets the AA rendering hint only for local display. - The SwingUtilities2.setAntialiasingHintForScaledGraphics() method javadoc is updated to mention that the null AA rendering hint means that the passed graphics is not instance of Graphics2D. On 3/16/2017 7:

Re: [9] Review request for 8176883 Enable antialiasing for Metal L icons on HiDPI display

Hi, It looks to me as if this applies AA rendering even when you are drawing using G2D calls. Why ? Also this clearly only helps Metal. Is that because only Metal has such problems ? I would doubt that. FWIW Motif L probably should not get this treatment. Also if the desktop is "remote" we

Re: [9] Review Request: 8176544 Compilation error in plaf.metal.MetalBumps.Test6657026

Fine by me. I am curious why a compilation failure wasn't found immediately ? -phil. On 03/17/2017 01:37 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. This test uses "ToolBarBorder.MetalBumps" which is not accessible because it is not public. The code was updated to use

Re: [9] Review request for 8176883 Enable antialiasing for Metal L icons on HiDPI display

OK. In that case I am fine with it. I expect a small swingmark hit but that is the price we need to pay here. -phil. On 03/16/2017 11:46 AM, Alexandr Scherbatiy wrote: On 3/16/2017 9:16 PM, Phil Race wrote: Hi, What I was referring to regarding "draws using G2D calls" was that

Re: [9] Review Request: 8177450: javax.swing.text.html.parser.Parser parseScript ignores a character after commend end

2122 if(i > 0) { should be "if (i > 0) {" Can you comment on what tests have been run to ensure this does not regress anything else ? -phil. On 03/31/2017 04:28 AM, Mikhail Cherkasov wrote: Hello, Could you please review the fix for jdk9? The problem is that Parser reads extra symbol after

Re: [9] Review Request: 8177450: javax.swing.text.html.parser.Parser parseScript ignores a character after commend end

it. -phil. On 04/05/2017 03:36 AM, Mikhail Cherkasov wrote: Hi Phil, On 4/4/2017 9:13 PM, Phil Race wrote: 2122 if(i > 0) { should be "if (i > 0) {" fixed: http://cr.openjdk.java.net/~mcherkas/8177450/9/webrev.01/ Can you comment on what tests have been run to ensure this d

Re: [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

Minor nit, a wildcard import in the test :- 31 import javax.swing.*; -phil On 04/13/2017 06:16 AM, Mikhail Cherkasov wrote: Hi Sergey, Right, a test case can be written without use of JAWS or other screen readers. Please find a new webrev with the test there:

Re: [10] Review Request: 8185683 Unaccessible and unused classes can be removed from java.desktop module

-8186003 On 08.08.2017 10:41, Phil Race wrote: I think the removal of AquaL and NimbusL merit a CSR request since they were in their different time and ways supported ways of invoking each of these L -phil. On 08/08/2017 10:34 AM, Kevin Rushforth wrote: I don't have any concerns with this. Phil

Re: [10] RFR JDK-8184813:Class javax/swing/plaf/metal/MetalFontDesktopProperty is broken in JDK10

+1 -phil. On 07/20/2017 01:45 AM, Prasanta Sadhukhan wrote: Hi All, This is a back-out of 6461834: Minimize WindowsLookAndFeel classes included with Unix JDKs fix which was done to make sure WindowsLookAndFeel classes are not built for non-windows platform but it seems there are some

Re: [9] Review request for 8179027: JComboBox too small under Windows LAF

OK. +1. No point in adding constants right now. I had thought the change that introduced this was not related to hidpi but it was not .. and it was a bit larger than I'd have expected this late in the release. -phil. On 04/26/2017 08:41 AM, Semyon Sadetsky wrote: I don't see any issues with

Re: a possible bug in javax.swing.text.Utilities.getTabbedTextOffset

It would be good to file a bug capturing as much as you can how to reproduce this and pointers to where you think the problem lies. It sounds like it may be code related to trying to support hi-dpi but that will become clearer with the additional info. -phil. On 8/16/2017 12:44 PM, Alan Snyder

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

e in the jaxp repo ... pretty much all tables there now have a reasonable, visible caption. -- Jon On 05/17/2017 11:19 AM, Phil Race wrote: I am not sure we are using the summary in a way that makes it worthwhile. As you noted in the other mail "The summary attribute was us

Re: [OpenJDK 2D-Dev] [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

I've looked through all the files now. No other comments. So approved. -phil. On 05/17/2017 11:19 AM, Phil Race wrote: I am not sure we are using the summary in a way that makes it worthwhile. As you noted in the other mail "The summary attribute was used to give a more descriptive

Re: [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

I am not sure we are using the summary in a way that makes it worthwhile. As you noted in the other mail "The summary attribute was used to give a more descriptive value of the contents of the table. A caption is more like a title" The values I see are more like a title and as you say that is

Re: [10] RFR JDK-6461834: Minimize WindowsLookAndFeel classes included with Unix JDKs

The way to do this is to create a file src/java.desktop/windows/classes/module-info.java.extra and move the opens there. See for example src/java.base/windows/classes/module-info.java.extra But are you sure jdk.jconsole needs these only on Windows ? Better make sure of it. -phil. On

Re: [9] Review Request: 8175915: NullPointerException from JComboBox and JList when Accessibility enabled

+1 -phil. On 05/11/2017 12:31 PM, Sergey Bylokhov wrote: Thanks, Looks fine. - mikhail.cherka...@oracle.com wrote: > Hi Sergey, > > it's the same problem as in https://bugs.openjdk.java.net/browse/JDK-8076249 > > AccessBridge trys to request information from obsoleted

Re: [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

This all looks OK to me. -phil. On 05/04/2017 06:15 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9-dev. This fix is a part of the effort to make all javadoc in jdk9 be compatible to HTML5. In the fix the most common issues are fixed. The issues related to tables will be

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

771 * @implNote Please note that for Mac OS, notifications 772 * are only sent if the Java app is a bundled application, 773 * with a {@code CFBundleDocumentTypes} array present in its 774 * Info.plist. Should we be using {@code ..} for CFBundleDocumentTypes. It is not Java

jdk10/client forest is FROZEN until JDK 10 repos are consolidated.

The JDK 10 repo consolidation [1] is about to begin. All the JDK forests need to be frozen to make this happen .. as per this excerpt from the email below //>/We're aiming to have the final pre-consolidation integrations of the />/hs and client forests into JDK 10 master the week of August 28

Re: [10] Review request for 8187599: Remove dependency of Building Nimbus L on JAXB

This change is also huge. How did you do this ? Manually ? There should be diffs of the files generated this way and the files generated by JAXB so we can compare. Ideally they'd be byte-for-byte identical but failing that it should be trivial to see that any diffs are insignificant. -phil.

Re: [10] Review request for 8180821: [macosx]com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java: The menu item should have been GC-ed

If it makes the test pass .. +1 -phil. On 10/11/2017 11:37 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK10 (the changes involve AWT and Swing): bug: https://bugs.openjdk.java.net/browse/JDK-8180821 webrev: http://cr.openjdk.java.net/~ssadetsky/8180821/webrev.00/ This is a

Re: [10] Review request for 8187599: Remove dependency of Building Nimbus L on JAXB

+1 -phil. On 9/27/2017 11:21 AM, Sergey Bylokhov wrote: On 9/25/17 10:34, Semyon Sadetsky wrote: ObjectFactory.java was missed from the webrev. It should be deleted actually. The updated webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.01/ Looks fine.

Re: [10] Review Request: 8189656 The Windows L should be moved out from the shared folder

I see this opens was moved to platform-specific code ... 115 opens com.sun.java.swing.plaf.windows to 116 jdk.jconsole; So jdk.jconsole definitely accesses this only on Windows ? -phil. On 11/28/2017 09:28 AM, Erik Joelsson wrote: From a build point of view, this looks great. /Erik On

RFR: 8191767: Memory leak in JabSwitch

This is a one line fix for a potential small leak .. the char* variable profilePath will not be freed in the case that when used it would make too long a path. bug: https://bugs.openjdk.java.net/browse/JDK-8191767 webrev: http://cr.openjdk.java.net/~prr/8191767/ -phil.

Re: [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

From memory, I think Sergey is right that the jtreg default time out is 2 minutes (120 seconds). As to changing that to 3 minutes .. that is something that needs to be decided at a jtreg ownership level. A little off topic, but I've sometimes pondered if jtreg ought to have an option to avoid

Re: [10][JDK-8187936] Automatically selecting a new JTree node in a model listener can cause unusual behavior.

Hi, Whilst I could perhaps provide some very minor tweaks to the wording you are adding, I would first like to understand the details of why the rendering becomes broken here since there doesn't seem to be anything intrinsically wrong - only the model is being updated. I've found that

Re: [OpenJDK 2D-Dev] [10] Review Request 8187367: Numerous swing display problems with scaled displays on Windows

I think we should push this fix, although there are concerns we can't immediately demonstrate that Math.ceil may be wrong in some theoretical case. Also Sergey, please add a comment in the bug report about the alternative fix you mentioned that was discussed previously so that can be

Re: Questionable Rendering of Disabled Text

Protocol is that there first be a bug report and then a "RFR" (request for review) is sent to the list referencing the bug + the fix I have filed https://bugs.openjdk.java.net/browse/JDK-8191041 and verified that it works. So we can perhaps short-circuit that this time .. but not next time ..

Re: [10] Review request for 8182043: Access to Windows Large Icons

This thread is very long and despite trying I am sure I have not absorbed every discussion point to date. I think a concise summary of the current opinions from Semyon would help as I don't yet see a concensus emerging and if we are adding a new public API we need to be sure that 1) It is

Re: Questionable Rendering of Disabled Text

at the patch and filing a report. Michael On Fri, 10 Nov 2017 at 05:52, Phil Race <philip.r...@oracle.com <mailto:philip.r...@oracle.com>> wrote: Protocol is that there first be a bug report and then a "RFR" (request for review) is sent to the list referen

RFR: 8190475: SwingSet2 won't start

Bug: https://bugs.openjdk.java.net/browse/JDK-8190475 Webrev: http://cr.openjdk.java.net/~prr/8190475/ Nor will Java2Demo .. and at least one beans test is failing (hanging) in the same place. All hanging in the new code added by the fix for 6463710: ListSelectionModel.setSelectionMode()

RFR: 8189809: Large performance regression in Swing text layout.

Bug: https://bugs.openjdk.java.net/browse/JDK-8189809 webrev: http://cr.openjdk.java.net/~prr/8189809/ This partially addresses a slow-down in Swing. Swing now usually calls Font.getStringBounds() instead of FontMetrics().stringWidth for text measurement. The latter has a fast-path for

RFR: 8193211 : Update jtreg TEST.groups and ProblemList for client-libs

Bug: https://bugs.openjdk.java.net/browse/JDK-8193211 Webrev: http://cr.openjdk.java.net/~prr/8193211/ adds jdk_swing_core and jdk_desktop_core test groups to jtreg Also problem lists many (by no means all) of the known jtreg failures. -phil

Re: [10][JDK-8187936] Automatically selecting a new JTree node in a model listener can cause unusual behavior.

ttp://cr.openjdk.java.net/%7Ekaddepalli/8187936/webrev01/> Regards, Krishna *From:*Phil Race *Sent:* Wednesday, December 6, 2017 10:17 PM *To:* Krishna Addepalli <krishna.addepa...@oracle.com>; swing-dev@openjdk.java.net *Subject:* Re: [10][JDK-8187936] Automatically selecting a new JTree nod

Re: [10][JDK-8187936] Automatically selecting a new JTree node in a model listener can cause unusual behavior.

t i = listeners.length-2; i>=0; i-=2) { if (listeners[i]==TreeModelListener.class) { // Lazily create the event: if (e == null) e = new TreeModelEvent(source, path, childIndices, children); ((TreeModelListener)listeners[i+1]).treeNodesInserted(e); } } } Thanks, Krishna *From

Re: [10] Review request for 8182041: File Chooser Shortcut Panel folders under on JDK 9

On 12/06/2017 09:39 AM, Semyon Sadetsky wrote: On 12/06/2017 08:33 AM, Phil Race wrote: Hi, I have some additional comments on this old review thread. Hopefully we can close it out soon although it will need a CSR whatever .. Since the implementation of ShellFolderManager filters out

Re: [10] Review request for 8182041: File Chooser Shortcut Panel folders under on JDK 9

Hi, I have some additional comments on this old review thread. Hopefully we can close it out soon although it will need a CSR whatever .. Since the implementation of ShellFolderManager filters out inaccessible files we should document this somewhere. I suggest either on the class or relevant

Re: RFR: 8189809: Large performance regression in Swing text layout.

(), 2614 tl.getAscent() + tl.getDescent() + 2615 tl.getLeading()); Note that the second parameter is negative, is it intentionally changed? On 07/12/2017 12:54, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8189809 webrev: http

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

Two quick comments. 1) I'd like "Peer" removed from all the exported API. 2) It is probably stable enough now that you can start to add some javadoc. -phil. On 05/04/2018 05:00 AM, Prasanta Sadhukhan wrote: Hi All, Please review an enhancement to remove the tight coupling of JDK internal

Re: [11] RFR: JDK-8199441: Wrong caret position in multiline text components on Windows with a screen resolution higher than 100%

I am not sure this is the right fix. If the intention had been to change all calls to getTabbedTextOffset() to use the FP API it would have just been changed .. rather than adding a new API that provides the option to specify whether to use FP. So perhaps the problem is that internal code

RFR: 8202811: Problem List some tests that leave windows open on the desktop

bug: https://bugs.openjdk.java.net/browse/JDK-8202811 webrev: http://cr.openjdk.java.net/~prr/8202811/ This started out as wanting to problem list a few tests that left windows open or otherwise did not terminate. And these are in there, but I also tried to clean up most of the reproducible

Re: RFR: 8202811: Problem List some tests that leave windows open on the desktop

PS .. I forgot I wanted to piggy back an update to TEST.ROOT to add some remaining directories for jtreg to use othervm mode : http://cr.openjdk.java.net/~prr/8202811.1/ -phil. On 05/11/2018 10:46 AM, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8202811 webrev: http

Re: RFR: 8202811: Problem List some tests that leave windows open on the desktop

of the tests fail because of some unrelated issues(other tests or some setup issues), at least some of them works fine on my mac, for example: java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java 8202931 macosx-all On 11/05/2018 12:08, Phil Race wrote: PS .. I forgot I wanted to piggy

Re: [11] Review Request: 8202878 com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java fails

sorry about that.. +1 again. -phil. On 05/11/2018 02:48 PM, Sergey Bylokhov wrote: The fix problemList is updated after JDK-8202811[1] was pushed: http://cr.openjdk.java.net/~serb/8202878/webrev.01 [1] http://cr.openjdk.java.net/~prr/8202811.1/ On 10/05/2018 18:45, Philip Race wrote: +1

Re: [11] RFR [TEST][JDK-8197948] Create test for SwingSet2 main window

+1 -phil. On 05/02/2018 07:04 PM, Muneer Kolarkunnu wrote: Hi All, Please review the following, a new client sanity test case: Task: https://bugs.openjdk.java.net/browse/JDK-8197948 Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/8197948/webrev.01/

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

+1 from me for the JDK changes. -phil. On 06/13/2018 06:04 PM, Kevin Rushforth wrote: The JDK changes look good to me, and as far as I have tested them, it works for me. I haven't tried Drag and Drop yet with the latest interface changes. To repeat something I've mentioned before, just so

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

you surely mean @since 11 I believe it has been verified that it is excluded from the docs build .. right Prasanta ? -phil On 06/14/2018 01:26 PM, mandy chung wrote: I reviewed the module-info.java change. @since 12 is missing in jdk.unsupported.desktop module-info.java Otherwise it's

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

+1 -phil. On 06/15/2018 12:31 AM, Prasanta Sadhukhan wrote: Webrev to add @since 11 to jdk.swing.interop classes (only difference from .14) http://cr.openjdk.java.net/~psadhukhan/fxswing.15/ I also tried submitting mach5 job from linux but it is failing to download jib (although I

Re: [OpenJDK 2D-Dev] [11] Review Request: 8199150 and 8150156

+1 -phil. On 05/16/2018 08:16 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11, which fixed some accessibility issues in the specification. Bug: https://bugs.openjdk.java.net/browse/JDK-8199150 https://bugs.openjdk.java.net/browse/JDK-8150156 Fix:

Re: [11] RFR: JDK-8199441: Wrong caret position in multiline text components on Windows with a screen resolution higher than 100%

, there was no regression with jck and jtreg tests with the fix. Regards Prasanta On 5/9/2018 12:41 AM, Phil Race wrote: I am not sure this is the right fix. If the intention had been to change all calls to getTabbedTextOffset() to use the FP API it would have just been changed .. rather than adding a new

RFR: 8203499 Uninitialised memory in WinAccessBridge.cpp

Bug: Uninitialised memory in WinAccessBridge.cpp:485 webrev: http://cr.openjdk.java.net/~prr/8203499/ element is not initialised on declaration. It should be initialised when its address is passed here messageQueue->remove(); but it is too hard to prove, so just initialise it to NULL .. and

Re: [11] RFR: JDK-8199441: Wrong caret position in multiline text components on Windows with a screen resolution higher than 100%

khan wrote: On 5/9/2018 12:41 AM, Phil Race wrote: I am not sure this is the right fix. If the intention had been to change all calls to getTabbedTextOffset() to use the FP API it would have just been changed .. rather than adding a new API that provides the option to specify whether to use FP.

Re: [11] Review Request: 8205454 is displayed in some Swing docs

+1 -phil. On 06/22/2018 12:50 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8205454 Webrev: http://cr.openjdk.java.net/~serb/8205454/webrev.00 A few typos were fixed. - In some cases it was caused by the JDK-8025230(Lamp;F

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L at Hidpi

The bug was seen when switching L .. how is that related to GraphicsConfiguration ? -phil. On 06/22/2018 01:48 PM, Sergey Bylokhov wrote: Any volunteers for review? =) On 17/06/2018 15:37, Sergey Bylokhov wrote: Unfortunately after additional testing I found a bug in our text related

RFR: 8196468 : Client jtreg ProblemList updates

Bug: https://bugs.openjdk.java.net/browse/JDK-8196468 Webrev: http://cr.openjdk.java.net/~prr/8196468/ There's some noise in here as I moved the swing tests added last time to be listed next to other swing tests and grouped a few other tests together. The biggest additions are a lot of

Re: [10] Review Request: 8196196 Headful tests should not be run in headless mode

You added @headful to BadDisplayTest, but also added this logic - why ? public class BadDisplayTest{ public static void main(String[] args) { + if (Boolean.getBoolean("java.awt.headless")) { + return; + } -phil. On 01/30/2018 11:47 AM, Sergey Bylokhov wrote: Hello.

Re: [10] Review Request: 8196196 Headful tests should not be run in headless mode

.. How would one do the same for excluding applets without tediously adding this keyword. Is there jtreg syntax to exclude '.*html' ? Which might be one way to do it. -phil. On 01/30/2018 11:57 AM, Phil Race wrote: You added @headful to BadDisplayTest, but also added this logic - why ? public

Re: RFR: 8196468 : Client jtreg ProblemList updates

these entries platform generic. http://cr.openjdk.java.net/~prr/8196468.1/ -phil. On 01/30/2018 06:30 PM, Sergey Bylokhov wrote: Looks fine. On 30/01/2018 16:07, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8196468 Webrev: http://cr.openjdk.java.net/~prr/8196468/ There's some noise

Re: [11][JDK-8196673] JFileChooser throws InvalidPathException when changing to directory with added space

it to them. Thanks, Krishna *From:*Phil Race *Sent:* Friday, February 16, 2018 10:38 PM *To:* Krishna Addepalli <krishna.addepa...@oracle.com>; Semyon Sadetsky <semyon.sadet...@oracle.com>; swing-dev@openjdk.java.net *Subject:* Re: [11][JDK-8196673] JFileChooser throws Inv

Re: [11][JDK-8196673] JFileChooser throws InvalidPathException when changing to directory with added space

Right, what I said was that perhaps nio is behaving as specified in this case. If a standalone nio program can be written that shows nio contravening its spec. then a bug should be raised against nio. I did not verify what the case is there .. I just suggested that should be investigated.

Re: [11] JDK-8198005:javax/swing/JFileChooser/7199708/bug7199708.java throws error

1) Getting rid of the deleteOnExit - and the *need* for it is a good thing here as it is run when the VM exits. This is not a friendly thing to do when an agentvm is being used as it means that only after several hours when the whole test run is done will the files be deleted. Perhaps this test

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198333 ProblemList should be updated for headless mode

+1 -phil On 02/20/2018 07:10 AM, Sergey Bylokhov wrote: Hello. Please review update of the tests for jdk11. The goal is to make our testing as stable as possible and exclude any unstable tests(I have started from the tests which may be run in the headless mode). Bug:

Re: [11] RFR JDK-8198693:Update ProblemsList for mac

+1 .. good to get these mac issues problem listed. -phil. On 2/26/2018 4:35 AM, Prasanta Sadhukhan wrote: Hi All, Please review the problem list updation for mac to weed out the test that are failing at least once in few iterations. I tested on mac 10.13.3. With this problem list, the test

Re: [12] RFR: JDK-8206343: There is a typo in the java documentation of javax.swing.JScrollBar.

Since you are updating these lines, maybe you could fix the grammar as well as the spelling ? - * the most look and feels will not provide the scrolling to the right/down. + * then most look and feels will not provide the scrolling to the right/down. - * up or down by large amount.

Re: [12] JDK-8202013: JEditorPane shows large HTML unordered list bullets

+1 -phil. On 09/04/2018 12:52 AM, Prasanta Sadhukhan wrote: Modified webrev caching the original antialias state and restoring it at the end http://cr.openjdk.java.net/~psadhukhan/8202013/webrev.1/ Regards Prasanta On 9/4/2018 4:58 AM, Philip Race wrote: On 9/3/18, 12:24 AM, Prasanta

RFR: 8206375 : ProblemList update of bug ID for SwingFontMetricsTest

Bug : https://bugs.openjdk.java.net/browse/JDK-8206375 One bug was closed as a dup of another, so the Problem List needs to be updated to refer to the one that is still open: diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++

<    1   2   3   4   5   >