Re: [11] RFR for JDK-8199627: Use "Per-Monitor V2" High DPI awareness for Windows 10 v1703

Thank you, Sergey, for your review. Any other volunteers? Thanks, Alexey On 05/04/2018 23:56, Sergey Bylokhov wrote: Looks fine. On 05/04/2018 15:39, Alexey Ivanov wrote: Hello, Could you please review the fix for jdk11? bug: https://bugs.openjdk.java.net/browse/JDK-8199627 webrev: http

Re: [11] RFR for JDK-8199627: Use "Per-Monitor V2" High DPI awareness for Windows 10 v1703

rk as intended? Do you have any suggestion on how to address this issue? /Magnus On 2018-04-06 00:39, Alexey Ivanov wrote: Hello, Could you please review the fix for jdk11? bug: https://bugs.openjdk.java.net/browse/JDK-8199627 webrev: http://cr.openjdk.java.net/~aivanov/8199627/webrev.0/ Window

Re: [12] JDK-8182043: Access to Windows Large Icons

Hi Shashi, SystemIcon.java What is the purpose of new SystemIcon class? It's not used anywhere but the provided test. Is this class really needed then? Is it supposed to become the public API for accessing system icons? Why can't FileSystemView be used for that purpose as it was proposed in Se

Re: [12] JDK-8182043: Access to Windows Large Icons

.03/> Please see below for inline comments. Thanks and regards, Shashi *From:*Alexey Ivanov *Sent:* Friday, September 21, 2018 2:09 PM *To:* Shashidhara Veerabhadraiah ; Prasanta Sadhukhan ; swing-dev ; awt-dev *Subject:* Re: [12] JDK-8182043: Access to Windows Large Icons Hi

Re: [12] JDK-8182043: Access to Windows Large Icons

Hi Shashi, Would you please update the copyright year in the modified files? Regards, Alexey On 24/09/2018 22:30, Alexey Ivanov wrote: Hi Shashi, Please see my comments inline: On 21/09/2018 23:22, Shashidhara Veerabhadraiah wrote: Hi Alexey, Thanks for your review and below is the new

Re: [12] JDK-8182043: Access to Windows Large Icons

ds, Shashi *From:*Alexey Ivanov *Sent:* Tuesday, September 25, 2018 3:00 AM *To:* Shashidhara Veerabhadraiah ; Prasanta Sadhukhan ; swing-dev ; awt-dev *Subject:* Re: [12] JDK-8182043: Access to Windows Large Icons Hi Shashi, Please see my comments inline: On 21/09/2018 23:22,

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Krishna, Shashi, I wonder how native progress bars behave. Is their value read by assistive technologies? Are they focusable? Are they focusable if no assistive technology enabled? JLabel is not focusable. It does not accept user input directly. Are JLabels also skipped by assistive techn

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

ndows progress bar demo application and found that they are not focused. But ideally certain visual cue is required to see where the cursor is highlighting else it seem lost. Thanks and regards, Shashi -Original Message- From: Alexey Ivanov Sent: Wednesday, October 24, 2018 12:16 AM To: Sh

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

r input. So the current behaviour in Java coincides with that of Windows native controls. Narrator does not work with Java apps: it sees only the top-level window of SwingSet2. Regards, Alexey On 24/10/2018 16:19, Alexey Ivanov wrote: Hi Shashi, I see, setting setFocusable dynamically is n

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

this problem. Regards, Alexey Thanks and regards, Shashi -Original Message- From: Alexey Ivanov Sent: Thursday, November 8, 2018 1:13 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: No

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Sergey, On 08/11/2018 17:51, Sergey Bylokhov wrote: On 08/11/2018 08:30, Alexey Ivanov wrote: What Sergey found is not general purpose but rather accessibility tool shortcuts. In that case, progress bar is still not accessible when using Tab, is it? This bug is not about access of the

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

On 08/11/2018 06:47, Sergey Bylokhov wrote: On 07/11/2018 11:42, Alexey Ivanov wrote: Narrator does not work with Java apps: it sees only the top-level window of SwingSet2. It is still unsupported =(, we need to check the jaws first using their shortcuts: https://www.freedomscientific.com

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Shashi, I absolutely agree with Sergey: the component must be accessible even if it's not focusable. And I don't quite understand what you're talking about. The person who uses an accessibility tool will use the shortcuts of the tool to navigate controls in the window. Tab key, on the ot

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Alexey, I totally understand your perspective and even I ran into some of those questions. Below are my responses!! Thank you Alexey for bringing out unique issues pertaining to accessibility. Thanks and regards, shashi On 08/11/18 10:00 PM, Alexey Ivanov wrote: Hi Shashi, On 08/11/2018 04:18

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Shashi, On 22/11/2018 09:43, shashidhara.veerabhadra...@oracle.com wrote: The mac platform keyboard shortcuts are specific to mac and they work differently as I think we wont be receiving those key strokes at the java program level instead they traverse thro' the platform component level.

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Shashi, On 23/11/2018 06:04, shashidhara.veerabhadra...@oracle.com wrote: Hi Alexey, The accessible information is already set for the component in question and that is the reason it works with the accessibility short cut(without this fix). Then there's no bug. Hence there's nothing to fix

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Saturday, December 1, 2018 6:11 AM To: Shashidhara Veerabhadraiah ; Alexey Ivanov ; Krishna Addepalli Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver reg

Re: [12] RFR JDK-8213049:Invalid HTML5 in javax.swing files

Hi Sergey, Thank you for additional details on handling ‘summary’ attribute and element. HTML 5 recommendation has a section “Techniques for describing tables” [1]. Description of element [2] provides some additional details. Hi Prasanta, *properties.html* From accessibility point of vie

Re: [12] RFR JDK-8213049:Invalid HTML5 in javax.swing files

3-Dec-18 9:25 PM, Alexey Ivanov wrote:

Re: [12] RFR JDK-8213049:Invalid HTML5 in javax.swing files

Hi Prasanta, Thank you for addressing all my comments. Looks good to me. Regards, Alexey On 04/12/2018 05:22, Prasanta Sadhukhan wrote: Hi Alexey, Here's the updated webrev catering to your comments: http://cr.openjdk.java.net/~psadhukhan/8213049/webrev.3/ Regards Prasanta

Re: [13] RFR JDK-8215909: Typo in Swing ProcessMouseEvent method documentation

+1 Regards, Alexey On 03/01/2019 01:37, Sergey Bylokhov wrote: Looks fine. On 02/01/2019 01:56, Prasanta Sadhukhan wrote: Hi All, Please review a doc fix to fix space missing after {@code} tag. diff -r 9eee0b148002 src/java.desktop/share/classes/javax/swing/MenuElement.java --- a/src/java.

Re: [OpenJDK 2D-Dev] RFR. Repeated words typos in java.desktop

Hi Andrey, src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java /*   * Used to override if system (desktop) text anti-aliasing settings should - * be used. The reasons for this are are is that currently its "off" + * be used. The reasons for this are i

Re: [OpenJDK 2D-Dev] RFR. Repeated words typos in java.desktop

On 20/02/2019 01:38, Sergey Bylokhov wrote: Hi, Andrey. I found only one questionable place in the fix: == /**   * Returns an object created with id=key. If the object is not of - * type type, this will throw an exception. + * that type, this will throw an except

Re: [12] JDK-8182043: Access to Windows Large Icons

Hi Shashi, Sorry for my belated review. On 22/01/2019 18:03, Shashidhara Veerabhadraiah wrote: Hi All, Please review the below new fix compared to earlier webrevs. Now the new api to get the icons of different sizes is being made part of a new class SystemIcon. Please consider this as a diff

Re: [13] RFR JDK-8220250: fix headings in java.desktop

Hi guys, This is more of a general comment rather than targeted at this particular change. Sorry if I missed any previous discussion on that matter. I think it's good to have consistent headings without skipping levels. Yet in the Javadoc comments does not seem right. Let's take a look at J

Re: [13] RFR JDK-8220250: fix headings in java.desktop

Hi Prasanta, On 15/03/2019 05:15, Prasanta Sadhukhan wrote: Hi Alexey, On 13-Mar-19 6:10 PM, Alexey Ivanov wrote: Hi guys, This is more of a general comment rather than targeted at this particular change. Sorry if I missed any previous discussion on that matter. I think it's go

Re: [13] RFR JDK-8220250: fix headings in java.desktop

Hi Prasanta, Looks fine. Regards, Alexey On 19/03/2019 10:41, Prasanta Sadhukhan wrote: Hi Alexey, Your points are valid so I modified those in this webrev, please have a look http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.3/ Regards Prasanta On 15-Mar-19 10:28 PM, Alexey Ivanov

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

Hi Sergey, Is style="font-weight:normal" necessary for each inside ? (The previous version defaulted to bold rendering.) If yes, is it possible to add a stylesheet to handle this for the entire page?     tbody th {     font-weight: normal;     } Should the title of the page use title c

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

On 11/06/2019 22:26, Sergey Bylokhov wrote: On 11/06/2019 14:11, Alexey Ivanov wrote: Is style="font-weight:normal" necessary for each inside ? I tried to set the style to tbody itself and it does not work, will check your suggestion below. But before that, I would like to co

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

On 11/06/2019 22:40, Sergey Bylokhov wrote: On 11/06/2019 14:26, Sergey Bylokhov wrote: Is style="font-weight:normal" necessary for each inside ? It works, thank you for suggestion: http://cr.openjdk.java.net/~serb/8225146/webrev.02 http://cr.openjdk.java.net/~serb/8225146/webrev.02/raw_files

Re: [13] Review Request: 8225372 accessibility errors in tables in java.desktop files

Hi Sergey, *GridBagLayout.java* Does it make sense to use nested lists for valid values? It could make the presentation clearer rather than a paragraph followed by a list. Line 125–     Absolute Values:             {@code GridBagConstraints.NORTH}             Orientation Relati

Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

On 20/06/2019 01:00, Sergey Bylokhov wrote: On 12/06/2019 07:09, Alexey Ivanov wrote: I'd rather leave bold rendering for keys, I think it makes sense. Yet it's up to you to decide. Something like this? http://cr.openjdk.java.net/~serb/8225146/webrev.03 http://cr.openjdk.java

Re: [13] Review Request: 8225372 accessibility errors in tables in java.desktop files

/~serb/8225372/docs.01/api/java.desktop/module-summary.html See comments inline: On 14/06/2019 09:19, Alexey Ivanov wrote: *GridBagLayout.java* Does it make sense to use nested lists for valid values> It could make the presentation clearer rather than a paragraph followed by a list. We

Re: [13] Review Request: 8225372 accessibility errors in tables in java.desktop files

ore. Let's leave it that way for now.  - Modality.html: An example block was reworked as suggested: http://cr.openjdk.java.net/~serb/8225372/docs.03/api/java.desktop/java/awt/doc-files/Modality.html On 9/3/19 10:55 am, Alexey Ivanov wrote: It looks fine to me. And it has more semantic m

Re: [13] Review Request: 8225372 accessibility errors in tables in java.desktop files

On 16/09/2019 20:09, Alexey Ivanov wrote: Hi Sergey, This version looks good to me. On 09/09/2019 23:14, Sergey Bylokhov wrote: Hi, Alexey.  - Modality.html: The was dropped from everywhere, it does not seems to be useful I think was used to make a term / concept stand out from its

[14] RFR JDK-8231144: Wrap contents of plain HTML files into contentContainer

Hello, Please review the following simple fix for JDK 14: bug: https://bugs.openjdk.java.net/browse/JDK-8231144 webrev: http://cr.openjdk.java.net/~aivanov/8231144/webrev.00/ docs: http://cr.openjdk.java.net/~aivanov/8231144/docs.00/api/java.desktop/module-summary.html Plain HTML documentatio

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

Hi Pankaj, I'd like to confirm: 793 int width = image.getWidth(imageObserver); 794 if (image != null) { the image is not null at line 793, and as the side effect of calling image.getWidth(imageObserver), image is set to null, right? This requires a comment, does

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hi Dmitry, Apple uses macOS to refer to its operating system, so should we also use it instead of former OS X? For HTML version, I would suggest using the following markup Ctrl +F1 for the keyboard shortcut. [1] I think using elements for instructions on how to disable the shortcut is inc

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Got it! Then I'd just drop the quotes from the key names: - `“CTRL” + “F1”` + `Ctrl + F1` On 25/10/2019 16:52, Erik Joelsson wrote: The HTML is generated from the markup and should not be edited by hand. /Erik -- Regards, Alexey

Re: [14] RFR 8232605: [macos] There is no Tooltip message displayed when Ctrl+F1 is clicked.

On 24/10/2019 14:27, Dmitry Markov wrote: On 24 Oct 2019, at 02:36, Sergey Bylokhov > wrote: On 10/23/19 3:17 am, Dmitry Markov wrote: I agree the generic documentation should be updated. I have openedhttps://bugs.openjdk.java.net/browse/JDK-8232880 to track t

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hi Dmitry, Shall we drop hyphen in the header: “Client UI Tests”? I think there should be no definite article in this sentence: “use -the- key sequences”. “…Turn off Windowss key hotkeys…”, there's an extra ‘s’ in Windows. ”Note: restart is required to make the settings take effect.” Just to

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

, Alexey On 31/10/2019 10:56, Dmitry Markov wrote: Hi Alexey, I have updated the fix based on your recommendation. The new version is located at: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.02/ Also please find my answers inline. Thanks, Dmitry On 29 Oct 2019, at 19:29, Alexey Ivanov <

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Thank you, Dmitry! The changes look good to me. On 01/11/2019 13:09, Dmitry Markov wrote: Hi Alexey, I have updated the fix. Please find the new version here: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/ Thanks, Dmitry On 31 Oct 2019, at 16:27, Alexey Ivanov <mailto:alexey.

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

in XML. I mean should be Backlash for closing tag is not standard HTML. Other than that, the test looks good. Regards, Alexey Regards, Pankaj -Original Message- From: Alexey Ivanov Sent: Wednesday, October 16, 2019 7:27 PM To: Pankaj Bansal; swing-dev Cc: Sergey Bylokhov Subject:

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

On 31/10/2019 19:53, Sergey Bylokhov wrote: On 10/31/19 5:59 am, Pankaj Bansal wrote: << I guess that the problem is that the "image" is accessed w/o synchronization on "this" like in other places, but it will be necessary to add one null check before usage of "image". I have updated the code t

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

/cr.openjdk.java.net/~pbansal/8230235/webrev02/ Regards, Pankaj -Original Message- From: Alexey Ivanov Sent: Wednesday, November 13, 2019 1:28 AM To: Sergey Bylokhov; Pankaj Bansal; swing-dev Subject: Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cau

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

l platforms with this test. It is green. Perfect! Thank you for confirming it. Regards, Alexey Regards, Pankaj Bansal -Original Message- From: Alexey Ivanov Sent: Monday, November 18, 2019 5:38 PM To: Pankaj Bansal; Sergey Bylokhov; swing-dev Subject: Re: [14] RFR JDK-8230235 - Rende

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

Hi Pankaj, Looks good to me. However, I suggest following the formatting of the surrounding code where arguments are aligned to the opening parenthesis: 797 Dimension d = adjustWidthHeight(img.getWidth(imageObserver), 798 img.getHeight(imageObserver)); (when the mail message i

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

+1 On 23/11/2019 00:03, Sergey Bylokhov wrote: Looks fine. On 11/21/19 3:00 am, Pankaj Bansal wrote: Hi Sergey, << Is it fine that we pass "-1" to the "adjustWidthHeight"? I am not sure that it is ready for the negative values(where it calculates proportions). Note that prepareImage() expec

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

Hi Sergey, Pankaj, On 12/02/2020 07:59, Sergey Bylokhov wrote: On 2/11/20 11:52 pm, Pankaj Bansal wrote: Hi Sergey, << Sometimes there are difference: Ok, I see it now. So, should I just close this bug as not an issue with proper comments or make changes using Math.fma for best possible resu

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

On 13/02/2020 21:33, Sergey Bylokhov wrote: On 2/12/20 8:21 am, Alexey Ivanov wrote: The bug report says that going from -0.15 to -0.10 does not allow going back to -0.15. This happens because the result of this sequence of operations cannot be represented exactly, or, in other words, because

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

and possible consequences, so feel free to ignore my email, if I am wrong. Kind regards, Vlad Sent from myPad On 13. Feb 2020, at 22:34, Sergey Bylokhov wrote: On 2/12/20 8:21 am, Alexey Ivanov wrote: The bug report says that going from -0.15 to -0.10 does not allow going back to -0.15

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

On 17/02/2020 10:10, Sergey Bylokhov wrote: On 2/17/20 1:50 am, Alexey Ivanov wrote: Otherwise there will always be cases where Spinner with float/double behaves unexpectedly, i.e. does not allow increasing/decreasing a value where one expects it to. But what value is expected/unexpected? If

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

On 17/02/2020 10:35, Sergey Bylokhov wrote: On 2/17/20 2:25 am, Alexey Ivanov wrote: As far as I understand your approach, is to select the minimum if the resulted float value after the calculation is a little bit smaller than the minimum. So if the minimum is -0.15 and resulted value is

Re: [15] Review Request: 8237746 Fixing compiler warnings in src/demo/share/jfc

Thank you, Marc, for your contribution. And thank you to Sergey for creating the review. *Font2DTest.java* 674 if ( selectedText == fp.USER_TEXT ) 675   userTextDialog.setVisible(true); 676 else 677   userTextDialog.setVisible(false); I'd put the braces around and

Re: [OpenJDK 2D-Dev] [15] Review Request: 8237746 Fixing compiler warnings in src/demo/share/jfc

g() method. Done. Shall the copyright year be updated in all the modified files? Please let me know what would be the correct process. Cheers, -marc On 17. Feb 2020, at 15:40, Alexey Ivanov wrote: Thank you, Marc, for your contribution. And thank you to Sergey for creating the revie

Re: [15] Review Request: 8237746 Fixing compiler warnings in src/demo/share/jfc

Thank you to Marc for updating webrev and to Sergey for uploading it. The changes look fine to me as I already stated. I just wanted to share more comments: On 22/02/2020 09:50, Sergey Bylokhov wrote: Thank you, an updated version is upload: http://cr.openjdk.java.net/~serb/8237746/webrev.01

Re: RFR 8241078: OOM error parsing HTML with large Tag text

Hi Prasanta, Looks good to me too. On 18/03/2020 21:59, Sergey Bylokhov wrote: Looks fine. On 3/17/20 8:54 pm, Prasanta Sadhukhan wrote: Hi Sergey, Test updated http://cr.openjdk.java.net/~psadhukhan/8241078/webrev.1/ Regards Prasanta On 17-Mar-20 11:48 PM, Sergey Bylokhov wrote: HI, Pras

Re: RFR: 8241229: Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java

Hi Phil, On 18/03/2020 21:54, Philip Race wrote: On 3/18/20, 2:52 PM, Sergey Bylokhov wrote: On 3/18/20 2:41 pm, Philip Race wrote: That is one possible solution that I mentioned, but I am not sure it is the right one. Needs investigating by the RE. It is an ok thing, the L&F might be unsupp

Re: RFR JDK-8241291: JCK test javax_swing/text/DefaultStyledDocument/ElementSpec/ESpecCtor.html fails

On 20/03/2020 08:45, Prasanta Sadhukhan wrote: Yes, logically it's possible. I am not sure how in that case, we can cater to both OOM and JCK issue so backing out the fix http://cr.openjdk.java.net/~psadhukhan/8241291/webrev.1/ I am not sure if JCK test is testing correctly, as the check it

Re: Editable combobox vs LaF change: javax.swing.plaf.UIResource vs javax.swing.plaf.basic.BasicComboBoxEditor.UIResource

Hi Vladimir, Thank you for your report, could you please submit the bug here: https://bugs.java.com/bugdatabase We would greatly appreciate if you could provide a test case. Regards, Alexey On 20/03/2020 12:06, Vladimir Sitnikov wrote: Hi, I'm facing an issue that the editor for an editable

Re: RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

Hi Bhawesh, Shall we add @requires |os.family == "windows" to the test? Then it won't be even selected for running by jtreg. It think the copyright year should be updated in both modified files, should it? I'd also suggest using explicit import statements for javax.swing.* classes instead of

Re: RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

There's a typo in the quoted text, there should be no ‘|’ character. @requires os.family == "windows" On 01/04/2020 19:47, Alexey Ivanov wrote: Shall we add @requires |os.family == "windows" to the test? Then it won't be even selected for running by jtreg. -- Regards, Alexey

Re: RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

an/8233584/webrev.2/ -Bhawesh On 4/2/2020 12:17 AM, Alexey Ivanov wrote: Hi Bhawesh, Shall we add @requires |os.family == "windows" to the test? Then it won't be even selected for running by jtreg. It think the copyright year should be updated in both modified files, should it?

Re: [16] RFR 8136363: Nimbus-LaF: background color cleared when setting component name of JToolBar

On 15/08/2020 06:56, Sergey Bylokhov wrote: On 14.08.2020 08:22, Kumar Abhishek wrote: I have updated the test. Please find the updated Webrev: http://cr.openjdk.java.net/~aivanov/kumar.abhishek/8136363/webrev.01/ I think that the test should be marked as headful, otherwise it will fail on th

Re: RFR 8250852: Address reliance on default constructors in the javax.swing.plaf.basic APIs

Hi Prasanta, Sergey, On 17/08/2020 21:19, Sergey Bylokhov wrote: Hi, Prasanta. There is a small typo, see dots: "Constructs for subclasses to call.." Shall it be "Constructs a {@code BasicLookAndFeel} for subclasses to call."? This way it is consistent with other added constructors and specif

Re: RFR 8250852: Address reliance on default constructors in the javax.swing.plaf.basic APIs

On 17/08/2020 22:10, Alexey Ivanov wrote: Hi Prasanta, Sergey, On 17/08/2020 21:19, Sergey Bylokhov wrote: Hi, Prasanta. There is a small typo, see dots: "Constructs for subclasses to call.." Shall it be "Constructs a {@code BasicLookAndFeel} for subclasses to call.&q

Re: RFR 8250852: Address reliance on default constructors in the javax.swing.plaf.basic APIs

r for subclasses to call. " It may not be the optimal text but it is certainly better than "Constructs for subclasses to call". -phil.11 On 8/17/20, 2:47 PM, Alexey Ivanov wrote: On 17/08/2020 22:10, Alexey Ivanov wrote: Hi Prasanta, Sergey, On 17/08/2020 21:19, Sergey Bylokhov

Re: RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

Hi Tejpal, Looks good overall, however, I have a couple of comments. I suggest using the elements for setting width of table columns. Add the following three lines before in *properties.html*: Then you can drop width specifiers from and in the entire table. The code will look much cl

Re: [16] RFR 8136363: Nimbus-LaF: background color cleared when setting component name of JToolBar

/~aivanov/kumar.abhishek/8136363/webrev.02/ Thanks, Abhsihek -Original Message- From: Alexey Ivanov Sent: Monday, August 17, 2020 11:47 PM To: Sergey Bylokhov ; Kumar Abhishek ; swing-dev@openjdk.java.net Subject: Re: [16] RFR 8136363: Nimbus-LaF: background color cleared when setting

Re: RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

51122/webrev03/ On 27-Aug-2020, at 2:15 PM, Tejpal Rebari <mailto:tejpal.reb...@oracle.com>> wrote: Hi Alexey, Thanks for the review On 21-Aug-2020, at 1:04 AM, Alexey Ivanov <mailto:alexey.iva...@oracle.com>> wrote: Hi Tejpal, Looks good overall, however, I have a couple

Re: RFR: 8182043: Access to Windows Large Icons

On Fri, 2 Oct 2020 23:29:10 GMT, Sergey Bylokhov wrote: >> @aivanov-jdk Can you review this? > > I still suggest to try the approach recommended here: > https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016074.html > > On 29.05.2020 14:35, Alexey Ivanov wrote: &g

Re: RFR: 8182043: Access to Windows Large Icons

On Mon, 28 Sep 2020 15:20:33 GMT, Alexander Zuev wrote: > Moving review from Mercurial. See > https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016078.html for > previous > iteration. src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 986: > 984: hI

Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v2]

On Sun, 4 Oct 2020 06:22:45 GMT, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk. >> >> Old review request: >> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html >> >> >> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it >> should b

Re: RFR: 6422025: ThemeReader.cpp can be updated for VC7

On Fri, 6 Nov 2020 08:51:46 GMT, Sergey Bylokhov wrote: > Some of the type definitions have been imported from `UxTheme.h` to the > `ThemeReader.cpp` because at that time we supported the windows OS below XP > as well as VC6. > > It is time to use `UxTheme.h ` directly, note I did not change h

Re: RFR: 6422025: ThemeReader.cpp can be updated for VC7

On Fri, 6 Nov 2020 08:51:46 GMT, Sergey Bylokhov wrote: > Some of the type definitions have been imported from `UxTheme.h` to the > `ThemeReader.cpp` because at that time we supported the windows OS below XP > as well as VC6. > > It is time to use `UxTheme.h ` directly, note I did not change h

Re: RFR: 6422025: ThemeReader.cpp can be updated for VC7

On Fri, 6 Nov 2020 22:09:52 GMT, Sergey Bylokhov wrote: >> src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 126: >> >>> 124: DTRACE_PRINTLN("Loaded UxTheme.dll\n"); >>> 125: OpenThemeDataFunc = >>> (PFNOPENTHEMEDATA)GetProcAddress(hModThemes, >>> 126:

Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v4]

On Wed, 28 Oct 2020 23:46:55 GMT, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk. >> >> Old review request: >> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html >> >> >> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it >> should

Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v4]

On Tue, 10 Nov 2020 18:40:45 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/sun/java2d/SunGraphicsEnvironment.java line >> 357: >> >>> 355: * @param config the graphics configuration which bounds are >>> requested >>> 356: * @return the bounds of the area covered by t

Re: RFR: 8256376: The javax/swing/JSpinner/SerializationTest.java fails on headful windows

On Mon, 16 Nov 2020 20:01:49 GMT, Sergey Bylokhov wrote: > The Windows L&F uses the windows specific class XPStyle as part of the border > in the JSpinner. This class cannot be serialized and causes an exception > during serialization. The root cause is that BasicSpinnerUI forgot to reset > th

Re: RFR: 8256187: [TEST_BUG] Automate bug4275046.java test

On Thu, 26 Nov 2020 17:01:16 GMT, skodanda wrote: > Hi All, Could you please review this fix for JDK16? > > Problem Description: Automate bug4275046.java test. > > Fix: This fix includes rewriting the applet based test to a regular java > application and its been automated too. Changes reque

Re: RFR: 8256187: [TEST_BUG] Automate bug4275046.java test

On Thu, 26 Nov 2020 17:01:16 GMT, skodanda wrote: > Hi All, Could you please review this fix for JDK16? > > Problem Description: Automate bug4275046.java test. > > Fix: This fix includes rewriting the applet based test to a regular java > application and its been automated too. Marked as rev

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test

On Wed, 23 Dec 2020 11:50:41 GMT, K Suman Rajkumaar wrote: > Hi All, Could you please review this fix for JDK16? > > Problem Description: The test > open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. > > Fix: Rewritten the above applet based test to a regular java te

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v2]

On Mon, 4 Jan 2021 09:15:14 GMT, K Suman Rajkumaar wrote: >> Hi All, Could you please review this fix for JDK16? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. >> >> Fix: Rewritten the above applet based test to a regular ja

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v4]

On Wed, 6 Jan 2021 09:46:10 GMT, K Suman Rajkumaar wrote: >> Hi All, Could you please review this fix for JDK16? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. >> >> Fix: Rewritten the above applet based test to a regular ja

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v2]

On Wed, 6 Jan 2021 08:24:04 GMT, K Suman Rajkumaar wrote: >> test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 68: >> >>> 66: >>> 67: if (!latch.await(5, TimeUnit.MINUTES)) { >>> 68: frame.dispose(); >> >> The `dispose()` method should be called on EDT. > > If I

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v5]

On Wed, 6 Jan 2021 14:28:29 GMT, K Suman Rajkumaar wrote: >> Hi All, Could you please review this fix for JDK16? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. >> >> Fix: Rewritten the above applet based test to a regular ja

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v6]

On Wed, 6 Jan 2021 16:25:16 GMT, K Suman Rajkumaar wrote: >> Hi All, Could you please review this fix for JDK16? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. >> >> Fix: Rewritten the above applet based test to a regular ja

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v6]

On Wed, 6 Jan 2021 20:42:55 GMT, Phil Race wrote: > "Hi All, Could you please review this fix for JDK16?" > This is for JDK 17, not JDK 16, right ? I can't imagine why it would be for > 16 at this juncture .. No, it's not meant for JDK 16 — it's for jdk-dev, the main development line which is

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop

On Mon, 11 Jan 2021 06:21:52 GMT, Sergey Bylokhov wrote: > Please review the application of @java.io.Serial annotation (JDK-8202385) to > types in the desktop module to enable stricter compile-time checking of > serialization-related declarations. > > This annotation can be applied to these me

Re: RFR: 8259522: Apply java.io.Serial annotations in java.desktop [v2]

On Tue, 12 Jan 2021 20:36:21 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/com/sun/media/sound/InvalidDataException.java >> line 42: >> >>> 40: */ >>> 41: @Serial >>> 42: private static final long serialVersionUID = 1L; >> >> This is the standard wording, yet shoul

Re: RFR: 8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails

On Wed, 13 Jan 2021 10:41:29 GMT, Prasanta Sadhukhan wrote: > This test was unstable in linux in nightly testing. Modified to move the > frame to center of screen so that the left-taskbar of linux doesn't interfere > with the mouse movement along with delay after frame is visible to make it >

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes

On Wed, 13 Jan 2021 21:46:45 GMT, Dalibor Topic wrote: >> I've just emailed my scanned OCA. > > Thank you. Your OCA has been processed and your account has been marked as > verified. Providing a way to display the rendered HTML, especially when the test fails, for visual inspection could be a

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v2]

On Fri, 15 Jan 2021 09:31:38 GMT, Prasanta Sadhukhan wrote: >> Stanimir Stamenkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixup! 8257664: Fix font-size inheritance with percentage values >> >> - Renamed bug8257665.java ->

Re: RFR: 8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails [v2]

On Fri, 15 Jan 2021 06:33:19 GMT, Prasanta Sadhukhan wrote: >> This test was unstable in linux in nightly testing. Modified to move the >> frame to center of screen so that the left-taskbar of linux doesn't >> interfere with the mouse movement along with delay after frame is visible to >> mak

Re: RFR: 8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails [v3]

On Fri, 15 Jan 2021 17:06:22 GMT, Prasanta Sadhukhan wrote: >> This test was unstable in linux in nightly testing. Modified to move the >> frame to center of screen so that the left-taskbar of linux doesn't >> interfere with the mouse movement along with delay after frame is visible to >> mak

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v4]

On Fri, 15 Jan 2021 18:07:25 GMT, Stanimir Stamenkov wrote: >> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes. >> >> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best >> chance to get it addressed is to submit a pull request against this >> rep

Re: RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

On Sat, 16 Jan 2021 00:42:45 GMT, Sergey Bylokhov wrote: >> Dear All, >> >> Hi All, Could you please review this fix for JDK17? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based. >> >> Fix: Rewritten the above applet based test

Re: RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

On Mon, 18 Jan 2021 11:30:55 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java line 50: >> >>> 48: * @bug 8032667 >>> 49: * @summary [macosx] Components cannot be rendered in HiDPI to >>> BufferedImage >>> 50:

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v5]

On Sat, 16 Jan 2021 06:45:35 GMT, Stanimir Stamenkov wrote: >> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes. >> >> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best >> chance to get it addressed is to submit a pull request against this >> rep

  1   2   3   4   >