Re: [sword-devel] filter !P patch

2013-01-02 Thread David Haslam
Aside: xulsword modules don't use OSIS elements p and /p for paragraphs. The developer would probably agree with Nic's comment! // paragraphing can be annoying, as different module creators can do things differently! xulsword modules just make use of lb / to provide the line breaks for where

Re: [sword-devel] filter !P patch

2013-01-01 Thread Nic Carter
A search of the PS source code for para; reveals no hits. Search of the current libsword that PS uses also reveals no hits. I believe PS only shows pilcrows for those modules that have them inside, such as KJV. FYI, there is a fun comment in our display code that says:

Re: [sword-devel] filter !P patch

2012-12-15 Thread David Haslam
The pilcrows in the KJV module are in the OSIS XML source text. See http://crosswire.org/wiki/User:Dmsmith/KJV2011#Pilcrow_signs David -- View this message in context: http://sword-dev.350566.n4.nabble.com/filter-P-patch-tp4651388p4651402.html Sent from the SWORD Dev mailing list archive at

Re: [sword-devel] filter !P patch

2012-12-15 Thread Karl Kleinpaste
David Haslam dfh...@googlemail.com writes: The pilcrows in the KJV module are in the OSIS XML source text. Yes, indeed they are. And it turns out that they are coming out from the engine effort, not from Xiphos' post-engine hackery. Matt 22:11, catching the content immediately after the

Re: [sword-devel] filter !P patch

2012-12-15 Thread David Haslam
Aside: There are 2970 pilcrows in the KJV module. The last pilcrow is in Acts.20.36. After that there are no more of them! Curious? Evidently it's thought the printers ran out of moveable type for pilcrows, maybe even back when it was first published in 1611. -- View this message in

Re: [sword-devel] filter !P patch

2012-12-14 Thread Karl Kleinpaste
Ben Morgan benpmor...@gmail.com writes: Look back at the conversations on ' div type=paragraph ' from September. Troy said he was happy to remove !P if Xiphos didn't use it. Someone needs to work out why it's in there, and whether it is really needed, then probably adapt the filters to remove

Re: [sword-devel] filter !P patch

2012-12-14 Thread Ben Morgan
On Fri, Dec 14, 2012 at 11:58 PM, Karl Kleinpaste k...@kleinpaste.orgwrote: Ben Morgan benpmor...@gmail.com writes: Look back at the conversations on ' div type=paragraph ' from September. Troy said he was happy to remove !P if Xiphos didn't use it. Someone needs to work out why it's in

Re: [sword-devel] filter !P patch

2012-12-14 Thread Karl Kleinpaste
I think it's pretty clear that all of this sort of processing belongs in the filter, not in the apps at all, and that if pilcrows (para;) are desired, they too should be part of the filter-provided stream. Do other apps generate pilcrows, or is this a GnomeSword/Xiphos-specific oddity?

[sword-devel] filter !P patch

2012-12-13 Thread cricketc
Hello, I came across the following output in various filters: !P. A comment in the code talks about this being a silent html comment that the front-ends can replace if desired. However, that tag is not valid (x)html (I guess it used to be a valid comment). I'm attaching a patch that replaces !P

Re: [sword-devel] filter !P patch

2012-12-13 Thread Ben Morgan
G'day Ben, From the viewpoint of a frontend developer, I don't really want this change committed. If this change is committed, it will break existing frontends which look for !P, and it produces little or no benefit - !P may be invalid, but I think it will just get ignored. We already don't

Re: [sword-devel] filter !P patch

2012-12-13 Thread cricketc
OK, thanks for the feedback Ben. I guess if it's not causing problems for any front-ends, there's no point in breaking existing code. -Ben On Thu, Dec 13, 2012 at 9:31 PM, Ben Morgan benpmor...@gmail.com wrote: G'day Ben, From the viewpoint of a frontend developer, I don't really want this

Re: [sword-devel] filter !P patch

2012-12-13 Thread Greg Hellings
On Thu, Dec 13, 2012 at 8:31 PM, Ben Morgan benpmor...@gmail.com wrote: G'day Ben, From the viewpoint of a frontend developer, I don't really want this change committed. If this change is committed, it will break existing frontends which look for !P, and it produces little or no benefit -

Re: [sword-devel] filter !P patch

2012-12-13 Thread Ben Morgan
Hi Greg, On Fri, Dec 14, 2012 at 2:15 PM, Greg Hellings greg.helli...@gmail.comwrote: ... As to the matter of breaking front-ends, library upgrades are going to do that anyway. The current development head of BibleTime does not even compile against the current development head of SWORD

Re: [sword-devel] filter !P patch

2012-12-13 Thread Chris Little
On 12/13/2012 5:45 PM, crick...@gmail.com wrote: Hello, I came across the following output in various filters: !P. A comment in the code talks about this being a silent html comment that the front-ends can replace if desired. However, that tag is not valid (x)html (I guess it used to be a valid