On Thu, Jan 22, 2015 at 11:29 PM, Jason Moore moorepa...@gmail.com wrote:
This is timely:
https://github.com/blog/1943-how-to-write-the-perfect-pull-request
Looks like Github had to clarify communication guidelines for their company
in an explicit way. Worth a read.
Thanks for sharing, very
On Wed, Jan 21, 2015 at 11:58:42AM -0700, Ondřej Čertík wrote:
Really the only unwritten rule that we have in the sympy community is
to be friendly, welcoming and polite.
And you personally decide what that means...
Also, I am honestly really
surprised and sad that anyone would like to
Though I'm too late, I'd still like to thank Sergey for mentoring my first
open source PR ever. You are an awesome reviewer. Yes, you were sometimes
difficult to please, but then that also made me try harder to fix things
myself.
Thank you.
--
You received this message because you are
This is timely:
https://github.com/blog/1943-how-to-write-the-perfect-pull-request
Looks like Github had to clarify communication guidelines for their company
in an explicit way. Worth a read.
Jason
moorepants.info
+01 530-601-9791
On Thu, Jan 22, 2015 at 7:45 AM, Shivam Vats
Hi,
First of all, thanks Sergey for all the work you have done, from
coding, pull request reviews, GSoC mentoring and other things. I am
sad that you decided to leave, but you have the right to decide that
way of course.
I wanted to say a few words publicly about this, since a few of you
might
Thanks to Sergey for all the PRs you've helped me wade through, including
the dead-end signs that you posted along the way! I was hoping you would be
around longer than me (who has been trying to leave for about 2 years now)!
Thanks to all (lilke Ondrej) who have been willing to offer help and
It was great working with you Sergey. You and Matthew were the best
combination of mentors I could have got. So, Thank you.
--
You received this message because you are subscribed to the Google Groups
sympy group.
To unsubscribe from this group and stop receiving emails from it, send an email
Though, I am comparatively new to SymPy, but I have pinged Sergey a lot for
PR reviews, his comments always had some sort of learning involved. Today I
feel pretty disappointed as Sergey has left Sympy. He has been a great
source of learning for me atleast.
His contribution to SymPy is
Hello,
I feel it would be a bad idea to quit silently. Probably, I should
explain this action for others (without fair warings and so on). This
thread - probably the best place, due to context.
I got several private messages about the tone in pull requests and so on.
Actually, besides the
Looking at the conversation you two look frustrated but still pretty civil;
I'm actually impressed at how civil both of you are given that it's a PEP8
conversation. I have experienced far less civil and constructive
conversations on PRs in SymPy without them being locked to people
officially
On Friday, January 2, 2015 10:37:40 AM UTC+3, Joachim Durchholz wrote:
Wow. Locked out without fair warning. No community consensus either.
Yes. I would like to see constructive discussion in that thread. When
(and if) consensus will be reached among collaborators, we can unlock the
thread
On Fri, Jan 2, 2015 at 11:30 PM, Sergey B Kirpichev
skirpic...@gmail.com wrote:
On Fri, Jan 02, 2015 at 10:19:48PM +0100, Ondřej Čertík wrote:
I have unlocked the PR (https://github.com/sympy/sympy/pull/8538).
Sergey, if there is ever need for such a thing (I actually didn't even
know you can
On Fri, Jan 02, 2015 at 10:19:48PM +0100, Ondřej Čertík wrote:
I have unlocked the PR (https://github.com/sympy/sympy/pull/8538).
Sergey, if there is ever need for such a thing (I actually didn't even
know you can lock a PR), please discuss this with me first.
Ok, I consider two
As Matthew noted, please appeal to me if you can't reach a consensus. The
point of the BDFL model is to have someone come in and make a final
decision, before the community tears itself apart.
I admit that I don't have time to read every pull request any more, and as
Joachim noted, I also try to
14 matches
Mail list logo
