Re: [systemd-devel] [PATCH v2] systemctl: introduce --now for enable, disable and mask

2015-05-15 Thread Jóhann B. Guðmundsson
On 05/15/2015 07:54 AM, jsyna...@redhat.com wrote: From: Jan Synacek jsyna...@redhat.com --- changes in v2: * simplified creation of new arguments (replaced unnecessary dynamic allocation with a VLA) * renamed add_file_change to unit_file_add_changes * addressed wording issues in

Re: [systemd-devel] [PATCH v2] systemctl: introduce --now for enable, disable and mask

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 10:22, Tomasz Torcz (to...@pipebreaker.pl) wrote: On Fri, May 15, 2015 at 09:54:10AM +0200, jsyna...@redhat.com wrote: From: Jan Synacek jsyna...@redhat.com Shouldn't systemctl preset be enhanced with --now, too? I think that might be confusing. Currently preset both

Re: [systemd-devel] [PATCH v2] systemctl: introduce --now for enable, disable and mask

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 08:58, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 05/15/2015 07:54 AM, jsyna...@redhat.com wrote: From: Jan Synacek jsyna...@redhat.com --- changes in v2: * simplified creation of new arguments (replaced unnecessary dynamic allocation with a VLA) *

[systemd-devel] [PATCH v2] systemctl: introduce --now for enable, disable and mask

2015-05-15 Thread jsynacek
From: Jan Synacek jsyna...@redhat.com --- changes in v2: * simplified creation of new arguments (replaced unnecessary dynamic allocation with a VLA) * renamed add_file_change to unit_file_add_changes * addressed wording issues in documentation --- Makefile.am | 1 +

Re: [systemd-devel] preset activation on first boot takes too long

2015-05-15 Thread Dimitri John Ledkov
On 14 May 2015 at 18:00, Lennart Poettering lenn...@poettering.net wrote: On Thu, 14.05.15 17:13, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: Heya, I'm looking at bootcharts and it seems like first boot preset activation takes too much time... So at the moment, we iterate all

Re: [systemd-devel] [PATCH v2] systemctl: introduce --now for enable, disable and mask

2015-05-15 Thread Tomasz Torcz
On Fri, May 15, 2015 at 09:54:10AM +0200, jsyna...@redhat.com wrote: From: Jan Synacek jsyna...@redhat.com Shouldn't systemctl preset be enhanced with --now, too? -- Tomasz Torcz God, root, what's the difference? xmpp: zdzich...@chrome.pl God is more forgiving.

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-15 Thread Ivan Shapovalov
On 2015-05-14 at 22:31 +0200, Lennart Poettering wrote: On Thu, 07.05.15 04:37, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-05-06 at 18:59 +0200, Lennart Poettering wrote: On Wed, 06.05.15 19:53, Andrei Borzenkov (arvidj...@gmail.com) wrote: I still think that being

Re: [systemd-devel] [PATCH v2] systemctl: introduce --now for enable, disable and mask

2015-05-15 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1431676450-16194-1-git-send-email-jsynacek%40redhat.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 11:38, Ivan Shapovalov (intelfx...@gmail.com) wrote: Hmm, if , I think this should be fixable though. Already, allocating a unit, loading a unit and starting a unit are three separate steps. It shouldn't be too hard to fix PID 1 to allow allocating all transient units to

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 13:03, Ivan Shapovalov (intelfx...@gmail.com) wrote: Hmm, what about this: use -- as separator for multiple unit definitions? $ systemd-run --name=foo.service /bin/foo -- --name=bar.service -p Nice=80 /bin/bar -- -p Nice=20 --name=bazz.service /usr/bin/bazz

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-15 Thread Richard Maw
On Fri, May 15, 2015 at 12:10:58PM +0200, Lennart Poettering wrote: On Fri, 15.05.15 13:03, Ivan Shapovalov (intelfx...@gmail.com) wrote: Hm. Actually, usage of *any* token as a command line separator makes it impossible to include that token *in* the command line. My original idea is even

Re: [systemd-devel] [PATCH v2] systemctl: introduce --now for enable, disable and mask

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 10:54, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: On 15 May 2015 at 10:47, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.05.15 10:22, Tomasz Torcz (to...@pipebreaker.pl) wrote: On Fri, May 15, 2015 at 09:54:10AM +0200, jsyna...@redhat.com wrote:

[systemd-devel] [PATCH] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-15 Thread Karel Zak
Currently we have no way how to specify dependencies between fstab entries (or another units) in the /etc/fstab. It means that users are forced to bypass fstab and write .mount units manually. The patch introduces new systemd fstab options: x-systemd.requires=PATH - to specify dependence an

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-15 Thread Richard Maw
On Fri, May 15, 2015 at 11:36:54AM +0100, Richard Maw wrote: On Fri, May 15, 2015 at 12:10:58PM +0200, Lennart Poettering wrote: On Fri, 15.05.15 13:03, Ivan Shapovalov (intelfx...@gmail.com) wrote: Hm. Actually, usage of *any* token as a command line separator makes it impossible to

Re: [systemd-devel] dbus inside nspawn container

2015-05-15 Thread arnaud gaboury
On Fri, May 15, 2015 at 2:21 PM, Dimitri John Ledkov dimitri.j.led...@intel.com wrote: On 15 May 2015 at 13:07, arnaud gaboury arnaud.gabo...@gmail.com wrote: Maybe a stupid question, but shall every container user start a per user dbus session ? Host has a dbus and user session activated,

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-15 Thread Ivan Shapovalov
On 2015-05-15 at 11:54 +0200, Lennart Poettering wrote: On Fri, 15.05.15 11:38, Ivan Shapovalov (intelfx...@gmail.com) wrote: Hmm, if , I think this should be fixable though. Already, allocating a unit, loading a unit and starting a unit are three separate steps. It shouldn't be too

Re: [systemd-devel] [RESEND][PATCH] man: IPMasquerade only implies IPForward=ipv4

2015-05-15 Thread Lennart Poettering
On Sun, 10.05.15 20:32, Benedikt Morbach (benedikt.morb...@googlemail.com) wrote: at least that's what the code does. Applied. (though I think we should really ensure ipv4 and ipv6 work the same way here...) I didn't get any feedback last time[1], maybe this fell through the cracks? [1]

Re: [systemd-devel] systemd-218 - Requisite implies TriggeredByRestartOf

2015-05-15 Thread Evert
On 15-05-15 07:05, Andrei Borzenkov wrote: В Thu, 14 May 2015 21:23:38 +0200 Evert пишет: Hi, According to the systemd documentation, Requisite disallows starting a unit unless the specified unit has been started. This seems to work fine, however, if the specified unit has been restarted,

[systemd-devel] [PATCH] core: Execute first boot presets in an enable-only preset-mode.

2015-05-15 Thread Dimitri John Ledkov
This means any existing enabled units well be preserved and no pre-created symlinks will be removed. This is done on first boot, when the assumption is that /etc is not populated at all (no machine-id setup). For minimal containers that gives a significant first boot speed up, approximately ~20ms

Re: [systemd-devel] [PATCH] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 12:41, Karel Zak (k...@redhat.com) wrote: +static int write_requires_after(FILE *f, const char *opts) { +_cleanup_free_ char *arg = NULL, *unit = NULL; +int r; + +assert(f); +assert(opts); + +r = fstab_filter_options(opts,

Re: [systemd-devel] [PATCH] core: Execute first boot presets in an enable-only preset-mode.

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 11:44, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: This means any existing enabled units well be preserved and no pre-created symlinks will be removed. This is done on first boot, when the assumption is that /etc is not populated at all (no machine-id setup). For

Re: [systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-05-15 Thread Lennart Poettering
On Wed, 13.05.15 19:19, Lennart Poettering (lenn...@poettering.net) wrote: On Sun, 10.05.15 20:52, Benedikt Morbach (benedikt.morb...@googlemail.com) wrote: This reverts commit 43c6d5abacaebf813845934ec8d5e5ee3c431854 (and a small part of 4046d8361c55c80ab8577aea52523b9e6eab0d0c) It

Re: [systemd-devel] networkd failure with ipv6.disable=1

2015-05-15 Thread Lennart Poettering
On Sun, 10.05.15 18:07, Mark Oteiza (mvote...@udel.edu) wrote: Hi, In 219, systemd.networkd fails to configure and set up links with ipv6 disabled. May 10 08:31:58 holos systemd-networkd[636]: bond0 : netdev ready May 10 08:31:58 holos systemd-networkd[636]: Enumeration

Re: [systemd-devel] Systemd 215 cannot start journald 219 inside systemd-nspawn

2015-05-15 Thread Lennart Poettering
On Sun, 10.05.15 11:20, Felipe Sateler (fsate...@debian.org) wrote: Hi, I'm having a problem with a systemd-nspawn'ed container. The guest journal will not start and thus I have no logs. The host is a 215 Debian Jessie system. The guest is a 219 Debian Sid system. The nspawn unit is at

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 11:36, Richard Maw (richard@codethink.co.uk) wrote: On Fri, May 15, 2015 at 12:10:58PM +0200, Lennart Poettering wrote: On Fri, 15.05.15 13:03, Ivan Shapovalov (intelfx...@gmail.com) wrote: Hm. Actually, usage of *any* token as a command line separator makes it

Re: [systemd-devel] [PATCH v2] systemctl: introduce --now for enable, disable and mask

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 09:54, jsyna...@redhat.com (jsyna...@redhat.com) wrote: From: Jan Synacek jsyna...@redhat.com Applied! Thanks! --- changes in v2: * simplified creation of new arguments (replaced unnecessary dynamic allocation with a VLA) * renamed add_file_change to

[systemd-devel] dbus inside nspawn container

2015-05-15 Thread arnaud gaboury
Maybe a stupid question, but shall every container user start a per user dbus session ? Host has a dbus and user session activated, shall it be same in container? Thank you for hints -- google.com/+arnaudgabourygabx ___ systemd-devel mailing list

Re: [systemd-devel] dbus inside nspawn container

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 14:07, arnaud gaboury (arnaud.gabo...@gmail.com) wrote: Maybe a stupid question, but shall every container user start a per user dbus session ? Host has a dbus and user session activated, shall it be same in container? We make not real distinction there. We intend to provide

Re: [systemd-devel] [PATCH 1/5] shared/import-util: tag renamed to reference to support v2 pull by digest

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 15:32, Pavel Odvody (podv...@redhat.com) wrote: +else if (!startswith(ref, sha256)) +return false; + +else if (!in_charset(colon + 1, 0123456789abcdef)) +return false; Hmm, how precisely do this refs look, can

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-15 Thread Per Bergqvist
Hej,Seems like nobody thinks using the scsi_id for NVMe drives is a good idea so the alternative must be to introduce a new nvme_id utility.Please find a patch (relative 2.19) to add this.It is using native nvme ioctl to get the model, serial and firmware revision info.To apply:patch -p0

Re: [systemd-devel] Systemd 215 cannot start journald 219 inside systemd-nspawn

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 10:10, Felipe Sateler (fsate...@debian.org) wrote: You appear to be using a systemd version without seccomp compiled in, hence you won't get the container behaviour described, and you need to disable audit in the kernel instead. So, to make sure I understood correctly:

Re: [systemd-devel] [PATCH 4/5] import/pull: Tag replaced with reference

2015-05-15 Thread Lennart Poettering
On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Hmm, can you quickly explain how tags and refs and digests relate? If refs replace tags in v2, then I figure we can also drop the dkr_tag_is_valid() definition from the headers, no? Lennart -- Lennart Poettering, Red Hat

Re: [systemd-devel] [PATCH 5/5] import/pull-dkr: V2 Image specification + manifest support

2015-05-15 Thread Lennart Poettering
On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: #define HEADER_TOKEN X-Do /* the HTTP header for the auth token */ cker-Token: -#define HEADER_REGISTRY X-Do /*the HTTP header for the registry */ cker-Endpoints: +#define HEADER_REGISTRY X-Do /* the HTTP header for the

Re: [systemd-devel] [PATCH 3/3] bootctl: print machine and boot ids in status

2015-05-15 Thread Lennart Poettering
On Tue, 05.05.15 01:16, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: This was removed in merging of gummmiboot (0974a682d155a58), but seems genuinely useful. Well, we already show this in hostnamectl, so I figure we dont need this in both tools? --- src/boot/bootctl.c | 20

Re: [systemd-devel] [PATCH 2/5] shared/json: JSON parser + number tokenizer bugfix

2015-05-15 Thread Lennart Poettering
On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Hmm, so if I grok this right, then this at's a DOM-like (object model) parser for json, where we previously hat a SAX-like (stream) parser only. What's the rationale for this? Why doesn't the stream parser suffice? I intentionally

Re: [systemd-devel] [PATCH 2/5] shared/json: JSON parser + number tokenizer bugfix

2015-05-15 Thread Pavel Odvody
On Fri, 2015-05-15 at 15:23 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Hmm, so if I grok this right, then this at's a DOM-like (object model) parser for json, where we previously hat a SAX-like (stream) parser only. What's the rationale

Re: [systemd-devel] Systemd 215 cannot start journald 219 inside systemd-nspawn

2015-05-15 Thread Felipe Sateler
On 15 May 2015 at 07:31, Lennart Poettering lenn...@poettering.net wrote: On Sun, 10.05.15 11:20, Felipe Sateler (fsate...@debian.org) wrote: Hi, I'm having a problem with a systemd-nspawn'ed container. The guest journal will not start and thus I have no logs. The host is a 215

Re: [systemd-devel] Systemd 215 cannot start journald 219 inside systemd-nspawn

2015-05-15 Thread Felipe Sateler
On 15 May 2015 at 10:15, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.05.15 10:10, Felipe Sateler (fsate...@debian.org) wrote: You appear to be using a systemd version without seccomp compiled in, hence you won't get the container behaviour described, and you need to disable

Re: [systemd-devel] [PATCH 1/3] bootctl: modernization

2015-05-15 Thread Lennart Poettering
On Tue, 05.05.15 01:15, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Use strjoina to avoid error handling, and openat to simplify things. Some fixes on the way: - ferror does not set errno, so the return value was wrong in some cases - errors are propagated in more cases -

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-15 Thread Richard Maw
On Fri, May 15, 2015 at 12:40:56PM +0200, Lennart Poettering wrote: On Fri, 15.05.15 11:36, Richard Maw (richard@codethink.co.uk) wrote: Is there precedent in any other commonly used command that could be used instead? I've never seen anything that required escaping like this before,

Re: [systemd-devel] [PATCH 1/5] shared/import-util: tag renamed to reference to support v2 pull by digest

2015-05-15 Thread Pavel Odvody
On Fri, 2015-05-15 at 15:20 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Signed-off-by: Pavel Odvody podv...@redhat.com We dont do S-o-b in systemd. oops. --- src/shared/import-util.c | 19 +++

Re: [systemd-devel] [systemd-commits] src/shared TODO

2015-05-15 Thread Lennart Poettering
B1;3802;0cOn Sun, 10.05.15 10:18, Zbigniew Jędrzejewski-Szmek (zbys...@kemper.freedesktop.org) wrote: + +fflush(f); +if (ferror(f)) +return log_error_errno(errno, Failed to write unit file %s: %m, unit); Small note: please use fflush_and_check() for cases

[systemd-devel] [PATCH] .gitignore: add GNU GLOBAL files

2015-05-15 Thread Łukasz Stelmach
--- .gitignore | 4 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index f550950..d2f1a1f 100644 --- a/.gitignore +++ b/.gitignore @@ -22,6 +22,10 @@ /*.tar.xz /Makefile /TAGS +/GPATH +/GRTAGS +/GSYMS +/GTAGS /accelerometer /ata_id /bootctl -- 2.1.4

Re: [systemd-devel] [PATCH] .gitignore: add GNU GLOBAL files

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 17:12, Łukasz Stelmach (l.stelm...@samsung.com) wrote: Hmm? What is GNU GLOBAL? --- .gitignore | 4 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index f550950..d2f1a1f 100644 --- a/.gitignore +++ b/.gitignore @@ -22,6 +22,10 @@

Re: [systemd-devel] [PATCH 2/5] shared/json: JSON parser + number tokenizer bugfix

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 17:05, Pavel Odvody (podv...@redhat.com) wrote: On Fri, 2015-05-15 at 16:12 +0200, Lennart Poettering wrote: On Fri, 15.05.15 16:03, Pavel Odvody (podv...@redhat.com) wrote: On Fri, 2015-05-15 at 15:23 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel

Re: [systemd-devel] [PATCH 2/3] sd-daemon: Use LISTEN_NAMES env when available

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 17:09, Krzysztof Opasiak (k.opas...@samsung.com) wrote: LISTEN_NAMES environment variable contains details about received file descriptors. Let's try to use it instead of doing always two stats. I am really not convinced that it is a good idea to store redundant information

Re: [systemd-devel] systemd-nspawn: cannot join existing macvlan

2015-05-15 Thread Lennart Poettering
On Fri, 08.05.15 20:53, Kai Krakow (hurikha...@gmail.com) wrote: # systemd-nspawn -b --link-journal=try-guest --network-macvlan=enp4s0 -- bind=/usr/portage --bind-ro=/usr/src --machine=test Spawning container test on /var/lib/machines/test. Press ^] three times within 1s to kill

Re: [systemd-devel] [PATCH 2/3] Allow $SYSTEMD_PRETEND_INITRD to override initramfs detection

2015-05-15 Thread Lennart Poettering
On Mon, 04.05.15 12:51, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Mon, May 04, 2015 at 02:55:39AM +0200, Lennart Poettering wrote: On Sat, 02.05.15 13:16, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: When testing generators and other utilities, it is

Re: [systemd-devel] [PATCH 3/3] TODO: Remove task related to LISTEN_NAMES

2015-05-15 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1431702553-4330-3-git-send-email-k.opasiak%40samsung.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel

Re: [systemd-devel] [PATCH 1/5] shared/import-util: tag renamed to reference to support v2 pull by digest

2015-05-15 Thread Lennart Poettering
On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Signed-off-by: Pavel Odvody podv...@redhat.com We dont do S-o-b in systemd. --- src/shared/import-util.c | 19 +++ src/shared/import-util.h | 1 + 2 files changed, 20 insertions(+) diff --git

[systemd-devel] [PATCH 1/3] core: Add LISTEN_NAMES environment variable

2015-05-15 Thread Krzysztof Opasiak
When passing file descriptors to service systemd pass also two environment variable: - LISTEN_PID - PID of service - LISTEN_FDS - Number of file descriptors passed to service Passed fds may have different types: socket, fifo etc. To distinguish them sd-daemon library provides a set of sd_is_*()

[systemd-devel] [PATCH 2/3] sd-daemon: Use LISTEN_NAMES env when available

2015-05-15 Thread Krzysztof Opasiak
LISTEN_NAMES environment variable contains details about received file descriptors. Let's try to use it instead of doing always two stats. This commit reworks all sd_is_*() functions to try parse LISTEN_NAMES variable in first step and do stats only as fallback procedure or if field for given fd

Re: [systemd-devel] [PATCH 2/5] shared/json: JSON parser + number tokenizer bugfix

2015-05-15 Thread Lennart Poettering
On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Signed-off-by: Pavel Odvody podv...@redhat.com Hmm, no S-o-b (as mentioned elsewhere already). Also, please add a commit msg explaining the need for the object parser... +int json_variant_new(json_variant **ret, int type) { +

Re: [systemd-devel] networkd must start before nspawn@container

2015-05-15 Thread Lennart Poettering
On Sun, 03.05.15 19:24, arnaud gaboury (arnaud.gabo...@gmail.com) wrote: As just mentioned on another thread: nspawn in git now is ordered after network.target by default, which should avoid this confusion. Lennart -- Lennart Poettering, Red Hat ___

Re: [systemd-devel] [PATCH] .gitignore: add GNU GLOBAL files

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 17:39, Łukasz Stelmach (l.stelm...@samsung.com) wrote: It was 2015-05-15 pią 17:25, when Lennart Poettering wrote: On Fri, 15.05.15 17:12, Łukasz Stelmach (l.stelm...@samsung.com) wrote: Hmm? What is GNU GLOBAL? Another cscope. A quote from

Re: [systemd-devel] [PATCH 3/5] test/test-json: Tests for the JSON parser and the tokenizer bugfix

2015-05-15 Thread Lennart Poettering
On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Signed-off-by: Pavel Odvody podv...@redhat.com --- src/test/test-json.c | 16 1 file changed, 16 insertions(+) diff --git a/src/test/test-json.c b/src/test/test-json.c index 24dc700..745eeb0 100644 ---

Re: [systemd-devel] [PATCH 1/3] core: Add LISTEN_NAMES environment variable

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 17:09, Krzysztof Opasiak (k.opas...@samsung.com) wrote: When passing file descriptors to service systemd pass also two environment variable: - LISTEN_PID - PID of service - LISTEN_FDS - Number of file descriptors passed to service Passed fds may have different types:

Re: [systemd-devel] [PATCH] .gitignore: add GNU GLOBAL files

2015-05-15 Thread Łukasz Stelmach
It was 2015-05-15 pią 17:25, when Lennart Poettering wrote: On Fri, 15.05.15 17:12, Łukasz Stelmach (l.stelm...@samsung.com) wrote: Hmm? What is GNU GLOBAL? Another cscope. A quote from http://www.gnu.org/software/global/ --8---cut here---start-8---

Re: [systemd-devel] [PATCH] .gitignore: add GNU GLOBAL files

2015-05-15 Thread Łukasz Stelmach
It was 2015-05-15 pią 18:03, when Lennart Poettering wrote: On Fri, 15.05.15 17:39, Łukasz Stelmach (l.stelm...@samsung.com) wrote: It was 2015-05-15 pią 17:25, when Lennart Poettering wrote: On Fri, 15.05.15 17:12, Łukasz Stelmach (l.stelm...@samsung.com) wrote: Hmm? What is GNU GLOBAL?

Re: [systemd-devel] [PATCH] .gitignore: add GNU GLOBAL files

2015-05-15 Thread Dimitri John Ledkov
Heya, On 15 May 2015 at 16:12, Łukasz Stelmach l.stelm...@samsung.com wrote: --- .gitignore | 4 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index f550950..d2f1a1f 100644 --- a/.gitignore +++ b/.gitignore @@ -22,6 +22,10 @@ /*.tar.xz /Makefile /TAGS

Re: [systemd-devel] [PATCH 2/5] shared/json: JSON parser + number tokenizer bugfix

2015-05-15 Thread Pavel Odvody
On Fri, 2015-05-15 at 16:12 +0200, Lennart Poettering wrote: On Fri, 15.05.15 16:03, Pavel Odvody (podv...@redhat.com) wrote: On Fri, 2015-05-15 at 15:23 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Hmm, so if I grok this right,

Re: [systemd-devel] dbus inside nspawn container

2015-05-15 Thread Simon McVittie
On 15/05/15 14:17, Lennart Poettering wrote: On Fri, 15.05.15 14:07, arnaud gaboury (arnaud.gabo...@gmail.com) wrote: Maybe a stupid question, but shall every container user start a per user dbus session ? We make not real distinction there. We intend to provide the same execution

Re: [systemd-devel] [PATCH 5/5] import/pull-dkr: V2 Image specification + manifest support

2015-05-15 Thread Pavel Odvody
On Fri, 2015-05-15 at 15:54 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: #define HEADER_TOKEN X-Do /* the HTTP header for the auth token */ cker-Token: -#define HEADER_REGISTRY X-Do /*the HTTP header for the registry */

Re: [systemd-devel] [PATCH 4/5] import/pull: Tag replaced with reference

2015-05-15 Thread Pavel Odvody
On Fri, 2015-05-15 at 15:29 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Hmm, can you quickly explain how tags and refs and digests relate? If refs replace tags in v2, then I figure we can also drop the dkr_tag_is_valid() definition from

Re: [systemd-devel] [PATCH 4/5] import/pull: Tag replaced with reference

2015-05-15 Thread Pavel Odvody
On Fri, 2015-05-15 at 16:35 +0200, Lennart Poettering wrote: On Fri, 15.05.15 16:32, Pavel Odvody (podv...@redhat.com) wrote: On Fri, 2015-05-15 at 15:29 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Hmm, can you quickly explain

Re: [systemd-devel] [PATCH 4/5] import/pull: Tag replaced with reference

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 16:32, Pavel Odvody (podv...@redhat.com) wrote: On Fri, 2015-05-15 at 15:29 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Hmm, can you quickly explain how tags and refs and digests relate? If refs replace tags in

Re: [systemd-devel] dbus inside nspawn container

2015-05-15 Thread arnaud gaboury
On Fri, May 15, 2015, 4:22 PM Simon McVittie simon.mcvit...@collabora.co.uk wrote: On 15/05/15 14:17, Lennart Poettering wrote: On Fri, 15.05.15 14:07, arnaud gaboury (arnaud.gabo...@gmail.com) wrote: Maybe a stupid question, but shall every container user start a per user dbus session ?

Re: [systemd-devel] [PATCH 1/5] shared/import-util: tag renamed to reference to support v2 pull by digest

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 16:48, Pavel Odvody (podv...@redhat.com) wrote: yes, sha256 - 256bits / 8 = 64bytes (can easily extrapolate other SHAs) Zero-length/invalid value would be an error resulting in 404. But I wonder whether we want to do that level of validation as the check is mostly sanity.

Re: [systemd-devel] [PATCH 5/5] import/pull-dkr: V2 Image specification + manifest support

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 16:24, Pavel Odvody (podv...@redhat.com) wrote: Also, can you quickly explain how the three servers relate to each other? Is this documented anywhere? I'm currently in the process of rewriting these to use the same domain name as is passed in --dkr-index-url, so

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 15:56, Per Bergqvist (p...@bst.lu) wrote: Hej, Seems like nobody thinks using the scsi_id for NVMe drives is a good idea so the alternative must be to introduce a new nvme_id utility. Please find a patch (relative 2.19) to add this. Hmm, did you intend to attach something

Re: [systemd-devel] [PATCH 2/5] shared/json: JSON parser + number tokenizer bugfix

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 16:03, Pavel Odvody (podv...@redhat.com) wrote: On Fri, 2015-05-15 at 15:23 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: Hmm, so if I grok this right, then this at's a DOM-like (object model) parser for json, where we

Re: [systemd-devel] Will *.network replace resolv.conf? What about Options single-request?

2015-05-15 Thread Tom Gundersen
On Mon, May 4, 2015 at 2:57 PM, Christian Brunotte c...@lathspell.de wrote: systemd.network(5) with Options like DNS= and Domains= looks like /etc/resolv.conf will soon be superfluous. In many setups, yes, but we will not aim at bug-for-bug compatibility or anything like that. We are open to

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Michael Marineau
On Fri, May 15, 2015 at 12:18 PM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.05.15 12:08, Nick Owens (nick.ow...@coreos.com) wrote: In 5a8bcb674f71a20e95df55319b34c556638378ce, IPForwarding was introduced to set forwarding flags on interfaces in .network files. networkd sets

Re: [systemd-devel] Will *.network replace resolv.conf? What about Options single-request?

2015-05-15 Thread Mantas Mikulėnas
On Fri, May 15, 2015 at 10:40 PM, Tom Gundersen t...@jklm.no wrote: On Mon, May 4, 2015 at 2:57 PM, Christian Brunotte c...@lathspell.de wrote: systemd.network(5) with Options like DNS= and Domains= looks like /etc/resolv.conf will soon be superfluous. In many setups, yes, but we will not

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 12:42, Michael Marineau (michael.marin...@coreos.com) wrote: On Fri, May 15, 2015 at 12:18 PM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.05.15 12:08, Nick Owens (nick.ow...@coreos.com) wrote: In 5a8bcb674f71a20e95df55319b34c556638378ce, IPForwarding was

[systemd-devel] [PATCH] timedate: fix memory leak in timedated

2015-05-15 Thread Cristian Rodríguez
$ /usr/lib/systemd/systemd-timedated (wait until auto-exit) = ==396==ERROR: LeakSanitizer: detected memory leaks Direct leak of 928 byte(s) in 1 object(s) allocated from: #0 0x7f782f788db1 in __interceptor_calloc

Re: [systemd-devel] [PATCH] .gitignore: add GNU GLOBAL files

2015-05-15 Thread Dimitri John Ledkov
On 15 May 2015 at 17:19, Łukasz Stelmach l.stelm...@samsung.com wrote: It was 2015-05-15 pią 18:03, when Lennart Poettering wrote: On Fri, 15.05.15 17:39, Łukasz Stelmach (l.stelm...@samsung.com) wrote: It was 2015-05-15 pią 17:25, when Lennart Poettering wrote: On Fri, 15.05.15 17:12,

Re: [systemd-devel] Reduce unit-loading time

2015-05-15 Thread cee1
Hey, Thanks for the suggestion, it was other processes running in parallel which presumably consuming lots of IO, after sending SIGSTOP at the first (and SIGCONT later), the unit loading time is decreased to ~100ms. 2015-05-13 19:38 GMT+08:00 Hoyer, Marko (ADITG/SW2) mho...@de.adit-jv.com: Hi,

Re: [systemd-devel] [PATCH] test-socket-util: Fix tests on machines without ipv6 support

2015-05-15 Thread Lennart Poettering
On Thu, 30.04.15 10:18, Sjoerd Simons (sjoerd.sim...@collabora.co.uk) wrote: The test for socket-util already has some code to only do certain tests on machines with ipv6 support. However this was incomplete causing the test to still fail on such machines, this patch adds the remaining cases

Re: [systemd-devel] [PATCH] core: Fix assertion with empty Exec*= paths

2015-05-15 Thread Lennart Poettering
On Thu, 14.05.15 09:15, Martin Pitt (martin.p...@ubuntu.com) wrote: Thanks! APplied! Martin Pitt [2015-05-13 17:01 +0200]: I got a report [1] that you can trivially crash systemd (pid1) at boot by creating a unit with an Exec= line with a modifier and a space: $ cat /tmp/foo.service

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Michael Marineau
On Fri, May 15, 2015 at 12:52 PM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.05.15 12:42, Michael Marineau (michael.marin...@coreos.com) wrote: On Fri, May 15, 2015 at 12:18 PM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.05.15 12:08, Nick Owens

Re: [systemd-devel] Rebooting systemd-nspawn container results in shutdown

2015-05-15 Thread Lennart Poettering
On Mon, 27.04.15 20:00, Kai Krakow (hurikha...@gmail.com) wrote: Lennart Poettering lenn...@poettering.net schrieb: On Sun, 26.04.15 16:55, Kai Krakow (hurikha...@gmail.com) wrote: Hello! I've successfully created a Gentoo container on top of a Gentoo host. I can start the

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1431716895-30240-1-git-send-email-nick.owens%40coreos.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel

Re: [systemd-devel] systemd-nspawn trouble

2015-05-15 Thread Tom Gundersen
On Wed, Apr 22, 2015 at 2:36 PM, Michael Biebl mbi...@gmail.com wrote: 2015-04-22 14:26 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Wed, 22.04.15 14:22, Michael Biebl (mbi...@gmail.com) wrote: 2015-04-22 14:14 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Wed, 22.04.15

Re: [systemd-devel] Will *.network replace resolv.conf? What about Options single-request?

2015-05-15 Thread Marcel Holtmann
Hi Lennart, On Mon, May 4, 2015 at 2:57 PM, Christian Brunotte c...@lathspell.de wrote: systemd.network(5) with Options like DNS= and Domains= looks like /etc/resolv.conf will soon be superfluous. In many setups, yes, but we will not aim at bug-for-bug compatibility or anything like that.

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Tom Gundersen
On Fri, May 15, 2015 at 10:02 PM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.05.15 12:56, Michael Marineau (michael.marin...@coreos.com) wrote: (build time option to ./configure that is) I guess I'd be OK with that... It would be a shame if we started diverging on the

Re: [systemd-devel] Dependency on timers.target

2015-05-15 Thread Bas van Dijk
On 13 May 2015 at 19:42, Lennart Poettering lenn...@poettering.net wrote: Set DefaultDependencies=no in the timer unit to turn this off. Thanks, that worked perfectly! Bas ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Michael Marineau
(build time option to ./configure that is) On Fri, May 15, 2015 at 12:55 PM, Michael Marineau michael.marin...@coreos.com wrote: On Fri, May 15, 2015 at 12:52 PM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.05.15 12:42, Michael Marineau (michael.marin...@coreos.com) wrote: On

Re: [systemd-devel] Will *.network replace resolv.conf? What about Options single-request?

2015-05-15 Thread Lennart Poettering
On Mon, 04.05.15 14:57, Christian Brunotte (c...@lathspell.de) wrote: Hello systemd.network(5) with Options like DNS= and Domains= looks like /etc/resolv.conf will soon be superfluous. If that's the plan, I wonder what happens to options single-request which I had to use on all IPv6

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 12:56, Michael Marineau (michael.marin...@coreos.com) wrote: (build time option to ./configure that is) I guess I'd be OK with that... On Fri, May 15, 2015 at 12:55 PM, Michael Marineau michael.marin...@coreos.com wrote: On Fri, May 15, 2015 at 12:52 PM, Lennart

Re: [systemd-devel] Will *.network replace resolv.conf? What about Options single-request?

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 22:51, Mantas Mikulėnas (graw...@gmail.com) wrote: On Fri, May 15, 2015 at 10:40 PM, Tom Gundersen t...@jklm.no wrote: On Mon, May 4, 2015 at 2:57 PM, Christian Brunotte c...@lathspell.de wrote: systemd.network(5) with Options like DNS= and Domains= looks like

Re: [systemd-devel] [PATCH 5/5] import/pull-dkr: V2 Image specification + manifest support

2015-05-15 Thread Vincent Batts
On 15/05/15 16:24 +0200, Pavel Odvody wrote: On Fri, 2015-05-15 at 15:54 +0200, Lennart Poettering wrote: On Thu, 07.05.15 17:47, Pavel Odvody (podv...@redhat.com) wrote: #define HEADER_TOKEN X-Do /* the HTTP header for the auth token */ cker-Token: -#define HEADER_REGISTRY X-Do /*the

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-15 Thread Per Bergqvist
Hej, Please (finally) find a patched for v219 to add a nvme_id utility and add support for NVMe disks in 60-persistent-storage.rules. BR Per --- Makefile.am | 11 +++ rules/60-persistent-storage.rules | 5 ++ src/udev/nvme_id/nvme_id.c| 155

Re: [systemd-devel] [PATCH] coredump: vacuum - fix MaxUse and KeepFree default handling

2015-05-15 Thread Lennart Poettering
On Wed, 29.04.15 14:31, Mike Winter (mike.win...@vecima.com) wrote: When max_use and keep_free are set to the defaults in coredump.conf for use in non-journal cores, systemd-coredump ignores the settings altogether and proceeds to fill up all available disk space with coredumps. '-1 'is

[systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Nick Owens
In 5a8bcb674f71a20e95df55319b34c556638378ce, IPForwarding was introduced to set forwarding flags on interfaces in .network files. networkd sets forwarding options regardless of the previous setting, even if it was set by e.g. sysctl. This commit makes IPForwarding not change forwarding settings,

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 20:53, Per Bergqvist (p...@bst.lu) wrote: Hej, Please (finally) find a patched for v219 to add a nvme_id utility and add support for NVMe disks in 60-persistent-storage.rules. I figure Kay and Tom have to decide if this goes in, but here's a quick code review, in case they

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Lennart Poettering
On Fri, 15.05.15 12:08, Nick Owens (nick.ow...@coreos.com) wrote: In 5a8bcb674f71a20e95df55319b34c556638378ce, IPForwarding was introduced to set forwarding flags on interfaces in .network files. networkd sets forwarding options regardless of the previous setting, even if it was set by e.g.

Re: [systemd-devel] networkd: dbus API for networkd reconfiguration at run-time

2015-05-15 Thread Lennart Poettering
On Thu, 30.04.15 12:57, Rauta, Alin (alin.ra...@intel.com) wrote: Hi Tom, Lennart, I have some questions regarding dbus API and run-time networkd configuration. I would really appreciate your answers/suggestions. First, when upstreaming BridgeFDB support in networkd, I had (in the first

Re: [systemd-devel] [PATCH] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Lennart Poettering
On Sat, 02.05.15 00:44, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Just a heads up: I have now merged Benedikt's patches that removes altering the global ip_forward sysctl from networkd. This means you have probably should rebase your patch if it is still relevant. Lennart --

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-15 Thread Per Bergqvist
OK, now in git-format-patch.BRPer nvme_id.patch Description: Binary data On 15 May 2015, at 17:03 , Lennart Poettering lenn...@poettering.net wrote:On Fri, 15.05.15 15:56, Per Bergqvist (p...@bst.lu) wrote:Hej,Seems like nobody thinks using the scsi_id for NVMe drives is a good idea so the

  1   2   >