Re: [systemd-devel] libsytemd is missing move-to-rootlibdir when using split-ur

2014-02-20 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 20, 2014 at 05:20:05PM +0100, Michael Biebl wrote: With split-usr, libsystemd should be installed to /lib, not /usr/lib. The compat-libs are still correctly installed to /lib, but libsystemd.so itself isn't Will follow up with a patch unless someone beats me to it

Re: [systemd-devel] systemd-networkd on by default?

2014-02-20 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 21, 2014 at 04:00:10AM +0100, Jason A. Donenfeld wrote: Hi folks, systemd-networkd seems to get started by default in 209. Why is this? What if I don't want to use it to manage my networks? Why does it have to be on by default? I think the reasoning was that it doesn't do

Re: [systemd-devel] Unmentioned 209 change: 80-net-name-slot.rules is gone

2014-02-21 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 21, 2014 at 02:24:58PM +0100, Tom Gundersen wrote: On Fri, Feb 21, 2014 at 3:29 AM, Jason A. Donenfeld ja...@zx2c4.com wrote: Hey guys, This commit caught me by surprise: http://git.zx2c4.com/systemd/commit/?id=daeb71a36a98834664e4d95773a3629b746f4db8 It wasn't in

Re: [systemd-devel] [PATCH] journald: ignore failure to watch hostname_fd on older kernels

2014-02-21 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 21, 2014 at 11:22:50AM -0500, Dave Reisner wrote: Prior to 3.2, /proc/sys/kernel/hostname isn't a pollable file and sd_event_add_io will return EPERM. Ignore this failure, since it isn't critical to journald operation. --- Reported and tested by user sraue on IRC. This should

Re: [systemd-devel] Unmentioned 209 change: 80-net-name-slot.rules is gone

2014-02-23 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 24, 2014 at 12:45:09AM +0100, Tom Gundersen wrote: On Mon, Feb 24, 2014 at 12:13 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: I've now added a paragraph about this change to NEWS. Not sure what to do in the Fedora package though. Why not do the same

Re: [systemd-devel] [PATCH 2/2] systemctl: move next elapse calculation to its own function

2014-02-23 Thread Zbigniew Jędrzejewski-Szmek
Applied both. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] make Virtualization an anonymous enum

2014-02-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Feb 23, 2014 at 10:05:18PM +0100, Thomas H.P. Andersen wrote: src/detect-virt/detect-virt.c | 2 +- src/hostname/hostnamed.c | 2 +- src/shared/condition-util.c | 3 +-- src/shared/virt.c | 2 +- src/shared/virt.h | 6 +++---

Re: [systemd-devel] missing install section in the serial-getty template

2014-02-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 24, 2014 at 11:31:28AM +0100, Tim Hardeck wrote: So I have to set up the instances manually too but the problem is that the serial-getty template doesn't have an install section. So unlike described in http://www.freedesktop.org/wiki/Software/systemd/FrequentlyAskedQuestions/ I

Re: [systemd-devel] [PATCH 2/2] build-sys: Also move libsystemd-journal to rootlibdir

2014-02-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 24, 2014 at 05:31:46PM +0400, Alexey Shabalin wrote: Excuse me, but what reason this libs in $rootlibdir ? All systemd components static linked now with internal libs(for v209). systemd can boot without $libdir (/usr/lib) mounted. All other software, why used libsystemd(or compat

Re: [systemd-devel] pcre in daemons

2014-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 26, 2014 at 08:54:34PM +0100, Thomas H.P. Andersen wrote: The todo says: something pulls in pcre as shared object dependency into our daemons such as hostnamed Normal buiild: ldd ./systemd-hostnamed linux-vdso.so.1 = (0x7fff247bc000) libselinux.so.1 =

Re: [systemd-devel] [PATCH] logs-show: fix corrupt output with empty messages

2014-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 20, 2014 at 03:00:09AM +0200, Uoti Urpala wrote: From 4775218f59474165395f7868dfbf9e6b831f5fee Mon Sep 17 00:00:00 2001 From: Uoti Urpala uau@glyph.nonexistent.invalid Date: Thu, 20 Feb 2014 02:31:04 +0200 Subject: [PATCH] logs-show: fix corrupt output with empty messages If a

Re: [systemd-devel] [PATCH] hwdb: keymaps for Samsung 900X3E/900X3F

2014-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 27, 2014 at 04:02:57PM +1030, Kieran Clancy wrote: Keymaps for Samsung 900X3E and 900X3F should be the same as for other models in the series. I have also moved the comment for '# Series 9' to the right place Applied. Zbyszek ___

[systemd-devel] [PATCH 1/2] journal: assume that next entry is after previous entry

2014-02-26 Thread Zbigniew Jędrzejewski-Szmek
With a corrupted file, we can get in a situation where two entries in the entry array point to the same object. Then journal_file_next_entry will find the first one using generic_arrray_bisect, and try to move to the second one, but since the address is the same, generic_array_get will return the

Re: [systemd-devel] [PATCH] build-sys: Do not distribute generated udev service files

2014-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 26, 2014 at 03:02:55PM +0100, Armin K wrote: They are already in nodist_systemunit_DATA and if they are shipped, they contain hardcoded paths to udevadm and systemd-udevd which will cause them to fail to start when rootprefix != prefix and rootlibdir != libdir. Applied. Zbyszek

Re: [systemd-devel] [PATCH] autogen: Allow running autogen from a builddir != srcdir

2014-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Feb 25, 2014 at 09:45:46AM +0100, Stef Walter wrote: While the configure correctly supports being run outside of the top source directory by default, it's nice if autogen.sh does too: $ git clone git://anongit.freedesktop.org/systemd/systemd $ cd systemd $ mkdir $(uname -m) $

[systemd-devel] [PATCH 2/2] journal: forget file after encountering an error

2014-02-26 Thread Zbigniew Jędrzejewski-Szmek
If we encounter an inconsistency in a file, let's just ignore it. Otherwise, after previous patch, we would try, and fail, to use this file in every invocation of sd_journal_next or sd_journal_previous that happens afterwards. --- src/journal/sd-journal.c | 16 1 file changed, 12

Re: [systemd-devel] [RFC] San Francisco Hackfest April 15th?

2014-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 27, 2014 at 11:40:45PM +0100, Lennart Poettering wrote: Heya! We are looking into organizing a systemd hackfest in San Francisco around th 15th of April, at the Pantheon offices. At least Kay and I will show up, but we were wondering regarding the precise date which day would

Re: [systemd-devel] [PATCH] sd-dhcp: implement IPv4 link-local support

2014-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 27, 2014 at 09:54:17PM +0100, Umut Tezduyar Lindskog wrote: Implements IPv4LL with respect to RFC 3927 (http://tools.ietf.org/rfc/rfc3927.txt) and integrates it with networkd. Majority of the IPv4LL state machine is taken from avahi (http://avahi.org/) project's autoip. IPv4LL

Re: [systemd-devel] binding tmpfiles.d to unit startup

2014-03-01 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Mar 01, 2014 at 02:46:45PM +, Colin Walters wrote: 2) Loss of association between package data and directory. While this is pretty minor, it *is* useful to be able to do rpm -qf /var/kerberos and see that it comes from the krb5-libs package. On a related note, I want to

[systemd-devel] [RFC/PATCH] tmpfiles: implement --transform=rpm

2014-03-01 Thread Zbigniew Jędrzejewski-Szmek
--- I'm not sure if this can be actually as useful as I envisioned. At least in case of systemd.spec there's a lot of special-casing required, which partially destroys the usefulness of this. Configuration for normal packages will hopefully be more straighforward. I made the switch name generic,

Re: [systemd-devel] [RFC/PATCH] tmpfiles: implement --transform=rpm

2014-03-02 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 02, 2014 at 06:14:58AM +0100, Kay Sievers wrote: On Sun, Mar 2, 2014 at 3:06 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: +--transform=rpm Create files list suitable for RPM %%files section\n Hmm, can't we maybe come up with something

Re: [systemd-devel] Process Manager?

2014-03-02 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 02, 2014 at 07:48:26PM -0600, David Farning wrote: I would would be happy to work on upstream wiki site to help with communication But I want to be careful not to overstep. Hi, quite a few people work on the documentation, but there still are extensive gaps. The TODO list

Re: [systemd-devel] [PATCH] Fix systemd-stdio-bridge symlink

2014-03-03 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 03, 2014 at 04:16:28PM +0100, Michael Biebl wrote: 2014-03-03 16:12 GMT+01:00 Michael Biebl mbi...@gmail.com: This really sounds like we want to use ln's --relative option here, so that the symlink is relative regardless what the setup is. The patch looked ok to me as is, but

Re: [systemd-devel] [RFC][PATCH 1/2] utmp-wtmp: allow overriding username on wall

2014-03-05 Thread Zbigniew Jędrzejewski-Szmek
Hi, both patches look useful. Some comments below. On Wed, Mar 05, 2014 at 01:46:01PM +0100, Sebastian Thorarensen wrote: utmp_wall() now takes an optional argument 'username_override' which allows the caller to override the username shown on wall messages. journald will use this to inform

Re: [systemd-devel] [RFC][PATCH 2/2] journald: add support for wall forwarding

2014-03-05 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 05, 2014 at 01:45:51PM +0100, Sebastian Thorarensen wrote: This will let journald forward logs as messages sent to all logged in users (like wall). Two options are added: * ForwardToWall (default no) Is there a good reason not to set it to yes by default? * MaxLevelWall

Re: [systemd-devel] [PATCH 2/2] systemctl: for switch-root check, if we switch to a systemd init

2014-03-05 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 05, 2014 at 02:37:47PM +0100, har...@redhat.com wrote: From: Harald Hoyer har...@redhat.com If systemctl switch-root is called with a specific INIT or /proc/cmdline contains init=, then systemd would not serialize itsself. Let systemctl check, if the new init is in the

Re: [systemd-devel] [PATCH 2/2] [V3] systemctl: switch-root check, if we switch to a systemd init

2014-03-06 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 06, 2014 at 09:12:58AM +0100, har...@redhat.com wrote: From: Harald Hoyer har...@redhat.com If systemctl switch-root is called with a specific INIT or /proc/cmdline contains init=, then systemd would not serialize itsself. Let systemctl check, if the new init is in the

Re: [systemd-devel] [PATCH] build-sys: Don't distribute generated udev rule

2014-03-06 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 07, 2014 at 12:13:39AM +0100, Armin K. wrote: On 03/04/2014 04:23 PM, Armin K wrote: It contains hardcoded path to systemd-sysctl executable which is /usr/lib/systemd/systemd-sysctl on latest stable release and as such it will complain at runtime if rootprefix != prefix ---

Re: [systemd-devel] [PATCH] units: Do not unescape instance name in systemd-backlight@.service

2014-03-06 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 07, 2014 at 01:50:34AM +0100, Thomas Bächler wrote: The instance name is never escaped in the udev rule, but unescaped in the unit. This results in the following error message on Asus boards: Failed to get backlight or LED device 'backlight:eeepc/wmi': No such file or

Re: [systemd-devel] [PATCH] Add CAP_MAC_OVERRIDE in logind and hostnamed units

2014-03-07 Thread Zbigniew Jędrzejewski-Szmek
What is it needed for? Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] Add CAP_MAC_OVERRIDE in logind and hostnamed units

2014-03-07 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 07, 2014 at 02:41:07PM +0100, Maciej Wereski wrote: 07.03.2014 at 14:27 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: What is it needed for? To fix SMACK: [8.715491] type=1400 audit(946708910.490:2): lsm=SMACK fn=smack_inode_permission action=denied subject=System

Re: [systemd-devel] [HEADSUP] Formalizing Backports

2014-03-08 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Mar 08, 2014 at 06:52:59PM -0800, Greg KH wrote: On Fri, Feb 28, 2014 at 02:34:15PM +0100, Lennart Poettering wrote: Heya! Since a while now we have been adding Backport tags to git commits with git notes. Zbigniew and Colin have now set up a new git repo with a stable branch

Re: [systemd-devel] [210] logind bypasses polkit? bug or new feature?

2014-03-10 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 10, 2014 at 11:41:52AM -0300, Gerardo Exequiel Pozzi wrote: On 03/10/2014 06:48 AM, Djalal Harouni wrote: On Sun, Mar 09, 2014 at 08:00:22PM -0300, Gerardo Exequiel Pozzi wrote: Hello To do tests I made a new Arch Linux (x86_64) base installation running in qemu/kvm with

Re: [systemd-devel] device state UNKNOWN

2014-03-10 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 10, 2014 at 06:36:27PM +0100, arnaud gaboury wrote: It seems to me that this device is configured, so why is its state unknown and not UP ? Shall I use a netctl profile to bring it UP, like I do for enp7s0 ? Yes. # netctl enable profile made the br0 UP Maybe

Re: [systemd-devel] [PATCH] systemd-run: extend bash completion

2014-03-11 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 11, 2014 at 08:05:48AM +0100, Thomas H.P. Andersen wrote: On Tue, Mar 11, 2014 at 4:52 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 05.03.14 23:48, Thomas H.P. Andersen (pho...@gmail.com) wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com --system

Re: [systemd-devel] [PATCH] Fix permissions on new journal files

2014-03-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 14, 2014 at 12:07:35AM +, Greg KH wrote: When starting up journald on a new system, set the proper permissions on the system.journal file, not only on the journal directory. diff --git a/tmpfiles.d/systemd.conf b/tmpfiles.d/systemd.conf index 7c6d6b9099b9..1aeb5e40f1ee 100644

Re: [systemd-devel] [PATCH 2/3] tmpfiles: Add --root option to operate on an alternate fs tree.

2014-03-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 13, 2014 at 09:32:13PM -0700, Michael Marineau wrote: This makes it possible to initialize or cleanup an arbitrary filesystem hierarchy in the same way that it would be during system boot. --- src/tmpfiles/tmpfiles.c | 27 --- 1 file changed, 24

Re: [systemd-devel] [PATCH] Use strlen even for constant strings

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Mar 08, 2014 at 10:54:36PM -0800, Josh Triplett wrote: GCC optimizes strlen(string constant) to a constant, even with -O0. (clang does too, btw). Thus, replace patterns like sizeof(string constant)-1 with strlen(string constant) where possible, for clarity. In particular, for

Re: [systemd-devel] [PATCH 2/4] libsystemd-network: Add hangcheck timer for DHCP client test

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 14, 2014 at 08:05:10PM +0100, Tom Gundersen wrote: On Thu, Mar 13, 2014 at 12:01 PM, Patrik Flykt patrik.fl...@linux.intel.com wrote: --- src/libsystemd-network/test-dhcp-client.c | 16 1 file changed, 16 insertions(+) diff --git

Re: [systemd-devel] [PATCH] man: improve wording of systemctl's --after/--before

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 13, 2014 at 09:03:09AM +0400, Andrey Borzenkov wrote: В Wed, 12 Mar 2014 23:07:32 -0400 Jason St. John jstj...@purdue.edu пишет: Commit 4a77ca7 was an attempt at fixing the wording of --after and --before, but the new wording was unclear. Split the combined

Re: [systemd-devel] Fix machinectls machine completion

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 10, 2014 at 03:17:30PM +0100, Wieland Hoffmann wrote: Hi, the following two patches fix machinectls machine name completion by actually installing the required _sd_machines file using machinectls --no-legend switch to prevent bogus entries from appearing in the list of machines.

Re: [systemd-devel] [RFC][PATCH v3 0/2] journald: add support for wall forwarding

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 14, 2014 at 12:37:56AM +0100, Sebastian Thorarensen wrote: These patches add two new options for journald.conf: * ForwardToWall (default yes) * MaxLevelWall (default emerg) Note for mailing-list archives' sake: whole series applied by Lennart as 40b71e89bae4. Zbyszek

Re: [systemd-devel] [PATCH 4/4] libsystemd-network: Add Init-Reboot support

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 13, 2014 at 01:01:52PM +0200, Patrik Flykt wrote: Init-Reboot is tried if a client IP address has been given when the DHCP client is started. In Init-Reboot, start by sending a broadcasted DHCP Request including the supplied client IP address but without the server identifier.

Re: [systemd-devel] [systemd-commits] .gitignore Makefile.am src/timedate

2014-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 13, 2014 at 04:39:37PM -0700, Kay Sievers wrote: .gitignore|1 Makefile.am | 27 + src/timedate/test-timedate-sntp.c | 107 ++ src/timedate/timedate-sntp.c | 652 ++

Re: [systemd-devel] [patch] Add -lresolv to libsystemd_intenal_la_LIBADD to prevent underlinking issues

2014-03-16 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 16, 2014 at 10:10:15AM +0200, Samuli Suominen wrote: Since -Wl,-fuse-ld=gold addition, this happens on IA64 arch where binutils's ld gold doesn't support --gc-sections yet: Maybe you should just use bfd linker then? Gold was only necessary for the ifunc stuff, which is gone anyway.

Re: [systemd-devel] [PATCH rebased] Use strlen even for constant strings

2014-03-16 Thread Zbigniew Jędrzejewski-Szmek
, 2014 at 05:37:49AM +0100, Zbigniew Jędrzejewski-Szmek wrote: strlen() is indeed much nicer. Unfortunately it stopped applying cleanly... Could you rebase this? Done; git rebased it automatically with no conflicts. (am -3 might work in the future for patches that trivially rebase.) I tried

Re: [systemd-devel] [PATCHv2] man: improve wording of systemctl's --after/--before

2014-03-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 17, 2014 at 12:03:46AM -0400, Jason St. John wrote: Commit 4a77ca7 was an attempt at fixing the wording of --after and --before, but the new wording was unclear. Split the combined --after/--before section into a separate section for each, explicitly state what each option does,

[systemd-devel] systemd-journal-remote

2014-03-17 Thread Zbigniew Jędrzejewski-Szmek
[CC: people who commented on previous version of patches or otherwise expressed interest] Hi, I now pushed patches which add systemd-journal-remote. They are based on the previous version from 2012, but were rewritten to use sd-event and epoll in µhttpd. Basic usage goes like this: pull:

Re: [systemd-devel] [PATCH] core, libsystemd, systemd, timedate, udev: spelling fixes

2014-03-17 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 14, 2014 at 09:13:38PM +0100, Miklos Vajna wrote: --- src/core/service.c | 2 +- src/core/unit.c | 2 +- src/libsystemd/sd-bus/bus-message.c | 2 +- src/libsystemd/sd-bus/sd-bus.c | 4 ++-- src/systemd/sd-resolve.h| 2 +-

Re: [systemd-devel] [PATCH 4/4] libsystemd-network: Add Init-Reboot support

2014-03-17 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 17, 2014 at 03:47:34PM +0200, Patrik Flykt wrote: On Sat, 2014-03-15 at 04:02 +0100, Zbigniew Jędrzejewski-Szmek wrote: This means that I can complain about spelling :) There's no such word as broadcasted. Past tense and adjective are broadcast. Yes :-) Spelling fixed

Re: [systemd-devel] systemd-journal-remote

2014-03-18 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 17, 2014 at 11:00:32PM -0700, David Timothy Strauss wrote: On Sun, Mar 16, 2014 at 11:29 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Curl requires the whole file to be exported first, which isn't great, because it wants to give the content size in the header. I'm

Re: [systemd-devel] [PATCH] timedated: add --timezone option to set the default timezone

2014-03-19 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 20, 2014 at 12:39:12AM +0900, juho son wrote: Hi, I omitted explain about. /etc have many system's configuration files. localtime is one of them. Normally /etc is on readable and writable location. So you've made the directory for configuration read-only, but you want to change

Re: [systemd-devel] Building systemd from git

2014-03-19 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 19, 2014 at 10:25:30PM +0200, Kevin Wilson wrote: Hello, When I build systemd from git using the usual procedure of configure, without setting special parameters, it installs folder under /usr/etc/systemd/ (like /usr/etc/systemd/system and its children,

Re: [systemd-devel] Building systemd from git

2014-03-20 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 20, 2014 at 04:02:37PM +0200, Kevin Wilson wrote: Thanks, Zbyszek. --prefix etc. I assume you mean: --prefix /etc and not prefix /etc is it so ? No, I meant --prefix as in the command line option to ./configure, e.g. --prefix=/usr, and etc as in et cetera, not the

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp. Yeah, that looks useful. You don't test negative values. Maybe you could an example with a negative value to the documentation and tests? Zbyszek Suggested by:

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 02:27:04PM -0400, Dave Reisner wrote: On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: ]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote

Re: [systemd-devel] [PATCH] util: always consider glusterfs as a network filesystem

2014-03-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 24, 2014 at 07:43:00PM +0100, Lennart Poettering wrote: On Mon, 24.03.14 17:48, Lennart Poettering (lenn...@poettering.net) wrote: To me it really appears as if _netdev is the right thing to use here, and we really should advertise its use for cases like this, and close the bug as

Re: [systemd-devel] [PATCH] Add hwdb entry for Samsung Series 7 Ultra.

2014-03-26 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 26, 2014 at 06:48:13PM -0700, Scott Thrasher wrote: Add hwdb entry for Samsung Series 7 Ultra. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] How to handle errors in systemd

2014-04-02 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 02, 2014 at 07:12:57PM +0530, shubham sharma wrote: Hi, I have recently switched to RHEL7. I had earlier written a sample service script test_service.sh in the /etc/init.d folder and i used the usual method $/etc/init.d/test_service.sh start to start the script and

Re: [systemd-devel] [PATCH] fstab-generator: local-fs.target waits for nofail mounts

2014-04-04 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 04, 2014 at 05:30:03PM -0400, Vivek Goyal wrote: On Fri, Apr 04, 2014 at 02:44:50PM +0800, WANG Chao wrote: In kdump kernel, we need mount certain file system, and we use nofail for all mounts specified in /etc/fstab. Because we don't want any mount failure to interrupt the boot

Re: [systemd-devel] [PATCH] tty-ask-password-agent: return negative errno

2014-04-04 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 03, 2014 at 09:17:20PM +0200, Florian Albrechtskirchinger wrote: Return negative errno in wall_tty_block(). get_ctty_devnr() already returns a negative errno in case of failure, no need to negate it again. Reported-by: Simon hw...@odai.homelinux.net Thank you both. Applied.

Re: [systemd-devel] [PATCH v4] use systemd.debug on the kernel command line, not debug

2014-04-04 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 03, 2014 at 04:08:15PM +0200, Hannes Reinecke wrote: From: Greg KH gre...@linuxfoundation.org If the kernel is started with debug, that's for the kernel to switch into debug mode. We should rely on a namespace for our options, like everything else (with the exception of quiet).

Re: [systemd-devel] [PATCH] core: Make sure a stamp file exists for all Persistent=true timers

2014-04-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 05, 2014 at 11:35:24AM +0200, Tom Gundersen wrote: On Wed, Apr 2, 2014 at 8:18 PM, Thomas Bächler tho...@archlinux.org wrote: If a persistent timer has no stamp file yet, it behaves just like a normal timer until it runs for the first time. If the system is always shut down

Re: [systemd-devel] systemd-git Build failed

2014-04-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 05, 2014 at 02:00:33PM +0200, arnaud gaboury wrote: I am running Archlinux with a custom 3.18.1 Kernel. Full system is upgraded. Usually systemd-git build fine using the AUR package[1]. The last two builds(first one was with linux 3.17) with these errors: ***

Re: [systemd-devel] [PATCH] journal-remote-parse: avoid passing null to memchr

2014-04-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 05, 2014 at 09:09:47PM +0200, Thomas H.P. Andersen wrote: static int get_line(RemoteSource *source, char **line, size_t *size) { ssize_t n, remain; -char *c; +char *c = NULL; char *newbuf = NULL; size_t newsize = 0; @@ -49,7 +49,9

Re: [systemd-devel] [PATCH v4] use systemd.debug on the kernel command line, not debug

2014-04-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 05, 2014 at 01:16:12PM -0700, Greg KH wrote: On Sat, Apr 05, 2014 at 07:11:47AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Apr 03, 2014 at 04:08:15PM +0200, Hannes Reinecke wrote: From: Greg KH gre...@linuxfoundation.org If the kernel is started with debug, that's

Re: [systemd-devel] [PATCH v4] use systemd.debug on the kernel command line, not debug

2014-04-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 05, 2014 at 11:32:50PM +0200, Tom Gundersen wrote: On Sat, Apr 5, 2014 at 11:22 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sat, Apr 05, 2014 at 01:16:12PM -0700, Greg KH wrote: On Sat, Apr 05, 2014 at 07:11:47AM +0200, Zbigniew Jędrzejewski-Szmek wrote

Re: [systemd-devel] Netconsole NG

2014-04-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 07, 2014 at 05:34:10PM +0200, Lukáš Nykrýn wrote: The reason why this was not rewritten a long time ago is that the initscript tries to figure some of those values by itself (for example the MAC address). But yes, we need to do something with netconsole. It is a blocker for my

Re: [systemd-devel] [PATCH] fstab-generator: local-fs.target waits for nofail mounts

2014-04-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 07, 2014 at 03:10:14PM -0400, Vivek Goyal wrote: On Mon, Apr 07, 2014 at 10:07:20PM +0400, Andrey Borzenkov wrote: В Mon, 7 Apr 2014 13:40:17 -0400 Vivek Goyal vgo...@redhat.com пишет: Defining a new target which by default waits for all the local fs target sounds

Re: [systemd-devel] Move use of locale_t to different shared file, so that udev can still be built without it (MinimalBuild)

2014-04-08 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 08, 2014 at 09:04:37AM +0300, Samuli Suominen wrote: File src/shared/util.h is using locale_t which isn't used by the strictly udev parts of the systemd code, I propose to move this to a different header, so it is only used where it's actually required. I see the usefulness of

Re: [systemd-devel] Two git trees

2014-04-08 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 08, 2014 at 11:06:44AM +0400, Kirill Elagin wrote: The description of repo on GitHub says “Mirror of git:// anongit.freedesktop.org/systemd/systemd”. That is, it's a mirror. I don't know how exactly it is synchronised, but, since it is a mirror, it might be out of date sometimes.

Re: [systemd-devel] [PATCH] fstab-generator: local-fs.target waits for nofail mounts

2014-04-08 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 08, 2014 at 06:35:03PM +0800, WANG Chao wrote: On 04/08/14 at 02:14am, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Apr 07, 2014 at 03:10:14PM -0400, Vivek Goyal wrote: On Mon, Apr 07, 2014 at 10:07:20PM +0400, Andrey Borzenkov wrote: В Mon, 7 Apr 2014 13:40:17 -0400 Vivek

Re: [systemd-devel] Two git trees

2014-04-08 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 08, 2014 at 11:21:57AM -0700, David Timothy Strauss wrote: On Tue, Apr 8, 2014 at 5:30 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: I think it is synchronized after successful jenkins runs, so it is always buildable and unit tests pass. That's my GitHub mirror

Re: [systemd-devel] [PATCH] Document CONFIG_NET_NS as a required kernel option

2014-04-09 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 09, 2014 at 07:35:15PM -0400, Mike Gilbert wrote: On Wed, Apr 9, 2014 at 12:32 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 09.04.14 11:21, Tom Gundersen (t...@jklm.no) wrote: On Mon, Mar 31, 2014 at 8:28 PM, Mike Gilbert flop...@gentoo.org wrote: Several

Re: [systemd-devel] [PATCH 1/2] EnvironmentFile: don't drop backslashes inside single quotes

2014-04-10 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 10, 2014 at 03:17:20PM +0200, Lukas Nykryn wrote: --- src/shared/fileio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/fileio.c b/src/shared/fileio.c index f101269..0eb131d 100644 --- a/src/shared/fileio.c +++ b/src/shared/fileio.c @@

Re: [systemd-devel] [PATCH] nspawn: Fix erroneous OOM when building group list

2014-04-10 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 09, 2014 at 07:08:45PM +0200, Philip Lorenz wrote: change_uid_gid() never initialises sz which may cause greedy_realloc to skip the initial buffer allocation. Applied, thanks. Zbyszek ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH] core: Make sure a stamp file exists for all Persistent=true timers

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 12, 2014 at 01:02:53PM +0200, Tom Gundersen wrote: On Sat, Apr 12, 2014 at 12:57 PM, Thomas Bächler tho...@archlinux.org wrote: Am 05.04.2014 17:32, schrieb Thomas Bächler: Am 05.04.2014 11:35, schrieb Tom Gundersen: On Wed, Apr 2, 2014 at 8:18 PM, Thomas Bächler

Re: [systemd-devel] [PATCH] build: if -fstack-protector-strong is available, use it.

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
Yeah, this seems a good thing. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] libnetworkd: only allow positive ifindex

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 12, 2014 at 01:19:48PM +0200, Umut Tezduyar Lindskog wrote: Patch doesn't apply anymore after reference counting changes. I will re-send it along with ipv4ll tests which is coming up right away. Cool. Could you add a bit of a commit message explaining the change for the poor ignorant

Re: [systemd-devel] [PATCH 1/2] man: mention XDG_CONFIG_HOME in systemd.unit

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 12, 2014 at 08:37:38AM +0300, Tanu Kaskinen wrote: --- man/systemd.unit.xml | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Applied 1/2. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH 2/2] path-lookup: don't hardcode .config

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 12, 2014 at 08:37:39AM +0300, Tanu Kaskinen wrote: If XDG_CONFIG_HOME is set, then we should respect that. --- src/shared/path-lookup.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/shared/path-lookup.c b/src/shared/path-lookup.c index

Re: [systemd-devel] [PATCH v2] fsck: Search for fsck.type in PATH

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 12, 2014 at 12:07:04PM -0400, Mike Gilbert wrote: Modifies find_binary() to accept NULL in the second argument. fsck.type lookup logic moved to new fsck_exists() function, with a test. --- src/fsck/fsck.c| 9 - src/shared/generator.c | 11 ---

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 08, 2014 at 08:52:51AM +0530, Susant Sahani wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev -- [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102

Re: [systemd-devel] [PATCH] libnetworkd: only allow positive ifindex

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 12, 2014 at 09:59:52PM +0200, Tom Gundersen wrote: On Sat, Apr 12, 2014 at 7:26 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sat, Apr 12, 2014 at 01:19:48PM +0200, Umut Tezduyar Lindskog wrote: Patch doesn't apply anymore after reference counting changes. I

Re: [systemd-devel] [PATCH v3] fsck: Search for fsck.type in PATH

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 12, 2014 at 04:07:45PM -0400, Mike Gilbert wrote: Modifies find_binary() to accept NULL in the second argument. fsck.type lookup logic moved to new fsck_exists() function, with a test. Applied. I added _cleanup_free_ to simplify one branch, and added a follow-up patch to check

Re: [systemd-devel] Get exit status inside ExecStopPost ?

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 11, 2014 at 12:19:52PM -0700, Anand Patil wrote: Hi everyone, In a service's ExecStopPost, is there an easy way to access the exit status of the service's ExecStart process? No. You might be able to get something useful over dbus, although I don't know if the exit value is

Re: [systemd-devel] Systemd askpassword

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 12, 2014 at 10:08:27PM +0200, Ismael Bouya wrote: Hi, I'm facing a problem with systemd and his askpassword feature: I want to add a luks partition, so I need to ask for the password at some time. However, I don't want to ask for it during the boot sequence, so I added the

Re: [systemd-devel] [systemd-commits] Makefile.am man/udevadm.xml src/libudev src/shared src/test src/udev

2014-04-14 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Apr 13, 2014 at 04:58:31PM -0700, Kay Sievers wrote: Makefile.am |6 man/udevadm.xml | 22 - src/libudev/libudev-monitor.c | 17 - src/libudev/libudev-queue-private.c | 406

Re: [systemd-devel] [systemd-commits] Makefile.am man/udevadm.xml src/libudev src/shared src/test src/udev

2014-04-14 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 14, 2014 at 09:29:54AM -0700, Kay Sievers wrote: On Mon, Apr 14, 2014 at 8:52 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sun, Apr 13, 2014 at 04:58:31PM -0700, Kay Sievers wrote: Makefile.am |6 man/udevadm.xml

Re: [systemd-devel] [systemd-commits] Makefile.am man/udevadm.xml src/libudev src/shared src/test src/udev

2014-04-14 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 14, 2014 at 09:51:08AM -0700, Kay Sievers wrote: On Mon, Apr 14, 2014 at 9:39 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Apr 14, 2014 at 09:29:54AM -0700, Kay Sievers wrote: On Mon, Apr 14, 2014 at 8:52 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl

Re: [systemd-devel] [PATCH] Handle Unix domain socket connections from outside our namespace

2014-04-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 16, 2014 at 06:39:07PM +0200, Eelco Dolstra wrote: NixOS uses Unix domain sockets for certain host - container interaction; i.e. the host connects to a socket visible in the container's directory tree, where the container uses a .socket unit to spawn the handler program on demand.

Re: [systemd-devel] [PATCH] systemctl: allow to change the default target without the --force switch

2014-04-16 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 17, 2014 at 01:41:51AM +0100, Djalal Harouni wrote: On Mon, Apr 14, 2014 at 01:07:52AM +0100, Djalal Harouni wrote: Currently systemctl set-default will fail to change the default target due to the 'default.target' being a symlink which is always the case. To work around

Re: [systemd-devel] [PATCH] systemctl: allow to change the default target without the --force switch

2014-04-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 14, 2014 at 01:07:52AM +0100, Djalal Harouni wrote: Currently systemctl set-default will fail to change the default target due to the 'default.target' being a symlink which is always the case. To work around this, the user must specify the --force switch to be able to overwrite

Re: [systemd-devel] [PATCH] install: create_symlink() check unlink() return value

2014-04-16 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 17, 2014 at 01:47:11AM +0100, Djalal Harouni wrote: create_symlink() do not check the return value of unlink(), this may confuse the user. Before the unlink() call we check the 'force' argument. If it is not set we fail with -EEXIST, otherwise we unlink() the file, therefore the

Re: [systemd-devel] [PATCH] systemctl: systemctl --root=container/ set-default ... is totally borked.

2014-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 17, 2014 at 10:40:37AM +0200, Jan Chaloupka wrote: On 04/17/2014 04:59 AM, Zbigniew Je;drzejewski-Szmek wrote: On Thu, Apr 17, 2014 at 01:41:51AM +0100, Djalal Harouni wrote: BTW, I've a question, why there is this item in the TODO: systemctl --root=container/ set-default ... is

Re: [systemd-devel] [PATCH] core: minor typo fix

2014-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 14, 2014 at 07:30:16PM +0200, Ali H. Caliskan wrote: diff --git a/src/core/dbus.c b/src/core/dbus.c index d482e6c..e9bf34c 100644 --- a/src/core/dbus.c +++ b/src/core/dbus.c @@ -918,7 +918,7 @@ static int bus_init_system(Manager *m) { r = bus_setup_system(m, bus);

Re: [systemd-devel] [PATCH] Add libkmod flags for test_rtnl_manual

2014-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 14, 2014 at 03:14:14PM +0200, Łukasz Stelmach wrote: --- Makefile.am | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Without CFLAGS my gcc is unable to find linkmod.h. KMOD_LIBS just look better than -lkomd for me. diff --git a/Makefile.am b/Makefile.am index

Re: [systemd-devel] [PATCH] Fix permissions on new journal files

2014-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 15, 2014 at 02:12:01PM -0700, Greg KH wrote: When starting up journald on a new system, set the proper permissions on the system.journal files, not only on the journal directory. diff --git a/tmpfiles.d/systemd.conf b/tmpfiles.d/systemd.conf index 7c6d6b9099b9..c47004532151

Re: [systemd-devel] [PATCH] Handle Unix domain socket connections from outside our namespace

2014-04-19 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 19, 2014 at 01:58:03PM +0200, Kay Sievers wrote: On Thu, Apr 17, 2014 at 4:24 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Apr 16, 2014 at 06:39:07PM +0200, Eelco Dolstra wrote: NixOS uses Unix domain sockets for certain host - container interaction; i.e

Re: [systemd-devel] [PATCH] Handle Unix domain socket connections from outside our namespace

2014-04-19 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 19, 2014 at 10:16:41PM +0200, Eelco Dolstra wrote: Hi Zbigniew, On 19/04/14 20:30, Zbigniew Jędrzejewski-Szmek wrote: PID1 crashes with this code, I have reverted the commit for now. Please have a look. systemd[1]: Code should not be reached 'Unhandled socket type

  1   2   3   4   5   6   7   8   9   10   >